Merge remote-tracking branch 'refs/remotes/npigeon/ticket-660'
[mediagoblin.git] / mediagoblin / user_pages / views.py
index 45effc55a7f69f5467e805a4eea8906790e48068..e3b46c0f8787b41a0868d38f6d113727265d8456 100644 (file)
@@ -18,17 +18,17 @@ import logging
 import datetime
 
 from mediagoblin import messages, mg_globals
-from mediagoblin.db.util import DESCENDING, ObjectId
-from mediagoblin.db.sql.models import (MediaEntry, Collection, CollectionItem,
-                                       User)
+from mediagoblin.db.models import (MediaEntry, MediaTag, Collection,
+                                   CollectionItem, User)
 from mediagoblin.tools.response import render_to_response, render_404, redirect
 from mediagoblin.tools.translate import pass_to_ugettext as _
 from mediagoblin.tools.pagination import Pagination
-from mediagoblin.tools.files import delete_media_files
 from mediagoblin.user_pages import forms as user_forms
-from mediagoblin.user_pages.lib import send_comment_email
+from mediagoblin.user_pages.lib import (send_comment_email,
+    add_media_to_collection)
 
 from mediagoblin.decorators import (uses_pagination, get_user_media_entry,
+    get_media_entry_by_id,
     require_active_login, user_may_delete_media, user_may_alter_collection,
     get_user_collection, get_user_collection_item, active_user_from_url)
 
@@ -54,8 +54,9 @@ def user_home(request, page):
             'mediagoblin/user_pages/user.html',
             {'user': user})
 
-    cursor = MediaEntry.query.filter_by(uploader = user.id).\
-        filter_by(state = u'processed').sort('created', DESCENDING)
+    cursor = MediaEntry.query.\
+        filter_by(uploader = user.id,
+                  state = u'processed').order_by(MediaEntry.created.desc())
 
     pagination = Pagination(page, cursor)
     media_entries = pagination()
@@ -81,10 +82,17 @@ def user_home(request, page):
 @uses_pagination
 def user_gallery(request, page, url_user=None):
     """'Gallery' of a User()"""
+    tag = request.matchdict.get('tag', None)
     cursor = MediaEntry.query.filter_by(
         uploader=url_user.id,
         state=u'processed').order_by(MediaEntry.created.desc())
 
+    # Filter potentially by tag too:
+    if tag:
+        cursor = cursor.filter(
+            MediaEntry.tags_helper.any(
+                MediaTag.slug == request.matchdict['tag']))
+
     # Paginate gallery
     pagination = Pagination(page, cursor)
     media_entries = pagination()
@@ -97,7 +105,7 @@ def user_gallery(request, page, url_user=None):
     return render_to_response(
         request,
         'mediagoblin/user_pages/gallery.html',
-        {'user': url_user,
+        {'user': url_user, 'tag': tag,
          'media_entries': media_entries,
          'pagination': pagination})
 
@@ -110,12 +118,13 @@ def media_home(request, media, page, **kwargs):
     """
     'Homepage' of a MediaEntry()
     """
-    if request.matchdict.get('comment', None):
+    comment_id = request.matchdict.get('comment', None)
+    if comment_id:
         pagination = Pagination(
             page, media.get_comments(
                 mg_globals.app_config['comments_ascending']),
             MEDIA_COMMENTS_PER_PAGE,
-            ObjectId(request.matchdict.get('comment')))
+            comment_id)
     else:
         pagination = Pagination(
             page, media.get_comments(
@@ -138,7 +147,7 @@ def media_home(request, media, page, **kwargs):
          'app_config': mg_globals.app_config})
 
 
-@get_user_media_entry
+@get_media_entry_by_id
 @require_active_login
 def media_post_comment(request, media):
     """
@@ -172,16 +181,15 @@ def media_post_comment(request, media):
     return redirect(request, location=media.url_for_self(request.urlgen))
 
 
-@get_user_media_entry
+@get_media_entry_by_id
 @require_active_login
 def media_collect(request, media):
     """Add media to collection submission"""
 
     form = user_forms.MediaCollectForm(request.form)
     # A user's own collections:
-    form.collection.query = Collection.query.filter(
-        request.db.Collection.creator == request.user.id)\
-        .order_by(Collection.title)
+    form.collection.query = Collection.query.filter_by(
+        creator = request.user.id).order_by(Collection.title)
 
     if request.method != 'POST' or not form.validate():
         # No POST submission, or invalid form
@@ -197,69 +205,63 @@ def media_collect(request, media):
 
     # If we are here, method=POST and the form is valid, submit things.
     # If the user is adding a new collection, use that:
-    if request.form['collection_title']:
+    if form.collection_title.data:
         # Make sure this user isn't duplicating an existing collection
         existing_collection = Collection.query.filter_by(
                                 creator=request.user.id,
-                                title=request.form['collection_title']).first()
+                                title=form.collection_title.data).first()
         if existing_collection:
             messages.add_message(request, messages.ERROR,
-                _('You already have a collection called "%s"!'
-                  % collection.title))
+                _('You already have a collection called "%s"!')
+                % existing_collection.title)
             return redirect(request, "mediagoblin.user_pages.media_home",
-                            user=request.user.username,
-                            media=media.id)
+                            user=media.get_uploader.username,
+                            media=media.slug_or_id)
 
         collection = Collection()
-        collection.title = request.form['collection_title']
-        collection.description = request.form.get('collection_description')
+        collection.title = form.collection_title.data
+        collection.description = form.collection_description.data
         collection.creator = request.user.id
         collection.generate_slug()
-        collection.save(validate=True)
+        collection.save()
 
     # Otherwise, use the collection selected from the drop-down
     else:
-        collection = Collection.query.filter_by(
-            id=request.form.get('collection')).first()
+        collection = form.collection.data
+        if collection and collection.creator != request.user.id:
+            collection = None
 
     # Make sure the user actually selected a collection
     if not collection:
         messages.add_message(
             request, messages.ERROR,
             _('You have to select or add a collection'))
+        return redirect(request, "mediagoblin.user_pages.media_collect",
+                    user=media.get_uploader.username,
+                    media_id=media.id)
+
 
     # Check whether media already exists in collection
     elif CollectionItem.query.filter_by(
         media_entry=media.id,
         collection=collection.id).first():
         messages.add_message(request, messages.ERROR,
-            _('"%s" already in collection "%s"'
-                % (media.title, collection.title)))
+                             _('"%s" already in collection "%s"')
+                             % (media.title, collection.title))
     else: # Add item to collection
-        collection_item = request.db.CollectionItem()
-        collection_item.collection = collection.id
-        collection_item.media_entry = media.id
-        collection_item.author = request.user.id
-        collection_item.note = request.form['note']
-        collection_item.save(validate=True)
-
-        collection.items = collection.items + 1
-        collection.save(validate=True)
-
-        media.collected = media.collected + 1
-        media.save()
+        add_media_to_collection(collection, media, form.note.data)
 
         messages.add_message(request, messages.SUCCESS,
-                             _('"%s" added to collection "%s"'
-                               % (media.title, collection.title)))
+                             _('"%s" added to collection "%s"')
+                             % (media.title, collection.title))
 
     return redirect(request, "mediagoblin.user_pages.media_home",
                     user=media.get_uploader.username,
-                    media=media.id)
+                    media=media.slug_or_id)
 
 
 #TODO: Why does @user_may_delete_media not implicate @require_active_login?
-@get_user_media_entry
+@get_media_entry_by_id
 @require_active_login
 @user_may_delete_media
 def media_confirm_delete(request, media):
@@ -269,21 +271,7 @@ def media_confirm_delete(request, media):
     if request.method == 'POST' and form.validate():
         if form.confirm.data is True:
             username = media.get_uploader.username
-
-            # Delete all the associated comments
-            for comment in media.get_comments():
-                comment.delete()
-
-            # Delete all files on the public storage
-            try:
-                delete_media_files(media)
-            except OSError, error:
-                _log.error('No such files from the user "{1}"'
-                           ' to delete: {0}'.format(str(error), username))
-                messages.add_message(request, messages.ERROR,
-                                     _('Some of the files with this entry seem'
-                                       ' to be missing.  Deleting anyway.'))
-
+            # Delete MediaEntry and all related files, comments etc.
             media.delete()
             messages.add_message(
                 request, messages.SUCCESS, _('You deleted the media.'))
@@ -319,6 +307,9 @@ def user_collection(request, page, url_user=None):
         get_creator=url_user,
         slug=request.matchdict['collection']).first()
 
+    if not collection:
+        return render_404(request)
+
     cursor = collection.get_collection_items()
 
     pagination = Pagination(page, cursor)
@@ -338,6 +329,19 @@ def user_collection(request, page, url_user=None):
          'pagination': pagination})
 
 
+@active_user_from_url
+def collection_list(request, url_user=None):
+    """A User-defined Collection"""
+    collections = Collection.query.filter_by(
+        get_creator=url_user)
+
+    return render_to_response(
+        request,
+        'mediagoblin/user_pages/collection_list.html',
+        {'user': url_user,
+         'collections': collections})
+
+
 @get_user_collection_item
 @require_active_login
 @user_may_alter_collection
@@ -440,15 +444,17 @@ def atom_feed(request):
     """
     generates the atom feed with the newest images
     """
-    user = User.query.filter(User.username==request.matchdict['user']).\
-        filter(User.status == u'active').first()
+    user = User.query.filter_by(
+        username = request.matchdict['user'],
+        status = u'active').first()
     if not user:
         return render_404(request)
 
-    cursor = MediaEntry.query.filter_by(MediaEntry.uploader == user.id).\
-                 filter_by(MediaEntry.state == u'processed').\
-                 sort('created', DESCENDING).\
-                 limit(ATOM_DEFAULT_NR_OF_UPDATED_ITEMS)
+    cursor = MediaEntry.query.filter_by(
+        uploader = user.id,
+        state = u'processed').\
+        order_by(MediaEntry.created.desc()).\
+        limit(ATOM_DEFAULT_NR_OF_UPDATED_ITEMS)
 
     """
     ATOM feed id is a tag URI (see http://en.wikipedia.org/wiki/Tag_URI)
@@ -501,18 +507,21 @@ def collection_atom_feed(request):
     """
     generates the atom feed with the newest images from a collection
     """
-    user = User.query.filter(User.username == request.matchdict['user']).\
-        filter_by(User.status == u'active').first()
+    user = User.query.filter_by(
+        username = request.matchdict['user'],
+        status = u'active').first()
     if not user:
         return render_404(request)
 
     collection = Collection.query.filter_by(
                creator=user.id,
                slug=request.matchdict['collection']).first()
+    if not collection:
+        return render_404(request)
 
     cursor = CollectionItem.query.filter_by(
                  collection=collection.id) \
-                 .sort(CollectionItem.added.desc()) \
+                 .order_by(CollectionItem.added.desc()) \
                  .limit(ATOM_DEFAULT_NR_OF_UPDATED_ITEMS)
 
     """
@@ -533,14 +542,16 @@ def collection_atom_feed(request):
                 'href': push_url})
 
     feed = AtomFeed(
-               "MediaGoblin: Feed for %s's collection %s" % (request.matchdict['user'], collection.title),
-               feed_url=request.url,
-               id='tag:{host},{year}:collection.user-{user}.title-{title}'.format(
-                   host=request.host,
-                   year=datetime.datetime.today().strftime('%Y'),
-                   user=request.matchdict['user'],
-                   title=collection.title),
-               links=atomlinks)
+                "MediaGoblin: Feed for %s's collection %s" %
+                (request.matchdict['user'], collection.title),
+                feed_url=request.url,
+                id=u'tag:{host},{year}:gnu-mediagoblin.{user}.collection.{slug}'\
+                    .format(
+                    host=request.host,
+                    year=collection.created.strftime('%Y'),
+                    user=request.matchdict['user'],
+                    slug=collection.slug),
+                links=atomlinks)
 
     for item in cursor:
         entry = item.get_media_entry
@@ -575,30 +586,27 @@ def processing_panel(request):
     #
     # Make sure we have permission to access this user's panel.  Only
     # admins and this user herself should be able to do so.
-    if not (user == request.user
-            or request.user.is_admin):
+    if not (user.id == request.user.id or request.user.is_admin):
         # No?  Simply redirect to this user's homepage.
-        print user
-        print request.user
         return redirect(
             request, 'mediagoblin.user_pages.user_home',
             user=user.username)
 
     # Get media entries which are in-processing
     processing_entries = MediaEntry.query.\
-        filter(MediaEntry.uploader == user.id).\
-        filter(MediaEntry.state == u'processing').\
+        filter_by(uploader = user.id,
+                  state = u'processing').\
         order_by(MediaEntry.created.desc())
 
     # Get media entries which have failed to process
     failed_entries = MediaEntry.query.\
-        filter(MediaEntry.uploader == user.id).\
-        filter(MediaEntry.state == u'failed').\
+        filter_by(uploader = user.id,
+                  state = u'failed').\
         order_by(MediaEntry.created.desc())
 
     processed_entries = MediaEntry.query.\
-        filter(MediaEntry.uploader == user.id).\
-        filter(MediaEntry.state == u'processed').\
+        filter_by(uploader = user.id,
+                  state = u'processed').\
         order_by(MediaEntry.created.desc()).\
         limit(10)