Delete the session cookie on an empty session.

[mediagoblin.git] / mediagoblin / tools / pagination.py

diff --git a/mediagoblin/tools/pagination.py b/mediagoblin/tools/pagination.py
index ff7d4cadab8c5cb274d8817072122646e483a593..d0f08c9443ae4dd2c7711e2426567ef2b6def8e2 100644 (file)
--- a/mediagoblin/tools/pagination.py
+++ b/mediagoblin/tools/pagination.py
@@ -25,7 +25,7 @@ PAGINATION_DEFAULT_PER_PAGE = 30
 
 class Pagination(object):
     """
-    Pagination class for mongodb queries.
+    Pagination class for database queries.
 
     Initialization through __init__(self, cursor, page=1, per_page=2),
     get actual data slice through __call__().
@@ -40,8 +40,8 @@ class Pagination(object):
          - page: requested page
          - per_page: number of objects per page
          - cursor: db cursor
-         - jump_to_id: ObjectId, sets the page to the page containing the
-           object with _id == jump_to_id.
+         - jump_to_id: object id, sets the page to the page containing the
+           object with id == jump_to_id.
         """
         self.page = page
         self.per_page = per_page
@@ -53,19 +53,21 @@ class Pagination(object):
             cursor = copy.copy(self.cursor)
 
             for (doc, increment) in izip(cursor, count(0)):
-                if doc._id == jump_to_id:
+                if doc.id == jump_to_id:
                     self.page = 1 + int(floor(increment / self.per_page))
 
                     self.active_id = jump_to_id
                     break
 
-
     def __call__(self):
         """
         Returns slice of objects for the requested page
         """
-        return self.cursor.skip(
-            (self.page - 1) * self.per_page).limit(self.per_page)
+        # TODO, return None for out of index so templates can
+        # distinguish between empty galleries and out-of-bound pages???
+        return self.cursor.slice(
+            (self.page - 1) * self.per_page,
+            self.page * self.per_page)
 
     @property
     def pages(self):
@@ -96,7 +98,7 @@ class Pagination(object):
         """
         Get a page url by adding a page= parameter to the base url
         """
-        new_get_params = copy.copy(get_params or {})
+        new_get_params = dict(get_params) or {}
         new_get_params['page'] = page_no
         return "%s?%s" % (
             base_url, urllib.urlencode(new_get_params))