Fix #1056 - Add flag to accept URLs without a trailing slash

[mediagoblin.git] / mediagoblin / tests / test_misc.py

diff --git a/mediagoblin/tests/test_misc.py b/mediagoblin/tests/test_misc.py
index b48b876213117594a7d067083a0d182a313c15c9..b3e59c0924ce120fd9e32c661603014a0d8a26ef 100644 (file)
--- a/mediagoblin/tests/test_misc.py
+++ b/mediagoblin/tests/test_misc.py
@@ -14,26 +14,33 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
-from nose.tools import assert_equal
+import pytz
+import datetime
 
+from werkzeug.datastructures import FileStorage
+
+from .resources import GOOD_JPG
 from mediagoblin.db.base import Session
+from mediagoblin.media_types import sniff_media
+from mediagoblin.submit.lib import new_upload_entry
+from mediagoblin.submit.task import collect_garbage
 from mediagoblin.db.models import User, MediaEntry, MediaComment
-from mediagoblin.tests.tools import get_app, \
-    fixture_add_user, fixture_media_entry
+from mediagoblin.tests.tools import fixture_add_user, fixture_media_entry
 
 
-def test_404_for_non_existent():
-    test_app = get_app(dump_old_app=False)
+def test_404_for_non_existent(test_app):
     res = test_app.get('/does-not-exist/', expect_errors=True)
-    assert_equal(res.status_int, 404)
+    assert res.status_int == 404
 
 
-def test_user_deletes_other_comments():
+def test_user_deletes_other_comments(test_app):
     user_a = fixture_add_user(u"chris_a")
     user_b = fixture_add_user(u"chris_b")
 
-    media_a = fixture_media_entry(uploader=user_a.id, save=False)
-    media_b = fixture_media_entry(uploader=user_b.id, save=False)
+    media_a = fixture_media_entry(uploader=user_a.id, save=False,
+                                  expunge=False, fake_upload=False)
+    media_b = fixture_media_entry(uploader=user_b.id, save=False,
+                                  expunge=False, fake_upload=False)
     Session.add(media_a)
     Session.add(media_b)
     Session.flush()
@@ -60,11 +67,11 @@ def test_user_deletes_other_comments():
     cmt_cnt2 = MediaComment.query.count()
 
     # One user deleted
-    assert_equal(usr_cnt2, usr_cnt1 - 1)
+    assert usr_cnt2 == usr_cnt1 - 1
     # One media gone
-    assert_equal(med_cnt2, med_cnt1 - 1)
+    assert med_cnt2 == med_cnt1 - 1
     # Three of four comments gone.
-    assert_equal(cmt_cnt2, cmt_cnt1 - 3)
+    assert cmt_cnt2 == cmt_cnt1 - 3
 
     User.query.get(user_b.id).delete()
 
@@ -73,8 +80,55 @@ def test_user_deletes_other_comments():
     cmt_cnt2 = MediaComment.query.count()
 
     # All users gone
-    assert_equal(usr_cnt2, usr_cnt1 - 2)
+    assert usr_cnt2 == usr_cnt1 - 2
     # All media gone
-    assert_equal(med_cnt2, med_cnt1 - 2)
+    assert med_cnt2 == med_cnt1 - 2
     # All comments gone
-    assert_equal(cmt_cnt2, cmt_cnt1 - 4)
+    assert cmt_cnt2 == cmt_cnt1 - 4
+
+
+def test_media_deletes_broken_attachment(test_app):
+    user_a = fixture_add_user(u"chris_a")
+
+    media = fixture_media_entry(uploader=user_a.id, save=False, expunge=False)
+    media.attachment_files.append(dict(
+            name=u"some name",
+            filepath=[u"does", u"not", u"exist"],
+            ))
+    Session.add(media)
+    Session.flush()
+
+    MediaEntry.query.get(media.id).delete()
+    User.query.get(user_a.id).delete()
+
+def test_garbage_collection_task(test_app):
+    """ Test old media entry are removed by GC task """
+    user = fixture_add_user()
+
+    # Create a media entry that's unprocessed and over an hour old.
+    entry_id = 72
+    now = datetime.datetime.now(pytz.UTC)
+    file_data = FileStorage(
+        stream=open(GOOD_JPG, "rb"),
+        filename="mah_test.jpg",
+        content_type="image/jpeg"
+    )
+
+    # Find media manager
+    media_type, media_manager = sniff_media(file_data, "mah_test.jpg")
+    entry = new_upload_entry(user)
+    entry.id = entry_id
+    entry.title = "Mah Image"
+    entry.slug = "slugy-slug-slug"
+    entry.media_type = 'image'
+    entry.created = now - datetime.timedelta(days=2)
+    entry.save()
+
+    # Validate the model exists
+    assert MediaEntry.query.filter_by(id=entry_id).first() is not None
+
+    # Call the garbage collection task
+    collect_garbage()
+
+    # Now validate the image has been deleted
+    assert MediaEntry.query.filter_by(id=entry_id).first() is None