Document bad assumption
authorpdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Tue, 19 Dec 2017 05:02:38 +0000 (05:02 +0000)
committerpdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Tue, 19 Dec 2017 05:02:38 +0000 (05:02 +0000)
git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14747 7612ce4b-ef26-0410-bec9-ea0150e637f0

functions/options.php

index dc4209530b547cffc34c7dcfb8f7f400de2c7ba2..8fde4ae84e03595be4f45ba68cba1f5ec3137ec5 100644 (file)
@@ -235,6 +235,8 @@ class SquirrelOption {
         //Check for a current value.  
         if (isset($GLOBALS[$name])) {
             $this->value = $GLOBALS[$name];
         //Check for a current value.  
         if (isset($GLOBALS[$name])) {
             $this->value = $GLOBALS[$name];
+        // TODO: This code should be something more like the following, but who knows what would break if it was changed at this point
+        // } else if (initial_value !== '') {
         } else if (!empty($initial_value)) {
             $this->value = $initial_value;
         } else {
         } else if (!empty($initial_value)) {
             $this->value = $initial_value;
         } else {