better debug logs for board process access rules

diff --git a/lib/Auth/Source/FSFDrupalAuth.php b/lib/Auth/Source/FSFDrupalAuth.php
index a44f5a8f47715eaf13b3a2ebc18aab83ea816b64..46ad5d4e9a925210c1ca7cf6a9b3bbdd4c70ed48 100644 (file)
--- a/lib/Auth/Source/FSFDrupalAuth.php
+++ b/lib/Auth/Source/FSFDrupalAuth.php
@@ -485,24 +485,25 @@ class FSFDrupalAuth extends \SimpleSAML\Module\core\Auth\UserPassBase
        $adhoc_params       = ['adhoc_access_group_id' => intval($this->nomination_process_adhoc_access_group_id)];
 
        if ($this->nomination_process_active != 'true' ) {
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Nomination board process checks not active');
                $attributes['nomination_process'] = ['false'];
 
        } elseif ($compare_res($donation_query('query_nomination_process_adhoc', $adhoc_params), 1)) {
+               Logger::debug('fsfdrupalauth:'.$this->authId.': In adhoc list of contacts for nomination board process');
                $attributes['nomination_process'] = ['true'];
 
        } elseif ($attributes['is_member'] != ['true']) {
-               Logger::debug('fsfdrupalauth:'.$this->authId.
-                       ': Not a member / comparable donor during window for board process.');
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Not a current member for nomination board process');
                $attributes['nomination_process'] = ['false'];
 
        } elseif ($nomination_process_analyze_history($donation_query('query_nomination_process_donations', $donation_params))
                || $compare_res($donation_query('query_nomination_process_gift_receipt', $gift_member_params), 1)) {
 
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Past membership / donations meet threshold for nomination board process');
                $attributes['nomination_process'] = ['true'];
 
        } else {
-               Logger::debug('fsfdrupalauth:'.$this->authId.
-                       ': Not a member / comparable donor during window for board process.');
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Past membership / donations do not meet threshold for nomination board process');
                $attributes['nomination_process'] = ['false'];
        }
 
@@ -516,32 +517,33 @@ class FSFDrupalAuth extends \SimpleSAML\Module\core\Auth\UserPassBase
        $adhoc_params_no    = ['adhoc_access_group_id' => intval($this->discussion_process_adhoc_no_access_group_id)];
 
        if ($this->discussion_process_active != 'true' ) {
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Discussion board process checks not active');
                $attributes['discussion_process'] = ['false'];
 
        } elseif ($compare_res($donation_query('query_discussion_process_adhoc', $adhoc_params_no), 1)) {
-               Logger::debug('fsfdrupalauth:'.$this->authId.
-                       ': Nominee not eligible for board nominee discussion process.');
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Nominee not allowed to participate in board discussion process.');
                $attributes['discussion_process'] = ['false'];
 
        } elseif ($compare_res($donation_query('query_discussion_process_adhoc', $adhoc_params), 1)) {
+               Logger::debug('fsfdrupalauth:'.$this->authId.': In adhoc list of contacts for discussion board process');
                $attributes['discussion_process'] = ['true'];
 
        } elseif ($attributes['is_fsf_staff'] == ['true']) {
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Is staff, so can access discussion board process');
                $attributes['discussion_process'] = ['true'];
 
        } elseif ($attributes['is_member'] != ['true']) {
-               Logger::debug('fsfdrupalauth:'.$this->authId.
-                       ': Not eligible for board nominee discussion process.');
+               Logger::debug('fsfdrupalauth :'.$this->authId.': Not a member, so not eligible for board nominee discussion process.');
                $attributes['discussion_process'] = ['false'];
 
        } elseif ($compare_res($old_membership_query('query_discussion_process_old_membership', $old_member_params), 1)
                || $discussion_process_analyze_history($donation_query('query_discussion_process_donations', $donation_params))) {
 
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Past membership / donations meet threshold for discussion board process');
                $attributes['discussion_process'] = ['true'];
 
        } else {
-               Logger::debug('fsfdrupalauth:'.$this->authId.
-                       ': Not eligible for board nominee discussion process.');
+               Logger::debug('fsfdrupalauth:'.$this->authId.': Past membership / donations do not meet threshold for discussion board process');
                $attributes['discussion_process'] = ['false'];
        }