Christopher Allan Webber [Tue, 28 May 2013 21:36:27 +0000 (16:36 -0500)]
The pdf.js iframe view is awesome so I'm making it the default. So there! ;)
This commit sponsored by Jay Turley. Thank you!
Christopher Allan Webber [Tue, 28 May 2013 21:34:47 +0000 (16:34 -0500)]
Fixing bug where non-image types might break if app_config['original_date_visible'] is true
Not all media managers have the .get_original_date attribute, so of
course break. This is fixed by making a new space where individual
media types can define this if they like.
This commit sponsored by Matthieu Dupont de Dinechin. Thank you!
Rodney Ewing [Fri, 24 May 2013 19:52:14 +0000 (12:52 -0700)]
added a register_user function
cherry picked from rodney757 and fixed for out of order
picking.
Rodney Ewing [Sat, 25 May 2013 14:59:03 +0000 (07:59 -0700)]
created a check_login_simple function
cherry-picked from rodney757, fixed few conflicts due to
out of order cherry-picking. Thanks to rodney757 for making
my idea even better.
Rodney Ewing [Fri, 24 May 2013 19:48:29 +0000 (12:48 -0700)]
moved email_debug_message to gmg/tools/mail
Rodney Ewing [Fri, 24 May 2013 19:26:45 +0000 (12:26 -0700)]
moved send_verification_email to auth/tools
Rodney Ewing [Thu, 23 May 2013 21:56:32 +0000 (14:56 -0700)]
removed unused import
Christopher Allan Webber [Mon, 27 May 2013 18:55:06 +0000 (13:55 -0500)]
Committing extracted and compiled translations
Elrond [Sun, 26 May 2013 11:29:02 +0000 (13:29 +0200)]
Extract footer into bits/base_footer.html.
Christopher Allan Webber [Fri, 24 May 2013 23:49:06 +0000 (18:49 -0500)]
No more of this find_packages nonsense.
Explicitly declare mediagoblin as the only package. find_packages has
caused messes in the past :)
This commit sponsored by Pedro Ângelo. Thanks!
Joar Wandborg [Fri, 24 May 2013 21:07:09 +0000 (23:07 +0200)]
Improved docs
- Fixed an outdated URL
- Rewrote "Separate Celery" section
- Changed literal blocks to bash code-blocks
- Changed wording when referring to the MediaGoblin WSGI application
Rodney Ewing [Thu, 23 May 2013 21:29:19 +0000 (14:29 -0700)]
moved normalize_user_or_email_field to auth/tools.py from auth/forms.py
Christopher Allan Webber [Thu, 23 May 2013 20:56:07 +0000 (15:56 -0500)]
Moving statcdirect automodule doc reference to autoclass per Elrond's suggestion.
Cleaner!
Joar Wandborg [Thu, 23 May 2013 20:21:02 +0000 (22:21 +0200)]
Cleaned up EXIF view
The last update made the assumption that EXIF metadata is in some way
consistent between camera models, images, manufacturers. This update
takes into account that nothing is certain whenever EXIF is involved.
Christopher Allan Webber [Thu, 23 May 2013 18:43:04 +0000 (13:43 -0500)]
Documentation changes to reflect new plugin assetlink stuff
- updated old theme assetlink section to reflect new location of
./bin/gmg assetlink and removed comment about the plugin command
being temporary.
- Added a new section to the standard config file on where to put the
plugin_static section
- Added release notes about said section
This commit sponsored by Thomas Webber. Thanks, Dad!
Christopher Allan Webber [Thu, 23 May 2013 18:14:01 +0000 (13:14 -0500)]
Full unit test for the plugin assetlink command.
Tests:
- if the link doesn't exist yet
- if the link already exists
- if it is a symlink to something else
- if it exists but is not a symlink
This commit sponsored by Lon Koenig. Thank you!
Christopher Allan Webber [Thu, 23 May 2013 18:12:20 +0000 (13:12 -0500)]
Cleaning a bit: os.path.sep.join -> os.path.join
Christopher Allan Webber [Thu, 23 May 2013 15:55:09 +0000 (10:55 -0500)]
docstring update: link theme... and plugins!
Christopher Allan Webber [Thu, 23 May 2013 14:52:57 +0000 (09:52 -0500)]
Generalize "gmg theme assetlink" -> "gmg assetlink" and cover both theme and plugins
We've moved the module... probably I'll re-add theme just to give a
warning that this is deprecated.
This commit sponsored by Kevin Williams. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 20:55:21 +0000 (15:55 -0500)]
test_plugin_staticdirect now works and passes.
This commit sponsored by Samuel Vale. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 19:20:44 +0000 (14:20 -0500)]
Simple "staticstuff" plugin for writing unit tests on plugin static asset linking.
It doesn't do much... it just has a static directory with a "bunnify"
CSS file and has a unit test that returns a json encoded set of a
staticdirect with both this plugin enabled and also
with (theoretically) a file distributed with MediaGoblin (it isn't
really, but in our case that doesn't matter.)
Also set up the static_setup hook / PluginStatic object for this
plugin; testing that with `./bin/gmg theme assetlink` seemed to work.
(And argh, need to update that command name, I know.)
This commit sponsored by Bradley Kuhn. Thanks bkuhn!
Christopher Allan Webber [Wed, 22 May 2013 19:07:41 +0000 (14:07 -0500)]
Various fixes to plugin assetlinking command.
Actually trying to run the command helps figure out what needs to be
fixed :)
This commit sponsored by Justin Nichol. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 17:23:06 +0000 (12:23 -0500)]
Moving test_user_dev->user_dev in plugin app configs & adding plugin static serving
The test_user_dev (as opposed to user_dev) was a legacy before we had
each application running in its own directory (as they now do in
pytest). Move that name to just user_dev... this is more consistent
with the rest of our naming and will make writing these config files
easier. (If we want to test that changing these still works, that
should be a separate unit test with special config files.)
Additionally, add plugin static serving to the common test paste
config file.
This commit sponsored by Juan Jose Marin Martinez. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 16:51:46 +0000 (11:51 -0500)]
Document assetlink and staticdirect usage for plugins.
Still a bit to clean up around what the command to be run actually is,
since that will likely change.
This commit sponsored by David Decker. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 15:06:24 +0000 (10:06 -0500)]
Oh right, actually mount /plugin_static/ :)
Christopher Allan Webber [Tue, 21 May 2013 21:07:18 +0000 (16:07 -0500)]
Work towards getting plugin static linking/serving to work
- add link_plugin_assets. For now, incorrectly running from
./bin/gmg theme assetlink... uh, will fix ;)
- Update paste and config_spec.ini configs to handle the locations
and serving of the plugins' static resources
This commit sponsored by Marko Dimjašević. Thank you!
Christopher Allan Webber [Thu, 16 May 2013 15:38:45 +0000 (10:38 -0500)]
Start of ability to have plugins provide static resources!
Note I have not tested any of this yet ;) But we're already on our way:
- We've got docs
- The hook is there
Lots to do still though. But, progress! :)
This commit sponsored by Laura Arjona Reina. Thanks larjona!
Christopher Allan Webber [Wed, 22 May 2013 21:44:50 +0000 (16:44 -0500)]
Move "bits" templates with dashes in them to underscores
Moved all references and also added a note to our release notes.
This commit sponsored by Juan Rodriguez. Thank you!
Christopher Allan Webber [Wed, 22 May 2013 21:31:39 +0000 (16:31 -0500)]
Moved frontpage "welcome" stuff into its own bits file.
This should make it easier to override just that part of the page.
This commit sponsored by David Rylander. Thank you!
Mats Sjöberg [Tue, 21 May 2013 19:55:55 +0000 (22:55 +0300)]
Piwigo minor fix in categories_getList.
Mats Sjöberg [Tue, 21 May 2013 19:46:57 +0000 (22:46 +0300)]
Piwigo: some sanity checks before adding to collection as per Elrond's suggestions.
Mats Sjöberg [Tue, 21 May 2013 19:42:41 +0000 (22:42 +0300)]
Piwigo: return collections list only to logged in users.
Mats Sjöberg [Tue, 21 May 2013 19:40:02 +0000 (22:40 +0300)]
Rudimentary collections support for piwigo plugin.
Mats Sjöberg [Tue, 21 May 2013 19:39:37 +0000 (22:39 +0300)]
Fixed minor typo in piwigo logging.
Elrond [Tue, 21 May 2013 16:34:23 +0000 (18:34 +0200)]
Merge remote-tracking branch 'rodney757/change_pass'
* rodney757/change_pass:
fixed translation, and changed tabs to spaces, and change it so the user can view their password as they're typing.
modified change_pass tests
moved change pass to a seperate view and fixed issues 709
Rodney Ewing [Tue, 21 May 2013 15:51:21 +0000 (08:51 -0700)]
fixed translation, and changed tabs to spaces, and change it so the user can view their password as they're typing.
Elrond [Mon, 20 May 2013 22:28:37 +0000 (00:28 +0200)]
Refactor submit util new_upload_entry
This tool creates an initial media entry for a given user.
No magic. It just prefills the license with the user's
default license and adds the user as uploader.
Rodney Ewing [Mon, 20 May 2013 21:27:43 +0000 (14:27 -0700)]
modified change_pass tests
Rodney Ewing [Mon, 20 May 2013 21:04:02 +0000 (14:04 -0700)]
moved change pass to a seperate view and fixed issues 709
Elrond [Mon, 20 May 2013 15:50:04 +0000 (17:50 +0200)]
piwigo: Return proper error for wrong user/password.
And fix tests.
Elrond [Mon, 20 May 2013 17:28:35 +0000 (19:28 +0200)]
piwigo: Add PwgError class.
This allows to return piwigo xml errors.
Those can also be matched into html error codes.
Elrond [Sat, 18 May 2013 23:14:46 +0000 (01:14 +0200)]
A bit of pep8 and small typo fix.
Joar Wandborg [Sun, 19 May 2013 22:46:29 +0000 (00:46 +0200)]
Only calculate aperture if fnumber is provided
Joar Wandborg [Sun, 19 May 2013 22:25:19 +0000 (00:25 +0200)]
Take into account incomplete EXIF data
Joar Wandborg [Sun, 19 May 2013 22:11:00 +0000 (00:11 +0200)]
Fixed EXIF tests
Gabriel Saldana [Tue, 5 Mar 2013 06:05:35 +0000 (00:05 -0600)]
Modifies EXIF section with Camera Info, display toggle and template styling
Gabriel Saldana [Tue, 5 Mar 2013 05:19:22 +0000 (23:19 -0600)]
Changes to display all EXIF information
Joar Wandborg [Sun, 19 May 2013 20:54:39 +0000 (22:54 +0200)]
Added upload processing to the piwigo/addSimple
Christopher Allan Webber [Fri, 17 May 2013 20:10:34 +0000 (15:10 -0500)]
Just word-wrapping the recent changes to the deployment docs.
Christopher Allan Webber [Fri, 17 May 2013 20:08:53 +0000 (15:08 -0500)]
Merge remote-tracking branch 'refs/remotes/merge-requests/58'
Christopher Allan Webber [Fri, 17 May 2013 19:10:29 +0000 (14:10 -0500)]
Noting why we don't have an email uniqueness constraint in the db.
This commit sponsored by Guido Günther. Thanks!
Christopher Allan Webber [Fri, 17 May 2013 16:13:17 +0000 (11:13 -0500)]
Merge remote-tracking branch 'refs/remotes/elrond/misc/pytest_enable_testing'
Christopher Allan Webber [Fri, 17 May 2013 16:12:56 +0000 (11:12 -0500)]
Reverting "Always activate testing in every test module ever."
Revert "Always activate testing in every test module ever."
This reverts commit
0536306048daa0970d2e43411ba2a9bf073e570e.
Elrond [Thu, 16 May 2013 23:46:20 +0000 (01:46 +0200)]
Always activate testing using pytest fixture.
This is possibly the cleaner approach to the problem solved
in the previous commit.
The previous commit makes sure, that testing is enabled at
import time. While this one enables it just before the
individual test is run. So this one takes a bit more CPU.
Maybe revert the previous commit?
References:
0536306048daa0970d2e43411ba2a9bf073e570e
Christopher Allan Webber [Thu, 16 May 2013 22:51:21 +0000 (17:51 -0500)]
Always activate testing in every test module ever.
Kind of a dorky way to implement this, but...
Christopher Allan Webber [Thu, 16 May 2013 21:56:20 +0000 (16:56 -0500)]
Fixing bug in dbupdate where it would explode on plugin that is missing MODELS or MIGRATIONS
The reason it blew up was because in the latter caught exception, it
wouldn't set models/migrations to an empty set, so it would actually
use the previous run's models/migrations! That's what we get for
"leaky" variables on python for loops :)
This commit sponsored by Pascal Diogo Antunes. Thank you!
Christopher Allan Webber [Wed, 15 May 2013 16:40:51 +0000 (11:40 -0500)]
Merge branch '623_context_hooks'
Christopher Allan Webber [Wed, 15 May 2013 16:40:28 +0000 (11:40 -0500)]
Testing the template_context_prerender hook
This allows for modifying any context *right before render*, including
access to the variables that are passed in. This test takes advantage
of that and takes one of the variables, "doubleme", and modifies
it (doubles it!)
In our case it turns "happy" and "joy" into "happyhappy" and "joyjoy".
This commit sponsored by Mark Holmquist. Thank you!
Christopher Allan Webber [Wed, 15 May 2013 16:29:43 +0000 (11:29 -0500)]
Simple tyop, view->test... I was writing too many tests at the time :)
Christopher Allan Webber [Wed, 15 May 2013 16:11:24 +0000 (11:11 -0500)]
Oh right, actually add that hook we just documented, "template_context_prerender" :)
This commit sponsored by William Goudie. Thanks Bill! :)
Christopher Allan Webber [Wed, 15 May 2013 16:10:25 +0000 (11:10 -0500)]
Hook->hooks since there's more than one of them :)
Christopher Allan Webber [Wed, 15 May 2013 15:37:41 +0000 (10:37 -0500)]
Adding global context hooks & fixing method names->symbolic view names in docs
This commit sponsored by Sheila Miguez. Thanks Sheila!
Christopher Allan Webber [Tue, 14 May 2013 21:09:55 +0000 (16:09 -0500)]
Added documentation on view specific hooks
This commit sponsored by Matthew Woodward. Thank you!
Christopher Allan Webber [Tue, 14 May 2013 19:57:37 +0000 (14:57 -0500)]
Normalizing indentation a bit in media.html
This commit sponsored by Christian Frank. Thank you!
Rodney Ewing [Tue, 14 May 2013 19:36:13 +0000 (12:36 -0700)]
fix for bug when comments are disabled, link attribute is never closed
Christopher Allan Webber [Tue, 14 May 2013 19:29:23 +0000 (14:29 -0500)]
Documenting the test_modify_context and context_modified_app methods
Christopher Allan Webber [Tue, 14 May 2013 19:24:27 +0000 (14:24 -0500)]
Fully working context hooks, both template/view and global level, with tests
Needs documentation though... that's coming next :)
This commit sponsored by Luca Tius. Thanks Luca!
Elrond [Thu, 9 May 2013 11:07:10 +0000 (13:07 +0200)]
piwigo: Start first tests.
This first test checks the session logic of the piwigo
plugin. login, logout, getStatus.
Elrond [Thu, 9 May 2013 10:28:54 +0000 (12:28 +0200)]
piwigo: Fix validator usage.
wtforms.validators.Optional doesn't take an argument.
I don't know, why I gave it one.
Christopher Allan Webber [Sun, 12 May 2013 21:17:35 +0000 (16:17 -0500)]
Merge branch 'master' into 623_context_hooks
Christopher Allan Webber [Sun, 12 May 2013 21:07:28 +0000 (16:07 -0500)]
Removing reference to nose (thanks for catching, Elrond!)
This commit sponsored by Kevin McCarthy. Thank you!
Christopher Allan Webber [Sun, 12 May 2013 20:55:59 +0000 (15:55 -0500)]
Tests should no longer use the environment-variable-related-setup and set up in app instead
This should remove a bunch of confusing cruft. I hate using that
environment variable! Also that old code was fragile.
This commit sponsored by Stephen Milton. Thanks!
Christopher Allan Webber [Sun, 12 May 2013 16:45:31 +0000 (11:45 -0500)]
Making the uncomment-able db string match the one that we use in the install docs
This commit sponsored by Denise Merkel. Thanks, Mom! Happy Mother's Day!
Christopher Allan Webber [Sat, 11 May 2013 22:02:26 +0000 (17:02 -0500)]
Moving the get_original_date method over to the MediaManager.
This fixes a bug so that it doesn't explode if the media_data doesn't
exist.
This commit sponsored by Ole-Morten Duesund. Thank you!
Christopher Allan Webber [Sat, 11 May 2013 18:56:02 +0000 (13:56 -0500)]
Updated "created on" feature to reflect new "hover for real time" tooling
Christopher Allan Webber [Sat, 11 May 2013 18:48:42 +0000 (13:48 -0500)]
Merge remote-tracking branch 'refs/remotes/tryggvib/532-exif-creation-date'
Conflicts:
mediagoblin/config_spec.ini
mediagoblin/templates/mediagoblin/user_pages/media.html
Christopher Allan Webber [Sat, 11 May 2013 15:19:31 +0000 (10:19 -0500)]
Merge remote-tracking branch 'gabithume/146_debug_message'
Christopher Allan Webber [Sat, 11 May 2013 01:26:55 +0000 (20:26 -0500)]
Use the controller's symbolic/lookup name as part of the key for context hooks
This commit sponsored by David Collins. Thank you!
Christopher Allan Webber [Sat, 11 May 2013 01:19:16 +0000 (20:19 -0500)]
Merge branch 'master' into 623_context_hooks
Christopher Allan Webber [Fri, 10 May 2013 21:33:52 +0000 (16:33 -0500)]
Merge remote-tracking branch 'refs/remotes/dthompson/453_disable_comments'
Christopher Allan Webber [Fri, 10 May 2013 16:26:55 +0000 (11:26 -0500)]
Merge branch 'master' of gitorious.org:mediagoblin/mediagoblin
Christopher Allan Webber [Fri, 10 May 2013 16:23:36 +0000 (11:23 -0500)]
Merge remote-tracking branch 'refs/remotes/merge-requests/47'
Elrond [Sun, 5 May 2013 15:02:00 +0000 (17:02 +0200)]
piwigo: Better logging for login.
Elrond [Fri, 29 Mar 2013 13:48:08 +0000 (14:48 +0100)]
piwigo: Let getStatus return the current user.
If there is a user logged in, show his name.
Elrond [Fri, 29 Mar 2013 13:49:13 +0000 (14:49 +0100)]
Create new session system for piwigo plugin.
Using the brand new itsdangerous sessions to power the
sessions for piwigo.
The real point is: Clients want to have the session in a
"pwg_id" cookie and don't accept any other cookie name.
Elrond [Mon, 25 Mar 2013 14:34:21 +0000 (15:34 +0100)]
piwigo: Add .images.add including form handling.
To make things a bit easier, switch to WTForms
for validating the received data.
Elrond [Sun, 5 May 2013 14:45:37 +0000 (16:45 +0200)]
piwigo: Remove possibly_add_cookie.
This one was a fake thing to make clients happy.
Real sessions coming sonn.
Christopher Allan Webber [Wed, 8 May 2013 20:21:15 +0000 (15:21 -0500)]
Fix the new config "plugin spec" loading code so it doesn't break on no plugins section
Christopher Allan Webber [Wed, 8 May 2013 20:20:27 +0000 (15:20 -0500)]
Fixing API setup with new plugin "config spec" world
It shouldn't reference the config until in the setup_plugin() method,
else there's a race condition.
Christopher Allan Webber [Wed, 8 May 2013 19:38:13 +0000 (14:38 -0500)]
Ah right, and here's the config we intend to use for these context modified tests :)
This commit sponsored by Xavier Gulliot. Thanks Xavier!
Christopher Allan Webber [Wed, 8 May 2013 19:35:31 +0000 (14:35 -0500)]
The beginning of context hooks.
Not the working solution, but getting there conceptually. Basically
we'll have a key with the view and the template as a tuple which is
the context hook that anyone can attach to.
However, some changes have still to be made:
- The unit test doesn't work yet and contains a set_trace ;)
- We'll probably switch the "view" component from being the callable
to the "urlgen"'able name per Elrond's suggestion
- Found a bug in unit tests related to running custom apps for
different configs... hm. I need to fix this!
Nonetheless, making progress.
This commit sponsored by... wait a minute... Christopher Webber?!
Christopher Allan Webber [Wed, 8 May 2013 15:57:23 +0000 (10:57 -0500)]
Documenting plugin configuration
This commit sponsored by David Krupicz. Thanks, David!
Christopher Allan Webber [Wed, 8 May 2013 15:54:43 +0000 (10:54 -0500)]
Unit tests for plugins defining their own config_spec.ini!
This commit sponsored by David Ahmed. Thank you!
Christopher Allan Webber [Wed, 8 May 2013 15:37:38 +0000 (10:37 -0500)]
Allow plugins to install their own config_spec.ini if they like.
This commit sponsored by Timothy Vollmer. Thanks Tim!
Sam Tuke [Mon, 6 May 2013 14:19:10 +0000 (16:19 +0200)]
Added info about editing mediagoblin.ini
Added link to Apache deployment instructions
Joar Wandborg [Sun, 5 May 2013 20:24:34 +0000 (22:24 +0200)]
Removed unused imports in httpapiauth
Elrond [Sun, 5 May 2013 12:29:57 +0000 (14:29 +0200)]
Use collection.url_for_self more; Add missing /a.
Using collection.url_for_self(request.urlgen) instead
of request.urlgen(lengthy) is so much nicer, so using
it around the place.
Also added a few missing </a> in one template.
Elrond [Thu, 2 May 2013 21:38:07 +0000 (23:38 +0200)]
Fix typo in new stl MEDIA_MANAGER.
Elrond [Tue, 30 Apr 2013 21:44:56 +0000 (23:44 +0200)]
Fix media manager reference in video.
An uninstantiated bare media manager doesn't any more
support ["something"]. You need to do .something.
Fixed for .source_type().
Praveen Kumar [Mon, 29 Apr 2013 00:15:05 +0000 (05:45 +0530)]
Make all media types use the new MediaManager classes.