Christopher Allan Webber [Sun, 4 Dec 2011 03:56:30 +0000 (21:56 -0600)]
PEP-8'ifying prompt_if_not_set
Christopher Allan Webber [Sun, 4 Dec 2011 03:43:15 +0000 (21:43 -0600)]
Merge remote-tracking branch 'remotes/manolinux/645_gmg_adduser_prompt'
Christopher Allan Webber [Sun, 4 Dec 2011 03:38:45 +0000 (21:38 -0600)]
Raise a slightly useful exception when we can't find the media type.
Christopher Allan Webber [Sat, 3 Dec 2011 22:59:20 +0000 (16:59 -0600)]
Updated translations
Elrond [Sat, 3 Dec 2011 21:11:54 +0000 (22:11 +0100)]
Merge remote branch 'remotes/manolinux/671_spaces_in_tag_list_edit'
* remotes/manolinux/671_spaces_in_tag_list_edit:
* Feature #678: Drop custom delimiters in tags * Eliminate the definition of the tag delimiter for tests. * Remove a test that was related to custom tags delimiter. * Bug #671: Tags list on Edit page is not seperated by spaces and hard to read * Modify a test to include this space.
* Bug #671: Tags list on Edit page is not seperated by spaces and hard to read : Make 'media_tags_as_string' function put a space after each comma. * Feature #678: Drop custom delimiters in tags : I declare a constant in the begining of text.py file.
Elrond [Sat, 3 Dec 2011 20:20:11 +0000 (21:20 +0100)]
Bug #685: only provide CSRF token if it exists
This was suggested by Nathan Yergler in the bug logs.
Just implementing it.
- Let render_csrf_form_token return None, if the CSRF_TOKEN
is not available in the environ, because the
process_request part of the meddleware has not yet run.
- In render_template: If the returned value from above is
None, then do not add the csrf_token to the templates
context.
Elrond [Sat, 3 Dec 2011 15:45:33 +0000 (16:45 +0100)]
Bug #685: Add failing unit test
The simplest way to reproduce Bug #685 is to ask for a non
existent page. This should return a proper 404. It
currently doesn't.
So add a unit test exactly for this.
This unit test fails currently! It will fail until the bug
gets fixed.
Manuel Urbano Santos [Sat, 3 Dec 2011 14:36:02 +0000 (15:36 +0100)]
Prompt for arguments in adduser if not present (I created a function in util.py to check and prompt for arguments).
Manuel Urbano Santos [Sat, 3 Dec 2011 13:29:28 +0000 (14:29 +0100)]
Change adduser arguments from positional to --keyword style.
Jef van Schendel [Sat, 3 Dec 2011 00:19:15 +0000 (01:19 +0100)]
Changed comment error message wording slightly. Btw, should we translate these things?
Christopher Allan Webber [Fri, 2 Dec 2011 22:13:14 +0000 (16:13 -0600)]
We should use the variable local_templates instead of user_template_path
Elrond [Thu, 1 Dec 2011 23:09:13 +0000 (00:09 +0100)]
Expect 404 in unit tests, if we now use 404.
Our unit tests for auth were expecting a 400.
Well, now we give a 404. So expect that!
I'm not completely sure, if the 404 is the right thing
here, but that's another topic.
Christopher Allan Webber [Thu, 1 Dec 2011 22:59:22 +0000 (16:59 -0600)]
Merge branch 'master' of gitorious.org:mediagoblin/mediagoblin
Christopher Allan Webber [Thu, 1 Dec 2011 22:58:56 +0000 (16:58 -0600)]
Should be 404 for 404s, not 400 :)
Christopher Allan Webber [Thu, 1 Dec 2011 21:21:15 +0000 (15:21 -0600)]
Don't barf on templates that use the autoescaping extension
Elrond [Mon, 28 Nov 2011 17:40:45 +0000 (18:40 +0100)]
Merge remote branch 'remotes/nyergler/issue-680-csrf-optout'
* remotes/nyergler/issue-680-csrf-optout:
Issue 680 Allow decorating views to prevent CSRF protection.
Issue 680: Dispatch meddleware request processing post-routing
Elrond [Mon, 28 Nov 2011 08:45:15 +0000 (09:45 +0100)]
Mark two strings for translation
1. "Go to page:" in pagination
2. "Submit" in the forget password form
Elrond [Sun, 27 Nov 2011 22:23:20 +0000 (23:23 +0100)]
Merge remote branch 'remotes/manolinux/683_text_separate_tags_by_commas_and_spaces'
* remotes/manolinux/683_text_separate_tags_by_commas_and_spaces:
Fix the text "Seperate tags by commas and spaces" since spaces are not used to seperate anymore.
Christopher Allan Webber [Sun, 27 Nov 2011 21:31:42 +0000 (15:31 -0600)]
Updating translations
Manuel Urbano Santos [Sun, 27 Nov 2011 13:31:20 +0000 (14:31 +0100)]
Fix the text "Seperate tags by commas and spaces" since spaces are not used to seperate anymore.
Manuel Urbano Santos [Sun, 27 Nov 2011 12:55:07 +0000 (13:55 +0100)]
* Feature #678: Drop custom delimiters in tags
* Eliminate the definition of the tag delimiter for tests.
* Remove a test that was related to custom tags delimiter.
* Bug #671: Tags list on Edit page is not seperated by spaces and hard to read
* Modify a test to include this space.
Manuel Urbano Santos [Sun, 27 Nov 2011 12:49:47 +0000 (13:49 +0100)]
* Bug #671: Tags list on Edit page is not seperated by spaces and hard to read : Make 'media_tags_as_string' function put a space after each comma.
* Feature #678: Drop custom delimiters in tags : I declare a constant in the begining of text.py file.
Nathan Yergler [Sat, 26 Nov 2011 23:32:35 +0000 (15:32 -0800)]
Issue 680 Allow decorating views to prevent CSRF protection.
Nathan Yergler [Sat, 26 Nov 2011 22:34:36 +0000 (14:34 -0800)]
Issue 680: Dispatch meddleware request processing post-routing
Elrond [Sat, 26 Nov 2011 12:50:06 +0000 (13:50 +0100)]
Merge remote branch 'remotes/inconexo/588_lowercase_extension'
* remotes/inconexo/588_lowercase_extension:
Filename extensions are lowercased before uploading the image.
The merge failed really. It tried to apply the changes to
the wrong file. So applied them by hand to
mediagoblin/media_types/image/processing.py
Conflicts:
mediagoblin/processing.py
Elrond [Sun, 23 Oct 2011 21:29:15 +0000 (23:29 +0200)]
Use setup_global_and_app_config in gmg's migrate.
Instead of using read_mediagoblin_config, forgetting to
check the validation report and then finding the main app
section by hand, just use setup_global_and_app_config.
Elrond [Fri, 25 Nov 2011 21:16:18 +0000 (22:16 +0100)]
Add base class for Meddleware
Created a BaseMeddleware which all Meddleware should derive
from. This is not strictly needed, but will greatly help.
The base class has the common __init__ of all the other
Meddlwares and fall backs for all hooks. That way a new
Meddlware only needs to override what it actually wants to
implement.
Christopher Allan Webber [Fri, 25 Nov 2011 18:33:34 +0000 (12:33 -0600)]
Uncommenting requires=['gst'] till I figure out why Joar added it there :)
Christopher Allan Webber [Fri, 25 Nov 2011 18:13:56 +0000 (12:13 -0600)]
Rename MediaGoblin middleware to meddleware to avoid confusion w/ wsgi middleware
hehehehehe, "meddleware"
Christopher Allan Webber [Fri, 25 Nov 2011 17:43:34 +0000 (11:43 -0600)]
Removing these video javascript files, which are currently unused
Christopher Allan Webber [Fri, 25 Nov 2011 17:42:03 +0000 (11:42 -0600)]
Remove old enable_video config option
Christopher Allan Webber [Fri, 25 Nov 2011 17:41:24 +0000 (11:41 -0600)]
Load multiple media types based on the media_types section of the config file
Christopher Allan Webber [Thu, 24 Nov 2011 21:24:58 +0000 (15:24 -0600)]
Merge remote-tracking branch 'remotes/jwandborg/master'
Elrond [Mon, 21 Nov 2011 20:40:48 +0000 (21:40 +0100)]
Rename MediaEntry.uploader() to .get_uploader()
The .uploader() method conflicts with the uploader database
field. As we're moving to .FIELD for db field access, this
is a relevant conflict.
So renaming .uploader() to .get_uploader()
Elrond [Fri, 18 Nov 2011 22:37:25 +0000 (23:37 +0100)]
652: Don't show empty field labels.
If the label for a field is empty, don't show it at all.
And don't translate it!
Elrond [Tue, 22 Nov 2011 20:48:56 +0000 (21:48 +0100)]
Wrap long line.
Nothing else.
Pablo J. Urbano Santos [Tue, 22 Nov 2011 20:07:09 +0000 (21:07 +0100)]
Added a message noticing the user the image has been successfully
deleted.
Joar Wandborg [Tue, 22 Nov 2011 20:06:08 +0000 (21:06 +0100)]
Fixes for video branch
- Removed superfluous code from media_types.image
- Updated lazy_pass_to_ugettext imports
Pablo J. Urbano Santos [Tue, 22 Nov 2011 19:29:33 +0000 (20:29 +0100)]
Fixes #597. Add a visible error when user tries to delete an image
without cheking the "I'm sure" checkbox.
Joar Wandborg [Mon, 21 Nov 2011 23:09:41 +0000 (00:09 +0100)]
Video support is disabled by default, set enable_video to true to enable
Joar Wandborg [Mon, 21 Nov 2011 22:38:31 +0000 (23:38 +0100)]
Fixes after merging video into master - part 2
- Added handling of InvalidFileType to submit.views
- Updated test_celery_setup and test_submission tests to reflect the changes to the
media procesing infrastructure
Joar Wandborg [Mon, 21 Nov 2011 22:18:40 +0000 (23:18 +0100)]
Fixes after merging video branch into master
- Removed debug output from init/celery
- Moved process_media/__init__ to processing.py
- Centralized the processing.ProcessMedia task class
- Updated media managers to reference the processing function
instead of the ProcessMedia instance
- Updated new-style image processing to previous, newer old-style
image processing
- Updated video transcoding
- Changed method in progress output, sometimes
message.structure['percent'] raises KeyError
Pablo J. Urbano Santos [Mon, 21 Nov 2011 21:42:55 +0000 (22:42 +0100)]
Filename extensions are lowercased before uploading the image.
Joar Wandborg [Mon, 21 Nov 2011 20:51:30 +0000 (21:51 +0100)]
Merge branch 'video_gstreamer-only'
Conflicts:
mediagoblin/db/migrations.py
mediagoblin/submit/views.py
Joar Wandborg [Mon, 21 Nov 2011 20:47:00 +0000 (21:47 +0100)]
Refractored GStreamer element linking
Christopher Allan Webber [Mon, 21 Nov 2011 04:25:22 +0000 (22:25 -0600)]
Tests for StorageInterface*.copy_local_to_storage()
Christopher Allan Webber [Mon, 21 Nov 2011 04:03:38 +0000 (22:03 -0600)]
Made the image processing use intermediary conversion file.
This should fix the problem with PIL and the cloudfiles storage system
fighting.
Christopher Allan Webber [Mon, 21 Nov 2011 04:02:02 +0000 (22:02 -0600)]
Slightly clearer docs on copy_local_to_storage
Christopher Allan Webber [Mon, 21 Nov 2011 04:01:43 +0000 (22:01 -0600)]
copy_local_to_storage, both general and specialized-for-BasicFileStorage versions
This utility should allow for easy copying from a local filesystem to
the storage instance.
Joar Wandborg [Sun, 20 Nov 2011 23:06:59 +0000 (00:06 +0100)]
Stashing changes
Jakob Kramer [Sun, 20 Nov 2011 20:40:51 +0000 (21:40 +0100)]
fixed identation
Jakob Kramer [Sun, 20 Nov 2011 20:30:46 +0000 (21:30 +0100)]
eyecandy for programmers
Jakob Kramer [Sun, 20 Nov 2011 20:15:07 +0000 (21:15 +0100)]
don't use 'and' anymore, if there is only one tag
Elrond [Sun, 20 Nov 2011 19:15:21 +0000 (20:15 +0100)]
Fix redirect to logical path
redirects should in nearly all cases go to a logical path
like 'mediagoblin.auth.login' and not to an absolute path
like "/auth/login".
Elrond [Sun, 20 Nov 2011 19:00:08 +0000 (20:00 +0100)]
Merge remote branch 'remotes/aaronw/bug614_verification_crash'
* remotes/aaronw/bug614_verification_crash:
Update english translation file.
Reverse order of sanity checks: check email_verified after making sure there's a user in the request.
Make sure user isn't already verified before resending verification.
Check request.user to determine if user is logged in.
Regenerated English .po file to include new string.
Display and error and redirect to login page if unauthenticated user tries to access resend_verification.
Conflicts:
mediagoblin/i18n/en/LC_MESSAGES/mediagoblin.po
Jef van Schendel [Sun, 20 Nov 2011 16:01:23 +0000 (17:01 +0100)]
Navigation buttons edits. Removed images as they are no longer needed. Related: bug #504
Jef van Schendel [Sun, 20 Nov 2011 15:45:45 +0000 (16:45 +0100)]
Remove Edit/Delete icons, since they are not required yet.
Jef van Schendel [Sun, 20 Nov 2011 15:18:27 +0000 (16:18 +0100)]
Change tag list from a list to a paragraph. Wrap text for translation.
Jef van Schendel [Sun, 20 Nov 2011 14:34:40 +0000 (15:34 +0100)]
Fix for bug #467, "Add explanatory copy to add/edit picture pages saying that tags are comma-separated"
Jef van Schendel [Sun, 20 Nov 2011 00:57:29 +0000 (01:57 +0100)]
Slight style changes to button_action_highlight
Jef van Schendel [Sun, 20 Nov 2011 00:57:02 +0000 (01:57 +0100)]
Small correction, this button should be button_action, not button_form
Jef van Schendel [Sun, 20 Nov 2011 00:46:21 +0000 (01:46 +0100)]
Slight change to error wording
Jef van Schendel [Sun, 20 Nov 2011 00:43:48 +0000 (01:43 +0100)]
Another change to button style. Renamed header_submit, header_submit_highlight and button classes, correct all references to these
Jef van Schendel [Sun, 20 Nov 2011 00:12:10 +0000 (01:12 +0100)]
Change to background of "empty_space", it now uses an image
Jakob Kramer [Sat, 19 Nov 2011 23:35:09 +0000 (00:35 +0100)]
added unittests, now using form errors and fixed bug when no GET parameter is given for /edit/profile/
Jakob Kramer [Sat, 19 Nov 2011 21:17:21 +0000 (22:17 +0100)]
added support for changing the password, issue #643
Jef van Schendel [Sat, 19 Nov 2011 23:28:19 +0000 (00:28 +0100)]
Change button style a bit
Jef van Schendel [Sat, 19 Nov 2011 22:46:42 +0000 (23:46 +0100)]
Change form structure and add relevant CSS rules
Christopher Allan Webber [Sat, 19 Nov 2011 20:06:48 +0000 (14:06 -0600)]
Added back the title block
Christopher Allan Webber [Sat, 19 Nov 2011 20:04:56 +0000 (14:04 -0600)]
Merge remote branch 'remotes/inconexo/613_custom_title'
Christopher Allan Webber [Sat, 19 Nov 2011 20:03:01 +0000 (14:03 -0600)]
Added Pablo Santos to the AUTHORS file
Christopher Allan Webber [Sat, 19 Nov 2011 20:01:38 +0000 (14:01 -0600)]
Allow user to set whether comments are ascending or descending
Christopher Allan Webber [Sat, 19 Nov 2011 19:54:49 +0000 (13:54 -0600)]
Merge remote branch 'remotes/inconexo/441_comment_order'
Christopher Allan Webber [Sat, 19 Nov 2011 19:42:30 +0000 (13:42 -0600)]
Added Corey Farwell to the list of contributors
Corey Farwell [Sat, 19 Nov 2011 18:43:31 +0000 (10:43 -0800)]
incorrect path in nginx config
Pablo J. Urbano Santos [Sat, 19 Nov 2011 18:15:41 +0000 (19:15 +0100)]
media_home: order comments by ascending date.
Pablo J. Urbano Santos [Sat, 19 Nov 2011 18:11:42 +0000 (19:11 +0100)]
Added parameter ascending to MediaEntry::get_comments, if true, comments
will be ordered ascending, otherwise descending
Pablo J. Urbano Santos [Sat, 19 Nov 2011 16:07:41 +0000 (17:07 +0100)]
Allow instance owners to customize html titles of page:
Added html_title config option.
Made base.html template use html_title option as page title.
Christopher Allan Webber [Sat, 19 Nov 2011 14:33:29 +0000 (08:33 -0600)]
Add app_config and global_config to the template environment
Christopher Allan Webber [Sat, 19 Nov 2011 14:31:37 +0000 (08:31 -0600)]
Adding app_config and global_config to the template environment
Christopher Allan Webber [Fri, 18 Nov 2011 15:34:09 +0000 (09:34 -0600)]
Merge branch 'master' of gitorious.org:mediagoblin/mediagoblin
Conflicts:
mediagoblin/templates/mediagoblin/user_pages/user.html
Christopher Allan Webber [Wed, 16 Nov 2011 23:53:46 +0000 (17:53 -0600)]
Accidentally had user['profile'] where it shoulda been user['bio']
Joar Wandborg [Wed, 16 Nov 2011 13:20:27 +0000 (14:20 +0100)]
Fixed video transcoding
- Added audiorate with tolerance 80 million
- Removed deprecated thumbnailer
Joar Wandborg [Tue, 15 Nov 2011 21:43:05 +0000 (22:43 +0100)]
Committing some futile attempts to make GStreamer transcode the audio properly.
- Added CPU count detection
- Added videorate
- Added audiorate
Elrond [Mon, 14 Nov 2011 16:11:37 +0000 (17:11 +0100)]
Dot-Notation: x._id = ObjectId() doesn't seem to work properly
For whatever reason, this does not work as expected:
entry._id = ObjectId()
Need to go this way:
entry['_id'] = ObjectId()
Elrond [Sun, 13 Nov 2011 18:25:06 +0000 (19:25 +0100)]
Dot-Notation for "_id"
Note: Migrations can't use "Dot Notation"!
Migrations run on pymongo, not mongokit.
So they can't use the "Dot Notation".
This isn't really a big issue, as migrations are anyway
quite mongo specific.
Elrond [Mon, 14 Nov 2011 13:21:06 +0000 (14:21 +0100)]
Enable mongokit's "Dot notation"
mongokit documents can allow to use x.FIELD instead of
x["FIELD"].
First it looks a lot more pythonic.
Second it might allow us an easier migration path towards
an sqlalchemy database backend.
Docs: http://namlook.github.com/mongokit/tutorial.html#dot-notation
Elrond [Tue, 15 Nov 2011 10:21:15 +0000 (11:21 +0100)]
export: Handle Unicode titles better in logging
log("ascii %s" % unicode_string) tries to convert unicode
to ascii, which might fail.
Better use log(u"unicode format %s" % unicode_string) and
let the logging framework handle the conversion. This works
much better and the exceptions still happening aren't
stopping the main app.
Also remove one useless import.
Joar Wandborg [Mon, 14 Nov 2011 23:27:21 +0000 (00:27 +0100)]
moved from videoscale => ffvideoscale *and* put queus before video and audio pipes
Christopher Allan Webber [Mon, 14 Nov 2011 02:39:42 +0000 (20:39 -0600)]
Only show "post a comment" link if comments already exist
The purpose of the link is to help you jump past comments to the
comment box, and so...
Even with this new conditional, I'm not entirely sure I like that link ;)
Christopher Allan Webber [Mon, 14 Nov 2011 02:23:26 +0000 (20:23 -0600)]
Merge remote-tracking branch 'remotes/nyergler/pep8-ification'
Conflicts:
mediagoblin/db/migrations.py
mediagoblin/db/models.py
mediagoblin/user_pages/views.py
mediagoblin/util.py
Christopher Allan Webber [Sun, 13 Nov 2011 20:48:51 +0000 (14:48 -0600)]
Improving <title> on tag page *and* adjusting translation for RTL reasons
Basically moving the variable inside the translation to give
translators more flexibility
Christopher Allan Webber [Sun, 13 Nov 2011 20:42:03 +0000 (14:42 -0600)]
Enhanced title on the user's main media gallery
Christopher Allan Webber [Sun, 13 Nov 2011 20:40:11 +0000 (14:40 -0600)]
If the gallery view makes sure we have a user anyway, do we need this check?
Seems like the classic annoying "SHOULD NEVER HAPPEN" else: statement :)
Christopher Allan Webber [Sun, 13 Nov 2011 20:38:40 +0000 (14:38 -0600)]
Enhanced title for user profile page
Christopher Allan Webber [Sun, 13 Nov 2011 20:34:22 +0000 (14:34 -0600)]
Improved title block on media page
Christopher Allan Webber [Sun, 13 Nov 2011 20:20:16 +0000 (14:20 -0600)]
Merge remote-tracking branch 'remotes/nyergler/issue-653-csrf-exception'
Nathan Yergler [Sun, 13 Nov 2011 20:07:09 +0000 (12:07 -0800)]
Issue 653: This time for sure!
Nathan Yergler [Sun, 13 Nov 2011 19:59:24 +0000 (11:59 -0800)]
Issue 653: Handle the case where request.vary is None
Nathan Yergler [Sun, 13 Nov 2011 19:41:43 +0000 (11:41 -0800)]
Issue 653: Don't throw exception if response has no vary header.