mediagoblin.git
4 years agoMerge branch 'master' into stable stable
Ben Sturmfels [Tue, 5 May 2020 10:57:18 +0000 (20:57 +1000)]
Merge branch 'master' into stable

4 years agodocs: Update relnotes to remove "node_modules".
Ben Sturmfels [Tue, 5 May 2020 10:50:45 +0000 (20:50 +1000)]
docs: Update relnotes to remove "node_modules".

4 years agodocs: Link up subtitles and video qualities in release notes.
Ben Sturmfels [Mon, 4 May 2020 06:03:10 +0000 (16:03 +1000)]
docs: Link up subtitles and video qualities in release notes.

4 years agoMerge remote-tracking branch 'origin/master' into stable.
Ben Sturmfels [Mon, 4 May 2020 03:33:27 +0000 (13:33 +1000)]
Merge remote-tracking branch 'origin/master' into stable.

4 years agoRemove reference to Gitorious.
Ben Sturmfels [Mon, 4 May 2020 03:13:53 +0000 (13:13 +1000)]
Remove reference to Gitorious.

4 years agoUpdate version for release.
Ben Sturmfels [Mon, 4 May 2020 03:11:48 +0000 (13:11 +1000)]
Update version for release.

4 years agodocs: Tweak the release notes and deployment docs following testing.
Ben Sturmfels [Mon, 4 May 2020 03:10:24 +0000 (13:10 +1000)]
docs: Tweak the release notes and deployment docs following testing.

4 years agoAdd release notes for v0.10.0.
Ben Sturmfels [Fri, 1 May 2020 06:37:23 +0000 (16:37 +1000)]
Add release notes for v0.10.0.

4 years agoAllow Python 2 minor version upgrades [#5595].
Ben Sturmfels [Thu, 30 Apr 2020 10:47:37 +0000 (20:47 +1000)]
Allow Python 2 minor version upgrades [#5595].

4 years agoForcibly pin all Python 2 dependencies [#5595].
Ben Sturmfels [Thu, 30 Apr 2020 06:54:55 +0000 (16:54 +1000)]
Forcibly pin all Python 2 dependencies [#5595].

This is really horrible, but seems like the only way to stop Python 2 installs
breaking randomly in the future.

4 years agoFix Python 2 package dependencies and sub-dependencies [#5595].
Ben Sturmfels [Thu, 30 Apr 2020 05:15:14 +0000 (15:15 +1000)]
Fix Python 2 package dependencies and sub-dependencies [#5595].

This fixes the installation process *right now* on Python 2. The problem is that
packages are dropping Python 2 support all over the place and due to
our (deliberate) loose dependency version specifications and the loose
sub-dependency version specifications, it's one horrible mess. But it works
right now.

Next up I'll be pinning all the currently installed Python 2 packages and all
dependencies.

4 years agodocs: Note possible permission issues during install.
Ben Sturmfels [Thu, 30 Apr 2020 05:11:55 +0000 (15:11 +1000)]
docs: Note possible permission issues during install.

4 years agosubtitles: Add documentation, limit uploads to *.vtt files, only show for video ...
Ben Sturmfels [Thu, 30 Apr 2020 01:38:44 +0000 (11:38 +1000)]
subtitles: Add documentation, limit uploads to *.vtt files, only show for video [#5589].

4 years agoAdd deprecation warning when running Python 2 [#5598].
Ben Sturmfels [Wed, 29 Apr 2020 04:10:01 +0000 (14:10 +1000)]
Add deprecation warning when running Python 2 [#5598].

4 years agoTest and update the media-types docs with Debian 10 and CentOS.
Ben Sturmfels [Wed, 29 Apr 2020 03:27:01 +0000 (13:27 +1000)]
Test and update the media-types docs with Debian 10 and CentOS.

Unfortunately wasn't able to get video going in CentOS.

4 years agoFix headings in production.rst.
Ben Sturmfels [Wed, 29 Apr 2020 00:02:00 +0000 (10:02 +1000)]
Fix headings in production.rst.

4 years agoFix some docs build warnings.
Ben Sturmfels [Tue, 28 Apr 2020 23:55:28 +0000 (09:55 +1000)]
Fix some docs build warnings.

4 years agoAdd CentOS rabbitmq instructions.
Ben Sturmfels [Tue, 28 Apr 2020 23:07:01 +0000 (09:07 +1000)]
Add CentOS rabbitmq instructions.

4 years agoReview and update the deploment docs for Debian 10 and CentOS 8 [#5593].
Ben Sturmfels [Tue, 28 Apr 2020 16:19:16 +0000 (02:19 +1000)]
Review and update the deploment docs for Debian 10 and CentOS 8 [#5593].

Mostly a thorough test and cleanup. The significant change is moving the systemd
config into the deployment docs an the registration/security considerations to
production considerations docs.

4 years agoFix dependencies and tests for clean Python 2 & 3 test runs under Docker.
Ben Sturmfels [Tue, 28 Apr 2020 05:51:41 +0000 (15:51 +1000)]
Fix dependencies and tests for clean Python 2 & 3 test runs under Docker.

This change gives a clean test run in the Debian-based Python 2 and Python 3
docker images.

4 years agoRevert "Use audio icon when spectrogram fails. Add note to doc:media-types."
Ben Sturmfels [Tue, 28 Apr 2020 05:28:59 +0000 (15:28 +1000)]
Revert "Use audio icon when spectrogram fails. Add note to doc:media-types."

This reverts commit 2b487fc16de2fc7c961f8df725c5ece0e5f56e3a.

4 years agoRevert "Fix Jorge's audio upload workaround in Python 3."
Ben Sturmfels [Tue, 28 Apr 2020 05:26:40 +0000 (15:26 +1000)]
Revert "Fix Jorge's audio upload workaround in Python 3."

This reverts commit f1c288b1d87fed959a124816ef7a8fd40aec3dd3.

4 years agoRemove spectrograms from Python 2 also [#5594].
Ben Sturmfels [Tue, 28 Apr 2020 04:39:53 +0000 (14:39 +1000)]
Remove spectrograms from Python 2 also [#5594].

For 0.10.0 we're removing specrograms entirely for reliability. This change only
disables spectrograms and updates install docs and Dockerfiles. We still need
to strip out all the spectrogram code and extlib/freesound/.

4 years agoPreparing to release 0.10.
Ben Sturmfels [Tue, 28 Apr 2020 03:44:21 +0000 (13:44 +1000)]
Preparing to release 0.10.

4 years agoProperly quote --without-python3 in docs (#5596).
Ben Sturmfels [Tue, 28 Apr 2020 03:40:39 +0000 (13:40 +1000)]
Properly quote --without-python3 in docs (#5596).

4 years agoFix missing logo in docs.
Ben Sturmfels [Tue, 28 Apr 2020 03:39:03 +0000 (13:39 +1000)]
Fix missing logo in docs.

4 years agoFix Sphinx build warnings, remove gNewSense, *buntu -> Ubuntu.
Ben Sturmfels [Tue, 28 Apr 2020 03:36:48 +0000 (13:36 +1000)]
Fix Sphinx build warnings, remove gNewSense, *buntu -> Ubuntu.

The * feels like it might confuse no-programmers.

4 years agoAdd some initial release notes for 0.10.0 (incomplete).
Ben Sturmfels [Fri, 24 Apr 2020 05:41:38 +0000 (15:41 +1000)]
Add some initial release notes for 0.10.0 (incomplete).

4 years agoUnmute videos by default.
Ben Sturmfels [Fri, 24 Apr 2020 05:24:33 +0000 (15:24 +1000)]
Unmute videos by default.

Fixes #5590.

4 years agoSwitch to Python 3 by default.
Ben Sturmfels [Fri, 24 Apr 2020 04:38:16 +0000 (14:38 +1000)]
Switch to Python 3 by default.

Addresses #5592.

4 years agoAdd draft Fedora dockerfile.
Ben Sturmfels [Mon, 20 Apr 2020 02:51:27 +0000 (12:51 +1000)]
Add draft Fedora dockerfile.

4 years agoMerge branch 'no-fastcgi' of https://github.com/mtlynch/mediagoblin
Ben Sturmfels [Thu, 16 Apr 2020 01:39:40 +0000 (11:39 +1000)]
Merge branch 'no-fastcgi' of https://github.com/mtlynch/mediagoblin

4 years agoAdding 'Waitress' where 'FastCGI' was previously referenced
Michael Lynch [Thu, 16 Apr 2020 00:14:11 +0000 (20:14 -0400)]
Adding 'Waitress' where 'FastCGI' was previously referenced

4 years agoRemoving flup and fastcgi from documentation
Michael Lynch [Wed, 15 Apr 2020 00:45:54 +0000 (20:45 -0400)]
Removing flup and fastcgi from documentation

flup is not supported on Python3, so MediaGoblin doesn't have a supported way to enable FastCGI support.

This change removes all references to flup and FastCGI and updates deployment instructions to use simple HTTP forwarding with nginx to access mediagoblin's non-static resources.

4 years agoNote how to run test suite under Docker.
Ben Sturmfels [Tue, 14 Apr 2020 08:40:55 +0000 (18:40 +1000)]
Note how to run test suite under Docker.

4 years agoFix "KeyError: 'No such transport: sqlite. Did you mean sqla?'" in tests.
Ben Sturmfels [Tue, 14 Apr 2020 08:02:12 +0000 (18:02 +1000)]
Fix "KeyError: 'No such transport: sqlite.  Did you mean sqla?'" in tests.

This is caused by Celery dropping the "sqlite" transport alias from version
4.3.0, so I've pinned an upper limit.

4 years agoRemove "git submodule init && git submodule update" from Dockerfiles.
Ben Sturmfels [Tue, 14 Apr 2020 06:40:38 +0000 (16:40 +1000)]
Remove "git submodule init && git submodule update" from Dockerfiles.

These commands are run by `bootstrap.sh`. Also includes a couple more tidy-ups.

4 years agoRequire jinja2<3.0.0 due to use of f-strings.
Ben Sturmfels [Thu, 9 Apr 2020 21:14:39 +0000 (07:14 +1000)]
Require jinja2<3.0.0 due to use of f-strings.

4 years agoDecode request.query_string before use.
Ben Sturmfels [Thu, 9 Apr 2020 05:53:49 +0000 (15:53 +1000)]
Decode request.query_string before use.

Prior to this change, when pagination kicks in on the user management or report
management panel, the following exception is raised:

  TypeError: a bytes-like object is required, not 'str'

The cause is that `request.query_string` in the URL parameters in raw bytestring
form as per Werkzeug documentation.

4 years agoRevert "Decode request.query_string before use."
Ben Sturmfels [Thu, 9 Apr 2020 05:48:21 +0000 (15:48 +1000)]
Revert "Decode request.query_string before use."

This reverts commit b6fba854007bb4392846085a60178c44dbd7989e.

4 years agoDecode request.query_string before use.
Ben Sturmfels [Thu, 9 Apr 2020 05:29:51 +0000 (15:29 +1000)]
Decode request.query_string before use.

This doesn't seem to be an issue in my Guix SD/Python 3.7 testing, but hit an
issue on Debian 9/Python3.5 where concatenating text to `request.query_string`
was causing the error:

  TypeError: a bytes-like object is required, not 'str'

This clearly hasn't been an issue in the past though, so I suspect there's a
library somewhere that's on a different version and is behaving differently.

4 years agoDocument SSL/TLS SMTP options.
Ben Sturmfels [Tue, 7 Apr 2020 06:45:17 +0000 (16:45 +1000)]
Document SSL/TLS SMTP options.

4 years agoFix Jorge's audio upload workaround in Python 3.
Ben Sturmfels [Tue, 7 Apr 2020 06:35:09 +0000 (16:35 +1000)]
Fix Jorge's audio upload workaround in Python 3.

Unfortunately now the player isn't showing up because there's no thumbnail.

4 years agoNote possible future steps for Python 3 audio thumbnailing.
Ben Sturmfels [Thu, 2 Apr 2020 06:18:39 +0000 (17:18 +1100)]
Note possible future steps for Python 3 audio thumbnailing.

4 years agoUse audio icon when spectrogram fails. Add note to doc:media-types.
Jorge [Fri, 10 Feb 2017 22:18:19 +0000 (23:18 +0100)]
Use audio icon when spectrogram fails. Add note to doc:media-types.

In addition to side-stepping spectrograms completely in Python 3 in 1038aea8,
this commit adds some fallbacks that will help with potential issues in Python 2.

Fixes Issue #5457

Signed-off-by: Ben Sturmfels <ben@sturm.com.au>
Author: Jorge <mediagoblin@gybs.waa>

4 years agoFix broken Dockerfile reference.
Ben Sturmfels [Thu, 2 Apr 2020 04:29:30 +0000 (15:29 +1100)]
Fix broken Dockerfile reference.

4 years agoAdd Muto to AUTHORS.
Ben Sturmfels [Thu, 2 Apr 2020 03:00:10 +0000 (14:00 +1100)]
Add Muto to AUTHORS.

4 years agoAdd visual feedback on link hover
Muto [Mon, 20 Jan 2020 18:33:35 +0000 (11:33 -0700)]
Add visual feedback on link hover

Signed-off-by: Ben Sturmfels <ben@sturm.com.au>
4 years agoFix audio thumbnailing once and for all.
Ben Sturmfels [Wed, 1 Apr 2020 05:52:05 +0000 (16:52 +1100)]
Fix audio thumbnailing once and for all.

This change adds a Python 3-specific audio thumbnailer that side-steps the
bundled Python 2-only `audioprocessing` module. Instead of an audio spectrogram,
Python 3 users will get a static image.

This also allows me to remove my ineffective customisations to
`audioprocessing`, returning it to the upstream version as should always be the
case for vendored code in "extlib".

4 years agoHandle moved SharedDataMiddleware in werkzeug >= 0.15.0.
Ben Sturmfels [Wed, 1 Apr 2020 04:32:42 +0000 (15:32 +1100)]
Handle moved SharedDataMiddleware in werkzeug >= 0.15.0.

4 years agoNote werkzeug breaking in Guix.
Ben Sturmfels [Wed, 1 Apr 2020 04:30:25 +0000 (15:30 +1100)]
Note werkzeug breaking in Guix.

The `python-lxml` package has also moved.

4 years agoPin werkzeug < 1.0.0.
Ben Sturmfels [Wed, 1 Apr 2020 04:26:47 +0000 (15:26 +1100)]
Pin werkzeug < 1.0.0.

In 1.0.0, the werkzeug.contrib module was removed which was required for `werkzeug.contrib.atom.AtomFeed`.

5 years agoNote potential issues with guix environment --pure.
Ben Sturmfels [Wed, 27 Nov 2019 11:31:16 +0000 (22:31 +1100)]
Note potential issues with guix environment --pure.

5 years agoUse items() for Python 3 support.
Ben Sturmfels [Wed, 27 Nov 2019 11:30:19 +0000 (22:30 +1100)]
Use items() for Python 3 support.

5 years agoExtend install instructions for raven plugin.
Ben Sturmfels [Wed, 27 Nov 2019 11:14:52 +0000 (22:14 +1100)]
Extend install instructions for raven plugin.

5 years agoRename Dockerfiles to be more specific.
Ben Sturmfels [Tue, 19 Nov 2019 01:55:59 +0000 (12:55 +1100)]
Rename Dockerfiles to be more specific.

5 years agoDocument and improve Docker handling of mounted source code directory.
Ben Sturmfels [Tue, 19 Nov 2019 01:53:48 +0000 (12:53 +1100)]
Document and improve Docker handling of mounted source code directory.

5 years agoPrevent warning when importing GstPbutils.
Ben Sturmfels [Fri, 1 Nov 2019 05:41:45 +0000 (16:41 +1100)]
Prevent warning when importing GstPbutils.

Warning was:

PyGIWarning: GstPbutils was imported without specifying a version first. Use gi.require_version('GstPbutils', '1.0') before import to ensure that the right version gets loaded.

5 years agoAdd Olivier Mehani to AUTHORS.
Ben Sturmfels [Fri, 20 Sep 2019 00:39:35 +0000 (10:39 +1000)]
Add Olivier Mehani to AUTHORS.

5 years agoAdd datetime_format config option.
Olivier Mehani [Sun, 3 Mar 2019 11:17:27 +0000 (22:17 +1100)]
Add datetime_format config option.

Moves the datetime_format used in various places to the config and allows a
global override per site.

Signed-off-by: Ben Sturmfels <ben@sturm.com.au>
5 years agoMerge branch swo-gitignore.
Ben Sturmfels [Fri, 20 Sep 2019 00:01:10 +0000 (10:01 +1000)]
Merge branch swo-gitignore.

Thanks mlynch for the contribution!

5 years agoAdd expression to ignore Vim temporary swap files.
Ben Sturmfels [Thu, 19 Sep 2019 23:58:15 +0000 (09:58 +1000)]
Add expression to ignore Vim temporary swap files.

I gather that Vim continues back through the alphabet with .swp, swo, swn etc:
https://groups.google.com/forum/#!msg/vim_use/JBHSs3kPPJU/X9WeMsZcfWAJ

5 years agoNote use of direnv with guix.
Ben Sturmfels [Thu, 19 Sep 2019 07:28:48 +0000 (17:28 +1000)]
Note use of direnv with guix.

5 years agometadata_display: Refine spacing.
Ben Sturmfels [Wed, 18 Sep 2019 07:36:36 +0000 (17:36 +1000)]
metadata_display: Refine spacing.

5 years agometadata_display: Improve default alignment/spacing of metadata.
Ben Sturmfels [Wed, 18 Sep 2019 07:28:43 +0000 (17:28 +1000)]
metadata_display: Improve default alignment/spacing of metadata.

5 years agoEven up top/bottom margins around header dropdown button.
Ben Sturmfels [Wed, 18 Sep 2019 06:02:38 +0000 (16:02 +1000)]
Even up top/bottom margins around header dropdown button.

Bottom margin was less than top margin.

5 years agoAdd basic duplicate prevention for batchaddmedia.
Ben Sturmfels [Wed, 18 Sep 2019 05:58:24 +0000 (15:58 +1000)]
Add basic duplicate prevention for batchaddmedia.

5 years agoAdd omitted --system-site-packages for Python 3 on Guix, add update_extlib.sh docs.
Ben Sturmfels [Wed, 18 Sep 2019 05:57:16 +0000 (15:57 +1000)]
Add omitted --system-site-packages for Python 3 on Guix, add update_extlib.sh docs.

5 years agoUpdate metadata_display plugin for Python 3.
Ben Sturmfels [Wed, 18 Sep 2019 05:30:32 +0000 (15:30 +1000)]
Update metadata_display plugin for Python 3.

Switching from iteritems() to items() is technically less memory efficient on
Python 2, but this appeared be a significantly cleaner approach than adding six
to the template context. It's also the right choice assuming the project will at
some point go Python 3 only.

5 years agoAdd Python 3 docker-compose recipe for MediaGoblin hacking.
Ben Sturmfels [Mon, 16 Sep 2019 08:08:57 +0000 (18:08 +1000)]
Add Python 3 docker-compose recipe for MediaGoblin hacking.

5 years agoReorder Python 2 Dockerfile to install dependencies together.
Ben Sturmfels [Mon, 16 Sep 2019 07:27:05 +0000 (17:27 +1000)]
Reorder Python 2 Dockerfile to install dependencies together.

5 years agoAdd Python 2 & 3 Docker files for MediaGoblin hacking.
Ben Sturmfels [Thu, 12 Sep 2019 10:23:08 +0000 (20:23 +1000)]
Add Python 2 & 3 Docker files for MediaGoblin hacking.

5 years agoWork around lack of scikits.audiolab support on Python 3.
Ben Sturmfels [Thu, 12 Sep 2019 09:58:32 +0000 (19:58 +1000)]
Work around lack of scikits.audiolab support on Python 3.

5 years agobatchaddmedia: Simplify the Python 2 & 3 unicode handling.
Ben Sturmfels [Thu, 12 Sep 2019 09:39:54 +0000 (19:39 +1000)]
batchaddmedia: Simplify the Python 2 & 3 unicode handling.

To avoid issues with quotes, I've replaced the manual CSV handling with
csv.DictReader and simplified the unicode handling down to a single line. I
don't believe any special encoding is required when writing to the database.

This has been tested by importing a CSV with braille characters on Python 3 and
Python 2.

5 years agoRemove unicode literals in batchaddmedia.
Ben Sturmfels [Thu, 12 Sep 2019 05:41:36 +0000 (15:41 +1000)]
Remove unicode literals in batchaddmedia.

5 years agoFix URL-based importing with batchaddmedia command.
Ben Sturmfels [Thu, 12 Sep 2019 04:47:45 +0000 (14:47 +1000)]
Fix URL-based importing with batchaddmedia command.

The command was raising "io.UnsupportedOperation: seek" for URL-based imports
and didn't support HTTPS.

5 years agoFix bulkupload documentation example.
Ben Sturmfels [Thu, 12 Sep 2019 04:39:11 +0000 (14:39 +1000)]
Fix bulkupload documentation example.

The `bulkupload` command expects "dc:title", rather than "dcterms:title".
Similar for description.

5 years agoNote issues uploading H264 video under Guix.
Ben Sturmfels [Thu, 12 Sep 2019 04:31:56 +0000 (14:31 +1000)]
Note issues uploading H264 video under Guix.

5 years agoProvide an update_extlib.sh alternative for Guix.
Ben Sturmfels [Mon, 9 Sep 2019 06:24:45 +0000 (16:24 +1000)]
Provide an update_extlib.sh alternative for Guix.

5 years agoUpdate guix-env.scm for use with current version of Guix.
Ben Sturmfels [Mon, 9 Sep 2019 05:20:52 +0000 (15:20 +1000)]
Update guix-env.scm for use with current version of Guix.

6 years agoAdding *.swo to gitignore
Michael Lynch [Thu, 1 Nov 2018 13:12:39 +0000 (09:12 -0400)]
Adding *.swo to gitignore

6 years agorequire higher version of six due to installation problems
Boris Bobrov [Mon, 13 Aug 2018 08:53:52 +0000 (10:53 +0200)]
require higher version of six due to installation problems

6 years agoFix saving original of the video
Boris Bobrov [Fri, 13 Jul 2018 17:05:38 +0000 (19:05 +0200)]
Fix saving original of the video

Original of the video was not saved because info about it was not
written to the database. Fixed that.

Also removed original video from get_all_media listing. The method is
weird, we should evaluate whether it is video-specific and how to
generalize it.

6 years agosimplify an if and fix string formatting
Boris Bobrov [Fri, 13 Jul 2018 16:29:01 +0000 (18:29 +0200)]
simplify an if and fix string formatting

6 years agonitpicking
Boris Bobrov [Fri, 13 Jul 2018 13:00:58 +0000 (15:00 +0200)]
nitpicking

6 years agoclose tag in subtitles html
Boris Bobrov [Thu, 12 Jul 2018 17:06:18 +0000 (19:06 +0200)]
close tag in subtitles html

6 years agomove subtitles out of media streams in html
Boris Bobrov [Thu, 12 Jul 2018 17:04:45 +0000 (19:04 +0200)]
move subtitles out of media streams in html

6 years agoMerge branch 'transcoding_progress'
Boris Bobrov [Thu, 12 Jul 2018 16:49:35 +0000 (18:49 +0200)]
Merge branch 'transcoding_progress'

This probably broke stuff

6 years agoFixes for small bugs
Boris Bobrov [Thu, 12 Jul 2018 16:27:44 +0000 (18:27 +0200)]
Fixes for small bugs

There were some blocking issues in the code. They are small, but break
tests and/or production. Fixed some of them.

6 years agoalways guess the same filetype
Boris Bobrov [Thu, 12 Jul 2018 10:50:54 +0000 (12:50 +0200)]
always guess the same filetype

6 years agofinally fix url validator
Boris Bobrov [Thu, 12 Jul 2018 10:50:37 +0000 (12:50 +0200)]
finally fix url validator

6 years agoRevert "Revert "Import messages in blog views""
Boris Bobrov [Thu, 12 Jul 2018 05:36:00 +0000 (07:36 +0200)]
Revert "Revert "Import messages in blog views""

This reverts commit 8c36ec5246828e3c99d956edd8524f3ade430571.

6 years agofix typo
Boris Bobrov [Wed, 11 Jul 2018 16:26:23 +0000 (18:26 +0200)]
fix typo

6 years agofix auth error and simplify url and email checks
Boris Bobrov [Wed, 11 Jul 2018 15:30:09 +0000 (17:30 +0200)]
fix auth error and simplify url and email checks

6 years agoremove requirement for the file to be with single dot in name
Boris Bobrov [Wed, 11 Jul 2018 14:54:08 +0000 (16:54 +0200)]
remove requirement for the file to be with single dot in name

6 years agofix default gmg help message
Boris Bobrov [Wed, 11 Jul 2018 14:53:32 +0000 (16:53 +0200)]
fix default gmg help message

6 years agoMerge remote-tracking branch 'gsoc2016/Subtitle-1'
Boris Bobrov [Tue, 10 Jul 2018 16:29:30 +0000 (18:29 +0200)]
Merge remote-tracking branch 'gsoc2016/Subtitle-1'

6 years agoFix server crash on blog about page [#5572]
Andrew Browning [Sun, 8 Jul 2018 23:00:52 +0000 (19:00 -0400)]
Fix server crash on blog about page [#5572]

Don't bother checking for user's blog if no user returned.

6 years agoFix server crash on blog about page [#5572]
Andrew Browning [Sun, 8 Jul 2018 23:00:52 +0000 (19:00 -0400)]
Fix server crash on blog about page [#5572]

Don't bother checking for user's blog if no user returned.

6 years ago2 bug fixes in editor views
ĎÚβĨŐÚŚ Dod [Tue, 26 Jun 2018 13:28:29 +0000 (09:28 -0400)]
2 bug fixes in editor views

* `WTForms` instances get `__init__`-ed with `defaults` as `kwargs`.
  The first arg is a `request.form` (which is what one must supply if
  this is a `POST` and must *not* supply otherwise).
  The content of that form (empty on `GET`) has higher priority than
  the defaults (which makes the user get an empty form).

* Fix `edit_profile()` to allow changing `location` from a non-blank
  value to blank (i.e. removing the location).

(cherry picked from commit 75f3e23b92392b9bd309fab4c1a52fd38d453627)