Got this notice:

Notice: Only variables should be assigned by reference in /data/www/squirrelmail-devel/src/view_html.php on line 57
Warning: Cannot modify header information - headers already sent by (output started at /data/www/squirrelmail-devel/src/view_html.php:57) in /data/www/squirrelmail-devel/src/view_html.php on line 84

PHP 4.4.0-3 (Ubuntu 5.10 package)

This fix eliminates it.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10236 7612ce4b-ef26-0410-bec9-ea0150e637f0

Sorry, copy paste didn't workout as it should.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10235 7612ce4b-ef26-0410-bec9-ea0150e637f0

fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10234 7612ce4b-ef26-0410-bec9-ea0150e637f0

It's easier to trigger errors then trigger developers to look at css.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10233 7612ce4b-ef26-0410-bec9-ea0150e637f0

Update the cached flag info in the mailbox cache in case of an reply (set
the reply flag in the cache)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10232 7612ce4b-ef26-0410-bec9-ea0150e637f0

Security: XSS issue in search.php originally reported in stable before 1.4.5
final release, but appears to have been overlooked here.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10216 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding IMAP folder type controls to folder option widget. Widget uses default
noselect filtering and sent_subfolders needs to filter noinferiors

fixed sent_subfolder E_NOTICE issues with yearly subfolders and added delimiter
between subfolder base and year folder.

Sent Subfolder Base selection box now lists only folders without noinferiors flag.

Tested on UW.

Some complex folder check is pending.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10210 7612ce4b-ef26-0410-bec9-ea0150e637f0

don't show language option when only two language options (default and English) are available

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10209 7612ce4b-ef26-0410-bec9-ea0150e637f0

use shorter names for x-euc-tw, x-windows-949 and Outlook Express Korean charsets.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10208 7612ce4b-ef26-0410-bec9-ea0150e637f0

update @since tags

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10207 7612ce4b-ef26-0410-bec9-ea0150e637f0

CAN- -> CVE-

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10204 7612ce4b-ef26-0410-bec9-ea0150e637f0

If no filters defined, and spam filters are not enabled, don't bother
issuing a possibly costly IMAP STATUS call to INBOX.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10199 7612ce4b-ef26-0410-bec9-ea0150e637f0

Make sure session is started. In some rare cases, php sees the session_id
being empty after the session_destroy

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10198 7612ce4b-ef26-0410-bec9-ea0150e637f0

XHTML fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10180 7612ce4b-ef26-0410-bec9-ea0150e637f0

rearranging global.php layout:
* first list defines, then functions, then run code
* move php_self() function from strings.php to global.php in order to provide
$PHP_SELF to session functions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10179 7612ce4b-ef26-0410-bec9-ea0150e637f0

revert addition of security=restricted tag since that breaks our authentication.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10177 7612ce4b-ef26-0410-bec9-ea0150e637f0

HttpOnly cookies

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10175 7612ce4b-ef26-0410-bec9-ea0150e637f0

Support for HttpOnly cookies.
HttpOnly cookies prohibit access by Javascript. Currently only IE6 supports
it. See http://msdn.microsoft.com/workshop/author/dhtml/httponly_cookies.asp
In order to achieve that the cookie with the session_id also contains the
httponly cookie attribute I introduced a new function, sqsession_start which
overwrites the cookie set by php by our own cookie containing the session_id
and the httponly attribute.
All session_start calls are replaced by sqsession_start.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10174 7612ce4b-ef26-0410-bec9-ea0150e637f0

sanitizing address book listing. extra field row is added for plugins
that want to add html tags to address book listing (like vcard_abook).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10173 7612ce4b-ef26-0410-bec9-ea0150e637f0

Windows aspell returns \r\n line endings. if \r is not removed, it breaks
javascript and list of suggestions is empty.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10172 7612ce4b-ef26-0410-bec9-ea0150e637f0

set security=restricted attribute on the iframe, preventing javascript
and other tricks to be used inside its contents on supporting browsers.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10169 7612ce4b-ef26-0410-bec9-ea0150e637f0

information about decodeBody fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10153 7612ce4b-ef26-0410-bec9-ea0150e637f0

fixed quoted-printable decoding.
removed $show_html_default global call. Call was introduced in 1.113 and
made obsolate in 1.114.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10152 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding Andre Nicholson

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10151 7612ce4b-ef26-0410-bec9-ea0150e637f0

Update

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10140 7612ce4b-ef26-0410-bec9-ea0150e637f0

if html attachment has character set information, it can be converted.
missing part of 1195232 patch

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10139 7612ce4b-ef26-0410-bec9-ea0150e637f0

updating translators' list

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10138 7612ce4b-ef26-0410-bec9-ea0150e637f0

simplified check. thanks, Jon.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10132 7612ce4b-ef26-0410-bec9-ea0150e637f0

explaining $plugins tests

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10131 7612ce4b-ef26-0410-bec9-ea0150e637f0

fix imap command. \r\n is added by sqimap_run_command. If second \r\n is
present, it breaks next issued imap command (sqimap_mailbox_exists() always
returns true).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10119 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fixed/restored reply focus functionality

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10118 7612ce4b-ef26-0410-bec9-ea0150e637f0

added more configuration controls
fixed address book deletes
fixed signature table

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10117 7612ce4b-ef26-0410-bec9-ea0150e637f0

both examples posted on mailing list nuke abook files. Nice.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10116 7612ce4b-ef26-0410-bec9-ea0150e637f0

add bincimap to top list

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10114 7612ce4b-ef26-0410-bec9-ea0150e637f0

phpDocumentor updates

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10112 7612ce4b-ef26-0410-bec9-ea0150e637f0

removed local directory name used for testing.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10110 7612ce4b-ef26-0410-bec9-ea0150e637f0

Tomas Kuliavas wrote:

>Hi,
>
>You have posted script that converts SquirrelMail data files from files to
>sql on SquirrelMail users mailing list.
>
>http://article.gmane.org/gmane.mail.squirrelmail.user/6706
>
>Can you clarify script copyrights? I would like to include script in
>SquirrelMail package, but SquirrelMail can use only GPL licensed software.
>
>
>
I spoke with Tal ( the co-author ) and we are both quite comfortable
releasing this under the gpl.

We had originally offered to include it in the distro but no one took us
up on the offer.  We haven't used it in 2-3 years so I don't know if it
works with current versions.  I also don't believe either of us have any
interest in maintaining it but we welcome the projects use of it.

Michael

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10109 7612ce4b-ef26-0410-bec9-ea0150e637f0

Original file 2 sql export script posted by Michael Blandford <mikey <at> blandford.net>.
http://article.gmane.org/gmane.mail.squirrelmail.user/6706

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10108 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding kink's instuctions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10104 7612ce4b-ef26-0410-bec9-ea0150e637f0

Spell fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10103 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding translator

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10102 7612ce4b-ef26-0410-bec9-ea0150e637f0

Spell fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10095 7612ce4b-ef26-0410-bec9-ea0150e637f0

Adding more index.php files
Unifying index.php files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10091 7612ce4b-ef26-0410-bec9-ea0150e637f0

one more identity action to process

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10089 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding bincimap preset

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10087 7612ce4b-ef26-0410-bec9-ea0150e637f0

style fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10085 7612ce4b-ef26-0410-bec9-ea0150e637f0

information about db and configtest changes.
php backported array_shift features from 5.1 (#1286195).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10084 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding database field size checks (#1233721)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10083 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding rg=on test

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10082 7612ce4b-ef26-0410-bec9-ea0150e637f0

information about bincimap

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10080 7612ce4b-ef26-0410-bec9-ea0150e637f0

Focus fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10074 7612ce4b-ef26-0410-bec9-ea0150e637f0

Don't auto-focus on compose form when user has already focused somewhere manually (very annoying over slow connections)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10073 7612ce4b-ef26-0410-bec9-ea0150e637f0

checkForJavascript never returns SMPRF_JS_AUTODETECT

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10072 7612ce4b-ef26-0410-bec9-ea0150e637f0

hide other special folders
reduce number of imap calls used to list subscribed folders

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10056 7612ce4b-ef26-0410-bec9-ea0150e637f0

Update

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10043 7612ce4b-ef26-0410-bec9-ea0150e637f0

Reverting strings (didn't work out in all languages)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10042 7612ce4b-ef26-0410-bec9-ea0150e637f0

Update

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10039 7612ce4b-ef26-0410-bec9-ea0150e637f0

String fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10037 7612ce4b-ef26-0410-bec9-ea0150e637f0

Update

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10036 7612ce4b-ef26-0410-bec9-ea0150e637f0

Recycling existing strings

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10035 7612ce4b-ef26-0410-bec9-ea0150e637f0

String fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10034 7612ce4b-ef26-0410-bec9-ea0150e637f0

String and PHP fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10033 7612ce4b-ef26-0410-bec9-ea0150e637f0

reread what I've wrote :(

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10030 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding missing identity hooks
removing duplicate generic_header hook call

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10029 7612ce4b-ef26-0410-bec9-ea0150e637f0

Use shell exec so we can escape the fortune output.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10020 7612ce4b-ef26-0410-bec9-ea0150e637f0

Remove data/ dir from distribution, update docs accordingly.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9984 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix for 1222436.  Forwarding broken when compose in new window not used.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9983 7612ce4b-ef26-0410-bec9-ea0150e637f0

phpDoc fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9982 7612ce4b-ef26-0410-bec9-ea0150e637f0

Fix a small typo (at least I assume)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9981 7612ce4b-ef26-0410-bec9-ea0150e637f0

don't allow use of starttls on ldap socket connection

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9980 7612ce4b-ef26-0410-bec9-ea0150e637f0

place login form elements before login button. #1245070.
I think change was approved by Paul in plugins mailing list. If you think
that I am breaking too many things, I can revert the change.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9979 7612ce4b-ef26-0410-bec9-ea0150e637f0

convert character set in html messages

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9978 7612ce4b-ef26-0410-bec9-ea0150e637f0

HTML fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9976 7612ce4b-ef26-0410-bec9-ea0150e637f0

typo.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9974 7612ce4b-ef26-0410-bec9-ea0150e637f0

PHP 4.4.0 notice: Only variables should be assigned by reference in src/right_main.php on line 346

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9965 7612ce4b-ef26-0410-bec9-ea0150e637f0

PHP 4.4.0 notice: Only variables should be assigned by reference in src/view_text.php on line 49

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9963 7612ce4b-ef26-0410-bec9-ea0150e637f0

Don't attempt to delete a mailbox that does not exist.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9928 7612ce4b-ef26-0410-bec9-ea0150e637f0

remove html formating from error messages. XSS fixes sanitize errors and display &quot;

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9927 7612ce4b-ef26-0410-bec9-ea0150e637f0

removed references from abook_database.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9926 7612ce4b-ef26-0410-bec9-ea0150e637f0

removing references from backend functions. lookup causes E_NOTICE in php
4.4.0, because tries to return array(). Use of references can't be explained.
Main backend class and file/ldap backends don't use refencences. If it is
used for some reason, other lookup() should have to use references too.
I suspect that reason is performance or it is relict from some different code.
PHP manual says that developers should not use references in order to increase
performance.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9925 7612ce4b-ef26-0410-bec9-ea0150e637f0

Respect the error_reporting setting in php.ini and do not display errors
when the error level is not enabled in php.ini

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9923 7612ce4b-ef26-0410-bec9-ea0150e637f0

Do not use $key as varname outside functions because that's used for the
global secret key.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9922 7612ce4b-ef26-0410-bec9-ea0150e637f0

phpdoc fix.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9919 7612ce4b-ef26-0410-bec9-ea0150e637f0

update pot and add locale options to xgetpo script

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9917 7612ce4b-ef26-0410-bec9-ea0150e637f0

removing $available_languages option

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9916 7612ce4b-ef26-0410-bec9-ea0150e637f0

moving administrator check to option block registration. reduces amount of
code loaded during plugin's init. removing trailing linefeed from auth.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9915 7612ce4b-ef26-0410-bec9-ea0150e637f0

some languages use syntax that can't be adapted for printf command. If translator
tries to translate string correctly, he/she can create msgfmt errors.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9913 7612ce4b-ef26-0410-bec9-ea0150e637f0

adding -c option to msgfmt calls in order to detect formating errors (#1252843)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9912 7612ce4b-ef26-0410-bec9-ea0150e637f0

Replace PHP4 -> PHP since we also support upcoming PHP versions
(at least we wish to support them).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9901 7612ce4b-ef26-0410-bec9-ea0150e637f0

* sync matches and replacement arrays again in magicHtml()
* fix for regular expression that should catch
url(http://domain.tld/location)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9894 7612ce4b-ef26-0410-bec9-ea0150e637f0

chmod 700 locale

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9893 7612ce4b-ef26-0410-bec9-ea0150e637f0

more php 4.1.2 testing. it is possible that ini_get call is not needed.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9892 7612ce4b-ef26-0410-bec9-ea0150e637f0

using B encoding with headers in multibyte character sets.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9891 7612ce4b-ef26-0410-bec9-ea0150e637f0

glob exists only in 4.3.0+

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9890 7612ce4b-ef26-0410-bec9-ea0150e637f0

Allow configure to be ran from any directory, thanks Ceri Davies.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9888 7612ce4b-ef26-0410-bec9-ea0150e637f0

information about $languages update

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9887 7612ce4b-ef26-0410-bec9-ea0150e637f0

$languages are moved to locale/<localename>/setup.php files.
SquirrelMail locales cvs should support in any package from 1.4.6 and 1.5.1.

Code can't be used for 1.4.x stable, if XTRA_CODE fixes are not backported.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9886 7612ce4b-ef26-0410-bec9-ea0150e637f0

invalid doc entry

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9885 7612ce4b-ef26-0410-bec9-ea0150e637f0

B encoding code is unstable. needs more coding and testing

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9884 7612ce4b-ef26-0410-bec9-ea0150e637f0

removing obsolate file

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@9879 7612ce4b-ef26-0410-bec9-ea0150e637f0