Leave slug empty until we are sure media processing was successful.

Patch submitted by LotusEcho

diff --git a/mediagoblin/plugins/api/views.py b/mediagoblin/plugins/api/views.py
index 9159fe65bf0a580b1869fa30ce8e67c7edec5704..0e8735bcbfacc4646f872f01be26c40abf565b4f 100644 (file)
--- a/mediagoblin/plugins/api/views.py
+++ b/mediagoblin/plugins/api/views.py
@@ -61,8 +61,6 @@ def post_entry(request):
     entry.description = unicode(request.form.get('description'))
     entry.license = unicode(request.form.get('license', ''))
 
-    entry.generate_slug()
-
     # queue appropriately
     queue_file = prepare_queue_task(request.app, entry, media_file.filename)
 

diff --git a/mediagoblin/processing/task.py b/mediagoblin/processing/task.py
index 9af192edb97f0f902dc15b253c1918dcae40cd40..ba2323b29bd5e5ea9408c62ca86b3d5f24e54239 100644 (file)
--- a/mediagoblin/processing/task.py
+++ b/mediagoblin/processing/task.py
@@ -94,6 +94,8 @@ class ProcessMedia(task.Task):
             # We set the state to processed and save the entry here so there's
             # no need to save at the end of the processing stage, probably ;)
             entry.state = u'processed'
+            #Generate the slug here rather than earlier when it could have failed.
+            entry.generate_slug()
             entry.save()
 
             # Notify the PuSH servers as async task

diff --git a/mediagoblin/submit/views.py b/mediagoblin/submit/views.py
index 3f9d5b2df2ac0adf654934d52cb4e8075586ffa7..b2629bb5cab2e3d83a6389fa3cc388c01538d040 100644 (file)
--- a/mediagoblin/submit/views.py
+++ b/mediagoblin/submit/views.py
@@ -78,9 +78,6 @@ def submit_start(request):
                 entry.tags = convert_to_tag_list_of_dicts(
                     submit_form.tags.data)
 
-                # Generate a slug from the title
-                entry.generate_slug()
-
                 queue_file = prepare_queue_task(request.app, entry, filename)
 
                 with queue_file: