No reason really to pass in fetch_order anyway...

I think this is legacy code from get_display_media being a utility, or
something.  Removed!  (Thanks for pointing this out, Elrond!)

This commit sponsored by Tristan Chambers.  Thank you!

diff --git a/mediagoblin/db/mixin.py b/mediagoblin/db/mixin.py
index c4bd806c73c3ffb026213f9ef2655fe1f92b2063..92834a72b4e6a6331ae02a374742135d093813f6 100644 (file)
--- a/mediagoblin/db/mixin.py
+++ b/mediagoblin/db/mixin.py
@@ -126,18 +126,16 @@ class MediaEntryMixin(object):
         """
         return cleaned_markdown_conversion(self.description)
 
-    def get_display_media(self, fetch_order=None):
-        """
-        Find the best media for display.
+    def get_display_media(self):
+        """Find the best media for display.
 
-        Args:
-        - fetch_order: the order we should try fetching images in.
-            If this isn't supplied, we try checking
-            self.media_data.fetching_order if it exists.
+        We try checking self.media_data.fetching_order if it exists to
+        pull down the order.
 
         Returns:
           (media_size, media_path)
           or, if not found, None.
+
         """
         fetch_order = self.media_manager.get("media_fetch_order")