Much more nicely formed form error check

This doesn't rely on checking HTML output... thus, cleaner.

This commit sponsored by Alexandre Guédon.  Thank you!

diff --git a/mediagoblin/tests/test_edit.py b/mediagoblin/tests/test_edit.py
index e34ca27a87d7efed2ac413f52dfb7a15731ea461..547b382e2242c18ad3994c705ed8347962b6994a 100644 (file)
--- a/mediagoblin/tests/test_edit.py
+++ b/mediagoblin/tests/test_edit.py
@@ -250,5 +250,7 @@ class TestMetaDataEdit:
         old_metadata = new_metadata
         new_metadata = media_entry.media_metadata
         assert new_metadata == old_metadata
-        assert (b"'On the worst day' is not a 'date-time'" in
-            response.body)
+        context = template.TEMPLATE_TEST_CONTEXT[
+            'mediagoblin/edit/metadata.html']
+        assert context['form'].errors['media_metadata'][0]['identifier'][0] == \
+            "'On the worst day' is not a 'date-time'"