Fix url_for_self mixup

Move changes from mongo/models:url_for_self back into
mixin:url_for_self.

diff --git a/mediagoblin/db/mixin.py b/mediagoblin/db/mixin.py
index 4fb325d20a6edcbcffee354d0883042bfed164d0..5145289efbe56530ed59a2de5b360613289bb5cc 100644 (file)
--- a/mediagoblin/db/mixin.py
+++ b/mediagoblin/db/mixin.py
@@ -63,7 +63,7 @@ class MediaEntryMixin(object):
     def main_mediafile(self):
         pass
 
-    def url_for_self(self, urlgen):
+    def url_for_self(self, urlgen, **extra_args):
         """
         Generate an appropriate url for ourselves
 
@@ -75,12 +75,14 @@ class MediaEntryMixin(object):
             return urlgen(
                 'mediagoblin.user_pages.media_home',
                 user=uploader.username,
-                media=self.slug)
+                media=self.slug,
+                **extra_args)
         else:
             return urlgen(
                 'mediagoblin.user_pages.media_home',
                 user=uploader.username,
-                media=unicode(self._id))
+                media=unicode(self._id),
+                **extra_args)
 
     def get_fail_exception(self):
         """

diff --git a/mediagoblin/db/mongo/models.py b/mediagoblin/db/mongo/models.py
index d9b5a57039f69479877979154ddf7b59a08c6241..906d284934e0c68c10091b08616209e11c771608 100644 (file)
--- a/mediagoblin/db/mongo/models.py
+++ b/mediagoblin/db/mongo/models.py
@@ -226,27 +226,6 @@ class MediaEntry(Document, MediaEntryMixin):
         if duplicate:
             self.slug = "%s-%s" % (self._id, self.slug)
 
-    def url_for_self(self, urlgen, **extra_args):
-        """
-        Generate an appropriate url for ourselves
-
-        Use a slug if we have one, else use our '_id'.
-        """
-        uploader = self.get_uploader
-
-        if self.get('slug'):
-            return urlgen(
-                'mediagoblin.user_pages.media_home',
-                user=uploader.username,
-                media=self.slug,
-                **extra_args)
-        else:
-            return urlgen(
-                'mediagoblin.user_pages.media_home',
-                user=uploader.username,
-                media=unicode(self._id),
-                **extra_args)
-
     def url_to_prev(self, urlgen):
         """
         Provide a url to the previous entry from this user, if there is one