Return to media collection page if no collection selected

schendje rightly pointed out that we should not return to the media
homepage if we did not select a collection on the "collect" page, but
should actually return to the collect page.

This is an improvement of the user experience ;-)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>

diff --git a/mediagoblin/user_pages/views.py b/mediagoblin/user_pages/views.py
index 30c78a380b97b9d97b82c9c12f6393302b581b90..d1ec23dc41d670d027711952fd579c3015a56a0f 100644 (file)
--- a/mediagoblin/user_pages/views.py
+++ b/mediagoblin/user_pages/views.py
@@ -226,6 +226,10 @@ def media_collect(request, media):
         messages.add_message(
             request, messages.ERROR,
             _('You have to select or add a collection'))
+        return redirect(request, "mediagoblin.user_pages.media_collect",
+                    user=media.get_uploader.username,
+                    media=media.id)
+
 
     # Check whether media already exists in collection
     elif CollectionItem.query.filter_by(