Replace switch with a hash table.

diff --git a/trustcommerce.php b/trustcommerce.php
index 6b029cdd24b6f9ef0629d6f84853f96cc93db140..d81c5a24b2980ac0cf72f83d40f4c8c2cb36c13e 100644 (file)
--- a/trustcommerce.php
+++ b/trustcommerce.php
@@ -217,27 +217,19 @@ class org_fsf_payment_trustcommerce extends CRM_Core_Payment {
    * @public
    */
   function _getRecurPaymentFields($fields) {
-    $payments = $this->_getParam('frequency_interval');
-    $cycle = $this->_getParam('frequency_unit');
-
     /* Translate billing cycle from CiviCRM -> TC */
-    switch($cycle) {
-    case 'day':
-      $cycle = 'd';
-      break;
-    case 'week':
-      $cycle = 'w';
-      break;
-    case 'month':
-      $cycle = 'm';
-      break;
-    case 'year':
-      $cycle = 'y';
-      break;
-    }
-    
+    $cycle_map = array(
+      'day' => 'd',
+      'week' => 'w',
+      'month' => 'm',
+      'year' => 'y'
+    );
+    $cycle = $cycle_map[$this->_getParam('frequency_unit')];
+
+
     /* Translate frequency interval from CiviCRM -> TC
      * Payments are the same, HOWEVER a payment of 1 (forever) should be 0 in TC */
+    $payments = $this->_getParam('frequency_interval');
     if($payments == 1) {
       $payments = 0;
     }