Fixed incorrect logger.[...] calls

- Added FIXME about thumb size

diff --git a/mediagoblin/media_types/video/processing.py b/mediagoblin/media_types/video/processing.py
index a088468b5589dd79530da1c72c52ee9524779d8d..d7a48caa6349300da82d0c5b008c3afb93374b51 100644 (file)
--- a/mediagoblin/media_types/video/processing.py
+++ b/mediagoblin/media_types/video/processing.py
@@ -202,23 +202,23 @@ def __close_processing(queue, qentry, info, **kwargs):
 
 def _transcoding_start(queue, qentry, info):
     logger.info('-> Starting transcoding')
-    logger.debug(queue, qentry, info)
+    logger.debug((queue, qentry, info))
 
 
 def _transcoding_complete(*args):
     __close_processing(*args)
-    print(args)
+    logger.debug(*args)
 
 
-def _transcoding_error(queue, qentry, info, *args):
+def _transcoding_error(queue, qentry, arg, info):
     logger.info('Error')
     __close_processing(queue, qentry, info, error=True)
-    logger.debug(queue, quentry, info, *args)
+    logger.debug((queue, quentry, info, arg))
 
 
 def _transcoding_pass_setup(queue, qentry, options):
     logger.info('Pass setup')
-    logger.debug(queue, qentry, options)
+    logger.debug((queue, qentry, options))
 
 
 def check_interrupted():

diff --git a/mediagoblin/media_types/video/transcoders.py b/mediagoblin/media_types/video/transcoders.py
index 06bfd3cc072718eaf097b55a51260cb665e7f091..1134bc668ce184b1264db6d36eee4988d11ac58f 100644 (file)
--- a/mediagoblin/media_types/video/transcoders.py
+++ b/mediagoblin/media_types/video/transcoders.py
@@ -33,6 +33,7 @@ try:
 except:
     _log.error('pygst could not be imported')
 
+
 class VideoThumbnailer:
     def __init__(self, src, dst):
         self._set_up_pass(src, dst)
@@ -61,6 +62,7 @@ class VideoThumbnailer:
         self.pipeline.add(self.videoscale)
 
         self.capsfilter = gst.element_factory_make('capsfilter', 'capsfilter')
+        # FIXME: videoscale doesn't care about original ratios
         self.capsfilter.set_property('caps', gst.caps_from_string('video/x-raw-rgb, width=180, height=100'))
         self.pipeline.add(self.capsfilter)