SOCKS: fix unitialized-pointer

diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index e777a2fb2132a85775c74ecb7fa7bc9f0ae1c310..8f1b6b7ad0ecac60956989bee15e1dc67d7ffedd 100644 (file)
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -163,6 +163,9 @@ JH/26 Fix DKIM bug: when the pseudoheader generated for signing was exactly
 HS/02 Fix Bug 2130: large writes from the transport subprocess where chunked
       and confused the parent.
 
+JH/27 Fix SOCKS bug: an unitialized pointer was deref'd by the transport process
+      which could crash as a result.  This could lead to undeliverable messages.
+
 
 Exim version 4.89
 -----------------

diff --git a/src/src/transports/smtp_socks.c b/src/src/transports/smtp_socks.c
index 5558430686e5b3bdefaecf36ea64c50e23392dd4..92d13659df4cc52d4c9c3c35e05b7e17d0f94123 100644 (file)
--- a/src/src/transports/smtp_socks.c
+++ b/src/src/transports/smtp_socks.c
@@ -285,7 +285,7 @@ for(;;)
   sob = &proxies[idx];
 
   /* bodge up a host struct for the proxy */
-  proxy.address = sob->proxy_host;
+  proxy.address = proxy.name = sob->proxy_host;
   proxy_af = Ustrchr(sob->proxy_host, ':') ? AF_INET6 : AF_INET;
 
   if ((fd = smtp_sock_connect(&proxy, proxy_af, sob->port,