Simply for the Notification.object_id migration
authorJessica Tallon <tsyesika@tsyesika.se>
Mon, 29 Feb 2016 15:34:14 +0000 (15:34 +0000)
committerJessica Tallon <tsyesika@tsyesika.se>
Mon, 29 Feb 2016 15:34:14 +0000 (15:34 +0000)
mediagoblin/db/migrations/versions/4066b9f8b84a_use_comment_link_ids_notifications.py

index 2e9c75134f762480cbc4e041e0b3b2c531439775..9dfef18d66bdb3c84847953bbaaec70ed4c39cf2 100644 (file)
@@ -36,12 +36,6 @@ def upgrade():
             comment_table.c.comment_id == notification.object_id
         )).first()
 
-        # Okay now we need to update the notification with the ID of the link
-        # rather than the ID of TextComment object.
-        db.execute(notification_table.update().values(
-            object_id=comment_link.id
-        ))
         # Find the GMR for this comment or make one if one doesn't exist.
         gmr = db.execute(gmr_table.select().where(and_(
             gmr_table.c.obj_pk == comment_link.id,
@@ -86,10 +80,6 @@ def downgrade():
             comment_table.c.id == notification.object_id
         )).first()
 
-        # Update the notification with the TextComment (i.e. the comment object)
-        db.execute(notification_table.update().values(
-            object_id=comment_link.comment_id
-        ))
         # Find the GMR for the TextComment
         gmr = db.execute(gmr_table.select().where(and_(
             gmr_table.c.obj_pk == comment_link.id,