Use isinstance and six.text_type to check types of an object.
authorBerker Peksag <berker.peksag@gmail.com>
Mon, 28 Jul 2014 12:26:13 +0000 (15:26 +0300)
committerBerker Peksag <berker.peksag@gmail.com>
Mon, 28 Jul 2014 12:26:13 +0000 (15:26 +0300)
mediagoblin/oauth/views.py

index 14c8ab140c9bdcac3b54673ed9c606e53a54341c..fd848467084d353cc4266fd43404f36689bf16da 100644 (file)
@@ -16,6 +16,8 @@
 
 import datetime
 
+import six
+
 from oauthlib.oauth1 import (RequestTokenEndpoint, AuthorizationEndpoint,
                              AccessTokenEndpoint)
 
@@ -136,7 +138,7 @@ def client_register(request):
 
     contacts = data.get("contacts", None)
     if contacts is not None:
-        if type(contacts) is not unicode:
+        if not isinstance(contacts, six.text_type):
             error = "Contacts must be a string of space-seporated email addresses."
             return json_response({"error": error}, status=400)
 
@@ -152,7 +154,7 @@ def client_register(request):
 
     redirect_uris = data.get("redirect_uris", None)
     if redirect_uris is not None:
-        if type(redirect_uris) is not unicode:
+        if not isinstance(redirect_uris, six.text_type):
             error = "redirect_uris must be space-seporated URLs."
             return json_response({"error": error}, status=400)