tests/auth: Don't rely on case sensitive error strings
authorSebastian Spaeth <Sebastian@SSpaeth.de>
Wed, 12 Dec 2012 10:54:43 +0000 (11:54 +0100)
committerSebastian Spaeth <Sebastian@SSpaeth.de>
Fri, 21 Dec 2012 07:12:25 +0000 (08:12 +0100)
webob's 404 status is "404 NOT FOUND" while werkzeug's is
"404 Not Found". Our test suite was checking the upper case string
for equality. Just test the status error code "404" rather than the
full string which might change at some points/versions and should
not need to be tested.

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
mediagoblin/tests/test_auth.py

index 063651613f01ce065a11658602e57b4137f825d5..169b2309e7aa8883a71050724aee8632c1bf4d14 100644 (file)
@@ -266,7 +266,7 @@ def test_register_views(test_app):
     response = test_app.get(
         "/auth/forgot_password/verify/?userid=%s&token=total_bs" % unicode(
             new_user.id), status=404)
-    assert_equal(response.status, '404 Not Found')
+    assert_equal(response.status.split()[0], u'404') # status="404 NOT FOUND"
 
     ## Try using an expired token to change password, shouldn't work
     template.clear_test_template_context()
@@ -275,7 +275,7 @@ def test_register_views(test_app):
     new_user.fp_token_expire = datetime.datetime.now()
     new_user.save()
     response = test_app.get("%s?%s" % (path, get_params), status=404)
-    assert_equal(response.status, '404 Not Found')
+    assert_equal(response.status.split()[0], u'404') # status="404 NOT FOUND"
     new_user.fp_token_expire = real_token_expiration
     new_user.save()