Removing docstring bit about delete_file possibly deleting directories in the future
authorChristopher Allan Webber <cwebber@dustycloud.org>
Tue, 22 Jan 2013 20:32:00 +0000 (14:32 -0600)
committerChristopher Allan Webber <cwebber@dustycloud.org>
Tue, 22 Jan 2013 20:32:00 +0000 (14:32 -0600)
I agree that delete_dir as a separate operation is a better way to do
things, especially since there is a non-recursive deletion option that
will politely fail if the directory is not empty.

mediagoblin/storage/__init__.py

index 77e4212ec2e83c2ce4a00e7c8dcd953abf0359d6..57218eb519977ac12f60586877e762813cb59499 100644 (file)
@@ -102,10 +102,6 @@ class StorageInterface(object):
     def delete_file(self, filepath):
         """
         Delete or dereference the file (not directory) at filepath.
-
-        TODO: is the below comment correct? AFAIK, we won't clean up empty directories...
-        This might need to delete directories, buckets, whatever, for
-        cleanliness.  (Be sure to avoid race conditions on that though)
         """
         # Subclasses should override this method.
         self.__raise_not_implemented()