From d9188d9ad875c5e29b88f3be6d65447f48984fff Mon Sep 17 00:00:00 2001 From: pdontthink Date: Thu, 1 Nov 2007 19:34:39 +0000 Subject: [PATCH] Add note about erroneous hook placement - PLEASE read the comment and reply if you have any input git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12753 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- include/init.php | 1 + 1 file changed, 1 insertion(+) diff --git a/include/init.php b/include/init.php index d0709d16..50124500 100644 --- a/include/init.php +++ b/include/init.php @@ -273,6 +273,7 @@ $SQM_INTERNAL_VERSION[2] = intval($SQM_INTERNAL_VERSION[2]); /* load prefs system; even when user not logged in, should be OK to do this here */ require(SM_PATH . 'functions/prefs.php'); +// FIXME: config/plugin_hooks.php has not yet been loaded (see a few lines below); so this hook call should I think not be working -- has anyone actually tested it? Is there any reason we cannot move this prefs code block down below "MAIN PLUGIN LOADING CODE HERE" (see below)? Reading the code, I *think* it should be OK, but.... $prefs_backend = do_hook('prefs_backend', $null); if (isset($prefs_backend) && !empty($prefs_backend) && file_exists(SM_PATH . $prefs_backend)) { require(SM_PATH . $prefs_backend); -- 2.25.1