From 60445d6495d032665582a681465a24b2650da7a6 Mon Sep 17 00:00:00 2001
From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Mon, 5 Feb 2007 03:43:56 +0000
Subject: [PATCH] Reminders of how horribly embedded HTML is in core

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12220 7612ce4b-ef26-0410-bec9-ea0150e637f0
---
 src/compose.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/compose.php b/src/compose.php
index bc4d5667..e774fd82 100644
--- a/src/compose.php
+++ b/src/compose.php
@@ -1276,6 +1276,7 @@ function showInputForm ($session, $values=false) {
     } // End of file_uploads if-block
     /* End of attachment code */
 
+//FIXME: no direct echoing to browser, no HTML output in core!
     echo addHidden('username', $username).
          addHidden('smaction', $action).
          addHidden('mailbox', $mailbox);
@@ -1284,6 +1285,7 @@ function showInputForm ($session, $values=false) {
        so we can restore them in case of a session timeout.
      */
     sqgetGlobalVar('QUERY_STRING', $queryString, SQ_SERVER);
+//FIXME: no direct echoing to browser, no HTML output in core!
     echo addHidden('restoremessages', urlencode(serialize($compose_messages))).
         addHidden('composesession', $composesession).
         addHidden('querystring', $queryString).
@@ -1291,6 +1293,7 @@ function showInputForm ($session, $values=false) {
     if (!(bool) ini_get('file_uploads')) {
         /* File uploads are off, so we didn't show that part of the form.
            To avoid bogus bug reports, tell the user why. */
+//FIXME: no direct echoing to browser, no HTML output in core!
         echo '<p style="text-align:center">'
             . _("Because PHP file uploads are turned off, you can not attach files to this message. Please see your system administrator for details.")
             . "</p>\r\n";
@@ -1326,6 +1329,7 @@ function showComposeButtonRow() {
     $mdn_user_support=getPref($data_dir, $username, 'mdn_user_support',$default_use_mdn);
 
     if ($use_javascript_addr_book) {
+//FIXME: do not construct HTML in core!
         $addr_book = "         <script type=\"text/javascript\"><!--\n document.write(\"".
             "            <input type=button value=\\\""._("Addresses").
             "\\\" onclick=\\\"javascript:open_abook();\\\" />\");".
-- 
2.25.1