squirrelmail.git
2 months agofsf changes, meant to be rebased on upstream master
Ian Kelling [Mon, 27 Apr 2020 01:39:19 +0000 (21:39 -0400)]
fsf changes, meant to be rebased on upstream

As upstream changes, rebase this commit on top.

The change to read_body.php, documented here
https://sourceforge.net/p/squirrelmail/mailman/message/36992407/
copied here in case that link dies:

In the svn version, when viewing a message, if you click the move or
copy button, the page changes to the list of messages. In older versions
such as 1.4.13, that button was enabled by the delete_move_next plugin,
and when pressing move, the page would change to the next message. That
is clearly the way it should work. When using the preview panel, this
behavior especially makes no sense because you were already seeing the
message list and it just turns the preview panel into blank space.

After a quick look into the code, I was able to make a one line change
to the svn version so that the the page does not change at all when
pressing move, which helps workaround the problem so that I can then
press a key to go to the next message. I'm hoping someone here is
familiar with the code and can help identify the root cause and find a
proper fix so it goes to the next message.

Here is a comparison of the post request when clicking move in svn vs
old working 1.4.13:

SVN post:

https://webmail.fsf.org/src/read_body.php?mailbox=INBOX&sort=6&startMessage=1&passed_id=18
form data:
show_more "0"
move_id "19"
targetMailbox "INBOX.Trash"

Working 1.4.13 post:

https://mail1p.fsf.org/src/right_main.php
form data:
smtoken "EEZR1hS4cPUh"
mailbox "INBOX"
msg[0] "19"
targetMailbox "INBOX.Trash"
moveButton "Move"

I figured out that if the post url didn't have any path, or had a path
of "right_main.php", like the old version, it would stop changing the
page, and there was already an example in the code of not passing the
path, so I copied that to make this hacky patch.

I enabled level 2 debug mode, didnt result in any output in the logs.

Configtest shows no errors.

2 months agoMigrate away from using create_function as long as PHP 5.3+ is available
pdontthink [Mon, 8 Feb 2021 21:59:46 +0000 (21:59 +0000)]
Migrate away from using create_function as long as PHP 5.3+ is available

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14900 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoRemove random default argument value in the middle of argument list
pdontthink [Mon, 8 Feb 2021 07:00:12 +0000 (07:00 +0000)]
Remove random default argument value in the middle of argument list

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14898 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoStop using curly braces
pdontthink [Sat, 6 Feb 2021 08:02:22 +0000 (08:02 +0000)]
Stop using curly braces

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14894 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoStop using curly braces
pdontthink [Sat, 6 Feb 2021 07:25:55 +0000 (07:25 +0000)]
Stop using curly braces

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14893 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoStop using curly braces
pdontthink [Sat, 6 Feb 2021 07:22:06 +0000 (07:22 +0000)]
Stop using curly braces

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14892 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoHappy New Year
pdontthink [Fri, 5 Feb 2021 19:29:03 +0000 (19:29 +0000)]
Happy New Year

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14886 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoFix variable name typo
pdontthink [Wed, 3 Feb 2021 05:42:46 +0000 (05:42 +0000)]
Fix variable name typo

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14884 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoTypo fix
pdontthink [Sat, 16 Jan 2021 09:45:33 +0000 (09:45 +0000)]
Typo fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14882 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoRemove use of each() as it is deprecated
pdontthink [Sat, 16 Jan 2021 09:42:31 +0000 (09:42 +0000)]
Remove use of each() as it is deprecated

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14881 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoFix for unknown broken mailer using "UTC" in Date header
pdontthink [Sat, 16 Jan 2021 02:51:18 +0000 (02:51 +0000)]
Fix for unknown broken mailer using "UTC" in Date header

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14878 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoGive attribution
pdontthink [Fri, 15 Jan 2021 16:34:45 +0000 (16:34 +0000)]
Give attribution

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14877 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 months agoPHP 8 compatibility fix
pdontthink [Fri, 15 Jan 2021 16:30:25 +0000 (16:30 +0000)]
PHP 8 compatibility fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14876 7612ce4b-ef26-0410-bec9-ea0150e637f0

4 months agoAdd default ability to view calendar attachments sent as application/ics
pdontthink [Sat, 21 Nov 2020 04:00:56 +0000 (04:00 +0000)]
Add default ability to view calendar attachments sent as application/ics

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14875 7612ce4b-ef26-0410-bec9-ea0150e637f0

5 months agoFix what I think was a misunderstanding of what the "extra" attribute was supposed...
pdontthink [Tue, 3 Nov 2020 20:17:15 +0000 (20:17 +0000)]
Fix what I think was a misunderstanding of what the "extra" attribute was supposed to be for the anchor links for attachment actions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14873 7612ce4b-ef26-0410-bec9-ea0150e637f0

9 months agoFix index value that was left over from 1.4.x
pdontthink [Sat, 11 Jul 2020 07:52:44 +0000 (07:52 +0000)]
Fix index value that was left over from 1.4.x

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14871 7612ce4b-ef26-0410-bec9-ea0150e637f0

9 months agoAllow plugins to provide their own view/download attachment links
pdontthink [Sat, 11 Jul 2020 07:08:51 +0000 (07:08 +0000)]
Allow plugins to provide their own view/download attachment links

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14870 7612ce4b-ef26-0410-bec9-ea0150e637f0

9 months agoFix previously incomplete commit
pdontthink [Sat, 11 Jul 2020 06:12:50 +0000 (06:12 +0000)]
Fix previously incomplete commit

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14869 7612ce4b-ef26-0410-bec9-ea0150e637f0

9 months agoAdd MIME type parameters ("type0", "type1") to the end of the plugin arguments for...
pdontthink [Sat, 11 Jul 2020 04:31:18 +0000 (04:31 +0000)]
Add MIME type parameters ("type0", "type1") to the end of the plugin arguments for all attachment hooks

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14867 7612ce4b-ef26-0410-bec9-ea0150e637f0

9 months agoRemove needless code
pdontthink [Sat, 11 Jul 2020 04:14:56 +0000 (04:14 +0000)]
Remove needless code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14866 7612ce4b-ef26-0410-bec9-ea0150e637f0

10 months agoFix overlooked default parameter value
pdontthink [Mon, 25 May 2020 05:04:52 +0000 (05:04 +0000)]
Fix overlooked default parameter value

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14864 7612ce4b-ef26-0410-bec9-ea0150e637f0

10 months agoMore accurate filesizes
pdontthink [Sat, 23 May 2020 19:42:53 +0000 (19:42 +0000)]
More accurate filesizes

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14863 7612ce4b-ef26-0410-bec9-ea0150e637f0

10 months agoShow better filesize approximations for base64-encoded attachments
pdontthink [Sat, 23 May 2020 19:42:22 +0000 (19:42 +0000)]
Show better filesize approximations for base64-encoded attachments

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14862 7612ce4b-ef26-0410-bec9-ea0150e637f0

10 months agoUploaded file sizes seem to be reported differently by PHP filesize(); changing divis...
pdontthink [Sat, 23 May 2020 19:29:27 +0000 (19:29 +0000)]
Uploaded file sizes seem to be reported differently by PHP filesize(); changing divisor from 1024 to 1000 in this case. You can set $upload_filesize_divisor in config/config_local.php to 1024 if this breaks things for you. Feedback appreciated for this one.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14861 7612ce4b-ef26-0410-bec9-ea0150e637f0

11 months agoImplement ability to move to next message after moving the one you are viewing, per...
pdontthink [Fri, 8 May 2020 00:59:52 +0000 (00:59 +0000)]
Implement ability to move to next message after moving the one you are viewing, per the way delete_move_next plugins does from v1.4.x

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14856 7612ce4b-ef26-0410-bec9-ea0150e637f0

12 months agoDocument $php_self_pattern and $php_self_replacement
pdontthink [Wed, 25 Mar 2020 00:20:42 +0000 (00:20 +0000)]
Document $php_self_pattern and $php_self_replacement

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14853 7612ce4b-ef26-0410-bec9-ea0150e637f0

12 months agoDocument $php_self_pattern and $php_self_replacement
pdontthink [Tue, 24 Mar 2020 22:44:57 +0000 (22:44 +0000)]
Document $php_self_pattern and $php_self_replacement

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14851 7612ce4b-ef26-0410-bec9-ea0150e637f0

12 months agoCache $PHP_SELF value, add ability to make custom changes to $PHP_SELF by putting...
pdontthink [Tue, 24 Mar 2020 20:12:42 +0000 (20:12 +0000)]
Cache $PHP_SELF value, add ability to make custom changes to $PHP_SELF by putting $php_self_pattern and $php_self_replacement in config/config_local.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14850 7612ce4b-ef26-0410-bec9-ea0150e637f0

12 months agoSearch page should remember last move-target too
pdontthink [Tue, 24 Mar 2020 17:38:48 +0000 (17:38 +0000)]
Search page should remember last move-target too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14848 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 months agoHappy New Year
pdontthink [Tue, 7 Jan 2020 08:09:34 +0000 (08:09 +0000)]
Happy New Year

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14845 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 months agoEven better HTML email content style containment
pdontthink [Tue, 7 Jan 2020 06:49:42 +0000 (06:49 +0000)]
Even better HTML email content style containment

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14839 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 months agoBetter HTML email content style containment
pdontthink [Mon, 6 Jan 2020 21:22:00 +0000 (21:22 +0000)]
Better HTML email content style containment

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14837 7612ce4b-ef26-0410-bec9-ea0150e637f0

19 months agoFix broken anchor links
pdontthink [Mon, 2 Sep 2019 02:45:49 +0000 (02:45 +0000)]
Fix broken anchor links

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14834 7612ce4b-ef26-0410-bec9-ea0150e637f0

20 months agoDocument CVE-2019-12970 fix
pdontthink [Wed, 24 Jul 2019 01:13:11 +0000 (01:13 +0000)]
Document CVE-2019-12970 fix

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14831 7612ce4b-ef26-0410-bec9-ea0150e637f0

20 months agoDocument new config_local item for CVE-2019-12970
pdontthink [Wed, 24 Jul 2019 01:07:50 +0000 (01:07 +0000)]
Document new config_local item for CVE-2019-12970

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14830 7612ce4b-ef26-0410-bec9-ea0150e637f0

20 months agoAdd handling for RCDATA and RAWTEXT elements in HTML sanitizer (CVE-2019-12970)
pdontthink [Wed, 24 Jul 2019 00:57:42 +0000 (00:57 +0000)]
Add handling for RCDATA and RAWTEXT elements in HTML sanitizer (CVE-2019-12970)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14829 7612ce4b-ef26-0410-bec9-ea0150e637f0

21 months agoPHP7.2 fix (#2848)
pdontthink [Tue, 18 Jun 2019 06:59:25 +0000 (06:59 +0000)]
PHP7.2 fix (#2848)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14826 7612ce4b-ef26-0410-bec9-ea0150e637f0

22 months agoSome browswers were not putting cursor at beginning of message body after focus
pdontthink [Mon, 27 May 2019 21:54:59 +0000 (21:54 +0000)]
Some browswers were not putting cursor at beginning of message body after focus

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14824 7612ce4b-ef26-0410-bec9-ea0150e637f0

22 months agoDon't wrap headers right after the name (configurable)
pdontthink [Tue, 21 May 2019 00:56:59 +0000 (00:56 +0000)]
Don't wrap headers right after the name (configurable)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14822 7612ce4b-ef26-0410-bec9-ea0150e637f0

23 months agoCorrect mistaken use of rfc822_header->date field that was being treated as a date...
pdontthink [Tue, 30 Apr 2019 02:30:07 +0000 (02:30 +0000)]
Correct mistaken use of rfc822_header->date field that was being treated as a date string when it is only ever a timestamp

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14818 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd IMAP ID command (RFC2971), sent after every login - use by setting $imap_id_comma...
pdontthink [Sat, 6 Apr 2019 19:06:29 +0000 (19:06 +0000)]
Add IMAP ID command (RFC2971), sent after every login - use by setting $imap_id_command_args in config/config_local.php (see notes in config/config_local.example.php for more details)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14814 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoUpdated SVG handling, closing several related vulnerabilities reported in #2831 and...
pdontthink [Wed, 27 Feb 2019 03:45:41 +0000 (03:45 +0000)]
Updated SVG handling, closing several related vulnerabilities reported in #2831 and CVE-2018-14950, CVE-2018-14951, CVE-2018-14952, CVE-2018-14953, CVE-2018-14954, CVE-2018-14955

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14810 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd new options for SVG handling and broken base64-encoded messages
pdontthink [Wed, 27 Feb 2019 03:31:33 +0000 (03:31 +0000)]
Add new options for SVG handling and broken base64-encoded messages

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14809 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoDisable SVG display be default
pdontthink [Wed, 27 Feb 2019 02:07:23 +0000 (02:07 +0000)]
Disable SVG display be default

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14807 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoUpdated SVG handling, gracefully fix broken base64-encoded messages, also close XSS...
pdontthink [Sat, 23 Feb 2019 22:04:27 +0000 (22:04 +0000)]
Updated SVG handling, gracefully fix broken base64-encoded messages, also close XSS reported in #2831 and CVE-2018-14950, CVE-2018-14951, CVE-2018-14952, CVE-2018-14953, CVE-2018-14954, CVE-2018-14955

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14805 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoWhen message being replied to has no Reply-To header, we use the From header to fill...
pdontthink [Sat, 23 Feb 2019 07:13:52 +0000 (07:13 +0000)]
When message being replied to has no Reply-To header, we use the From header to fill in the reply To address, so we have to account for that situation when building the Cc header

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14803 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoHappy New Year
pdontthink [Tue, 8 Jan 2019 04:38:12 +0000 (04:38 +0000)]
Happy New Year

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14801 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAllow unsent compose sessions to stay around, but remove them after successful send
pdontthink [Sun, 25 Nov 2018 20:25:43 +0000 (20:25 +0000)]
Allow unsent compose sessions to stay around, but remove them after successful send

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14799 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoMake sure link tags are proper XHTML
pdontthink [Sat, 13 Oct 2018 22:59:15 +0000 (22:59 +0000)]
Make sure link tags are proper XHTML

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14792 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoForgot the icon file
pdontthink [Sat, 13 Oct 2018 15:40:11 +0000 (15:40 +0000)]
Forgot the icon file

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14790 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd favicon and ability for admins to use their own by setting $head_tag_extra in...
pdontthink [Sat, 13 Oct 2018 07:18:33 +0000 (07:18 +0000)]
Add favicon and ability for admins to use their own by setting $head_tag_extra in config_local.php (see documentation in config/config_local.php)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14789 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd generic bottom hook for miscellaneous option pages
pdontthink [Mon, 8 Oct 2018 17:36:34 +0000 (17:36 +0000)]
Add generic bottom hook for miscellaneous option pages

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14785 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoFix broken mailto links created by some (Microsoft?) clients
pdontthink [Fri, 21 Sep 2018 17:21:03 +0000 (17:21 +0000)]
Fix broken mailto links created by some (Microsoft?) clients

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14779 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd better spam header handling; also cache raw headers
pdontthink [Wed, 19 Sep 2018 15:59:00 +0000 (15:59 +0000)]
Add better spam header handling; also cache raw headers

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14778 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAllow caller to get message object before sending
pdontthink [Wed, 12 Sep 2018 18:28:28 +0000 (18:28 +0000)]
Allow caller to get message object before sending

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14776 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoGive back the message object to those who want it
pdontthink [Wed, 12 Sep 2018 17:27:58 +0000 (17:27 +0000)]
Give back the message object to those who want it

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14775 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoStream options were forgot here
pdontthink [Wed, 12 Sep 2018 14:05:13 +0000 (14:05 +0000)]
Stream options were forgot here

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14774 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoChange anti-CSRF security token lifetime to be session-based
pdontthink [Sat, 25 Aug 2018 21:03:09 +0000 (21:03 +0000)]
Change anti-CSRF security token lifetime to be session-based

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14772 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd hidden configuration variables for anti-CSRF security token features
pdontthink [Sat, 25 Aug 2018 20:57:06 +0000 (20:57 +0000)]
Add hidden configuration variables for anti-CSRF security token features

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14771 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAdd session-based security token functionality (enabled by default)
pdontthink [Sat, 25 Aug 2018 20:40:34 +0000 (20:40 +0000)]
Add session-based security token functionality (enabled by default)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14770 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoAllow more advanced element focusing
pdontthink [Thu, 19 Apr 2018 20:43:35 +0000 (20:43 +0000)]
Allow more advanced element focusing

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14765 7612ce4b-ef26-0410-bec9-ea0150e637f0

2 years agoTLS settings were not working
pdontthink [Thu, 19 Apr 2018 11:01:57 +0000 (11:01 +0000)]
TLS settings were not working

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14762 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoFix link
pdontthink [Fri, 6 Apr 2018 17:31:06 +0000 (17:31 +0000)]
Fix link

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14756 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoCorrect CVE number
pdontthink [Wed, 4 Apr 2018 07:49:48 +0000 (07:49 +0000)]
Correct CVE number

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14755 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoSanitize user-supplied attachment filename [CVE-2018-8741]
pdontthink [Wed, 4 Apr 2018 03:19:39 +0000 (03:19 +0000)]
Sanitize user-supplied attachment filename [CVE-2018-8741]

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14753 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoHappy New Year
pdontthink [Tue, 16 Jan 2018 23:44:07 +0000 (23:44 +0000)]
Happy New Year

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14750 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoSeriously? The variable is named as an array and initialized as a string? Well, I...
pdontthink [Fri, 29 Dec 2017 20:03:40 +0000 (20:03 +0000)]
Seriously? The variable is named as an array and initialized as a string? Well, I hope no callers were expecting a potentially empty string, because now they will get an empty array instead. empty() should handle this fine, hopefully callers do something sane like that.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14748 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoDocument bad assumption
pdontthink [Tue, 19 Dec 2017 05:02:38 +0000 (05:02 +0000)]
Document bad assumption

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14747 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMake return-to-message work for forwards
pdontthink [Wed, 22 Nov 2017 22:56:18 +0000 (22:56 +0000)]
Make return-to-message work for forwards

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14745 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd option to allow returning to the message one had been replying to after sending
pdontthink [Wed, 22 Nov 2017 06:15:41 +0000 (06:15 +0000)]
Add option to allow returning to the message one had been replying to after sending

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14742 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd option to allow returning to the message one had been replying to after sending
pdontthink [Wed, 22 Nov 2017 06:08:38 +0000 (06:08 +0000)]
Add option to allow returning to the message one had been replying to after sending

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14741 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd ability for saved drafts to indicate if they are a reply or forward and if so...
pdontthink [Sat, 18 Nov 2017 22:59:59 +0000 (22:59 +0000)]
Add ability for saved drafts to indicate if they are a reply or forward and if so, to which message, and mark that message as replied or forwarded when the draft is finally sent

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14737 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd ability for saved drafts to indicate if they are a reply or forward and if so...
pdontthink [Sat, 18 Nov 2017 22:58:10 +0000 (22:58 +0000)]
Add ability for saved drafts to indicate if they are a reply or forward and if so, to which message, and mark that message as replied or forwarded when the draft is finally sent

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14736 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMinor fix and clarify return types
pdontthink [Sat, 18 Nov 2017 22:44:10 +0000 (22:44 +0000)]
Minor fix and clarify return types

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14735 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMinor fix and clarify return types
pdontthink [Sat, 18 Nov 2017 22:41:40 +0000 (22:41 +0000)]
Minor fix and clarify return types

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14734 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAllow callers of sqm_api_mailbox_select() to determine if errors should be handled...
pdontthink [Sat, 18 Nov 2017 22:33:48 +0000 (22:33 +0000)]
Allow callers of sqm_api_mailbox_select() to determine if errors should be handled internally or just returned

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14733 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMake drafts send with in-reply-to headers (fix regression from long ago)
pdontthink [Sat, 18 Nov 2017 22:09:00 +0000 (22:09 +0000)]
Make drafts send with in-reply-to headers (fix regression from long ago)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14732 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAllow callers of sqimap_mailbox_select() to determine if errors should be handled...
pdontthink [Sat, 18 Nov 2017 21:29:11 +0000 (21:29 +0000)]
Allow callers of sqimap_mailbox_select() to determine if errors should be handled internally or just returned

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14727 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMay as well grab offset info too
pdontthink [Fri, 10 Nov 2017 02:39:26 +0000 (02:39 +0000)]
May as well grab offset info too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14724 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMinor change
pdontthink [Mon, 2 Oct 2017 02:20:48 +0000 (02:20 +0000)]
Minor change

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14722 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd trailing text display to edit list widget types
pdontthink [Wed, 13 Sep 2017 01:42:34 +0000 (01:42 +0000)]
Add trailing text display to edit list widget types

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14720 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd docs for function
pdontthink [Wed, 13 Sep 2017 01:26:14 +0000 (01:26 +0000)]
Add docs for function

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14719 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd trailing text to boolean-radio widgets
pdontthink [Thu, 17 Aug 2017 02:34:54 +0000 (02:34 +0000)]
Add trailing text to boolean-radio widgets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14715 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoRemove outdated headers
pdontthink [Wed, 16 Aug 2017 07:59:53 +0000 (07:59 +0000)]
Remove outdated headers

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14713 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd title to folder names
pdontthink [Mon, 7 Aug 2017 09:25:27 +0000 (09:25 +0000)]
Add title to folder names

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14711 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAllow options to use HTML in trailing text
pdontthink [Tue, 25 Jul 2017 22:25:39 +0000 (22:25 +0000)]
Allow options to use HTML in trailing text

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14706 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAllow options to use HTML in trailing text
pdontthink [Tue, 25 Jul 2017 22:16:04 +0000 (22:16 +0000)]
Allow options to use HTML in trailing text

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14705 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoLegacy code was probably wrong
pdontthink [Thu, 6 Jul 2017 04:33:07 +0000 (04:33 +0000)]
Legacy code was probably wrong

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14702 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd newline after <textarea> because it is always removed by the browser per spec...
pdontthink [Thu, 6 Jul 2017 02:36:51 +0000 (02:36 +0000)]
Add newline after <textarea> because it is always removed by the browser per spec: https://w3.org/TR/html401/appendix/notes.html#notes-line-breaks

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14699 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd note about squirrelspell plugin change
pdontthink [Sat, 17 Jun 2017 20:26:31 +0000 (20:26 +0000)]
Add note about squirrelspell plugin change

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14687 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd ability to control the display of the "Check Spelling" button. Allows administrat...
pdontthink [Sat, 17 Jun 2017 20:23:12 +0000 (20:23 +0000)]
Add ability to control the display of the "Check Spelling" button. Allows administrators to offer this plugin but keep it out of the way for users who do not want it. Put sqspell_show_button=0 in default preferences if it should be hidden by default.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14686 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMissing close form tag
pdontthink [Sat, 17 Jun 2017 20:08:33 +0000 (20:08 +0000)]
Missing close form tag

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14683 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd "trailing_text_small" flag for option widgets
pdontthink [Mon, 12 Jun 2017 08:15:08 +0000 (08:15 +0000)]
Add "trailing_text_small" flag for option widgets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14676 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoBetter white space and wrapping
pdontthink [Mon, 12 Jun 2017 07:54:06 +0000 (07:54 +0000)]
Better white space and wrapping

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14675 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoBetter white space and wrapping
pdontthink [Mon, 12 Jun 2017 07:49:33 +0000 (07:49 +0000)]
Better white space and wrapping

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14674 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoSM doesn't know how to log in again on the same connection, so best to actually close...
pdontthink [Fri, 9 Jun 2017 10:25:27 +0000 (10:25 +0000)]
SM doesn't know how to log in again on the same connection, so best to actually close the file handle as well

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14662 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAllow HTML in option info
pdontthink [Sat, 3 Jun 2017 16:30:59 +0000 (16:30 +0000)]
Allow HTML in option info

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14658 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoMake server TZ available after it is changed
pdontthink [Tue, 2 May 2017 19:55:46 +0000 (19:55 +0000)]
Make server TZ available after it is changed

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14656 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoChange credits
pdontthink [Tue, 25 Apr 2017 16:58:16 +0000 (16:58 +0000)]
Change credits

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14654 7612ce4b-ef26-0410-bec9-ea0150e637f0

3 years agoAdd one more person
pdontthink [Mon, 24 Apr 2017 20:22:15 +0000 (20:22 +0000)]
Add one more person

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@14651 7612ce4b-ef26-0410-bec9-ea0150e637f0