15 years agoChangr filename back.
pdontthink [Tue, 17 Jul 2007 01:23:13 +0000 (01:23 +0000)]
Changr filename back.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12548 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoUse attachment_dir only at the point where we're actually
kink [Mon, 16 Jul 2007 20:48:46 +0000 (20:48 +0000)]
Use attachment_dir only at the point where we're actually
reading from / writing to the files, do not carry it around
in the object. This makes us safer in the event the object
is somehow exposed to the outside world.

I may be cleaning this up some more for devel.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12541 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoEnable better plugin motd hooking
pdontthink [Sun, 15 Jul 2007 19:16:05 +0000 (19:16 +0000)]
Enable better plugin motd hooking

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12539 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agouse PAGE_NAME rather than PHP_SELF in session_expired_location
kink [Sat, 14 Jul 2007 18:04:09 +0000 (18:04 +0000)]
use PAGE_NAME rather than PHP_SELF in session_expired_location

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12536 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agouse PAGE_NAME in themes and templates
kink [Sat, 14 Jul 2007 17:56:47 +0000 (17:56 +0000)]
use PAGE_NAME in themes and templates

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12535 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop unused global
kink [Sat, 14 Jul 2007 17:45:20 +0000 (17:45 +0000)]
drop unused global

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12534 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomake use of PAGE_NAME constant in plugin, prefix it with the plugin name.
kink [Sat, 14 Jul 2007 17:44:29 +0000 (17:44 +0000)]
make use of PAGE_NAME constant in plugin, prefix it with the plugin name.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12533 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agouse PAGE_NAME to switch on which page we are, rather than
kink [Sat, 14 Jul 2007 17:39:27 +0000 (17:39 +0000)]
use PAGE_NAME to switch on which page we are, rather than

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12532 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agorename squirrelmail_rpc.php to rpc.php, it doesn't make much sense to
kink [Sat, 14 Jul 2007 17:32:50 +0000 (17:32 +0000)]
rename squirrelmail_rpc.php to rpc.php, it doesn't make much sense to
have 'squirrelmail' in our path components (i.e. also no squirrelmail_compose.php)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12531 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadd PAGE_NAME constant to every page under src/.
kink [Sat, 14 Jul 2007 17:30:44 +0000 (17:30 +0000)]
add PAGE_NAME constant to every page under src/.
These can/will be used in various tests, and for consistency every page
sets the constant to the appropriate setting.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12530 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoon second thought, revise r12527 to use one, generic constant
kink [Sat, 14 Jul 2007 17:11:31 +0000 (17:11 +0000)]
on second thought, revise r12527 to use one, generic constant
PAGE_NAME, because that doesn't clutter the namespace as much.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12529 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix test for signout.php in the logged in check in init.php so it
kink [Sat, 14 Jul 2007 17:07:23 +0000 (17:07 +0000)]
Fix test for signout.php in the logged in check in init.php so it
cannot be circumvented by manipulating the URL. External plugins migh
rely on init.php guarranteeing that the user is logged in.
Thanks Stefan Esser for finding this.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12528 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove PHP closing tag in example config file
kink [Wed, 11 Jul 2007 09:44:01 +0000 (09:44 +0000)]
remove PHP closing tag in example config file

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12527 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoTry to tag all the places that need to be fixed (no echoing direct from core). We...
pdontthink [Tue, 10 Jul 2007 19:21:46 +0000 (19:21 +0000)]
Try to tag all the places that need to be fixed (no echoing direct from core).  We need to do this in all the rest of the core files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12525 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremoving attachedmessages GET variable that was not being used
pdontthink [Tue, 10 Jul 2007 19:14:39 +0000 (19:14 +0000)]
removing attachedmessages GET variable that was not being used

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12524 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMake all comparisons case insensitive for forwarded protocol in get_location()
pdontthink [Tue, 10 Jul 2007 07:54:42 +0000 (07:54 +0000)]
Make all comparisons case insensitive for forwarded protocol in get_location()

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12518 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdded ability to detect HTTP_X_FORWARDED_PROTO in get_location(), thanks to Daniel...
pdontthink [Tue, 10 Jul 2007 06:00:11 +0000 (06:00 +0000)]
Added ability to detect HTTP_X_FORWARDED_PROTO in get_location(), thanks to Daniel Watts

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12516 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop unneeded global
kink [Mon, 9 Jul 2007 09:38:28 +0000 (09:38 +0000)]
drop unneeded global

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12515 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop two unneeded globals
kink [Mon, 9 Jul 2007 09:37:05 +0000 (09:37 +0000)]
drop two unneeded globals

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12514 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove unused globals, thanks Tomas Kuliavas for $day
kink [Mon, 9 Jul 2007 09:02:54 +0000 (09:02 +0000)]
remove unused globals, thanks Tomas Kuliavas for $day

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12513 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoResolved issue with compose session not being updated on send/save.
jangliss [Sun, 8 Jul 2007 06:11:59 +0000 (06:11 +0000)]
Resolved issue with compose session not being updated on send/save.

Thanks to Michael Andreas for bringing this back up.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12511 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoDon't include svn files in any of the cached template files
pdontthink [Sun, 8 Jul 2007 00:25:23 +0000 (00:25 +0000)]
Don't include svn files in any of the cached template files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12509 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agolist_files vomits over the non-existence of 'none'. The definition of $used_theme is
ebullient [Fri, 6 Jul 2007 23:49:59 +0000 (23:49 +0000)]
list_files vomits over the non-existence of 'none'. The definition of $used_theme is
arguably wrong, but either way, 'none' means 'none', and we shouldn't go off
listing files if that's the value.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12507 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoTypos in sqsetcookie. This might explain a few things. :-)
pdontthink [Sun, 1 Jul 2007 07:28:59 +0000 (07:28 +0000)]
Typos in sqsetcookie.  This might explain a few things.  :-)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12500 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd cc: to the list of checks for empty recipients
pdontthink [Sun, 1 Jul 2007 07:26:57 +0000 (07:26 +0000)]
Add cc: to the list of checks for empty recipients

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12498 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix syntax error
pdontthink [Fri, 29 Jun 2007 23:38:35 +0000 (23:38 +0000)]
Fix syntax error

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12496 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMake sq_change_text_domain() return previous text domain
pdontthink [Fri, 29 Jun 2007 23:29:09 +0000 (23:29 +0000)]
Make sq_change_text_domain() return previous text domain

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12494 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMake dir parameter optional for sq_bindtextdomain()
pdontthink [Fri, 29 Jun 2007 21:30:52 +0000 (21:30 +0000)]
Make dir parameter optional for sq_bindtextdomain()

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12492 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoupdate randomizing themes for larger color array
kink [Wed, 27 Jun 2007 16:24:01 +0000 (16:24 +0000)]
update randomizing themes for larger color array

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12485 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofix spice of life for newer color array
kink [Wed, 27 Jun 2007 16:17:26 +0000 (16:17 +0000)]
fix spice of life for newer color array

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12484 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop unnecessary mt_rand() call, found by Tomas Kuliavas
kink [Wed, 27 Jun 2007 16:12:07 +0000 (16:12 +0000)]
drop unnecessary mt_rand() call, found by Tomas Kuliavas

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12482 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- Fix busy loop and notice when two literals in IMAP fetch (#1739433).
kink [Mon, 25 Jun 2007 21:05:56 +0000 (21:05 +0000)]
- Fix busy loop and notice when two literals in IMAP fetch (#1739433).
thanks James E. Blair

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12477 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop "Application" on second thought (a matter of taste, mostly)
kink [Mon, 25 Jun 2007 20:26:01 +0000 (20:26 +0000)]
drop "Application" on second thought (a matter of taste, mostly)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12474 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- Fix disabling password encryption in mail_fetch (#1738001).
kink [Mon, 25 Jun 2007 20:18:15 +0000 (20:18 +0000)]
- Fix disabling password encryption in mail_fetch (#1738001).
Thanks Stephen More

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12473 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- Fix compatibility with Windows path in administrator plugin (#1740469).
kink [Mon, 25 Jun 2007 19:43:38 +0000 (19:43 +0000)]
- Fix compatibility with Windows path in administrator plugin (#1740469).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12471 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomissing ,
kink [Mon, 25 Jun 2007 19:33:52 +0000 (19:33 +0000)]
missing ,

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12469 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop obsolete parameter, thanks Tomas Kuliavas for finding
kink [Mon, 25 Jun 2007 15:24:42 +0000 (15:24 +0000)]
drop obsolete parameter, thanks Tomas Kuliavas for finding

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12466 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofix switch of en/decode in mdn, thanks Masato HIGASHIYAMA (#1694687)
kink [Mon, 25 Jun 2007 15:22:27 +0000 (15:22 +0000)]
fix switch of en/decode in mdn, thanks Masato HIGASHIYAMA (#1694687)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12465 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix JavaScript errors; make resizable compose body work again.
pdontthink [Sun, 24 Jun 2007 07:48:30 +0000 (07:48 +0000)]
Fix JavaScript errors; make resizable compose body work again.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12462 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFew tweaks to list_files() and add new sq_popen() and friends. PLEASE NOTE that...
pdontthink [Sun, 24 Jun 2007 05:39:04 +0000 (05:39 +0000)]
Few tweaks to list_files() and add new sq_popen() and friends.  PLEASE NOTE that the lass commit mistakenly added sq_htmlspecialchars(), but I think we can leave it in.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12461 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd ask_user_info redirect to compose screen
pdontthink [Fri, 15 Jun 2007 19:24:10 +0000 (19:24 +0000)]
Add ask_user_info redirect to compose screen

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12453 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoTypo
pdontthink [Fri, 15 Jun 2007 19:19:06 +0000 (19:19 +0000)]

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12452 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofix some bugs found by grepping for urlencode/urldecode
kink [Fri, 8 Jun 2007 20:14:37 +0000 (20:14 +0000)]
fix some bugs found by grepping for urlencode/urldecode

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12450 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agocolor has been dropped as a parameter from (plain_)error_message,
kink [Fri, 8 Jun 2007 19:55:53 +0000 (19:55 +0000)]
color has been dropped as a parameter from (plain_)error_message,
update the code to follow

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12449 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove some HTML from within functions. Unneeded HTML to be precise.
kink [Fri, 8 Jun 2007 19:50:02 +0000 (19:50 +0000)]
remove some HTML from within functions. Unneeded HTML to be precise.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12448 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop some unused globals
kink [Fri, 8 Jun 2007 19:42:55 +0000 (19:42 +0000)]
drop some unused globals

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12447 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agohtml/plain should be text/html
kink [Fri, 8 Jun 2007 18:31:54 +0000 (18:31 +0000)]
html/plain should be text/html

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12445 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAlways treat Content-Type case-insensitively (#1732092).
kink [Fri, 8 Jun 2007 18:28:30 +0000 (18:28 +0000)]
Always treat Content-Type case-insensitively (#1732092).
Thanks Rich Pinkall Pollei!

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12444 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- fix notice when returning from a restored compose session.
kink [Fri, 8 Jun 2007 16:40:37 +0000 (16:40 +0000)]
- fix notice when returning from a restored compose session.
- there's no need to urldecode the restored session parameter.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12442 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix broken set_url_var function in functions/html.php (#1729814).
bouchon [Sun, 3 Jun 2007 13:58:37 +0000 (13:58 +0000)]
Fix broken set_url_var function in functions/html.php (#1729814).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12437 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoTemplates also known as skins; also alphabetize list of available plugins (whew)
pdontthink [Sat, 2 Jun 2007 19:37:44 +0000 (19:37 +0000)]
Templates also known as skins; also alphabetize list of available plugins (whew)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12436 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMore XHTML Cleanup
jangliss [Fri, 1 Jun 2007 04:13:38 +0000 (04:13 +0000)]
More XHTML Cleanup

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12434 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAnother XHTML fix.
jangliss [Fri, 1 Jun 2007 03:54:11 +0000 (03:54 +0000)]
Another XHTML fix.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12433 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoXHTML is case sensitive. onLoad != onload
jangliss [Fri, 1 Jun 2007 03:41:01 +0000 (03:41 +0000)]
XHTML is case sensitive.  onLoad != onload

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12432 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agostate license as recommended by the free software foundation
kink [Thu, 31 May 2007 12:27:08 +0000 (12:27 +0000)]
state license as recommended by the free software foundation

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12430 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadapt to approximate global changelog style
kink [Wed, 30 May 2007 19:07:05 +0000 (19:07 +0000)]
adapt to approximate global changelog style

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12428 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofix mail_fetch class to properly cope with dots as specified
kink [Wed, 30 May 2007 18:30:27 +0000 (18:30 +0000)]
fix mail_fetch class to properly cope with dots as specified
in the RFC, thanks Tomas Kuliavas. Closes: #1621267

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12425 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFixed #1727033 (auth support detection in conf.pl)
bouchon [Wed, 30 May 2007 09:43:43 +0000 (09:43 +0000)]
Fixed #1727033 (auth support detection in conf.pl)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12424 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agowork around broken mailers sending broken date headers without
kink [Tue, 29 May 2007 15:29:13 +0000 (15:29 +0000)]
work around broken mailers sending broken date headers without
a space after the day name (e.g. "Tue,23"). from stable

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12422 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRemove duplicated javascript function definition
pdontthink [Fri, 18 May 2007 13:31:55 +0000 (13:31 +0000)]
Remove duplicated javascript function definition

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12419 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd autohide functionality for preview pane. Thanks to Daniel Watts.
pdontthink [Fri, 18 May 2007 13:17:27 +0000 (13:17 +0000)]
Add autohide functionality for preview pane.  Thanks to Daniel Watts.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12418 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMinor adjustments to variable_orders & gpc_order checks. "Special thanks" to Tomas...
pdontthink [Fri, 18 May 2007 12:22:01 +0000 (12:22 +0000)]
Minor adjustments to variable_orders & gpc_order checks.  "Special thanks" to Tomas for "not informing" about his "pet project".

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12417 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoUpdate preview pane functionality so it only refreshes message list when viewing...
pdontthink [Fri, 18 May 2007 11:10:12 +0000 (11:10 +0000)]
Update preview pane functionality so it only refreshes message list when viewing a message that has not yet been seen; also small code updates

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12416 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdding comment for future developer(s)
pdontthink [Fri, 18 May 2007 11:05:23 +0000 (11:05 +0000)]
Adding comment for future developer(s)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12415 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFirstTimeSee is useful to other functionalities beside MDN
pdontthink [Fri, 18 May 2007 10:53:51 +0000 (10:53 +0000)]
FirstTimeSee is useful to other functionalities beside MDN

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12414 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoCorrectly update cached message flags in ALL places when they are changed by the...
pdontthink [Fri, 18 May 2007 10:41:02 +0000 (10:41 +0000)]
Correctly update cached message flags in ALL places when they are changed by the user

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12413 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoGrammar fix and comment to Marc I think.
pdontthink [Fri, 18 May 2007 10:17:30 +0000 (10:17 +0000)]
Grammar fix and comment to Marc I think.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12412 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd the message as a parameter to subject_link hook since it could be useful too
pdontthink [Fri, 18 May 2007 06:57:25 +0000 (06:57 +0000)]
Add the message as a parameter to subject_link hook since it could be useful too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12410 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoValues that test as "empty" should actually be displayed in some cases. For now...
pdontthink [Fri, 18 May 2007 06:42:36 +0000 (06:42 +0000)]
Values that test as "empty" should actually be displayed in some cases.  For now, using === intentionally, as isset() is always true due to how the values are passed around, so we have to actually test the contents of the values.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12409 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd ability to collapse headers into one line; works with but is unrelated to preview...
pdontthink [Fri, 18 May 2007 06:30:07 +0000 (06:30 +0000)]
Add ability to collapse headers into one line; works with but is unrelated to preview pane functionality.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12408 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix spacing
pdontthink [Fri, 18 May 2007 06:23:33 +0000 (06:23 +0000)]
Fix spacing

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12407 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd reminder comments that someone needs to take a look and fix some code in this...
pdontthink [Fri, 18 May 2007 05:27:31 +0000 (05:27 +0000)]
Add reminder comments that someone needs to take a look and fix some code in this file.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12406 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd comments reminding someone to make a fix here
pdontthink [Fri, 18 May 2007 05:14:48 +0000 (05:14 +0000)]
Add comments reminding someone to make a fix here

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12405 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoreplace preg_split without a regular expression with the
kink [Thu, 17 May 2007 16:36:13 +0000 (16:36 +0000)]
replace preg_split without a regular expression with the
faster and less complicated explode()

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12400 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoalso fix duplicated version of parsepriority code
kink [Thu, 17 May 2007 16:29:47 +0000 (16:29 +0000)]
also fix duplicated version of parsepriority code
and remove a 3rd version

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12399 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agousing split() with wrong perl regexes will not work.
kink [Thu, 17 May 2007 15:39:06 +0000 (15:39 +0000)]
using split() with wrong perl regexes will not work.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12397 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agocompare addresses case insensitively, thanks Xaviet Bruyet.
kink [Mon, 14 May 2007 16:16:55 +0000 (16:16 +0000)]
compare addresses case insensitively, thanks Xaviet Bruyet.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12395 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agocentralise the "From"-header construction in functions/identities.php.
kink [Fri, 11 May 2007 21:49:36 +0000 (21:49 +0000)]
centralise the "From"-header construction in functions/identities.php.
This reduces the two instances used under src/ to one, and picks the best
features of both.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12394 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoreplace string "Cute." with "Invalid URL" (reuse of existing string)
kink [Thu, 10 May 2007 11:41:20 +0000 (11:41 +0000)]
replace string "Cute." with "Invalid URL" (reuse of existing string)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12393 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agouse plugins in our examples that actually still exist
kink [Thu, 10 May 2007 11:07:56 +0000 (11:07 +0000)]
use plugins in our examples that actually still exist

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12389 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoSecurity: fixes for the HTML filter to counter further XSS exploits:
kink [Wed, 9 May 2007 14:01:13 +0000 (14:01 +0000)]
Security: fixes for the HTML filter to counter further XSS exploits:
HTML attachments containing 'data:' URLs, Internet Explorer-specifc
charset conversion exploits, and request forgery through included
images. Thanks to Mikhail Markin, Tomas Kuliavas and Michael Jordon
for reporting these issues. [CVE-2007-1262]

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12371 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoUse constant instead of hard-coded string for plugin incompatibility indicator
pdontthink [Mon, 7 May 2007 05:43:56 +0000 (05:43 +0000)]
Use constant instead of hard-coded string for plugin incompatibility indicator

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12369 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd ability for plugin to indicate that they are not compatible with a particular...
pdontthink [Sun, 6 May 2007 03:33:23 +0000 (03:33 +0000)]
Add ability for plugin to indicate that they are not compatible with a particular SM version.  Using hard-coded string maybe should be changed to a constant...?

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12367 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoForgot CSS style for resizable widget code
pdontthink [Sun, 6 May 2007 02:22:19 +0000 (02:22 +0000)]
Forgot CSS style for resizable widget code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12366 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd dynamic textarea sizing slider control to compose screen (default_advanced skin...
pdontthink [Sat, 5 May 2007 18:35:46 +0000 (18:35 +0000)]
Add dynamic textarea sizing slider control to compose screen (default_advanced skin).  Initially based on Drupal implementation.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12365 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoImplement checks for correct PHP variables_order and gpc_order settings
pdontthink [Thu, 3 May 2007 04:31:16 +0000 (04:31 +0000)]
Implement checks for correct PHP variables_order and gpc_order settings

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12363 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoShort PHP tags are against the SquirrelMail coding standards.
jervfors [Thu, 26 Apr 2007 06:22:50 +0000 (06:22 +0000)]
Short PHP tags are against the SquirrelMail coding standards.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12362 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd generic get_plugin_requirement() function and change expected structure for plugi...
pdontthink [Thu, 5 Apr 2007 03:48:55 +0000 (03:48 +0000)]
Add generic get_plugin_requirement() function and change expected structure for plugin dependency information (but is still backward compatible).  Also change configtest to make use of extended information

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12361 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoShifting the location of bind_textdomain_codeset() in the SM wrapper functions
pdontthink [Sun, 1 Apr 2007 23:31:44 +0000 (23:31 +0000)]
Shifting the location of bind_textdomain_codeset() in the SM wrapper functions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12358 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd sq_change_text_domain for plugins to use when switching text domains
pdontthink [Fri, 30 Mar 2007 20:45:55 +0000 (20:45 +0000)]
Add sq_change_text_domain for plugins to use when switching text domains

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12356 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd sq_change_text_domain for plugins to use when switching text domains
pdontthink [Fri, 30 Mar 2007 20:44:27 +0000 (20:44 +0000)]
Add sq_change_text_domain for plugins to use when switching text domains

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12355 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoHandle change of behavior with session ID being left after session close (see #1685031)
pdontthink [Thu, 29 Mar 2007 21:07:10 +0000 (21:07 +0000)]
Handle change of behavior with session ID being left after session close (see #1685031)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12354 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoHandle change of behavior with session ID being left after session close (see #1685031)
pdontthink [Thu, 29 Mar 2007 21:03:53 +0000 (21:03 +0000)]
Handle change of behavior with session ID being left after session close (see #1685031)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12353 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoSkip .svn dir. Leaving CVS dir in case it is left over in some people's downloaded...
pdontthink [Tue, 27 Mar 2007 19:08:15 +0000 (19:08 +0000)]
Skip .svn dir.  Leaving CVS dir in case it is left over in some people's downloaded locale packages.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12351 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRevert last change, which caused nasty sesion ID errors, although now we still have...
pdontthink [Mon, 26 Mar 2007 17:39:43 +0000 (17:39 +0000)]
Revert last change, which caused nasty sesion ID errors, although now we still have a problem wherein other cookies that are intentionally set to an empty string are revalued as 'deleted', and the caller may not expect such

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12350 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoUsing the string 'deleted' in expired cookies can have unintented consequences for...
pdontthink [Mon, 26 Mar 2007 16:32:26 +0000 (16:32 +0000)]
Using the string 'deleted' in expired cookies can have unintented consequences for cookies treated as boolean, also 'deleted' could be a potential valid cookie value.  Using empty string instead.  Anyone know of any reason 'deleted' is actually useful?

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12349 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd functions to help diagnose if plugin dependencies are in place
pdontthink [Thu, 22 Mar 2007 21:24:05 +0000 (21:24 +0000)]
Add functions to help diagnose if plugin dependencies are in place

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12347 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRemove $version, use SM_VERSION constant instead
pdontthink [Thu, 22 Mar 2007 20:01:33 +0000 (20:01 +0000)]
Remove $version, use SM_VERSION constant instead

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12346 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRe-add hook just removed; compose templates are so scattered, there is nowhere a...
pdontthink [Thu, 22 Mar 2007 03:14:20 +0000 (03:14 +0000)]
Re-add hook just removed; compose templates are so scattered, there is nowhere a plugin can add output to the bottom of the compose page except to output its own template on this hook -- must make sure plugins NEVER output directly here without using the template API (it is possible a plugin could slip this by us).  Steve did his best with converting the compose page to templates, but it's a pretty big mess, with template chunks and still a lot of output coming directly from compose.php, especially things like the form tags and misc formatting - this must be cleaned out.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12345 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRemoving hook that, AFAIK is only used to add output to compose screen; other hooks...
pdontthink [Thu, 22 Mar 2007 02:52:05 +0000 (02:52 +0000)]
Removing hook that, AFAIK is only used to add output to compose screen; other hooks will be used for this in 1.5.2+

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12344 7612ce4b-ef26-0410-bec9-ea0150e637f0