15 years agoMove always included vars to init.php because it is confusing when not logged in.
stevetruckstuff [Fri, 18 Aug 2006 21:27:51 +0000 (21:27 +0000)]
Move always included vars to init.php because it is confusing when not logged in.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11614 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoResolve confusing var names for preferences.
stevetruckstuff [Fri, 18 Aug 2006 21:26:04 +0000 (21:26 +0000)]
Resolve confusing var names for preferences.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11613 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoADd some additional variables to the template
stevetruckstuff [Fri, 18 Aug 2006 20:19:28 +0000 (20:19 +0000)]
ADd some additional variables to the template

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11612 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoSome variables are needed by all templates to make creation easier. Make sure they...
stevetruckstuff [Fri, 18 Aug 2006 20:17:43 +0000 (20:17 +0000)]
Some variables are needed by all templates to make creation easier.  Make sure they are passed as variables to the template.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11611 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd template for field ordering
stevetruckstuff [Thu, 17 Aug 2006 22:26:41 +0000 (22:26 +0000)]
Add template for field ordering

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11610 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix incorrect template assignment.
stevetruckstuff [Thu, 17 Aug 2006 20:54:46 +0000 (20:54 +0000)]
Fix incorrect template assignment.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11609 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoIniitial option templating.
stevetruckstuff [Thu, 17 Aug 2006 19:35:27 +0000 (19:35 +0000)]
Iniitial option templating.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11608 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix undefined function when downloading attachments. See comments for details.
stevetruckstuff [Wed, 16 Aug 2006 16:38:46 +0000 (16:38 +0000)]
Fix undefined function when downloading attachments.  See comments for details.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11607 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd list_writable_backends() function back for plugins.
stevetruckstuff [Wed, 16 Aug 2006 14:21:53 +0000 (14:21 +0000)]
Add list_writable_backends() function back for plugins.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11606 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoIncorporate new add/edit template and remove functions that are no longer needed.
stevetruckstuff [Tue, 15 Aug 2006 21:33:24 +0000 (21:33 +0000)]
Incorporate new add/edit template and remove functions that are no longer needed.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11605 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd template for address book add/edit functions.
stevetruckstuff [Tue, 15 Aug 2006 21:32:45 +0000 (21:32 +0000)]
Add template for address book add/edit functions.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11604 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoCorrect invalid HTML id attributes. Modify add/edit/delete actions to account for...
stevetruckstuff [Tue, 15 Aug 2006 21:31:48 +0000 (21:31 +0000)]
Correct invalid HTML id attributes.  Modify add/edit/delete actions to account for new id format.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11603 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoWhen modifying an entry, if the nick name is different, check that the new nick name...
stevetruckstuff [Tue, 15 Aug 2006 20:41:20 +0000 (20:41 +0000)]
When modifying an entry, if the nick name is different, check that the new nick name doesn't exist in the address book.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11602 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMissing close paren
stevetruckstuff [Tue, 15 Aug 2006 18:28:18 +0000 (18:28 +0000)]
Missing close paren

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11601 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix some HTML/CSS errors
stevetruckstuff [Tue, 15 Aug 2006 18:23:50 +0000 (18:23 +0000)]
Fix some HTML/CSS errors

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11600 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago$abook->error is never htmlsanitized in 1.5.2cvs.
tokul [Tue, 15 Aug 2006 18:02:29 +0000 (18:02 +0000)]
$abook->error is never htmlsanitized in 1.5.2cvs.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11599 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix FIXME in functions/addressbook.php
stevetruckstuff [Tue, 15 Aug 2006 17:54:15 +0000 (17:54 +0000)]
Fix FIXME in functions/addressbook.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11598 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFix cancel button in HTML address book.
stevetruckstuff [Tue, 15 Aug 2006 17:36:15 +0000 (17:36 +0000)]
Fix cancel button in HTML address book.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11596 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRemove unneeded comment
stevetruckstuff [Tue, 15 Aug 2006 17:35:28 +0000 (17:35 +0000)]
Remove unneeded comment

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11595 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove todo. multiple address books displayed in template
tokul [Tue, 15 Aug 2006 17:09:53 +0000 (17:09 +0000)]
remove todo. multiple address books displayed in template

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11594 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofullname layout is controled in gettext string instead of $squirrelmail_language
tokul [Tue, 15 Aug 2006 17:01:41 +0000 (17:01 +0000)]
fullname layout is controled in gettext string instead of $squirrelmail_language
removed unfinished pagination code
added list_addr() error handling

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11593 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAddress book templates
stevetruckstuff [Tue, 15 Aug 2006 15:44:31 +0000 (15:44 +0000)]
Address book templates

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11592 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd more functions for address book templating
stevetruckstuff [Tue, 15 Aug 2006 15:43:55 +0000 (15:43 +0000)]
Add more functions for address book templating

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11591 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoupdated google translate form.
tokul [Tue, 15 Aug 2006 13:57:27 +0000 (13:57 +0000)]
updated google translate form.
* eight additional language pairs
* fixed form field order

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11588 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAccount for extra fields in address book more correctly. Also account for no global...
stevetruckstuff [Mon, 14 Aug 2006 16:12:12 +0000 (16:12 +0000)]
Account for extra fields in address book more correctly.  Also account for no global address book.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11585 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd template for address book listings along with required files
stevetruckstuff [Mon, 14 Aug 2006 15:50:43 +0000 (15:50 +0000)]
Add template for address book listings along with required files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11584 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- Drop obsolete script plugins/make_archive.pl.
kink [Mon, 14 Aug 2006 13:48:29 +0000 (13:48 +0000)]
- Drop obsolete script plugins/make_archive.pl.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11583 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoClean up webmail.tpl. Also implement delayed errors.
stevetruckstuff [Thu, 10 Aug 2006 22:34:54 +0000 (22:34 +0000)]
Clean up webmail.tpl.  Also implement delayed errors.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11512 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoTurn on delayed errors. ERrors generated here will be held over until right_main...
stevetruckstuff [Thu, 10 Aug 2006 22:33:36 +0000 (22:33 +0000)]
Turn on delayed errors.  ERrors generated here will be held over until right_main.php.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11511 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoImplement delayed error handling. Defaults to FALSE. Enable this feature by calling...
stevetruckstuff [Thu, 10 Aug 2006 22:31:56 +0000 (22:31 +0000)]
Implement delayed error handling.  Defaults to FALSE.  Enable this feature by calling $oErrorHandler->setDealyedErrors(true).  This allows errors to be held on certain pages, e.g. webmail.php and displayed at a more appropriate time, e.g. at the bottom of left_main.php.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11510 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoCall the new function displayErrors() to display errors rather than refering to ...
stevetruckstuff [Thu, 10 Aug 2006 22:29:17 +0000 (22:29 +0000)]
Call the new function displayErrors() to display errors rather than refering to $this.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11509 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd function for displaying errors to avoid having to call $oErrorHandler or $this...
stevetruckstuff [Thu, 10 Aug 2006 22:26:19 +0000 (22:26 +0000)]
Add function for displaying errors to avoid having to call $oErrorHandler or $this within footer template.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11508 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoCaching of style.php doesn't work. Make an attempt to get it working and add documen...
stevetruckstuff [Wed, 9 Aug 2006 19:53:55 +0000 (19:53 +0000)]
Caching of style.php doesn't work.  Make an attempt to get it working and add documentation so someone else can fix it later. :-)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11501 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoAdd CSS support to folder manipulation templates. Also make subscribe folder list...
stevetruckstuff [Wed, 9 Aug 2006 18:01:22 +0000 (18:01 +0000)]
Add CSS support to folder manipulation templates.  Also make subscribe folder list checkboxes rather than select per TODO in folders.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11500 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomove variables that are loaded before environment is secured against rg=on
tokul [Wed, 9 Aug 2006 06:58:42 +0000 (06:58 +0000)]
move variables that are loaded before environment is secured against rg=on

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11490 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodrop very old and very obsolete function
kink [Mon, 7 Aug 2006 18:47:59 +0000 (18:47 +0000)]
drop very old and very obsolete function

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11483 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofixed phpdoc tag
tokul [Sun, 6 Aug 2006 08:46:36 +0000 (08:46 +0000)]
fixed phpdoc tag

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11480 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMoving the development documentation to the documentation module.
jervfors [Sat, 5 Aug 2006 21:28:35 +0000 (21:28 +0000)]
Moving the development documentation to the documentation module.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11479 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMoving the development documentation to the documentation module.
jervfors [Sat, 5 Aug 2006 18:44:30 +0000 (18:44 +0000)]
Moving the development documentation to the documentation module.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11478 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agono need to pass $key variable to sqimap_login anymore
kink [Sat, 5 Aug 2006 14:49:49 +0000 (14:49 +0000)]
no need to pass $key variable to sqimap_login anymore

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11477 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoDo not pass the $key to sqimap_login, that takes care of that itself.
kink [Sat, 5 Aug 2006 14:39:17 +0000 (14:39 +0000)]
Do not pass the $key to sqimap_login, that takes care of that itself.
Also remove any globals that are not needed anymore because of this change,
or because they're already set in init.php.

I believe that we should move to a sqimap_login() without any parameters,
but this is a good first step.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11476 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomissing '}' in session_expired_post, thanks Rusty Nejdl
kink [Sat, 5 Aug 2006 14:11:38 +0000 (14:11 +0000)]
missing '}' in session_expired_post, thanks Rusty Nejdl

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11475 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoinformation about #1312915 fix and phpdoc updates
tokul [Sat, 5 Aug 2006 11:21:35 +0000 (11:21 +0000)]
information about #1312915 fix and phpdoc updates

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11474 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodon't add delimiter to folder name, when folder with subfolders is
tokul [Sat, 5 Aug 2006 10:42:20 +0000 (10:42 +0000)]
don't add delimiter to folder name, when folder with subfolders is
created. Use sqimap_mailbox_create() $type option. If suffix is added,
sqimap_mailbox_create() uses incorrect subscription command (#1315912).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11472 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agosimple "equal to 'none'" test instead of testing all other authentication
tokul [Sat, 5 Aug 2006 09:54:27 +0000 (09:54 +0000)]
simple "equal to 'none'" test instead of testing all other authentication

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11471 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agousername should not be empty
tokul [Sat, 5 Aug 2006 08:22:45 +0000 (08:22 +0000)]
username should not be empty

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11470 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomoved smtp sitewide configuration to main configuration utility
tokul [Sat, 5 Aug 2006 07:38:01 +0000 (07:38 +0000)]
moved smtp sitewide configuration to main configuration utility
added quote_single subroutine, that is used to sanitize single quoted php strings
removed obsolete command18() subroutine

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11469 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadd purge link when folder contains subfolders.
tokul [Sat, 5 Aug 2006 04:33:43 +0000 (04:33 +0000)]
add purge link when folder contains subfolders.
Issue does not apply to 1.4.7 (code checks for parent tag) or
default_advanced template (purge link always visible above folder tree).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11468 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodon't tag subfolders of Drafts,Trash and Sent as special in folder management
tokul [Fri, 4 Aug 2006 09:17:43 +0000 (09:17 +0000)]
don't tag subfolders of Drafts,Trash and Sent as special in folder management
page. Allows rename and delete operations with subfolders.

don't treat INBOX.Trash as special on Courier. Trash folder can have subfolders
in courier. Only XMAGICTRASH extension can cause errors when trash folder is
deleted. Courier does not document commands that allow to detect folder that
is used as magic trash.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11466 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agophpdoc source parsing locks on trailing comments.
tokul [Fri, 4 Aug 2006 07:36:52 +0000 (07:36 +0000)]
phpdoc source parsing locks on trailing comments.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11464 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agosome code simplification
kink [Thu, 3 Aug 2006 16:06:47 +0000 (16:06 +0000)]
some code simplification

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11463 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofirst start of removing direct access of key/onetimepad in all scripts
kink [Thu, 3 Aug 2006 15:14:58 +0000 (15:14 +0000)]
first start of removing direct access of key/onetimepad in all scripts

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11462 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFixed resuming of compose when session expired while writing, and make
kink [Thu, 3 Aug 2006 15:03:44 +0000 (15:03 +0000)]
Fixed resuming of compose when session expired while writing, and make
sure the code only sets those variables that are needed in compose and
are not already set. Thanks James Bercegay from GulfTech for pointing
this out.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11460 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoloading default configuration before config.php in order to make sure
tokul [Wed, 2 Aug 2006 18:05:33 +0000 (18:05 +0000)]
loading default configuration before config.php in order to make sure
that all variables are loaded.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11458 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove crufty code (commented out for >2 y) and the closing '?>' because
kink [Wed, 2 Aug 2006 11:09:16 +0000 (11:09 +0000)]
remove crufty code (commented out for >2 y) and the closing '?>' because
this is one of the files where it could really cause trouble if there's whitespace
after it.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11457 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agotemplatize folder management (create, rename, delete, subscribe).
kink [Tue, 1 Aug 2006 15:34:19 +0000 (15:34 +0000)]
templatize folder management (create, rename, delete, subscribe).
it's not complete in the sense that it still uses $color etc, feel free to
cssify! I'd like feedback if this is not the proper way to templatize something.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11456 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agotemplating for signout
kink [Tue, 1 Aug 2006 11:13:56 +0000 (11:13 +0000)]
templating for signout

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11455 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadded safety checks for outdated config.php and
tokul [Mon, 31 Jul 2006 16:43:56 +0000 (16:43 +0000)]
added safety checks for outdated config.php and
updated sendMDN code to newer sendmail delivery class

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11452 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoperl compilation error was caused by curly brackets.
tokul [Sun, 30 Jul 2006 17:39:15 +0000 (17:39 +0000)]
perl compilation error was caused by curly brackets.
tested 5.8, 5.6 and 5.004

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11449 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago$version is not available when config.php is loaded
tokul [Sun, 30 Jul 2006 13:08:56 +0000 (13:08 +0000)]
$version is not available when config.php is loaded

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11446 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremoved non-standard wrap attribute
tokul [Sun, 30 Jul 2006 13:05:58 +0000 (13:05 +0000)]
removed non-standard wrap attribute

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11445 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofixed undefined notice
tokul [Sun, 30 Jul 2006 11:55:50 +0000 (11:55 +0000)]
fixed undefined notice
removed two references in asearch_get_title_display() and asearch_get_error_display()
added some phpdoc tags

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11444 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoFixing PHP notice which was introduced in 1.42 of this file. If this should be somewh...
jervfors [Sat, 29 Jul 2006 06:47:59 +0000 (06:47 +0000)]
Fixing PHP notice which was introduced in 1.42 of this file. If this should be somewhere else, considering the centralized init, pleae move it.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11441 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agosemicolor confused phpdoc
tokul [Wed, 26 Jul 2006 16:50:26 +0000 (16:50 +0000)]
semicolor confused phpdoc

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11437 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agocode could be triggered to unset variables that are used in foreach or
tokul [Wed, 26 Jul 2006 06:39:01 +0000 (06:39 +0000)]
code could be triggered to unset variables that are used in foreach or
unset call. PHP 5.2.0 does not handle it gracefully.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11435 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago#1527493 typo in elseif.
tokul [Mon, 24 Jul 2006 19:20:24 +0000 (19:20 +0000)]
#1527493 typo in elseif.

code later tries to use $a, but it is not always available. We have if()
and elseif(). There is no failsafe else version.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11432 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago1.4.7 cleans globals too
tokul [Sat, 22 Jul 2006 17:56:52 +0000 (17:56 +0000)]
1.4.7 cleans globals too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11428 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodata and attachment directories need trailing slash. If we don't require it,
tokul [Sat, 22 Jul 2006 17:28:53 +0000 (17:28 +0000)]
data and attachment directories need trailing slash. If we don't require it,
code that uses $data_dir or $attachment_dir will need extra checks

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11425 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoLocation: header automatically adds 302 Status header. If extra Status header
tokul [Sat, 22 Jul 2006 17:24:33 +0000 (17:24 +0000)]
Location: header automatically adds 302 Status header. If extra Status header
is used, PHP bug (#36705) causes errors in fastcgi setups. RFC 2616 recommends
use of 302 headers for agents that don't support HTTP 1.1.

Status header was used when code was introduced in SM 1.1.1. There is
no explanation why 303 status is needed instead of standard 302.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11424 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoPutting Erin and Philippe as retired, and getting STABLE and DEVEL in sync.
jervfors [Wed, 19 Jul 2006 19:28:15 +0000 (19:28 +0000)]
Putting Erin and Philippe as retired, and getting STABLE and DEVEL in sync.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11415 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoIO::Socket was loaded without checking. Script failed with compilation
tokul [Wed, 19 Jul 2006 07:56:48 +0000 (07:56 +0000)]
IO::Socket was loaded without checking. Script failed with compilation
errors, if IO::Socket was not available.

0x80-0xFF (no Unicode support) range is actually more accurate than
0x80-0xFFFF (with Unicode support)

fixed $use_imap_tls and $use_smtp_tls checks.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11412 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoUnicode support was added in Perl 5.6, use a less useful range in earlier versions...
indiri69 [Mon, 17 Jul 2006 19:39:23 +0000 (19:39 +0000)]
Unicode support was added in Perl 5.6, use a less useful range in earlier versions. For those of use running antiquated servers.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11409 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoThe footer probably shouldn't go before the rest of the HTML. Looks like a cut and...
indiri69 [Mon, 17 Jul 2006 18:56:51 +0000 (18:56 +0000)]
The footer probably shouldn't go before the rest of the HTML. Looks like a cut and paste error.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11408 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadding config_location_base to administrator plugin
tokul [Mon, 17 Jul 2006 16:19:19 +0000 (16:19 +0000)]
adding config_location_base to administrator plugin

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11407 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoimprovements to 1.244 suggested by Tomas
kink [Mon, 17 Jul 2006 15:39:36 +0000 (15:39 +0000)]
improvements to 1.244 suggested by Tomas

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11406 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoMake the base for the SquirrelMail URL configurable. Adds a new variable
kink [Mon, 17 Jul 2006 14:42:06 +0000 (14:42 +0000)]
Make the base for the SquirrelMail URL configurable. Adds a new variable
config_base_location to config.php and a new option to conf.pl. This is
to prevent problems in installs where our heuristic doesn't work
correctly (#1521299, #1460675, #1110064, #1000850, #1113791)

I believe this is one of the most commonly reported issues in current
stable. That's why I've created the code to be minimally invasive: it only
allows to set the proto+host+port part, because this means all changes
can remain within get_location().

I want to backport this bugfix to stable so I appreciate any feedback
on it. And also of course if you think that this is the wrong way to
solve it :)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11405 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremove references to submitting themes to us. we've got a LOT of themes
kink [Sun, 16 Jul 2006 18:10:56 +0000 (18:10 +0000)]
remove references to submitting themes to us. we've got a LOT of themes
already included

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11404 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agolist cve's that are fixed by the deregister globals code
kink [Sun, 16 Jul 2006 18:06:55 +0000 (18:06 +0000)]
list cve's that are fixed by the deregister globals code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11402 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agocomment about closing tag now superfluous
kink [Sat, 15 Jul 2006 14:26:45 +0000 (14:26 +0000)]
comment about closing tag now superfluous

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11401 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoRemove CVS $Log$ keywords, since that info is available by doing 'cvs log'
kink [Sat, 15 Jul 2006 14:19:12 +0000 (14:19 +0000)]
Remove CVS $Log$ keywords, since that info is available by doing 'cvs log'
and there's no need to ship the changes of 100's of file revisions to all
our users.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11400 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agodisplay disabled,TLS,STARTTLS instead of 0,1,2 in menu
tokul [Sat, 15 Jul 2006 12:58:14 +0000 (12:58 +0000)]
display disabled,TLS,STARTTLS instead of 0,1,2 in menu

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11399 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoolder code used sel[] name in list form. Label code added backend id and
tokul [Sat, 15 Jul 2006 12:39:16 +0000 (12:39 +0000)]
older code used sel[] name in list form. Label code added backend id and
nickname. extracting array value with current() instead of using index.
$sel is also used when address book entry is deleted, but array is
reindexed there.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11398 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadding safety checks. if invalid backend number was used, script used invalid
tokul [Sat, 15 Jul 2006 12:35:16 +0000 (12:35 +0000)]
adding safety checks. if invalid backend number was used, script used invalid
object calls

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11397 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremoving trailing ?> from function scripts
tokul [Sat, 15 Jul 2006 12:01:32 +0000 (12:01 +0000)]
removing trailing ?> from function scripts

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11396 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoreverting some templating changes. They broke plugin blocks.
tokul [Thu, 13 Jul 2006 18:49:44 +0000 (18:49 +0000)]
reverting some templating changes. They broke plugin blocks.
moving display of option blocks to separate template

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11395 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agofixed spamcop plugin
tokul [Thu, 13 Jul 2006 10:02:10 +0000 (10:02 +0000)]
fixed spamcop plugin

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11392 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoremoved service type option - spamcop uses same form for free and paying
tokul [Thu, 13 Jul 2006 10:00:35 +0000 (10:00 +0000)]
removed service type option - spamcop uses same form for free and paying
reporters. web based reporting form will use members.spamcop.net address
(#1519673). www.spamcop.net form is broken, if user is not logged into

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11391 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agoadd code to reinitialize the templating for the case that one has reloaded
kink [Tue, 11 Jul 2006 22:23:33 +0000 (22:23 +0000)]
add code to reinitialize the templating for the case that one has reloaded
signout.php. that used to spew all kinds of errors, this handles it more
gracefully. closes: #1519716

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11390 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomove the 'fallback theme colors' to init.php. It makes sense to initialise
kink [Tue, 11 Jul 2006 22:12:09 +0000 (22:12 +0000)]
move the 'fallback theme colors' to init.php. It makes sense to initialise
that array as early as possible, because we may need the colours when
setting up something goes wrong.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11389 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- added new utils_css file to contain CSS-related functions for use in templates
vanmer [Mon, 10 Jul 2006 15:48:51 +0000 (15:48 +0000)]
- added new utils_css file to contain CSS-related functions for use in templates
- altered stylelink template to use new util_css.php file for all function definitions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11388 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- changed to actually apply style instead of returning false
vanmer [Sun, 9 Jul 2006 23:29:13 +0000 (23:29 +0000)]
- changed to actually apply style instead of returning false

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11386 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- added variable initalization and check on variable
vanmer [Sun, 9 Jul 2006 22:37:35 +0000 (22:37 +0000)]
- added variable initalization and check on variable

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11385 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- added template output for style links before link to style.php
vanmer [Sun, 9 Jul 2006 22:29:07 +0000 (22:29 +0000)]
- added template output for style links before link to style.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11384 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- moved all output from webmail.php to webmail.tpl template
vanmer [Sun, 9 Jul 2006 22:27:40 +0000 (22:27 +0000)]
- moved all output from webmail.php to webmail.tpl template

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11383 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- pulled all options output in options.tpl template
vanmer [Sun, 9 Jul 2006 22:27:04 +0000 (22:27 +0000)]
- pulled all options output in options.tpl template

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11382 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years agomake a start with adding labels for html form elements. this aids disabled
kink [Sun, 9 Jul 2006 22:26:05 +0000 (22:26 +0000)]
make a start with adding labels for html form elements. this aids disabled
users, but also e.g. allows one to click the text next to a checkbox to
select it.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11381 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- added default entries for new templates for webmail, options and stylesheet links
vanmer [Sun, 9 Jul 2006 22:25:56 +0000 (22:25 +0000)]
- added default entries for new templates for webmail, options and stylesheet links

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11380 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- moved all static style elements out of stylesheet.tpl into /css/default.css
vanmer [Sun, 9 Jul 2006 22:24:31 +0000 (22:24 +0000)]
- moved all static style elements out of stylesheet.tpl into /css/default.css

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11379 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- initial revision of a default stylesheet for squirrelmail, including style and...
vanmer [Sun, 9 Jul 2006 22:23:46 +0000 (22:23 +0000)]
- initial revision of a default stylesheet for squirrelmail, including style and basic color defaults

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11378 7612ce4b-ef26-0410-bec9-ea0150e637f0

15 years ago- intial revision of a template to display CSS links at the top of the page
vanmer [Sun, 9 Jul 2006 22:23:03 +0000 (22:23 +0000)]
- intial revision of a template to display CSS links at the top of the page

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11377 7612ce4b-ef26-0410-bec9-ea0150e637f0