squirrelmail.git
17 years agoChanges that follow per the inheritance and associated changes to Template.class.php
pdontthink [Mon, 2 Oct 2006 09:38:49 +0000 (09:38 +0000)]
Changes that follow per the inheritance and associated changes to Template.class.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11792 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMassive rewrite of Template class to implement template inheritance, along with a...
pdontthink [Mon, 2 Oct 2006 09:38:05 +0000 (09:38 +0000)]
Massive rewrite of Template class to implement template inheritance, along with a fallback template (different than concept of a default which just helps catch void in user prefs).  As suggested by Alexandros, a caching mechanism replaces the heaps of file_exists() calls in previous implementation, although this introduces more complexity, so watch for bugs!  Inheritance implies changes in stylesheet and javascript file loading, in that now all such files inherited from all ancestors are loaded in case a template falls back to one of those ancestors (or the fallback set).  Template config file caching and an easy API to get those settings also implemented.  Finally, when a template set falls back to another set with a different template engine for a given page, the engine is swapped out dynamically (although this is less than ideal and should be discouraged when authors are creating template sets).

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11791 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoadding php pspell support. If it breaks - blame me.
tokul [Sat, 30 Sep 2006 17:48:14 +0000 (17:48 +0000)]
adding php pspell support. If it breaks - blame me.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11790 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoadding php pspell support
tokul [Sat, 30 Sep 2006 17:35:20 +0000 (17:35 +0000)]
adding php pspell support

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11789 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agosqBodywrap was extreme slow on large messages. The reason for that were the
stekkel [Sat, 30 Sep 2006 16:24:00 +0000 (16:24 +0000)]
sqBodywrap was extreme slow on large messages. The reason for that were the
amount of calls to sq_strpos and sq_substr. Those functions did expensive
in_array calls and a few other things that only need to be done once. By
using static vars I cached the results with as result my compose screen
opens within a second again instead of 10 seconds.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11788 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoDemo user provided alternate stylsheet
stevetruckstuff [Sat, 30 Sep 2006 10:39:30 +0000 (10:39 +0000)]
Demo user provided alternate stylsheet

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11787 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd support for user-provided alternate stylesheets
stevetruckstuff [Sat, 30 Sep 2006 10:38:34 +0000 (10:38 +0000)]
Add support for user-provided alternate stylesheets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11786 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMove squirrelmail.css into default.css. squirrelmail.css should no longer be needed.
stevetruckstuff [Sat, 30 Sep 2006 10:36:18 +0000 (10:36 +0000)]
Move squirrelmail.css into default.css.  squirrelmail.css should no longer be needed.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11785 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoignore msg copy errors when messages are deleted. Most common error is related
tokul [Sat, 30 Sep 2006 09:49:08 +0000 (09:49 +0000)]
ignore msg copy errors when messages are deleted. Most common error is related
to quota issues. Updated function tries to copy message to trash and then tags
it as deleted. If we can store message in trash, message is stored. If we can't,
trash folder is bypassed.

added version information to two configuration variables

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11783 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agolist_files does not work correctly if not extension is given.
stevetruckstuff [Sat, 30 Sep 2006 09:25:09 +0000 (09:25 +0000)]
list_files does not work correctly if not extension is given.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11782 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoblock uw mailbox abuse in imap select command instead of applying same
tokul [Sat, 30 Sep 2006 07:38:03 +0000 (07:38 +0000)]
block uw mailbox abuse in imap select command instead of applying same
code in all scripts that get $mailbox from GET or POST.

don't check imap_server_type, because interface can be used with different
type setting.

display error message instead of silently overriding $mailbox. (#1557078)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11781 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agodon't leave old code and DO check filters plugin when reporter informs about
tokul [Sat, 30 Sep 2006 07:09:09 +0000 (07:09 +0000)]
don't leave old code and DO check filters plugin when reporter informs about
the way to reproduce issue.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11780 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd tempalte config var for alternate stylesheets
stevetruckstuff [Fri, 29 Sep 2006 22:14:26 +0000 (22:14 +0000)]
Add tempalte config var for alternate stylesheets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11778 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd tempalte config for alternate stylesheets
stevetruckstuff [Fri, 29 Sep 2006 22:13:17 +0000 (22:13 +0000)]
Add tempalte config for alternate stylesheets

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11777 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdditional safety check
stevetruckstuff [Fri, 29 Sep 2006 21:45:29 +0000 (21:45 +0000)]
Additional safety check

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11776 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agocorrect typo.
stevetruckstuff [Fri, 29 Sep 2006 21:16:17 +0000 (21:16 +0000)]
correct typo.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11775 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCSS touchups
stevetruckstuff [Fri, 29 Sep 2006 21:09:50 +0000 (21:09 +0000)]
CSS touchups

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11774 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMake style.php only load font prefs.
stevetruckstuff [Fri, 29 Sep 2006 20:59:41 +0000 (20:59 +0000)]
Make style.php only load font prefs.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11773 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd new default.css. $color themes will be supported later by alternate stylesheets...
stevetruckstuff [Fri, 29 Sep 2006 20:59:21 +0000 (20:59 +0000)]
Add new default.css.  $color themes will be supported later by alternate stylesheets.  Some of this CSS may not be perfect, but it will get cleaned up!!

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11772 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd documentation re CSS, and clean up some what.
stevetruckstuff [Fri, 29 Sep 2006 20:58:11 +0000 (20:58 +0000)]
Add documentation re CSS, and clean up some what.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11771 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoApply correct stylesheets for RTL languages
stevetruckstuff [Fri, 29 Sep 2006 20:22:47 +0000 (20:22 +0000)]
Apply correct stylesheets for RTL languages

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11770 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoTemplate object is referenced in load_prefs.php if icons are enabled. Need to includ...
stevetruckstuff [Fri, 29 Sep 2006 19:56:12 +0000 (19:56 +0000)]
Template object is referenced in load_prefs.php if icons are enabled.  Need to include template class files before loaded load_prefs.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11769 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoShould be a better fix so this hook now works with plugins that have been using it...
pdontthink [Fri, 29 Sep 2006 18:20:56 +0000 (18:20 +0000)]
Should be a better fix so this hook now works with plugins that have been using it the old way too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11768 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoRemove debugging code
pdontthink [Fri, 29 Sep 2006 17:08:49 +0000 (17:08 +0000)]
Remove debugging code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11767 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMake temporary code more obvious
pdontthink [Fri, 29 Sep 2006 09:11:23 +0000 (09:11 +0000)]
Make temporary code more obvious

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11766 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years ago"Fix" so old prefs do not totally kill conf.pl. Should be reverted when everyone...
pdontthink [Fri, 29 Sep 2006 09:03:34 +0000 (09:03 +0000)]
"Fix" so old prefs do not totally kill conf.pl.  Should be reverted when everyone has had a good chance to upgrade their configuration files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11765 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFix reply indentation. It was an ordinary typo ;)
stekkel [Fri, 29 Sep 2006 09:02:22 +0000 (09:02 +0000)]
Fix reply indentation. It was an ordinary typo ;)

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11764 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoprevent notice on non-html attachment viewing
kink [Fri, 29 Sep 2006 08:53:51 +0000 (08:53 +0000)]
prevent notice on non-html attachment viewing

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11763 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCheckboxes without labels are a pain to use... Now text is clickable as well.
avel [Thu, 28 Sep 2006 17:13:14 +0000 (17:13 +0000)]
Checkboxes without labels are a pain to use... Now text is clickable as well.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11761 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMisc template changes
pdontthink [Thu, 28 Sep 2006 14:59:20 +0000 (14:59 +0000)]
Misc template changes

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11760 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMisc template changs
pdontthink [Thu, 28 Sep 2006 14:55:00 +0000 (14:55 +0000)]
Misc template changs

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11759 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMostly moved from base template dir
pdontthink [Thu, 28 Sep 2006 14:52:14 +0000 (14:52 +0000)]
Mostly moved from base template dir

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11758 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMoved to css dir
pdontthink [Thu, 28 Sep 2006 14:38:23 +0000 (14:38 +0000)]
Moved to css dir

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11757 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMoved to config.php
pdontthink [Thu, 28 Sep 2006 14:34:37 +0000 (14:34 +0000)]
Moved to config.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11756 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew hook type that I am very excited about; should address a kind of plugin stacking...
pdontthink [Thu, 28 Sep 2006 14:30:45 +0000 (14:30 +0000)]
New hook type that I am very excited about; should address a kind of plugin stacking that we should have had long ago

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11755 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoOops, don't want multilogin plugin patch in here
pdontthink [Thu, 28 Sep 2006 14:29:14 +0000 (14:29 +0000)]
Oops, don't want multilogin plugin patch in here

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11754 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew template files
pdontthink [Thu, 28 Sep 2006 14:26:07 +0000 (14:26 +0000)]
New template files

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11753 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMisc templating changes. Note that the global template set indicator is now called .
pdontthink [Thu, 28 Sep 2006 14:21:51 +0000 (14:21 +0000)]
Misc templating changes.  Note that the global template set indicator is now called .

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11752 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMoving sm_print_r back to globals.php; tired of it not being available when developin...
pdontthink [Thu, 28 Sep 2006 14:17:15 +0000 (14:17 +0000)]
Moving sm_print_r back to globals.php; tired of it not being available when developing - that's what it's for, more than being available for actual code use as a string function in a file that's not included high enough.  Also new directory parsing fxn.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11751 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoHopefully more of what is in the util files in the templates directory can be moved...
pdontthink [Thu, 28 Sep 2006 14:11:32 +0000 (14:11 +0000)]
Hopefully more of what is in the util files in the templates directory can be moved here

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11750 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFile name change
pdontthink [Thu, 28 Sep 2006 14:09:18 +0000 (14:09 +0000)]
File name change

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11749 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFunctionality moved to Template class and/or functions/template.php
pdontthink [Thu, 28 Sep 2006 14:08:43 +0000 (14:08 +0000)]
Functionality moved to Template class and/or functions/template.php

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11748 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoChange to store template ID and not path; also bug fixes and fine-tuning the detectio...
pdontthink [Thu, 28 Sep 2006 14:06:54 +0000 (14:06 +0000)]
Change to store template ID and not path; also bug fixes and fine-tuning the detection algorithm, etc

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11747 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agodisplayHtmlHeader uses template, no more direct echoing; also restructure how style...
pdontthink [Thu, 28 Sep 2006 14:04:53 +0000 (14:04 +0000)]
displayHtmlHeader uses template, no more direct echoing; also restructure how style links are sent out

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11746 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew Template class implementation
pdontthink [Thu, 28 Sep 2006 14:02:11 +0000 (14:02 +0000)]
New Template class implementation

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11745 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agorenamed with proper class file naming conventions
pdontthink [Thu, 28 Sep 2006 14:01:19 +0000 (14:01 +0000)]
renamed with proper class file naming conventions

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11744 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agot12n of compose function. Paul, could you please check the plugin hook implementatio...
stevetruckstuff [Wed, 27 Sep 2006 21:54:14 +0000 (21:54 +0000)]
t12n of compose function.  Paul, could you please check the plugin hook implementation for correctness?  I don't think I understand it all yet.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11743 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCorrecting login stylesheet since changes to template class.
stevetruckstuff [Wed, 27 Sep 2006 21:43:41 +0000 (21:43 +0000)]
Correcting login stylesheet since changes to template class.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11742 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoReverting other changes that snuck in. These need to wait for a bit until other...
pdontthink [Sun, 24 Sep 2006 19:05:28 +0000 (19:05 +0000)]
Reverting other changes that snuck in.  These need to wait for a bit until other files are ready to commit.  Sorry for the noise.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11740 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoReverting ampersand encoding. Glad I'm not going crazy after all. Thanks Tomas.
pdontthink [Sun, 24 Sep 2006 19:00:19 +0000 (19:00 +0000)]
Reverting ampersand encoding.  Glad I'm not going crazy after all.  Thanks Tomas.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11739 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCorrect me if I'm wrong (because oddly, this seemed to be working previously for...
pdontthink [Sun, 24 Sep 2006 18:04:29 +0000 (18:04 +0000)]
Correct me if I'm wrong (because oddly, this seemed to be working previously for me), but ampersands do not need to be encoded in links like this.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11738 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFix broken legacy use of concat_hook_function. Now you can log in again.
pdontthink [Fri, 22 Sep 2006 09:42:04 +0000 (09:42 +0000)]
Fix broken legacy use of concat_hook_function.  Now you can log in again.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11737 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoMove sqm_array_merge to arrays.php and subsequently move inclusion of arrays.php...
pdontthink [Fri, 22 Sep 2006 09:29:04 +0000 (09:29 +0000)]
Move sqm_array_merge to arrays.php and subsequently move inclusion of arrays.php to init.php for global access.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11736 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoSolved recursion problem and increased efficiency of template_construct hook by addin...
pdontthink [Fri, 22 Sep 2006 03:43:26 +0000 (03:43 +0000)]
Solved recursion problem and increased efficiency of template_construct hook by adding file name to the end of the hook name, such as template_construct_login.tpl.  Changed hook type to use the newly reworked concat_hook_function which can support merged arrays retued from the plugins.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11735 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoExtensive rework of concat hook function to support merged array return values
pdontthink [Fri, 22 Sep 2006 03:31:50 +0000 (03:31 +0000)]
Extensive rework of concat hook function to support merged array return values

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11734 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoForgot since tag
pdontthink [Fri, 22 Sep 2006 03:22:39 +0000 (03:22 +0000)]
Forgot since tag

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11733 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew 'nice' array_merge function that doesn't overwrite array values
pdontthink [Fri, 22 Sep 2006 03:19:05 +0000 (03:19 +0000)]
New 'nice' array_merge function that doesn't overwrite array values

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11732 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdding template_construct and template_output hooks. Yikes.
pdontthink [Thu, 21 Sep 2006 15:24:41 +0000 (15:24 +0000)]
Adding template_construct and template_output hooks.  Yikes.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11731 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoRemoving login_form hook, plugins can now use template_construct hook and add an...
pdontthink [Thu, 21 Sep 2006 15:19:44 +0000 (15:19 +0000)]
Removing login_form hook, plugins can now use template_construct hook and add an array index called login_form to the return value for that hook

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11730 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFixed error check
pdontthink [Thu, 21 Sep 2006 13:29:22 +0000 (13:29 +0000)]
Fixed error check

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11729 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoForgot to check default template set before falling back to plugin default template...
pdontthink [Thu, 21 Sep 2006 13:25:09 +0000 (13:25 +0000)]
Forgot to check default template set before falling back to plugin default template for plugin t12n

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11728 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAbstract template file location logic and enable plugin templating. This class still...
pdontthink [Thu, 21 Sep 2006 12:51:27 +0000 (12:51 +0000)]
Abstract template file location logic and enable plugin templating.  This class still needs abstraction which is the next task here.  Only possibly contentious change people should look at here is the use of file_exists() to find template files instead of reling on a hard-coded list of files in template.php.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11727 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoEnabling use of <plugin>_info() function
pdontthink [Tue, 19 Sep 2006 17:19:29 +0000 (17:19 +0000)]
Enabling use of <plugin>_info() function

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11725 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoDon't load prefs for serving stylesheets; instead grab template directory info from...
pdontthink [Tue, 19 Sep 2006 14:46:53 +0000 (14:46 +0000)]
Don't load prefs for serving stylesheets; instead grab template directory info from GET query string so we can make sure we are getting correct template set

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11724 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoVariable name is misleading, if technically correct. I'd personally eventually like...
pdontthink [Tue, 19 Sep 2006 14:43:41 +0000 (14:43 +0000)]
Variable name is misleading, if technically correct.  I'd personally eventually like to see a wrapper (class) around template ids, names, dirs, and other attributes.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11723 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoDefault was overriding legitimate values in sqgetGlobalVar due to recent addition...
pdontthink [Tue, 19 Sep 2006 14:26:46 +0000 (14:26 +0000)]
Default was overriding legitimate values in sqgetGlobalVar due to recent addition of typecast logic

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11722 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoVariable name is misleading, if technically correct. I'd personally eventually like...
pdontthink [Tue, 19 Sep 2006 14:11:33 +0000 (14:11 +0000)]
Variable name is misleading, if technically correct.  I'd personally eventually like to see a wrapper (class) around template ids, names, dirs, and other attributes.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11721 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoVariable name is misleading, if technically correct. I'd personally eventually like...
pdontthink [Tue, 19 Sep 2006 14:06:32 +0000 (14:06 +0000)]
Variable name is misleading, if technically correct.  I'd personally eventually like to see a wrapper (class) around template ids, names, dirs, and other attributes.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11720 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoClarifications, questions, proposals
pdontthink [Tue, 19 Sep 2006 13:26:08 +0000 (13:26 +0000)]
Clarifications, questions, proposals

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11719 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoPulling imapConnection var. Still causes segfaults which cannot be tracked down.
stevetruckstuff [Mon, 18 Sep 2006 20:11:34 +0000 (20:11 +0000)]
Pulling imapConnection var.  Still causes segfaults which cannot be tracked down.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11718 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFix no login button displayed when icons are disabled.
stevetruckstuff [Mon, 18 Sep 2006 19:08:18 +0000 (19:08 +0000)]
Fix no login button displayed when icons are disabled.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11717 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFixed CRLFs. Is somebody seriously developing in Windoze??
pdontthink [Mon, 18 Sep 2006 17:13:14 +0000 (17:13 +0000)]
Fixed CRLFs.  Is somebody seriously developing in Windoze??

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11716 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoStylesheets provided with templates won't load unless we load up prefs for stylesheet...
pdontthink [Mon, 18 Sep 2006 17:09:06 +0000 (17:09 +0000)]
Stylesheets provided with templates won't load unless we load up prefs for stylesheets too

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11715 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoJust in case....
stevetruckstuff [Mon, 18 Sep 2006 14:57:18 +0000 (14:57 +0000)]
Just in case....

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11714 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCorrect path for the default icon theme.
stevetruckstuff [Mon, 18 Sep 2006 14:54:50 +0000 (14:54 +0000)]
Correct path for the default icon theme.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11713 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFix unreachable code
stevetruckstuff [Mon, 18 Sep 2006 14:38:46 +0000 (14:38 +0000)]
Fix unreachable code

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11712 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoApache 2.0.55/PHP 5.1.6
tokul [Mon, 18 Sep 2006 11:31:35 +0000 (11:31 +0000)]
Apache 2.0.55/PHP 5.1.6
Apache 1.3.33/PHP 4.3.11
Apache 2.0.54/PHP 4.3.10
Apache 1.3.33/PHP 4.1.2

No segfaults.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11711 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoSuppress SID constant notices in older PHP versions.
tokul [Mon, 18 Sep 2006 11:30:00 +0000 (11:30 +0000)]
Suppress SID constant notices in older PHP versions.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11710 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoDelivery notifications and Read notifications are currently treated as identical...
stevetruckstuff [Fri, 15 Sep 2006 19:31:32 +0000 (19:31 +0000)]
Delivery notifications and Read notifications are currently treated as identical, which they are not.  This patch creates a separate var for these two types of notifications.  compose.php will be patched to handle this correctly when templatization (t12n) is completed.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11709 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdd explicit saveDelayedErrors() member function
stevetruckstuff [Fri, 15 Sep 2006 14:36:34 +0000 (14:36 +0000)]
Add explicit saveDelayedErrors() member function

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11708 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agokibibyte is with a capital K
kink [Sun, 10 Sep 2006 08:30:13 +0000 (08:30 +0000)]
kibibyte is with a capital K

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11688 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agokilo has a small 'k'.
kink [Sat, 9 Sep 2006 18:51:06 +0000 (18:51 +0000)]
kilo has a small 'k'.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11687 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoUse constants for sqgetGlobalVar() typecasting
pdontthink [Fri, 8 Sep 2006 06:33:53 +0000 (06:33 +0000)]
Use constants for sqgetGlobalVar() typecasting

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11685 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoAdded check_plugin_version() function
pdontthink [Thu, 7 Sep 2006 17:53:42 +0000 (17:53 +0000)]
Added check_plugin_version() function

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11684 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoDuh
pdontthink [Thu, 7 Sep 2006 17:18:59 +0000 (17:18 +0000)]
Duh

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11683 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew helper function for checking plugin version numbers check_plugin_version()
pdontthink [Thu, 7 Sep 2006 16:53:57 +0000 (16:53 +0000)]
New helper function for checking plugin version numbers check_plugin_version()

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11682 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoSlight adjustment. Plugins create their own table row for login_form hook; core...
pdontthink [Thu, 7 Sep 2006 09:40:04 +0000 (09:40 +0000)]
Slight adjustment.  Plugins create their own table row for login_form hook; core sets 'extra' variables separate from plugin data

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11681 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoI don't remember why the login_form hook had to be moved up into the table (it was...
pdontthink [Wed, 6 Sep 2006 07:55:39 +0000 (07:55 +0000)]
I don't remember why the login_form hook had to be moved up into the table (it was in fact always in the form), but placing it seemingly haphazard into just one of the two table cells is not useful for any of the plugins I can think of.  Moving to a table row of its own.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11680 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoWrong variable name used
pdontthink [Mon, 4 Sep 2006 18:06:28 +0000 (18:06 +0000)]
Wrong variable name used

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11679 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoTemplating for searching email
stevetruckstuff [Thu, 31 Aug 2006 18:12:27 +0000 (18:12 +0000)]
Templating for searching email

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11667 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoNew minus image
stevetruckstuff [Thu, 31 Aug 2006 18:09:32 +0000 (18:09 +0000)]
New minus image

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11666 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoRemove $settings['imapConnection']. Passing this to the template causes in intermitt...
stevetruckstuff [Thu, 31 Aug 2006 18:08:40 +0000 (18:08 +0000)]
Remove $settings['imapConnection'].  Passing this to the template causes in intermittent segfault on PHP 4.3.11 (maybe others??).  Since this variable is not used by the templates right now, we will simply remove it.  Probably need to re-evaluate this later as the IMAP connection could be extremely useful to template developers.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11665 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoPrevent the same error from being displayed twice
stevetruckstuff [Thu, 31 Aug 2006 18:05:41 +0000 (18:05 +0000)]
Prevent the same error from being displayed twice

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11664 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoCorrect typo in previous commit.
stevetruckstuff [Thu, 31 Aug 2006 14:44:51 +0000 (14:44 +0000)]
Correct typo in previous commit.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11663 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoFix error with trying to resend the header on a fatal error.
stevetruckstuff [Thu, 31 Aug 2006 14:14:28 +0000 (14:14 +0000)]
Fix error with trying to resend the header on a fatal error.

We *really* need to figure out why changes to member variables aren't being remembered outside of the member function in which they are changed.  This is afflicting the Template class and the Error class.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11662 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agohook must be moved because include/constants.php is
tokul [Thu, 31 Aug 2006 06:16:27 +0000 (06:16 +0000)]
hook must be moved because include/constants.php is
loaded before plugins are initialized.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11661 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agofunction is modified copy of list_writable_backends(). diff -uw between
tokul [Thu, 31 Aug 2006 05:43:18 +0000 (05:43 +0000)]
function is modified copy of list_writable_backends(). diff -uw between
1.96 and 1.97 shows that. Same structure, same while() arguments.

Steve's name is in AUTHORS. Please don't claim authorship on code that is
written by you AND other people.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11659 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoI've forgot that function is private in 1.4.x and is not available to plugins.
tokul [Thu, 31 Aug 2006 05:37:53 +0000 (05:37 +0000)]
I've forgot that function is private in 1.4.x and is not available to plugins.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11658 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoSplit sqimap_mailbox_option_list() into two functions to facilitate template development.
stevetruckstuff [Wed, 30 Aug 2006 20:45:56 +0000 (20:45 +0000)]
Split sqimap_mailbox_option_list() into two functions to facilitate template development.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11657 7612ce4b-ef26-0410-bec9-ea0150e637f0

17 years agoXCOURIEROUTBOX indicates option that can create duplicate messages.
tokul [Tue, 29 Aug 2006 18:30:09 +0000 (18:30 +0000)]
XCOURIEROUTBOX indicates option that can create duplicate messages.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11655 7612ce4b-ef26-0410-bec9-ea0150e637f0