From: pdontthink <pdontthink@7612ce4b-ef26-0410-bec9-ea0150e637f0>
Date: Wed, 25 Oct 2006 11:05:18 +0000 (+0000)
Subject: After looking into it, I slightly misunderstood the intention here.  Code is just... 
X-Git-Url: https://vcs.fsf.org/?p=squirrelmail.git;a=commitdiff_plain;h=d79174e80e6bc3e105a5d58b5448c5e768e41919;hp=9b94c54da2dbd7ff84e721712dfc0c75676377c8

After looking into it, I slightly misunderstood the intention here.  Code is just fine as is.


git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@11936 7612ce4b-ef26-0410-bec9-ea0150e637f0
---

diff --git a/functions/mime.php b/functions/mime.php
index 35ce6e7c..12c46a3c 100644
--- a/functions/mime.php
+++ b/functions/mime.php
@@ -549,14 +549,6 @@ function buildAttachmentArray($message, $exclude_id, $mailbox, $id) {
         $hookresults = do_hook("attachment $type0/$type1", $links,
                 $startMessage, $id, $urlMailbox, $ent, $defaultlink,
                 $display_filename, $where, $what);
-// FIXME: How does this code ever get executed?  $hookresults[1] is $links
-//        from above, and should always be returned by do_hook().  I will
-//        test this and fix if needed (but it has been working, right???)
-//        and get rid of these comments (Paul)
-// UPDATE: Preliminary testing shows that in fact I am correct that the
-//         following never gets executed (unless a strange plugin actually
-//         unsets the contents of the links)... how did this ever work???
-//         Can someonen please show a plugin that worked here?
         if(count($hookresults[1]) <= 1) {
             $hookresults = do_hook("attachment $type0/*", $links,
                     $startMessage, $id, $urlMailbox, $ent, $defaultlink,