From: pdontthink Date: Wed, 10 Jan 2007 20:34:26 +0000 (+0000) Subject: Back out something that shouldn't be here (yet?) and leave behind a comment explainin... X-Git-Url: https://vcs.fsf.org/?p=squirrelmail.git;a=commitdiff_plain;h=98e88751fa8c6c482e009f6d5d8e0cb5ee9d57af;hp=5edfad3d07901c07aa0509318884b861878598ec Back out something that shouldn't be here (yet?) and leave behind a comment explaining that htmlencoded is currently ignored git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@12110 7612ce4b-ef26-0410-bec9-ea0150e637f0 --- diff --git a/functions/options.php b/functions/options.php index d03d05ba..7332303d 100644 --- a/functions/options.php +++ b/functions/options.php @@ -370,8 +370,8 @@ class SquirrelOption { * @return string html formated selection box */ function createWidget_StrList() { - - return addSelect('new_' . $this->name, $this->possible_values, $this->value, TRUE, $this->aExtraAttribs, !$this->htmlencoded) . htmlspecialchars($this->trailing_text); +//FIXME: Currently, $this->htmlencoded is ignored here -- was removed when changing to template-based output; a fix is available as part of proposed centralized sanitizing patch + return addSelect('new_' . $this->name, $this->possible_values, $this->value, TRUE, $this->aExtraAttribs) . htmlspecialchars($this->trailing_text); }