Tweaked printer friendly attachment display. Looked a little odd squished

over on the left.  Removed invalid html, and set widths on the "headers".

What do people think of this display?  I think it needs css borders rather
than the good ol' html borders.

git-svn-id: https://svn.code.sf.net/p/squirrelmail/code/trunk/squirrelmail@10321 7612ce4b-ef26-0410-bec9-ea0150e637f0

diff --git a/ChangeLog b/ChangeLog
index b991ef261cbf2e9af0c011969d86f53c93ab3aa9..daa9b31f01305323debb2107de3208e19b0e9eff 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -479,6 +479,7 @@ Version 1.5.1 -- CVS
     than 6 (#1339211).
   - Allow double quote to be used in MOTD (#1276959).
   - Prevent right_frame to be set to '//www.example.com'.
+  - Tweak printer friendly attachment view.
 
 Version 1.5.0 - 2 February 2004
 -------------------------------

diff --git a/src/printer_friendly_bottom.php b/src/printer_friendly_bottom.php
index 1194e37a6c1c89f88acf25cc2122ed97883d7454..f4a2fde200d4837d433054e46e76d51731950368 100644 (file)
--- a/src/printer_friendly_bottom.php
+++ b/src/printer_friendly_bottom.php
@@ -260,13 +260,13 @@ function pf_show_attachments($message, $exclude_id, $mailbox, $id) {
         $display_filename = $filename;
 
         // TODO: maybe make it nicer?
-        $attachments .= '<table cellpadding="0" cellspacing="0" border="1"><tr><th colspan="2">'.decodeHeader($display_filename).'</th></tr>' .
-            '<tr border="0">'.
-            html_tag( 'td',_("Size:"), 'right') .
-            html_tag( 'td',show_readable_size($header->size), 'left') .
-            '</tr><tr>' .
-            html_tag( 'td',_("Type:"), 'right') .
-            html_tag( 'td',htmlspecialchars($type0).'/'.htmlspecialchars($type1), 'left') . 
+        $attachments .= '<table cellpadding="1" cellspacing="0" width="100%" border="1"><tr><th colspan="2">'.decodeHeader($display_filename).'</th></tr>' .
+            '<tr>'. 
+            html_tag( 'td',_("Size:"), 'right', '', 'width="25%"') . 
+            html_tag( 'td',show_readable_size($header->size), 'left', '', 'width="75%"') .
+            '</tr><tr>' . "\n" .
+            html_tag( 'td',_("Type:"), 'right', '', 'width="25%"') .
+            html_tag( 'td',htmlspecialchars($type0).'/'.htmlspecialchars($type1), 'left', '', 'width="75%"') . 
             '</tr>';
         if (! empty($description)) {
             $attachments .= $description;