X-Git-Url: https://vcs.fsf.org/?p=squirrelmail.git;a=blobdiff_plain;f=src%2Foptions.php;h=0d320b21030de7769925de18718df578f9761c7e;hp=c018186a1ce162e1496fe58829837749d7506418;hb=24e8917ead46268f6a4264900c832b4a5c37ee84;hpb=cc61478a38c0d56346511026c34063262eb989c6 diff --git a/src/options.php b/src/options.php index c018186a..0d320b21 100644 --- a/src/options.php +++ b/src/options.php @@ -1,41 +1,36 @@ name == 'email_address' ) { + $option->setValue(''); + } + /* Remove Debug Mode Until Needed echo "name = '$option->name', " . "value = '$option->value', " - . "new_value = '$option->new_value'
\n"; + . "new_value = '$option->new_value'\n"; +//FIXME: NO HTML IN THE CORE! + echo "
"; */ if ($option->changed()) { $option->save(); @@ -74,9 +97,22 @@ function process_optionmode_link($optpage) { /* There will be something here, later. */ } + + +/* ---------------------------- main ---------------------------- */ + +/* get the globals that we may need */ +sqgetGlobalVar('optpage', $optpage); +sqgetGlobalVar('optmode', $optmode, SQ_FORM); +sqgetGlobalVar('optpage_data',$optpage_data, SQ_POST); +sqgetGlobalVar('smtoken', $submitted_token, SQ_FORM, ''); +/* end of getting globals */ + /* Make sure we have an Option Page set. Default to main. */ -if (!isset($optpage)) { - $optpage = 'main'; +if ( !isset($optpage) || $optpage == '' ) { + $optpage = SMOPT_PAGE_MAIN; +} else { + $optpage = strip_tags( $optpage ); } /* Make sure we have an Option Mode set. Default to display. */ @@ -84,9 +120,9 @@ if (!isset($optmode)) { $optmode = SMOPT_MODE_DISPLAY; } -/*************************************************************/ -/*** First, set the load information for each option page. ***/ -/*************************************************************/ +/* + * First, set the load information for each option page. + */ /* Initialize load information variables. */ $optpage_name = ''; @@ -95,54 +131,83 @@ $optpage_loader = ''; /* Set the load information for each page. */ switch ($optpage) { - case SMOPT_PAGE_MAIN: break; + case SMOPT_PAGE_MAIN: + break; case SMOPT_PAGE_PERSONAL: - $optpage_name = _("Personal Information"); - $optpage_file = 'options_personal.php'; - $optpage_loader = 'load_optpage_data_personal'; + $optpage_name = _("Personal Information"); + $optpage_file = SM_PATH . 'include/options/personal.php'; + $optpage_loader = 'load_optpage_data_personal'; + $optpage_loadhook = 'optpage_loadhook_personal'; break; case SMOPT_PAGE_DISPLAY: $optpage_name = _("Display Preferences"); - $optpage_file = 'options_display.php'; + $optpage_file = SM_PATH . 'include/options/display.php'; $optpage_loader = 'load_optpage_data_display'; + $optpage_loadhook = 'optpage_loadhook_display'; + break; + case SMOPT_PAGE_COMPOSE: + $optpage_name = _("Compose Preferences"); + $optpage_file = SM_PATH . 'include/options/compose.php'; + $optpage_loader = 'load_optpage_data_compose'; + $optpage_loadhook = 'optpage_loadhook_compose'; + break; + case SMOPT_PAGE_ACCESSIBILITY: + $optpage_name = _("Accessibility Preferences"); + $optpage_file = SM_PATH . 'include/options/accessibility.php'; + $optpage_loader = 'load_optpage_data_accessibility'; + $optpage_loadhook = 'optpage_loadhook_accessibility'; break; case SMOPT_PAGE_HIGHLIGHT: $optpage_name = _("Message Highlighting"); - $optpage_file = 'options_highlight.php'; + $optpage_file = SM_PATH . 'include/options/highlight.php'; $optpage_loader = 'load_optpage_data_highlight'; + $optpage_loadhook = 'optpage_loadhook_highlight'; break; case SMOPT_PAGE_FOLDER: $optpage_name = _("Folder Preferences"); - $optpage_file = 'options_folder.php'; + $optpage_file = SM_PATH . 'include/options/folder.php'; $optpage_loader = 'load_optpage_data_folder'; + $optpage_loadhook = 'optpage_loadhook_folder'; break; case SMOPT_PAGE_ORDER: $optpage_name = _("Index Order"); - $optpage_file = 'options_order.php'; + $optpage_file = SM_PATH . 'include/options/order.php'; $optpage_loader = 'load_optpage_data_order'; + $optpage_loadhook = 'optpage_loadhook_order'; break; - default: do_hook('set_optpage_loadinfo'); + default: do_hook('optpage_set_loadinfo', $null); } /**********************************************************/ /*** Second, load the option information for this page. ***/ /**********************************************************/ -if ($optpage != SMOPT_PAGE_MAIN) { +if ( !@is_file( $optpage_file ) ) { + $optpage = SMOPT_PAGE_MAIN; +} elseif ($optpage != SMOPT_PAGE_MAIN ) { /* Include the file for this optionpage. */ + require_once($optpage_file); /* Assemble the data for this option page. */ $optpage_data = array(); $optpage_data = $optpage_loader(); - $optpage_data['options'] = - create_option_groups($optpage_data['grps'], $optpage_data['vals']); + do_hook($optpage_loadhook, $null); + $optpage_data['options'] = create_option_groups($optpage_data['grps'], $optpage_data['vals']); } /***********************************************************/ /*** Next, process anything that needs to be processed. ***/ /***********************************************************/ +// security check before saving anything... +//FIXME: what about SMOPT_MODE_LINK?? +if ($optmode == SMOPT_MODE_SUBMIT) { + sm_validate_security_token($submitted_token, -1, TRUE); +} + +$optpage_save_error=array(); + if ( isset( $optpage_data ) ) { switch ($optmode) { case SMOPT_MODE_SUBMIT: @@ -153,30 +218,19 @@ if ( isset( $optpage_data ) ) { break; } } -/*** MOVE THIS DISPLAY CODE DOWN EVENTUALLY!!! ***/ $optpage_title = _("Options"); if (isset($optpage_name) && ($optpage_name != '')) { $optpage_title .= " - $optpage_name"; } -?> - -
- - -
-
- - -
- -' . _("Successfully Saved Options") . ": $optpage_name
\n"; + if (!isset($frame_top)) { + $frame_top = '_top'; + } + + if (isset($optpage_save_error) && $optpage_save_error!=array()) { +//FIXME: REMOVE HTML FROM CORE + $notice = _("Error(s) occurred while saving your options") . "
\n
    \n"; + foreach ($optpage_save_error as $error_message) { + $notice.= '
  • ' . $error_message . "
  • \n"; + } + $notice.= "
\n" . _("Some of your preference changes were not applied.") . "\n"; + } else { + /* Display a message indicating a successful save. */ + // i18n: The %s represents the name of the option page saving the options + $notice = sprintf(_("Successfully Saved Options: %s"), $optpage_name) . "
\n"; + } /* If $max_refresh != SMOPT_REFRESH_NONE, provide a refresh link. */ - if ($max_refresh == SMOPT_REFRESH_FOLDERLIST) { - echo '' . _("Refresh Folder List") . '
'; + if ( !isset( $max_refresh ) ) { + } else if ($max_refresh == SMOPT_REFRESH_FOLDERLIST) { +//FIXME: REMOVE HTML FROM CORE - when migrating, keep in mind that the javascript below assumes the folder list is in a separate sibling frame under the same parent, and it is called "left" + if (checkForJavascript()) { + $notice .= sprintf(_("Folder list should automatically %srefresh%s."), '', '') . '
\n"; + } else { + $notice .= '' . _("Refresh Folder List") . '
'; + } } else if ($max_refresh) { - echo '' . _("Refresh Page") . '
'; + if (checkForJavascript()) { +//FIXME: REMOVE HTML FROM CORE - when migrating, keep in mind that the javascript below assumes the parent is the top-most SM frame and is what should be refreshed with webmail.php + $notice .= sprintf(_("This page should automatically %srefresh%s."), '', '') . '
\n"; + } else { + $notice .= '' . _("Refresh Page") . '
'; + } } } + + if (!empty($notice)) { + $oTemplate->assign('note', $notice); + $oTemplate->display('note.tpl'); + } + /******************************************/ /* Build our array of Option Page Blocks. */ /******************************************/ $optpage_blocks = array(); + // access keys... + global $accesskey_options_personal, $accesskey_options_display, + $accesskey_options_highlighting, $accesskey_options_folders, + $accesskey_options_index_order, $accesskey_options_compose, + $accesskey_options_accessibility; + /* Build a section for Personal Options. */ $optpage_blocks[] = array( - 'name' => _("Personal Information"), - 'url' => 'options.php?optpage=' . SMOPT_PAGE_PERSONAL, - 'desc' => _("This contains personal information about yourself such as your name, your email address, etc."), - 'js' => false + 'name' => _("Personal Information"), + 'url' => 'options.php?optpage=' . SMOPT_PAGE_PERSONAL, + 'desc' => _("This contains personal information about yourself such as your name, your email address, etc."), + 'js' => false, + 'accesskey' => $accesskey_options_personal, ); /* Build a section for Display Options. */ $optpage_blocks[] = array( - 'name' => _("Display Preferences"), - 'url' => 'options.php?optpage=' . SMOPT_PAGE_DISPLAY, - 'desc' => _("You can change the way that SquirrelMail looks and displays information to you, such as the colors, the language, and other settings."), - 'js' => false + 'name' => _("Display Preferences"), + 'url' => 'options.php?optpage=' . SMOPT_PAGE_DISPLAY, + 'desc' => _("You can change the way that SquirrelMail looks and displays information to you, such as the colors, the language, and other settings."), + 'js' => false, + 'accesskey' => $accesskey_options_display, ); /* Build a section for Message Highlighting Options. */ $optpage_blocks[] = array( - 'name' =>_("Message Highlighting"), - 'url' => 'options_highlight.php', - 'desc' =>_("Based upon given criteria, incoming messages can have different background colors in the message list. This helps to easily distinguish who the messages are from, especially for mailing lists."), - 'js' => false + 'name' =>_("Message Highlighting"), + 'url' => 'options_highlight.php', + 'desc' =>_("Based upon given criteria, incoming messages can have different background colors in the message list. This helps to easily distinguish who the messages are from, especially for mailing lists."), + 'js' => false, + 'accesskey' => $accesskey_options_highlighting, ); /* Build a section for Folder Options. */ $optpage_blocks[] = array( - 'name' => _("Folder Preferences"), - 'url' => 'options.php?optpage=' . SMOPT_PAGE_FOLDER, - 'desc' => _("These settings change the way your folders are displayed and manipulated."), - 'js' => false + 'name' => _("Folder Preferences"), + 'url' => 'options.php?optpage=' . SMOPT_PAGE_FOLDER, + 'desc' => _("These settings change the way your folders are displayed and manipulated."), + 'js' => false, + 'accesskey' => $accesskey_options_folders, ); /* Build a section for Index Order Options. */ $optpage_blocks[] = array( - 'name' => _("Index Order"), - 'url' => 'options_order.php', - 'desc' => _("The order of the message index can be rearanged and changed to contain the headers in any order you want."), - 'js' => false + 'name' => _("Index Order"), + 'url' => 'options_order.php', + 'desc' => _("The order of the message index can be rearranged and changed to contain the headers in any order you want."), + 'js' => false, + 'accesskey' => $accesskey_options_index_order, + ); + + /* Build a section for Compose Options. */ + $optpage_blocks[] = array( + 'name' => _("Compose Preferences"), + 'url' => 'options.php?optpage=' . SMOPT_PAGE_COMPOSE, + 'desc' => _("Control the behaviour and layout of writing new mail messages, replying to and forwarding messages."), + 'js' => false, + 'accesskey' => $accesskey_options_compose, + ); + + /* Build a section for Accessibility Options. */ + $optpage_blocks[] = array( + 'name' => _("Accessibility Preferences"), + 'url' => 'options.php?optpage=' . SMOPT_PAGE_ACCESSIBILITY, + 'desc' => _("You can configure features that improve interface usability."), + 'js' => false, + 'accesskey' => $accesskey_options_accessibility, ); /* Build a section for plugins wanting to register an optionpage. */ - do_hook('optpage_register_block'); + do_hook('optpage_register_block', $null); /*****************************************************/ /* Let's sort Javascript Option Pages to the bottom. */ @@ -285,9 +409,12 @@ if ($optpage == SMOPT_PAGE_MAIN) { $js_optpage_blocks = array(); $reg_optpage_blocks = array(); foreach ($optpage_blocks as $cur_optpage) { - if (!$cur_optpage['js']) { + if (!isset($cur_optpage['accesskey'])) { + $cur_optpage['accesskey'] = 'NONE'; + } + if (!isset($cur_optpage['js']) || !$cur_optpage['js']) { $reg_optpage_blocks[] = $cur_optpage; - } else if ($javascript_on == SMPREF_JS_ON) { + } else if (checkForJavascript()) { $js_optpage_blocks[] = $cur_optpage; } } @@ -296,161 +423,89 @@ if ($optpage == SMOPT_PAGE_MAIN) { /********************************************/ /* Now, print out each option page section. */ /********************************************/ - $first_optpage = false; - echo "" . - '
' . - ""; - foreach ($optpage_blocks as $next_optpage) { - if ($first_optpage == false) { - $first_optpage = $next_optpage; - } else { - print_optionpages_row($first_optpage, $next_optpage); - $first_optpage = false; - } - } - - if ($first_optpage != false) { - print_optionpages_row($first_optpage); - } + $oTemplate->assign('page_title', $optpage_title); + $oTemplate->assign('options', $optpage_blocks); - echo "
\n"; - - do_hook('options_link_and_description'); + $oTemplate->display('option_groups.tpl'); + + do_hook('options_link_and_description', $null); /*************************************************************************/ /* If we are not looking at the main option page, display the page here. */ /*************************************************************************/ } else { - echo '

' . "\n" - . '' . "\n" - . create_optpage_element($optpage) - . create_optmode_element(SMOPT_MODE_SUBMIT); - - /* Output the option groups for this page. */ - print_option_groups($optpage_data['options']); - - /*** FIXME: CURRENTLY, THIS NEXT SWITCH STATEMENT DOES NOT TAKE - *** INTO ACCOUNT FOR PLUGINS. NEED TO FIX IT. ***/ - - /* Set the inside_hook_name and submit_name. */ + /* Set the bottom_hook_name and submit_name. */ switch ($optpage) { case SMOPT_PAGE_PERSONAL: - $inside_hook_name = 'options_personal_inside'; $bottom_hook_name = 'options_personal_bottom'; $submit_name = 'submit_personal'; break; case SMOPT_PAGE_DISPLAY: - $inside_hook_name = 'options_display_inside'; $bottom_hook_name = 'options_display_bottom'; $submit_name = 'submit_display'; break; + case SMOPT_PAGE_COMPOSE: + $bottom_hook_name = 'options_compose_bottom'; + $submit_name = 'submit_compose'; + break; + case SMOPT_PAGE_ACCESSIBILITY: + $bottom_hook_name = 'options_accessibility_bottom'; + $submit_name = 'submit_accessibility'; + break; case SMOPT_PAGE_HIGHLIGHT: - $inside_hook_name = 'options_highlight_inside'; - $bottom_hook_name = 'options_display_bottom'; + $bottom_hook_name = 'options_highlight_bottom'; $submit_name = 'submit_highlight'; break; case SMOPT_PAGE_FOLDER: - $inside_hook_name = 'options_folder_inside'; - $bottom_hook_name = 'options_display_bottom'; + $bottom_hook_name = 'options_folder_bottom'; $submit_name = 'submit_folder'; break; case SMOPT_PAGE_ORDER: - $inside_hook_name = 'options_order_inside'; $bottom_hook_name = 'options_order_bottom'; $submit_name = 'submit_order'; break; default: - $inside_hook_name = ''; - $bottom_hook_name = ''; + $bottom_hook_name = 'options_generic_bottom'; $submit_name = 'submit'; } - /* If it is not empty, trigger the inside hook. */ - if ($inside_hook_name != '') { - do_hook($inside_hook_name); - } + // Begin output form + echo addForm('options.php', 'post', 'option_form', '', '', array(), TRUE) + . create_optpage_element($optpage) + . create_optmode_element(SMOPT_MODE_SUBMIT); - /* Spit out a submit button. */ - OptionSubmit($submit_name); - echo '
'; + // This is the only variable that is needed by *just* the template. + $oTemplate->assign('option_groups', $optpage_data['options']); + + global $ask_user_info, $org_name; + if ( $optpage == SMOPT_PAGE_PERSONAL && $ask_user_info + && getPref($data_dir, $username,'email_address') == "" ) { + $oTemplate->assign('topmessage', + sprintf(_("Welcome to %s. Please supply your full name and email address."), $org_name) ); + } + + // These variables are not specifically needed by the template, + // but they are relevant to the page being built, so we'll add + // them in case some plugin is modifying the page, etc.... + // + $oTemplate->assign('max_refresh', isset($max_refresh) ? $max_refresh : NULL); + $oTemplate->assign('page_title', $optpage_title); + $oTemplate->assign('optpage', $optpage); + $oTemplate->assign('optpage_name', $optpage_name); + $oTemplate->assign('optmode', $optmode); + $oTemplate->assign('optpage_data', $optpage_data); + + $oTemplate->assign('submit_name', $submit_name); + $oTemplate->display('options.tpl'); + + $oTemplate->display('form_close.tpl'); /* If it is not empty, trigger the bottom hook. */ if ($bottom_hook_name != '') { - do_hook($bottom_hook_name); + do_hook($bottom_hook_name, $null); } + } -?> -
- -
- - - -" . - '' . - '' . - '' . - "'. - ""; - if ($rightopt) { - echo "'; - } else { - echo ""; - } - - echo '' . - '' . - "' . - ""; - if ($rightopt) { - echo "'; - } else { - echo ""; - } - - echo '' . - '
" . - '' . $leftopt['name'] . ''. - ' " . - '' . $rightopt['name'] . '' . - ' 
" . - $leftopt['desc'] . - ' " . - $rightopt['desc'] . - ' 
' . - '' . - "\n"; - } - -?> \ No newline at end of file +$oTemplate->display('footer.tpl');