X-Git-Url: https://vcs.fsf.org/?p=squirrelmail.git;a=blobdiff_plain;f=src%2Fcompose.php;h=9f99f9855554d5adf0045bb29d70255a44905ca9;hp=a76e7e65abdc9ac9ad2650bd07880fcbc8bbeba6;hb=c90271cb5202fc5f59e0c253df4f2e7a3fb5f337;hpb=74f66d27976844a6b3cd4a6b7be37f16ee0ba318 diff --git a/src/compose.php b/src/compose.php index a76e7e65..9f99f985 100644 --- a/src/compose.php +++ b/src/compose.php @@ -10,7 +10,7 @@ * - Send mail * - Save As Draft * - * @copyright © 1999-2006 The SquirrelMail Project Team + * @copyright © 1999-2007 The SquirrelMail Project Team * @license http://opensource.org/licenses/gpl-license.php GNU Public License * @version $Id$ * @package squirrelmail @@ -21,11 +21,19 @@ */ require('../include/init.php'); +/* If email_address not set and admin wants us to ask user for it, + * redirect to options page. */ +if ( $ask_user_info && getPref($data_dir, $username,'email_address') == "" ) { + header("Location: " . get_location() . "/options.php?optpage=personal"); + exit; +} + /* SquirrelMail required files. */ require_once(SM_PATH . 'functions/imap_general.php'); require_once(SM_PATH . 'functions/imap_messages.php'); require_once(SM_PATH . 'functions/date.php'); require_once(SM_PATH . 'functions/mime.php'); +require_once(SM_PATH . 'functions/compose.php'); require_once(SM_PATH . 'class/deliver/Deliver.class.php'); require_once(SM_PATH . 'functions/addressbook.php'); require_once(SM_PATH . 'functions/forms.php'); @@ -44,32 +52,42 @@ sqgetGlobalVar('delayed_errors', $delayed_errors, SQ_SESSION); $oErrorHandler->setDelayedErrors(true); /** SESSION/POST/GET VARS */ -sqgetGlobalVar('session',$session); -sqgetGlobalVar('mailbox',$mailbox); -if(!sqgetGlobalVar('identity',$identity)) { +sqgetGlobalVar('send', $send, SQ_POST); +// Send can only be achieved by setting $_POST var. If Send = true then +// retrieve other form fields from $_POST +if (isset($send) && $send) { + $SQ_GLOBAL = SQ_POST; +} else { + $SQ_GLOBAL = SQ_FORM; +} +sqgetGlobalVar('session',$session, $SQ_GLOBAL); +sqgetGlobalVar('mailbox',$mailbox, $SQ_GLOBAL); +if(!sqgetGlobalVar('identity',$identity, $SQ_GLOBAL)) { $identity=0; } -sqgetGlobalVar('send_to',$send_to); -sqgetGlobalVar('send_to_cc',$send_to_cc); -sqgetGlobalVar('send_to_bcc',$send_to_bcc); -sqgetGlobalVar('subject',$subject); -sqgetGlobalVar('body',$body); -sqgetGlobalVar('mailprio',$mailprio); -sqgetGlobalVar('request_mdn',$request_mdn); -sqgetGlobalVar('request_dr',$request_dr); -sqgetGlobalVar('html_addr_search',$html_addr_search); -sqgetGlobalVar('mail_sent',$mail_sent); -sqgetGlobalVar('passed_id',$passed_id); -sqgetGlobalVar('passed_ent_id',$passed_ent_id); -sqgetGlobalVar('send',$send); - -sqgetGlobalVar('attach',$attach); - -sqgetGlobalVar('draft',$draft); -sqgetGlobalVar('draft_id',$draft_id); -sqgetGlobalVar('ent_num',$ent_num); -sqgetGlobalVar('saved_draft',$saved_draft); -sqgetGlobalVar('delete_draft',$delete_draft); +sqgetGlobalVar('send_to',$send_to, $SQ_GLOBAL); +sqgetGlobalVar('send_to_cc',$send_to_cc, $SQ_GLOBAL); +sqgetGlobalVar('send_to_bcc',$send_to_bcc, $SQ_GLOBAL); +sqgetGlobalVar('subject',$subject, $SQ_GLOBAL); +sqgetGlobalVar('body',$body, $SQ_GLOBAL); +sqgetGlobalVar('mailprio',$mailprio, $SQ_GLOBAL); +sqgetGlobalVar('request_mdn',$request_mdn, $SQ_GLOBAL); +sqgetGlobalVar('request_dr',$request_dr, $SQ_GLOBAL); +sqgetGlobalVar('html_addr_search',$html_addr_search, $SQ_GLOBAL); +sqgetGlobalVar('mail_sent',$mail_sent, $SQ_GLOBAL); +sqgetGlobalVar('passed_id',$passed_id, $SQ_GLOBAL); +sqgetGlobalVar('passed_ent_id',$passed_ent_id, $SQ_GLOBAL); + +sqgetGlobalVar('attach',$attach, SQ_POST); +sqgetGlobalVar('draft',$draft, SQ_POST); +sqgetGlobalVar('draft_id',$draft_id, $SQ_GLOBAL); +sqgetGlobalVar('ent_num',$ent_num, $SQ_GLOBAL); +sqgetGlobalVar('saved_draft',$saved_draft, SQ_FORM); + +if ( sqgetGlobalVar('delete_draft',$delete_draft) ) { + $delete_draft = (int)$delete_draft; +} + if ( sqgetGlobalVar('startMessage',$startMessage) ) { $startMessage = (int)$startMessage; } else { @@ -110,6 +128,25 @@ if ( !sqgetGlobalVar('smaction',$action) ) if ( sqgetGlobalVar('smaction_edit_new',$tmp) ) $action = 'edit_as_new'; } +/** + * Here we decode the data passed in from mailto.php. + */ +if ( sqgetGlobalVar('mailtodata', $mailtodata, SQ_GET) ) { + $trtable = array('to' => 'send_to', + 'cc' => 'send_to_cc', + 'bcc' => 'send_to_bcc', + 'body' => 'body', + 'subject' => 'subject'); + $mtdata = unserialize($mailtodata); + + foreach ($trtable as $f => $t) { + if ( !empty($mtdata[$f]) ) { + $$t = $mtdata[$f]; + } + } + unset($mailtodata,$mtdata, $trtable); +} + /* Location (For HTTP 1.1 Header("Location: ...") redirects) */ $location = get_location(); /* Identities (fetch only once) */ @@ -123,8 +160,8 @@ function replyAllString($header) { /** * 1) Remove the addresses we'll be sending the message 'to' */ - if (isset($header->replyto)) { - $excl_ar = $header->getAddr_a('replyto'); + if (isset($header->reply_to)) { + $excl_ar = $header->getAddr_a('reply_to'); } /** * 2) Remove our identities from the CC list (they still can be in the @@ -261,7 +298,7 @@ function getforwardHeader($orig_header) { $bodyTop = sq_str_pad(' '._("Original Message").' ',$editor_size -2,'-',STR_PAD_BOTH,$default_charset) . "\n". $display[_("Subject")] . $subject . "\n" . $display[_("From")] . $from . "\n" . - $display[_("Date")] . getLongDateString( $orig_header->date ). "\n" . + $display[_("Date")] . getLongDateString( $orig_header->date, $orig_header->date_unparsed ). "\n" . $display[_("To")] . $to . "\n"; if ($orig_header->cc != array() && $orig_header->cc !='') { $cc = decodeHeader($orig_header->getAddr_s('cc',"\n$indent"),false,false,true); @@ -289,7 +326,7 @@ if (sqsession_is_registered('session_expired_post')) { sqsession_unregister('session_expired_post'); session_write_close(); } else { - // these are the vars that we can set from the expired composed session + // these are the vars that we can set from the expired composed session $compo_var_list = array ( 'send_to', 'send_to_cc','body','startMessage', 'passed_body','use_signature','signature','attachments','subject','newmail', 'send_to_bcc', 'passed_id', 'mailbox', 'from_htmladdr_search', 'identity', @@ -298,11 +335,11 @@ if (sqsession_is_registered('session_expired_post')) { foreach ($compo_var_list as $var) { if ( isset($session_expired_post[$var]) && !isset($$var) ) { - $$var = $session_expired_post[$var]; + $$var = $session_expired_post[$var]; } } - $compose_messages = unserialize(urldecode($restoremessages)); + $compose_messages = unserialize($restoremessages); sqsession_register($compose_messages,'compose_messages'); sqsession_register($composesession,'composesession'); if (isset($send)) { @@ -333,6 +370,8 @@ if (sqsession_is_registered('session_expired_post')) { if (!isset($composesession)) { $composesession = 0; sqsession_register(0,'composesession'); +} else { + $composesession = (int)$composesession; } if (!isset($session) || (isset($newmessage) && $newmessage)) { @@ -357,7 +396,7 @@ if (!isset($compose_messages[$session]) || ($compose_messages[$session] == NULL) $composeMessage=$compose_messages[$session]; } -if (!isset($mailbox) || $mailbox == '' || ($mailbox == 'None')) { +if (empty($mailbox)) { $mailbox = 'INBOX'; } @@ -387,7 +426,7 @@ if ($draft) { } sqimap_logout($imap_stream); } - + $oErrorHandler->saveDelayedErrors(); session_write_close(); @@ -426,7 +465,7 @@ if ($send) { /* We entered compose via the search results page */ $mailbox = 'INBOX'; /* Send 'em to INBOX, that's safe enough */ } - $urlMailbox = urlencode (trim($mailbox)); + $urlMailbox = urlencode($mailbox); if (! isset($passed_id)) { $passed_id = 0; } @@ -451,10 +490,10 @@ if ($send) { if( $line <> '-- ' ) { $line = rtrim($line); } - if (sq_strlen($line,$default_charset) <= $editor_size + 1) { + if (sq_strlen($line, $default_charset) <= $editor_size + 1) { $newBody .= $line . "\n"; } else { - sqWordWrap($line, $editor_size,$default_charset); + sqWordWrap($line, $editor_size, $default_charset); $newBody .= $line . "\n"; } @@ -466,7 +505,15 @@ if ($send) { $Result = deliverMessage($composeMessage); - do_hook('compose_send_after', $Result, $composeMessage); + if ($Result) + $mail_sent = 'yes'; + else + $mail_sent = 'no'; + + // NOTE: this hook changed in 1.5.2 from sending $Result and + // $composeMessage as args #2 and #3 to being in an array + // under arg #2 + do_hook('compose_send_after', $temp=array(&$Result, &$composeMessage, &$mail_sent)); if (! $Result) { showInputForm($session); exit(); @@ -494,21 +541,21 @@ if ($send) { if ($compose_new_win == '1') { if ( !isset($pageheader_sent) || !$pageheader_sent ) { - Header("Location: $location/compose.php?mail_sent=yes"); + Header("Location: $location/compose.php?mail_sent=$mail_sent"); } else { echo '

' + . '/compose.php?mail_sent=$mail_sent">' . _("Return") . '
'; } exit(); } else { if ( !isset($pageheader_sent) || !$pageheader_sent ) { Header("Location: $location/right_main.php?mailbox=$urlMailbox". - "&startMessage=$startMessage&mail_sent=yes"); + "&startMessage=$startMessage&mail_sent=$mail_sent"); } else { echo '

" + . "&startMessage=$startMessage&mail_sent=$mail_sent\">" . _("Return") . '
'; } exit(); @@ -682,8 +729,8 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se $use_signature, $data_dir, $username, $key, $imapServerAddress, $imapPort, $compose_messages, $composeMessage, $body_quote, $request_mdn, $request_dr, - $default_use_mdn, $mdn_user_support; - global $languages, $squirrelmail_language, $default_charset; + $mdn_user_support, $languages, $squirrelmail_language, + $default_charset; /* * Set $default_charset to correspond with the user's selection @@ -715,7 +762,7 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se (array(), $alt_order = array('text/plain')); if (!count($entities)) { $entities = $message->entities[0]->findDisplayEntity - (array(), $alt_order = array('text/plain','html/plain')); + (array(), $alt_order = array('text/plain','text/html')); } $orig_header = $message->rfc822_header; /* here is the envelope located */ /* redefine the message for picking up the attachments */ @@ -724,7 +771,7 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se } else { $entities = $message->findDisplayEntity (array(), $alt_order = array('text/plain')); if (!count($entities)) { - $entities = $message->findDisplayEntity (array(), $alt_order = array('text/plain','html/plain')); + $entities = $message->findDisplayEntity (array(), $alt_order = array('text/plain','text/html')); } $orig_header = $message->rfc822_header; } @@ -737,7 +784,7 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se $type1 = $msg->type1; $unencoded_bodypart = mime_fetch_body($imapConnection, $passed_id, $ent); $body_part_entity = $message->getEntity($ent); - $bodypart = decodeBody($unencoded_bodypart, + $bodypart = decodeBody($unencoded_bodypart, $body_part_entity->header->encoding); if ($type1 == 'html') { $bodypart = str_replace("\n", ' ', $bodypart); @@ -775,7 +822,6 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se $mailprio = ''; } - $identity = ''; $from_o = $orig_header->from; if (is_array($from_o)) { if (isset($from_o[0])) { @@ -816,21 +862,13 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se $send_from_parts = new AddressStructure(); $send_from_parts = $orig_header->parseAddress($send_from); $send_from_add = $send_from_parts->mailbox . '@' . $send_from_parts->host; - $identities = get_identities(); - if (count($identities) > 0) { - foreach($identities as $iddata) { - if ($send_from_add == $iddata['email_address']) { - $identity = $iddata['index']; - break; - } - } - } + $identity = find_identity(array($send_from_add)); $subject = decodeHeader($orig_header->subject,false,false,true); - + // Remember the receipt settings $request_mdn = $mdn_user_support && !empty($orig_header->dnt) ? '1' : '0'; $request_dr = $mdn_user_support && !empty($orig_header->drnt) ? '1' : '0'; - + /* remember the references and in-reply-to headers in case of an reply */ $composeMessage->rfc822_header->more_headers['References'] = $orig_header->references; $composeMessage->rfc822_header->more_headers['In-Reply-To'] = $orig_header->in_reply_to; @@ -894,7 +932,7 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se } /* this corrects some wrapping/quoting problems on replies */ $rewrap_body = explode("\n", $body); - $from = (is_array($orig_header->from)) ? $orig_header->from[0] : $orig_header->from; + $from = (is_array($orig_header->from) && !empty($orig_header->from)) ? $orig_header->from[0] : $orig_header->from; $body = ''; $strip_sigs = getPref($data_dir, $username, 'strip_sigs'); foreach ($rewrap_body as $line) { @@ -946,8 +984,8 @@ function newMail ($mailbox='', $passed_id='', $passed_ent_id='', $action='', $se * @return object */ function getAttachments($message, &$composeMessage, $passed_id, $entities, $imapConnection) { - global $attachment_dir, $username, $data_dir, $squirrelmail_language, $languages; - $hashed_attachment_dir = getHashedDir($username, $attachment_dir); + global $squirrelmail_language, $languages; + if (!count($message->entities) || ($message->type0 == 'message' && $message->type1 == 'rfc822')) { if ( !in_array($message->entity_id, $entities) && $message->entity_id) { @@ -975,19 +1013,14 @@ function getAttachments($message, &$composeMessage, $passed_id, $entities, $imap function_exists($languages[$squirrelmail_language]['XTRA_CODE'] . '_encode')) { $filename = call_user_func($languages[$squirrelmail_language]['XTRA_CODE'] . '_encode', $filename); } - $localfilename = GenerateRandomString(32, '', 7); - $full_localfilename = "$hashed_attachment_dir/$localfilename"; - while (file_exists($full_localfilename)) { - $localfilename = GenerateRandomString(32, '', 7); - $full_localfilename = "$hashed_attachment_dir/$localfilename"; - } - $message->att_local_name = $full_localfilename; + $localfilename = sq_get_attach_tempfile(); + $message->att_local_name = $localfilename; $composeMessage->initAttachment($message->type0.'/'.$message->type1,$filename, - $full_localfilename); + $localfilename); /* Write Attachment to file */ - $fp = fopen ("$hashed_attachment_dir/$localfilename", 'wb'); + $fp = fopen ($localfilename, 'wb'); mime_print_body_lines ($imapConnection, $passed_id, $message->entity_id, $message->header->encoding, $fp); fclose ($fp); } @@ -1001,8 +1034,6 @@ function getAttachments($message, &$composeMessage, $passed_id, $entities, $imap function getMessage_RFC822_Attachment($message, $composeMessage, $passed_id, $passed_ent_id='', $imapConnection) { - global $attachment_dir, $username, $data_dir; - $hashed_attachment_dir = getHashedDir($username, $attachment_dir); if (!$passed_ent_id) { $body_a = sqimap_run_command($imapConnection, 'FETCH '.$passed_id.' RFC822', @@ -1020,23 +1051,22 @@ function getMessage_RFC822_Attachment($message, $composeMessage, $passed_id, array_pop($body_a); $body = implode('', $body_a) . "\r\n"; - $localfilename = GenerateRandomString(32, 'FILE', 7); - $full_localfilename = "$hashed_attachment_dir/$localfilename"; - - $fp = fopen($full_localfilename, 'w'); + $localfilename = sq_get_attach_tempfile(); + $fp = fopen($localfilename, 'wb'); fwrite ($fp, $body); fclose($fp); $composeMessage->initAttachment('message/rfc822',$subject.'.msg', - $full_localfilename); + $localfilename); } return $composeMessage; } function showInputForm ($session, $values=false) { - global $send_to, $send_to_cc, $body, $startMessage, $action, - $color, $use_signature, $signature, $prefix_sig, + global $send_to, $send_to_cc, $send_to_bcc, + $body, $startMessage, $action, + $use_signature, $signature, $prefix_sig, $editor_size, $editor_height, $subject, $newmail, - $use_javascript_addr_book, $send_to_bcc, $passed_id, $mailbox, + $use_javascript_addr_book, $passed_id, $mailbox, $from_htmladdr_search, $location_of_buttons, $attachment_dir, $username, $data_dir, $identity, $idents, $delete_draft, $mailprio, $compose_new_win, $saved_draft, $mail_sent, $sig_first, @@ -1082,7 +1112,8 @@ function showInputForm ($session, $values=false) { 'enctype="multipart/form-data"'; $compose_onsubmit = array(); - do_hook('compose_form'); + global $null; + do_hook('compose_form', $null); // Plugins that use compose_form hook can add an array entry // to the globally scoped $compose_onsubmit; we add them up @@ -1130,17 +1161,17 @@ function showInputForm ($session, $values=false) { } if ($saved_draft == 'yes') { - $oTemplate->assign('note', _("Draft Saved")); + $oTemplate->assign('note', _("Your draft has been saved.")); $oTemplate->display('note.tpl'); } if ($mail_sent == 'yes') { - $oTemplate->assign('note', _("Your message has been sent.")); + $oTemplate->assign('note', _("Your mail has been sent.")); $oTemplate->display('note.tpl'); } if ($compose_new_win == '1') { $oTemplate->display('compose_newwin_close.tpl'); } - + if ($location_of_buttons == 'top') { showComposeButtonRow(); } @@ -1152,16 +1183,16 @@ function showInputForm ($session, $values=false) { $identities[$id] = $data['full_name'].' <'.$data['email_address'].'>'; } } - + $oTemplate->assign('identities', $identities); $oTemplate->assign('identity_def', $identity); $oTemplate->assign('input_onfocus', 'onfocus="'.join(' ', $onfocus_array).'"'); - + $oTemplate->assign('to', htmlspecialchars($send_to)); $oTemplate->assign('cc', htmlspecialchars($send_to_cc)); $oTemplate->assign('bcc', htmlspecialchars($send_to_bcc)); $oTemplate->assign('subject', htmlspecialchars($subject)); - + $oTemplate->display('compose_header.tpl'); if ($location_of_buttons == 'between') { @@ -1203,9 +1234,9 @@ function showInputForm ($session, $values=false) { $oTemplate->assign('input_onfocus', 'onfocus="'.join(' ', $onfocus_array).'"'); $oTemplate->assign('body', $body_str); $oTemplate->assign('show_bottom_send', $location_of_buttons!='bottom'); - + $oTemplate->display ('compose_body.tpl'); - + if ($location_of_buttons == 'bottom') { showComposeButtonRow(); } @@ -1229,14 +1260,15 @@ function showInputForm ($session, $values=false) { } $attach = array(); - if ($composeMessage->entities) { + // composeMessage can be empty when coming from a restored session + if (is_object($composeMessage) && $composeMessage->entities) { foreach ($composeMessage->entities as $key => $attachment) { $attached_file = $attachment->att_local_name; if ($attachment->att_local_name || $attachment->body_part) { $attached_filename = decodeHeader($attachment->mime_header->getParameter('name')); $type = $attachment->mime_header->type0.'/'. $attachment->mime_header->type1; - + $a = array(); $a['Key'] = $key; $a['FileName'] = $attached_filename; @@ -1246,15 +1278,16 @@ function showInputForm ($session, $values=false) { } } } - + $max = min($sizes); $oTemplate->assign('max_file_size', empty($max) ? -1 : $max); $oTemplate->assign('attachments', $attach); - + $oTemplate->display('compose_attachments.tpl'); } // End of file_uploads if-block /* End of attachment code */ +//FIXME: no direct echoing to browser, no HTML output in core! echo addHidden('username', $username). addHidden('smaction', $action). addHidden('mailbox', $mailbox); @@ -1263,24 +1296,26 @@ function showInputForm ($session, $values=false) { so we can restore them in case of a session timeout. */ sqgetGlobalVar('QUERY_STRING', $queryString, SQ_SERVER); - echo addHidden('restoremessages', serialize($compose_messages)). +//FIXME: no direct echoing to browser, no HTML output in core! + echo addHidden('restoremessages', urlencode(serialize($compose_messages))). addHidden('composesession', $composesession). addHidden('querystring', $queryString). "\n"; if (!(bool) ini_get('file_uploads')) { /* File uploads are off, so we didn't show that part of the form. To avoid bogus bug reports, tell the user why. */ +//FIXME: no direct echoing to browser, no HTML output in core! echo '

' . _("Because PHP file uploads are turned off, you can not attach files to this message. Please see your system administrator for details.") . "

\r\n"; } - do_hook('compose_bottom'); - if ($compose_new_win=='1') { $oTemplate->display('compose_newwin_close.tpl'); } - + + do_hook('compose_bottom', $null); + $oErrorHandler->setDelayedErrors(false); $oTemplate->display('footer.tpl'); } @@ -1293,38 +1328,31 @@ function showComposeButtonRow() { $data_dir, $username; global $oTemplate, $buffer_hook; - - if ($default_use_priority) { + + if ($default_use_priority) { $priorities = array('1'=>_("High"), '3'=>_("Normal"), '5'=>_("Low")); $priority = isset($mailprio) ? $mailprio : 3; } else { $priorities = array(); $priority = NULL; } - + $mdn_user_support=getPref($data_dir, $username, 'mdn_user_support',$default_use_mdn); - if ($use_javascript_addr_book) { - $addr_book = " \n"; + if ($use_javascript_addr_book && checkForJavascript()) { + $addr_book = addButton(_("Addresses"), null, array('onclick' => 'javascript:open_abook();')); } else { - $addr_book = ' ' . "\n"; + $addr_book = addSubmit(_("Addresses"), 'html_addr_search'); } $oTemplate->assign('allow_priority', $default_use_priority==1); $oTemplate->assign('priority_list', $priorities); $oTemplate->assign('current_priority', $priority); - + $oTemplate->assign('notifications_enabled', $mdn_user_support==1); $oTemplate->assign('read_receipt', $request_mdn=='1'); $oTemplate->assign('delivery_receipt', $request_dr=='1'); - + $oTemplate->assign('drafts_enabled', $save_as_draft); $oTemplate->assign('address_book_button', $addr_book); @@ -1352,33 +1380,26 @@ function checkInput ($show) { /* True if FAILURE */ function saveAttachedFiles($session) { - global $_FILES, $attachment_dir, $username, - $data_dir, $compose_messages; + global $compose_messages; /* get out of here if no file was attached at all */ if (! is_uploaded_file($_FILES['attachfile']['tmp_name']) ) { return true; } - $hashed_attachment_dir = getHashedDir($username, $attachment_dir); - $localfilename = GenerateRandomString(32, '', 7); - $full_localfilename = "$hashed_attachment_dir/$localfilename"; - while (file_exists($full_localfilename)) { - $localfilename = GenerateRandomString(32, '', 7); - $full_localfilename = "$hashed_attachment_dir/$localfilename"; - } + $localfilename = sq_get_attach_tempfile(); // m_u_f works better with restricted PHP installs (safe_mode, open_basedir), // if that doesn't work, try a simple rename. - if (!@move_uploaded_file($_FILES['attachfile']['tmp_name'],$full_localfilename)) { - if (!@rename($_FILES['attachfile']['tmp_name'], $full_localfilename)) { + if (!@move_uploaded_file($_FILES['attachfile']['tmp_name'],$localfilename)) { + if (!@rename($_FILES['attachfile']['tmp_name'], $localfilename)) { return true; } } $message = $compose_messages[$session]; $type = strtolower($_FILES['attachfile']['type']); $name = $_FILES['attachfile']['name']; - $message->initAttachment($type, $name, $full_localfilename); + $message->initAttachment($type, $name, $localfilename); $compose_messages[$session] = $message; sqsession_register($compose_messages , 'compose_messages'); } @@ -1422,10 +1443,10 @@ function getByteSize($ini_size) { */ function deliverMessage($composeMessage, $draft=false) { global $send_to, $send_to_cc, $send_to_bcc, $mailprio, $subject, $body, - $username, $popuser, $usernamedata, $identity, $idents, $data_dir, - $request_mdn, $request_dr, $default_charset, $color, $useSendmail, - $domain, $action, $default_move_to_sent, $move_to_sent; - global $imapServerAddress, $imapPort, $sent_folder, $key; + $username, $identity, $idents, $data_dir, + $request_mdn, $request_dr, $default_charset, $useSendmail, + $domain, $action, $default_move_to_sent, $move_to_sent, + $imapServerAddress, $imapPort, $sent_folder, $key; $rfc822_header = $composeMessage->rfc822_header; @@ -1447,45 +1468,24 @@ function deliverMessage($composeMessage, $draft=false) { } $composeMessage->setBody($body); - if (ereg("^([^@%/]+)[@%/](.+)$", $username, $usernamedata)) { - $popuser = $usernamedata[1]; - $domain = $usernamedata[2]; - unset($usernamedata); - } else { - $popuser = $username; - } $reply_to = ''; - $from_mail = $idents[$identity]['email_address']; - $full_name = $idents[$identity]['full_name']; $reply_to = $idents[$identity]['reply_to']; - if (!$from_mail) { - $from_mail = "$popuser@$domain"; - } - $rfc822_header->from = $rfc822_header->parseAddress($from_mail,true); - if ($full_name) { - $from = $rfc822_header->from[0]; - if (!$from->host) $from->host = $domain; - $full_name_encoded = encodeHeader($full_name); - if ($full_name_encoded != $full_name) { - $from_addr = $full_name_encoded .' <'.$from->mailbox.'@'.$from->host.'>'; - } else { - $from_addr = '"'.$full_name .'" <'.$from->mailbox.'@'.$from->host.'>'; - } - $rfc822_header->from = $rfc822_header->parseAddress($from_addr,true); - } + + $from_addr = build_from_header($identity); + $rfc822_header->from = $rfc822_header->parseAddress($from_addr,true); if ($reply_to) { $rfc822_header->reply_to = $rfc822_header->parseAddress($reply_to,true); } /* Receipt: On Read */ if (isset($request_mdn) && $request_mdn) { - $rfc822_header->dnt = $rfc822_header->parseAddress($from_mail,true); + $rfc822_header->dnt = $rfc822_header->parseAddress($from_addr,true); } elseif (isset($rfc822_header->dnt)) { unset($rfc822_header->dnt); } - + /* Receipt: On Delivery */ if (isset($request_dr) && $request_dr) { - $rfc822_header->more_headers['Return-Receipt-To'] = $from_mail; + $rfc822_header->more_headers['Return-Receipt-To'] = $from->mailbox.'@'.$from->domain; } elseif (isset($rfc822_header->more_headers['Return-Receipt-To'])) { unset($rfc822_header->more_headers['Return-Receipt-To']); } @@ -1523,14 +1523,11 @@ function deliverMessage($composeMessage, $draft=false) { $rfc822_header->content_type = $content_type; $composeMessage->rfc822_header = $rfc822_header; - + /* Here you can modify the message structure just before we hand - it over to deliver */ - $hookReturn = do_hook('compose_send', $composeMessage); - /* Get any changes made by plugins to $composeMessage. */ - if ( is_object($hookReturn[1]) ) { - $composeMessage = $hookReturn[1]; - } + it over to deliver; plugin authors note that $composeMessage + is sent and modified by reference since 1.5.2 */ + do_hook('compose_send', $composeMessage); if (!$useSendmail && !$draft) { require_once(SM_PATH . 'class/deliver/Deliver_SMTP.class.php'); @@ -1583,7 +1580,8 @@ function deliverMessage($composeMessage, $draft=false) { } if (!$success) { // $deliver->dlv_server_msg is not always server's reply - $msg = $deliver->dlv_msg; + $msg = _("Message not sent.") . "
\n" . + $deliver->dlv_msg; if (!empty($deliver->dlv_server_msg)) { // add 'server replied' part only when it is not empty. // Delivery error can be generated by delivery class itself @@ -1617,8 +1615,8 @@ function deliverMessage($composeMessage, $draft=false) { $lcl_allow_sent = false; } + global $passed_id, $mailbox; if (($fld_sent && $svr_allow_sent && !$lcl_allow_sent) || ($fld_sent && $lcl_allow_sent)) { - global $passed_id, $mailbox, $action; if ($action == 'reply' || $action == 'reply_all') { $save_reply_with_orig=getPref($data_dir,$username,'save_reply_with_orig'); if ($save_reply_with_orig) { @@ -1633,33 +1631,55 @@ function deliverMessage($composeMessage, $draft=false) { unset ($imap_deliver); } - global $passed_id, $mailbox, $action, $what, $iAccount,$startMessage; + global $what, $iAccount, $startMessage; $composeMessage->purgeAttachments(); - if ($action == 'reply' || $action == 'reply_all') { + if ($action=='reply' || $action=='reply_all' || $action=='forward' || $action=='forward_as_attachment') { require(SM_PATH . 'functions/mailbox_display.php'); $aMailbox = sqm_api_mailbox_select($imap_stream, $iAccount, $mailbox,array('setindex' => $what, 'offset' => $startMessage),array()); - // check if we are allowed to set the \\Answered flag - if (in_array('\\answered',$aMailbox['PERMANENTFLAGS'], true)) { - $aUpdatedMsgs = sqimap_toggle_flag($imap_stream, array($passed_id), '\\Answered', true, false); - if (isset($aUpdatedMsgs[$passed_id]['FLAGS'])) { - /** - * Only update the cached headers if the header is - * cached. - */ - if (isset($aMailbox['MSG_HEADERS'][$passed_id])) { - $aMailbox['MSG_HEADERS'][$passed_id]['FLAGS'] = $aMsg['FLAGS']; + switch($action) { + case 'reply': + case 'reply_all': + // check if we are allowed to set the \\Answered flag + if (in_array('\\answered',$aMailbox['PERMANENTFLAGS'], true)) { + $aUpdatedMsgs = sqimap_toggle_flag($imap_stream, array($passed_id), '\\Answered', true, false); + if (isset($aUpdatedMsgs[$passed_id]['FLAGS'])) { + /** + * Only update the cached headers if the header is + * cached. + */ + if (isset($aMailbox['MSG_HEADERS'][$passed_id])) { + $aMailbox['MSG_HEADERS'][$passed_id]['FLAGS'] = $aMsg['FLAGS']; + } } } + break; + case 'forward': + case 'forward_as_attachment': + // check if we are allowed to set the $Forwarded flag (RFC 4550 paragraph 2.8) + if (in_array('$forwarded',$aMailbox['PERMANENTFLAGS'], true) || + in_array('\\*',$aMailbox['PERMANENTFLAGS'])) { + + $aUpdatedMsgs = sqimap_toggle_flag($imap_stream, array($passed_id), '$Forwarded', true, false); + if (isset($aUpdatedMsgs[$passed_id]['FLAGS'])) { + if (isset($aMailbox['MSG_HEADERS'][$passed_id])) { + $aMailbox['MSG_HEADERS'][$passed_id]['FLAGS'] = $aMsg['FLAGS']; + } + } + } + break; } + /** * Write mailbox with updated seen flag information back to cache. */ - $mailbox_cache[$iAccount.'_'.$aMailbox['NAME']] = $aMailbox; - sqsession_register($mailbox_cache,'mailbox_cache'); + if(isset($aUpdatedMsgs[$passed_id])) { + $mailbox_cache[$iAccount.'_'.$aMailbox['NAME']] = $aMailbox; + sqsession_register($mailbox_cache,'mailbox_cache'); + } + + sqimap_logout($imap_stream); } - sqimap_logout($imap_stream); } return $success; } -?> \ No newline at end of file