X-Git-Url: https://vcs.fsf.org/?p=squirrelmail.git;a=blobdiff_plain;f=functions%2Fpage_header.php;h=8052a0a9e63829b821b3c02f928672aaa4e45f2e;hp=f69be5bb1c3a35b91afb0463185958a8215671f5;hb=daf777102978219856d97b6b4e93f8b5815db234;hpb=cd81f9562ceed8c2fac4462c7f2055e6d9ca5c8c diff --git a/functions/page_header.php b/functions/page_header.php index f69be5bb..8052a0a9 100644 --- a/functions/page_header.php +++ b/functions/page_header.php @@ -72,10 +72,12 @@ function displayHtmlHeader( $title = 'SquirrelMail', $xtra = '', $do_hook = TRUE // 2. Option user-defined stylesheet from preferences. if (!empty($used_theme) && $used_theme != 'none') { /** - * All styles just point to a directory, so we need to include all .css - * files in that directory. + * All styles (except "none" - ugh) just point to a directory, + * so we need to include all .css files in that directory. */ - $styles = list_files($used_theme, '.css'); +//FIXME: rid ourselves of "none" strings! I didn't do it here because I think the problem is that the theme itself should never be "none" (? well, what else would it be? if "none" theme is actually OK, then is there a constant to use below in stead of a hard-coded string?) + $styles = $used_theme == 'none' ? array() + : list_files($used_theme, '.css'); foreach ($styles as $sheet) { $aUserStyles[] = $used_theme .'/'.$sheet; } @@ -176,14 +178,6 @@ function makeInternalLink($path, $text, $target='') { return create_hyperlink($base_uri . $path, $text, $target); } -/** - * Same as makeInternalLink, but echoes it too - */ -function displayInternalLink($path, $text, $target='') { -// FIXME: should let the template echo all these kinds of things - echo makeInternalLink($path, $text, $target); -} - /** * Outputs a complete SquirrelMail page header, starting with and * including the default menu bar. Uses displayHtmlHeader and takes @@ -200,7 +194,8 @@ function displayPageHeader($color, $mailbox='', $sHeaderJs='', $sBodyTagJs = '') global $reply_focus, $hide_sm_attributions, $frame_top, $provider_name, $provider_uri, $startMessage, - $action, $oTemplate, $org_title, $base_uri; + $action, $oTemplate, $org_title, $base_uri, + $data_dir, $username; //FIXME: $sBodyTag should be turned into $sOnload and should only contain the contents of the onload attribute (not the attribute name nor any quotes).... only question is if anyone was using $sBodyTag for anything but onload event handlers? (see function compose_Header() below for how to fix it once we confirm it can be changed) if (empty($sBodyTagJs)) { @@ -216,7 +211,6 @@ function displayPageHeader($color, $mailbox='', $sHeaderJs='', $sBodyTagJs = '') $sBodyTagJs = 'onload="checkForm();"'; } - $urlMailbox = urlencode($mailbox); $startMessage = (int)$startMessage; sqgetGlobalVar('delimiter', $delimiter, SQ_SESSION ); @@ -243,14 +237,20 @@ function displayPageHeader($color, $mailbox='', $sHeaderJs='', $sBodyTagJs = '') displayHtmlHeader ($org_title); $sBodyTagJs = ''; } - /* - * this explains the imap_mailbox.php dependency. We should instead store - * the selected mailbox in the session and fallback to the session var. - */ - $shortBoxName = htmlspecialchars(imap_utf7_decode_local( - readShortMailboxName($mailbox, $delimiter))); - if ( $shortBoxName == 'INBOX' ) { - $shortBoxName = _("INBOX"); + if ($mailbox) { + /* + * this explains the imap_mailbox.php dependency. We should instead store + * the selected mailbox in the session and fallback to the session var. + */ + $shortBoxName = htmlspecialchars(imap_utf7_decode_local( + readShortMailboxName($mailbox, $delimiter))); + if (getPref($data_dir, $username, 'translate_special_folders')) { + $shortBoxName = _($shortBoxName); + } + $urlMailbox = urlencode($mailbox); + } else { + $shortBoxName = ''; + $urlMailbox = ''; } $provider_link = '';