From: Andrew Browning <ayleph@thisshitistemp.com>
Date: Tue, 15 Aug 2017 06:11:06 +0000 (-0400)
Subject: Fix #5460 - Log IP address for failed login
X-Git-Url: https://vcs.fsf.org/?p=mediagoblin.git;a=commitdiff_plain;h=b121d89cc55551e3b2f3f160a42af998491b41d7;ds=sidebyside

Fix #5460 - Log IP address for failed login

This patch logs the remote address when a login attempt fails.
---

diff --git a/mediagoblin/auth/views.py b/mediagoblin/auth/views.py
index 2f95fd81..fb8e7265 100644
--- a/mediagoblin/auth/views.py
+++ b/mediagoblin/auth/views.py
@@ -14,6 +14,8 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import logging
+
 import six
 
 from itsdangerous import BadSignature
@@ -29,6 +31,8 @@ from mediagoblin.tools.pluginapi import hook_handle
 from mediagoblin.auth.tools import (send_verification_email, register_user,
                                     check_login_simple)
 
+_log = logging.getLogger(__name__)
+
 
 @allow_registration
 @auth_enabled
@@ -105,6 +109,8 @@ def login(request):
                     return redirect(request, "index")
 
             login_failed = True
+            remote_addr = request.access_route[-1] or request.remote_addr
+            _log.warn("Failed login attempt from %r", remote_addr)
 
     return render_to_response(
         request,