From 345f272404cb1c454b7602214c76fd0ebf04d66e Mon Sep 17 00:00:00 2001 From: Jeremy Harris Date: Thu, 9 May 2019 14:10:12 +0100 Subject: [PATCH] Avoid potential crash in close of a verify callout --- src/src/verify.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/src/verify.c b/src/src/verify.c index 720f85d8c..184809fb5 100644 --- a/src/src/verify.c +++ b/src/src/verify.c @@ -1103,12 +1103,9 @@ no_conn: if (options & vopt_callout_recipsender) cancel_cutthrough_connection(TRUE, US"not usable for cutthrough"); if (sx.send_quit) - { - (void) smtp_write_command(&sx, SCMD_FLUSH, "QUIT\r\n"); - - /* Wait a short time for response, and discard it */ - smtp_read_response(&sx, sx.buffer, sizeof(sx.buffer), '2', 1); - } + if (smtp_write_command(&sx, SCMD_FLUSH, "QUIT\r\n") != -1) + /* Wait a short time for response, and discard it */ + smtp_read_response(&sx, sx.buffer, sizeof(sx.buffer), '2', 1); if (sx.cctx.sock >= 0) { -- 2.25.1