exim.git
10 years agoFix testsuite GnuTLS case for 511a6c1
Jeremy Harris [Wed, 19 Mar 2014 19:46:35 +0000 (19:46 +0000)]
Fix testsuite GnuTLS case for 511a6c1

10 years agoFix ACL "condition =" for negative number values. Bug 1005
Jeremy Harris [Tue, 18 Mar 2014 16:17:56 +0000 (16:17 +0000)]
Fix ACL "condition =" for negative number values.  Bug 1005
Fix conditional "bool{<string>}" for negative number values, to match.

10 years agoEnforce that only smtp transports can be used for verify callouts. Bug 1445
Heiko Schlittermann [Sun, 16 Mar 2014 22:29:59 +0000 (22:29 +0000)]
Enforce that only smtp transports can be used for verify callouts.  Bug 1445

10 years agoSupport transport-added headers under cutthrough delivery. Bug 1431
Jeremy Harris [Sun, 16 Mar 2014 17:22:56 +0000 (17:22 +0000)]
Support transport-added headers under cutthrough delivery.  Bug 1431

10 years agoAdd tls_verify_hosts and tls_try_verify_hosts to smtp transport. Bug 1371
Wolfgang Breyha [Sat, 15 Mar 2014 14:16:05 +0000 (14:16 +0000)]
Add tls_verify_hosts and tls_try_verify_hosts to smtp transport.  Bug 1371

Code by Wolfgang Breyha, docs and testsuite by Jeremy Harris

10 years agoTestcases
Jeremy Harris [Sat, 15 Mar 2014 14:06:07 +0000 (14:06 +0000)]
Testcases

10 years agoAdd documentation
Jeremy Harris [Sat, 15 Mar 2014 12:29:31 +0000 (12:29 +0000)]
Add documentation

10 years agoFix DISABLE_DKIM build
Jeremy Harris [Tue, 11 Mar 2014 16:24:50 +0000 (16:24 +0000)]
Fix DISABLE_DKIM build

Reported-by: heiko.schlichting@fu-berlin.de
Broken-in: 6e62c454 - jgh146exb@wizmail.org

10 years agoRefactor malware.c and introduce new scanner type "sock". Bugs 1418 and 1396
Jeremy Harris [Sun, 9 Mar 2014 21:45:33 +0000 (21:45 +0000)]
Refactor malware.c and introduce new scanner type "sock". Bugs 1418 and 1396

10 years agoLog port and TLS details for a failed delivery
Jeremy Harris [Sun, 9 Mar 2014 16:51:00 +0000 (16:51 +0000)]
Log port and TLS details for a failed delivery

10 years agoLog incoming-TLS details on rejects. Bug 305
Jeremy Harris [Sun, 9 Mar 2014 16:41:20 +0000 (16:41 +0000)]
Log incoming-TLS details on rejects. Bug 305

10 years agoFix docs for utf8clean
Jeremy Harris [Sun, 9 Mar 2014 21:05:59 +0000 (21:05 +0000)]
Fix docs for utf8clean

10 years ago${utf8clean:string} expansion operator. Bug 1401
Axel Rau [Sat, 8 Mar 2014 20:59:24 +0000 (20:59 +0000)]
${utf8clean:string} expansion operator.  Bug 1401

10 years agoExpand documentation on use of dnslists in an IPv6 environment. Bug 1369
Jeremy Harris [Sat, 8 Mar 2014 18:50:16 +0000 (18:50 +0000)]
Expand documentation on use of dnslists in an IPv6 environment. Bug 1369

10 years agoChange strings of SPF result to conform to RFC 4408
Todd Lyons [Fri, 7 Mar 2014 04:55:19 +0000 (20:55 -0800)]
Change strings of SPF result to conform to RFC 4408

Introduces a small backwards incompatible change to two results,
  err_temp to temperror and err_perm to permerror.

10 years agoCode for verify=header_names_ascii
Michael Fischer v. Mollard [Thu, 6 Mar 2014 02:19:24 +0000 (18:19 -0800)]
Code for verify=header_names_ascii

Documentation and test included.

Fixed Conflicts:
doc/doc-txt/ChangeLog

10 years agoSupport log_selector smtp_confirmation for the lmtp transport. Bug 1157
Wolfgang Breyha [Wed, 5 Mar 2014 19:33:04 +0000 (19:33 +0000)]
Support log_selector smtp_confirmation for the lmtp transport.  Bug 1157

10 years agoFix docs, `dns_dnssec_ok` not `dns_use_dnssec`
Phil Pennock [Sun, 2 Mar 2014 20:48:02 +0000 (15:48 -0500)]
Fix docs, `dns_dnssec_ok` not `dns_use_dnssec`

The variable rename in 4.82 PP/19 (commit 0fbd9bff) was incomplete, I
missed changing the documentation.  :(

10 years agoFix parallel make. Bug 1446
Jeremy Harris [Sat, 1 Mar 2014 17:02:43 +0000 (17:02 +0000)]
Fix parallel make.  Bug 1446
from work by Heiko Schlittermann

10 years agoAdd tls_verify_hosts and tls_try_verify_hosts to smtp transport
Wolfgang Breyha [Wed, 26 Feb 2014 20:07:46 +0000 (20:07 +0000)]
Add tls_verify_hosts and tls_try_verify_hosts to smtp transport

Patch version 2

10 years agoFix build on systems having ipv6 but lacking an IPV6_TCLASS define (GNU Hurd). Bug...
Jeremy Harris [Sun, 9 Feb 2014 21:03:27 +0000 (21:03 +0000)]
Fix build on systems having ipv6 but lacking an IPV6_TCLASS define (GNU Hurd).  Bug 1441
By Samuel Thibault

10 years agoFix tls_verify_certificates in gnutls use. Bug 1413.
Jeremy Harris [Sun, 26 Jan 2014 18:03:01 +0000 (18:03 +0000)]
Fix tls_verify_certificates in gnutls use.  Bug 1413.
Patch by W.Breyha, tested by H.Schlittermann

10 years agoBugzilla 1433: Fix DMARC SEGV
Wolfgang Breyha [Tue, 14 Jan 2014 14:12:38 +0000 (06:12 -0800)]
Bugzilla 1433: Fix DMARC SEGV

Properly escape value passed to expand_string().
Check for NULL return from expand_string().

10 years agoUpdate copyright year in --version output
Phil Pennock [Tue, 7 Jan 2014 06:59:04 +0000 (01:59 -0500)]
Update copyright year in --version output

10 years agoCopyright year updates:
Phil Pennock [Tue, 7 Jan 2014 06:56:40 +0000 (01:56 -0500)]
Copyright year updates:

    vi $(git whatchanged --since=2013-01-01 | grep '^:100' | sed 's/^[^M]*M//' | sort -u | fgrep -v test/)

Did 2014 first, since otherwise every file I touched to update to 2013
would show as changed in 2014.  Last invocation logged to git was during
2012.  Will need to be more careful if auditing next year.

10 years agoCopyright year updates: 2014
Phil Pennock [Tue, 7 Jan 2014 06:49:54 +0000 (01:49 -0500)]
Copyright year updates: 2014

    vi $(git whatchanged --since=2014-01-01 | grep '^:100' | sed 's/^[^M]*M//' | sort -u | fgrep -v test/)

10 years agoDocument (and enforce) that DKIM-signing is not supported in cobination with cutthrou...
Jeremy Harris [Sun, 5 Jan 2014 21:22:06 +0000 (21:22 +0000)]
Document (and enforce) that DKIM-signing is not supported in cobination with cutthrough routing

10 years agoDocumant the non-support of header manipulation in post-RCPT ACLs in combination...
Jeremy Harris [Sun, 5 Jan 2014 17:54:41 +0000 (17:54 +0000)]
Documant the non-support of header manipulation in post-RCPT ACLs in combination with cuttrhough.
Add check and paniclog attempts to do so.  Bug 1411 (WONTFIX).

10 years agoExplicitly disable cutthrough on transports having filters
Jeremy Harris [Sun, 5 Jan 2014 15:27:19 +0000 (15:27 +0000)]
Explicitly disable cutthrough on transports having filters

10 years agoExplicitly disable cutthrough on transports having filters
Jeremy Harris [Sun, 29 Dec 2013 19:10:05 +0000 (19:10 +0000)]
Explicitly disable cutthrough on transports having filters

10 years agoProxy negotiation saves socket timeout values.
Todd Lyons [Mon, 30 Dec 2013 23:02:21 +0000 (15:02 -0800)]
Proxy negotiation saves socket timeout values.

Rename proxy expansions conforming to Exim standards.
Update documentation to reflect rename.
Seperate restore socket function

10 years agoAdd ${listextract {n}{list}...}
Jeremy Harris [Sun, 27 Oct 2013 15:18:44 +0000 (15:18 +0000)]
Add ${listextract {n}{list}...}

10 years agoFix use of uninitialized variable
Jeremy Harris [Sun, 15 Dec 2013 18:36:48 +0000 (18:36 +0000)]
Fix use of uninitialized variable

10 years agoIncrease test CA key sizes from 512 to 1024 to handle TLS1.2 digest sizes.
Jeremy Harris [Sun, 15 Dec 2013 22:17:42 +0000 (22:17 +0000)]
Increase test CA key sizes from 512 to 1024 to handle TLS1.2 digest sizes.

10 years agoClarify interaction of delay_warning and retry configuration.
Jeremy Harris [Sat, 7 Dec 2013 13:34:42 +0000 (13:34 +0000)]
Clarify interaction of delay_warning and retry configuration.

10 years agoProxy Protocol - Server support
Todd Lyons [Sat, 30 Nov 2013 19:31:21 +0000 (11:31 -0800)]
Proxy Protocol - Server support

Initial conf setting and expansions
Logging setting whether to record proxy host, off by default
Put PROXY processing before connect ACL
Fix incoming address logging
Add Proxy Protocol to ChangeLog
Set window for Proxy Protocol header to be sent
Update docs and EDITME.

10 years agobuild: try to get dash/bash for sanity
Phil Pennock [Thu, 21 Nov 2013 01:16:02 +0000 (17:16 -0800)]
build: try to get dash/bash for sanity

The "local" builtin is not part of POSIX.  We want it.  Try harder to
get a vaguely sane shell, rather than just a POSIX shell.

Also, safeguard to error out more gracefully if invoked from outside the
build process.

10 years agoFix testsuite build on Solaris
Jeremy Harris [Wed, 20 Nov 2013 14:19:37 +0000 (14:19 +0000)]
Fix testsuite build on Solaris

As of s11, Solaris & derivatives need libsocket and libnsl.  Ensure they are searched for
by autoconfig.  This seems to be successfully ignored on Linux.
Credit to Dave Edmondson (dme@dme.org) for the fix.

10 years agoFix ldap option setting.
Todd Lyons [Thu, 31 Oct 2013 16:42:15 +0000 (09:42 -0700)]
Fix ldap option setting.

Some client libs set a global context, newer client libs set a global
  default which then needs to be reloaded.

10 years agoFix memory management vs acl-as-conditional, redux
Jeremy Harris [Tue, 12 Nov 2013 19:51:10 +0000 (19:51 +0000)]
Fix memory management vs acl-as-conditional, redux

10 years agoFix memory management vs. acl-as-conditional
Jeremy Harris [Sun, 10 Nov 2013 21:31:17 +0000 (21:31 +0000)]
Fix memory management vs. acl-as-conditional

10 years agoAdd commented-braces for ease of brace-matching editor use
Jeremy Harris [Sun, 10 Nov 2013 21:12:51 +0000 (21:12 +0000)]
Add commented-braces for ease of brace-matching editor use

10 years agospec: TLS certificates: avoid MD5
Phil Pennock [Sun, 10 Nov 2013 10:16:27 +0000 (05:16 -0500)]
spec: TLS certificates: avoid MD5

Make it clearer in the spec, where talking about certificates, that MD5
in certs is a really Quite Bad idea.

10 years agoBug 1334: AutoDetect compression type in exigrep
Todd Lyons [Sat, 12 Oct 2013 16:42:31 +0000 (09:42 -0700)]
Bug 1334: AutoDetect compression type in exigrep

Does not use any extra perl modules.
Attempts hard coded types first, so no extra code for the standard
  case.
Easy to add more compression types.

10 years agoPortability fix for Solaris without xpg4 utilities
Tony Finch [Thu, 7 Nov 2013 16:26:33 +0000 (16:26 +0000)]
Portability fix for Solaris without xpg4 utilities

10 years agoquickrelease: A dumb script for making source-only tarballs
Tony Finch [Thu, 7 Nov 2013 16:25:51 +0000 (16:25 +0000)]
quickrelease: A dumb script for making source-only tarballs

10 years agoPut back a required .new/.wen stanza
Todd Lyons [Tue, 5 Nov 2013 18:18:24 +0000 (10:18 -0800)]
Put back a required .new/.wen stanza

10 years agoPrep docs/markup for next release cycle
Todd Lyons [Tue, 5 Nov 2013 16:30:37 +0000 (08:30 -0800)]
Prep docs/markup for next release cycle

10 years agoExplain the TLS cleanup bug in the ChangeLog
Tony Finch [Tue, 5 Nov 2013 15:20:05 +0000 (15:20 +0000)]
Explain the TLS cleanup bug in the ChangeLog

10 years agoCorrectly close the server side of TLS when forking for delivery.
Tony Finch [Tue, 5 Nov 2013 12:18:02 +0000 (12:18 +0000)]
Correctly close the server side of TLS when forking for delivery.

10 years agoOnly unbind ldap connection if bind succeeded
Todd Lyons [Thu, 31 Oct 2013 13:04:27 +0000 (06:04 -0700)]
Only unbind ldap connection if bind succeeded

10 years agoDoc/Spec: section "Trust in configuration data" exim-4_82
Phil Pennock [Fri, 25 Oct 2013 00:38:28 +0000 (20:38 -0400)]
Doc/Spec: section "Trust in configuration data"

10 years agoMerge branch 'master' of git://git.exim.org/exim exim-4_82_RC5
Todd Lyons [Tue, 22 Oct 2013 12:11:33 +0000 (05:11 -0700)]
Merge branch 'master' of git://git.exim.org/exim

10 years agoSilence compiler string format warning exim-4_82_RC4
Todd Lyons [Tue, 22 Oct 2013 11:57:40 +0000 (04:57 -0700)]
Silence compiler string format warning

10 years agoBug 1400: Fix GnuTLS PKCS11 issues
Todd Lyons [Sun, 20 Oct 2013 00:01:26 +0000 (17:01 -0700)]
Bug 1400: Fix GnuTLS PKCS11 issues

Can disable PKCS11 in Makefile with AVOID_GNUTLS_PKCS11 build flag.
Rename gnutls_enable_pkcs11 option to gnutls_allow_auto_pkcs11.
Update Changelog

10 years agoTests: Don't delete patched exim if -KEEP is used
Todd Lyons [Sat, 19 Oct 2013 14:17:36 +0000 (07:17 -0700)]
Tests: Don't delete patched exim if -KEEP is used

10 years agoExtra requires/notes for running test suite
Todd Lyons [Sat, 19 Oct 2013 14:16:40 +0000 (07:16 -0700)]
Extra requires/notes for running test suite

10 years agoBugzilla 1402 - Handle upper case chars in tests
Todd Lyons [Sat, 19 Oct 2013 13:53:59 +0000 (06:53 -0700)]
Bugzilla 1402 - Handle upper case chars in tests

Test 533 fails if there are any upper case chars in the path to the
  test suite. Added caseful_local_part=true to the router which calls
  the pipe.

10 years agoAdjust runtest -CONTINUE to work everywhere
Todd Lyons [Fri, 18 Oct 2013 18:49:57 +0000 (11:49 -0700)]
Adjust runtest -CONTINUE to work everywhere

10 years agoFormat String safety
Todd Lyons [Tue, 15 Oct 2013 20:41:21 +0000 (13:41 -0700)]
Format String safety

10 years agoUpdate copyright year in exim -bV output
Todd Lyons [Tue, 15 Oct 2013 12:18:31 +0000 (05:18 -0700)]
Update copyright year in exim -bV output

10 years agoFix listnamed doc typos
Jeremy Harris [Sun, 13 Oct 2013 21:29:04 +0000 (22:29 +0100)]
Fix listnamed doc typos

10 years agoCross-ref av_scanner syntax to list syntax
Jeremy Harris [Sun, 13 Oct 2013 13:34:35 +0000 (14:34 +0100)]
Cross-ref av_scanner syntax to list syntax

10 years agoAdded missing .new/.wen in spec.xpft exim-4_82_RC3
Todd Lyons [Wed, 9 Oct 2013 20:40:49 +0000 (13:40 -0700)]
Added missing .new/.wen in spec.xpft

10 years agoDocumentation for multiple TCP clamd servers
Todd Lyons [Wed, 9 Oct 2013 15:48:39 +0000 (08:48 -0700)]
Documentation for multiple TCP clamd servers

10 years agoImported Bug 1057 multiple clamd patch from PLD repo
Todd Lyons [Fri, 9 Nov 2012 22:28:37 +0000 (14:28 -0800)]
Imported Bug 1057 multiple clamd patch from PLD repo

10 years agoBug 1150: Enhance docs for ${addresses:} expansion
Todd Lyons [Tue, 8 Oct 2013 18:00:33 +0000 (11:00 -0700)]
Bug 1150: Enhance docs for ${addresses:} expansion

10 years agoFix TPDA text.
Jeremy Harris [Mon, 7 Oct 2013 19:47:54 +0000 (20:47 +0100)]
Fix TPDA text.
Credit Axel Rau for careful proofreading.

10 years agoMerge branch 'master' of ssh://git.exim.org/home/git/exim
Todd Lyons [Mon, 7 Oct 2013 02:31:57 +0000 (19:31 -0700)]
Merge branch 'master' of ssh://git.exim.org/home/git/exim

10 years agoBug 1289: Clarify host list processing failures
Todd Lyons [Mon, 7 Oct 2013 02:21:55 +0000 (19:21 -0700)]
Bug 1289: Clarify host list processing failures

Enhance explanation of +ignore_unknown.

10 years agoTypo in docs: routing rules mentioned in retry rules section. Bug 1349
Jeremy Harris [Sun, 6 Oct 2013 17:31:15 +0000 (18:31 +0100)]
Typo in docs: routing rules mentioned in retry rules section.  Bug 1349

10 years agoMake smtp_accept_max_per_connection option text searchable. Bug 1361
Jeremy Harris [Sun, 6 Oct 2013 17:05:48 +0000 (18:05 +0100)]
Make smtp_accept_max_per_connection option text searchable. Bug 1361

Same fix as for 1197; abandon attempt to permit intelligent wrapping of the text

10 years agoAdd exiqsumm fix to ChangeLog
Todd Lyons [Sat, 5 Oct 2013 15:41:29 +0000 (08:41 -0700)]
Add exiqsumm fix to ChangeLog

10 years agoFix exiqsumm output for single queue item.
Todd Lyons [Sat, 5 Oct 2013 15:31:49 +0000 (08:31 -0700)]
Fix exiqsumm output for single queue item.

Patch from Richard Hall, with one minor addition to prevent
  uninitialized value error during output.

10 years agoBug 1392: Change status text when no dmarc record
Wolfgang Breyha [Fri, 4 Oct 2013 20:02:44 +0000 (13:02 -0700)]
Bug 1392: Change status text when no dmarc record

10 years agoFix DKIM variable name in documentation.
Ted Cooper [Fri, 4 Oct 2013 00:17:19 +0000 (10:17 +1000)]
Fix DKIM variable name in documentation.

10 years agoPrint tarball names in debug mode too
Todd Lyons [Thu, 3 Oct 2013 23:35:05 +0000 (16:35 -0700)]
Print tarball names in debug mode too

10 years agoFilter xfpt needs new macro too
Todd Lyons [Thu, 3 Oct 2013 23:29:52 +0000 (16:29 -0700)]
Filter xfpt needs new macro too

10 years agoFinish the xfpt fix.
Phil Pennock [Thu, 3 Oct 2013 20:13:52 +0000 (16:13 -0400)]
Finish the xfpt fix.

The readers of the version expect no surrounding whitespace; putting the
content in-place requires macro expansion, which requires that .literal
mode be `layout` or `off`, but either of those will escape the XML angle
brackets.  The easiest fix is to generate the XML as part of the macro
definition.

Moved local_params rules out of Makefile and into GenLocalParams

10 years agoBug 1389: Initialize and clear variables
Todd Lyons [Thu, 3 Oct 2013 23:24:14 +0000 (16:24 -0700)]
Bug 1389: Initialize and clear variables

10 years agoMerge branch 'master' of ssh://git.exim.org/home/git/exim
Todd Lyons [Thu, 3 Oct 2013 23:11:04 +0000 (16:11 -0700)]
Merge branch 'master' of ssh://git.exim.org/home/git/exim

10 years agoUnbreak HTML build for RC candidates.
Phil Pennock [Thu, 3 Oct 2013 18:50:09 +0000 (14:50 -0400)]
Unbreak HTML build for RC candidates.

The HTML build now uses the website repo, which extracts the version
number from the XML (generated from the .xfpt).  Meanwhile, commit
2aee48d6 made the version number in the build process dynamic, taking
the value from the release script (via an environ variable).

This change fixes the invocation to pass the version _without_ an RC
suffix to the XML build, letting HTML generation happen.

10 years agoMention Redis lookup in NewStuff
Todd Lyons [Thu, 3 Oct 2013 16:34:44 +0000 (09:34 -0700)]
Mention Redis lookup in NewStuff

10 years agoSetting LC_ALL with make overrode this sort check exim-4_82_RC2
Todd Lyons [Thu, 3 Oct 2013 13:42:26 +0000 (06:42 -0700)]
Setting LC_ALL with make overrode this sort check

10 years agoFix docbook paths for xml generation
Todd Lyons [Thu, 3 Oct 2013 02:21:22 +0000 (19:21 -0700)]
Fix docbook paths for xml generation

10 years agoBugzilla 1217: Experimental Redis lookup
Todd Lyons [Tue, 1 Oct 2013 16:24:19 +0000 (09:24 -0700)]
Bugzilla 1217: Experimental Redis lookup

Add want_experimental() test in the script to create the lookups
  Makefile to ease detection of requested Experimental features, and
  simplify the #ifdef guards in the redis.c.

10 years agoDo not use MSG_NOSIGNAL on send() in ${udpsend}
Jeremy Harris [Mon, 30 Sep 2013 19:24:13 +0000 (20:24 +0100)]
Do not use MSG_NOSIGNAL on send() in ${udpsend}

Some non-Posix systems don't define it.  Anyway, Exim ignores SIGPIPE for most purposes.

10 years agoMerge branch 'patch-3' of https://github.com/bes-internal/exim into master_dmarc_doc
Todd Lyons [Mon, 30 Sep 2013 19:55:44 +0000 (12:55 -0700)]
Merge branch 'patch-3' of https://github.com/bes-internal/exim into master_dmarc_doc

10 years agoAdded documentation of features, acknowledgements
Todd Lyons [Mon, 30 Sep 2013 18:56:42 +0000 (11:56 -0700)]
Added documentation of features, acknowledgements

10 years agoAdd ratelimit doc addition to ChangeLog
Todd Lyons [Mon, 30 Sep 2013 18:24:44 +0000 (11:24 -0700)]
Add ratelimit doc addition to ChangeLog

10 years agoTypo re-fix in ratelimit.pl doc
Todd Lyons [Mon, 30 Sep 2013 18:22:58 +0000 (11:22 -0700)]
Typo re-fix in ratelimit.pl doc

10 years agoMerge branch 'patch-1' of https://github.com/bes-internal/exim into master-bes-rateli...
Todd Lyons [Mon, 30 Sep 2013 18:20:46 +0000 (11:20 -0700)]
Merge branch 'patch-1' of https://github.com/bes-internal/exim into master-bes-ratelimit.pl

10 years agoMerge branch 'master_tpda'
Todd Lyons [Mon, 30 Sep 2013 18:10:50 +0000 (11:10 -0700)]
Merge branch 'master_tpda'

10 years agoAdjust test build link paths.
Todd Lyons [Mon, 30 Sep 2013 17:52:50 +0000 (10:52 -0700)]
Adjust test build link paths.

Details at: http://comments.gmane.org/gmane.mail.exim.user/91154
Add ignore for a logfile from test run.

10 years agoBug 1031: Experimental TPDA
Jeremy Harris [Mon, 30 Sep 2013 17:12:12 +0000 (10:12 -0700)]
Bug 1031: Experimental TPDA

Remove whitespace

10 years agoRemove whitespace
Todd Lyons [Mon, 30 Sep 2013 17:08:53 +0000 (10:08 -0700)]
Remove whitespace

10 years agofix dmarc_status condition documentation
bes-internal [Mon, 30 Sep 2013 15:06:06 +0000 (18:06 +0300)]
fix dmarc_status condition documentation

10 years agoFix dovecot with empty 334 challenge.
Phil Pennock [Mon, 30 Sep 2013 04:57:07 +0000 (00:57 -0400)]
Fix dovecot with empty 334 challenge.

Thomas Morper reported, with 4.82RC1, that he saw "334 NULL" as the
challenge when using AUTH PLAIN to Dovecot when the client does not send
an initial response.  I could replicate.

This was caused by commit 3f1df0e3 on 2012-11-19 (PP/13 of 4.82); I was
too cautious in the robustness fixes; the clue came in this line of
debug output:

    76430 dovecot: warning: ignoring trailing tab

This change removes that check, and documents in a comment that this
input is acceptable protocol-wise, and why.

With this fix:

    AUTH PLAIN
    334
    AGZyZWRlcmljAGh1bXB0eS1kdW1wdHk=
    235 Authentication succeeded

10 years agosmall typo
bes-internal [Sat, 28 Sep 2013 18:26:02 +0000 (21:26 +0300)]
small typo

10 years agoCorrect spelling of dmarc_disable_verify
Jeremy Harris [Sat, 28 Sep 2013 12:49:33 +0000 (13:49 +0100)]
Correct spelling of dmarc_disable_verify