From: Jeremy Harris <jgh146exb@wizmail.org>
Date: Thu, 9 May 2019 13:10:12 +0000 (+0100)
Subject: Avoid potential crash in close of a verify callout
X-Git-Tag: exim-4.93-RC0~195
X-Git-Url: https://vcs.fsf.org/?p=exim.git;a=commitdiff_plain;h=345f272404cb1c454b7602214c76fd0ebf04d66e;hp=eb2163cbc29a00b2ca214e507e4a57f374c2e8ed

Avoid potential crash in close of a verify callout
---

diff --git a/src/src/verify.c b/src/src/verify.c
index 720f85d8c..184809fb5 100644
--- a/src/src/verify.c
+++ b/src/src/verify.c
@@ -1103,12 +1103,9 @@ no_conn:
       if (options & vopt_callout_recipsender)
         cancel_cutthrough_connection(TRUE, US"not usable for cutthrough");
       if (sx.send_quit)
-	{
-	(void) smtp_write_command(&sx, SCMD_FLUSH, "QUIT\r\n");
-
-	/* Wait a short time for response, and discard it */
-	smtp_read_response(&sx, sx.buffer, sizeof(sx.buffer), '2', 1);
-	}
+	if (smtp_write_command(&sx, SCMD_FLUSH, "QUIT\r\n") != -1)
+	  /* Wait a short time for response, and discard it */
+	  smtp_read_response(&sx, sx.buffer, sizeof(sx.buffer), '2', 1);
 
       if (sx.cctx.sock >= 0)
 	{