Content scan: Use ETIMEDOUT not ETIME, as having better portability. Bug 1640
authorAndreas Metzler <ametzler@downhill.at.eu.org>
Sun, 7 Jun 2015 14:16:35 +0000 (15:16 +0100)
committerJeremy Harris <jgh146exb@wizmail.org>
Sun, 7 Jun 2015 14:16:35 +0000 (15:16 +0100)
src/src/malware.c

index 17a652a..141c6ea 100644 (file)
@@ -879,7 +879,7 @@ if (!malware_ok)
 
        for (;;)
          {
-         errno = ETIME;
+         errno = ETIMEDOUT;
          i =  av_buffer+sizeof(av_buffer)-p;
          if ((bread= ip_recv(sock, p, i-1, tmo-time(NULL))) < 0)
            return m_errlog_defer_3(scanent,
@@ -1212,7 +1212,7 @@ if (!malware_ok)
 * WITH_OLD_CLAMAV_STREAM is defined.
 * See Exim bug 926 for details.  */
 
-      uschar *p, *vname, *result_tag, *response_end;
+      uschar *p, *vname, *result_tag;
       int bread=0;
       uschar * file_name;
       uschar av_buffer[1024];
@@ -1614,10 +1614,9 @@ if (!malware_ok)
       while (isspace(*--p) && (p > av_buffer))
        *p = '\0';
       if (*p) ++p;
-      response_end = p;
 
       /* colon in returned output? */
-      if((p = Ustrchr(av_buffer,':')) == NULL)
+      if(!(p = Ustrchr(av_buffer,':')))
        return m_errlog_defer(scanent, string_sprintf(
                  "ClamAV returned malformed result (missing colon): %s",
                  av_buffer));