X-Git-Url: https://vcs.fsf.org/?p=exim.git;a=blobdiff_plain;f=src%2Fsrc%2Fbuildconfig.c;h=780800c5831ef298f3b8cc154c73ac5036a19716;hp=51fe026181bffdf95eeba48eb8174e41621fcd8d;hb=655c589513d20178c1979517320fc446f1a197f6;hpb=0a49a7a4f1090b6f1ce1d0f9d969804c9226b53e diff --git a/src/src/buildconfig.c b/src/src/buildconfig.c index 51fe02618..780800c58 100644 --- a/src/src/buildconfig.c +++ b/src/src/buildconfig.c @@ -1,4 +1,4 @@ -/* $Cambridge: exim/src/src/buildconfig.c,v 1.15 2009/11/16 19:50:36 nm4 Exp $ */ +/* $Cambridge: exim/src/src/buildconfig.c,v 1.19 2010/06/07 18:25:57 pdp Exp $ */ /************************************************* * Exim - an Internet mail transport agent * @@ -34,6 +34,7 @@ normally called independently. */ #include +#include #include #include #include @@ -103,6 +104,11 @@ main(int argc, char **argv) { off_t test_off_t = 0; time_t test_time_t = 0; +#if !(__STDC_VERSION__ >= 199901L) && !defined(PRIdMAX) +size_t test_size_t = 0; +unsigned long test_ulong_t = 0L; +#endif +long test_long_t = 0; FILE *base; FILE *new; int last_initial = 'A'; @@ -145,7 +151,7 @@ printing long long variables, and there will be support for the long long type. This assumption is known to be OK for the common operating systems. */ fprintf(new, "#ifndef OFF_T_FMT\n"); -if (sizeof(test_off_t) > 4) +if (sizeof(test_off_t) > sizeof(test_long_t)) { fprintf(new, "#define OFF_T_FMT \"%%lld\"\n"); fprintf(new, "#define LONGLONG_T long long int\n"); @@ -163,7 +169,7 @@ length is 4 or less, we can leave LONGLONG_T to whatever was defined above for off_t. */ fprintf(new, "#ifndef TIME_T_FMT\n"); -if (sizeof(test_time_t) > 4) +if (sizeof(test_time_t) > sizeof(test_long_t)) { fprintf(new, "#define TIME_T_FMT \"%%lld\"\n"); fprintf(new, "#undef LONGLONG_T\n"); @@ -175,6 +181,22 @@ else } fprintf(new, "#endif\n\n"); +/* And for sizeof() results, size_t, which should with C99 be just %zu, deal +with C99 not being ubiquitous yet. Unfortunately. */ + +#if __STDC_VERSION__ >= 199901L +fprintf(new, "#define SIZE_T_FMT \"%%zu\"\n"); +#else +# ifdef PRIdMAX +fprintf(new, "#define SIZE_T_FMT \"%%" PRIdMAX "\"\n"); +# else +if (sizeof(test_size_t) > sizeof (test_ulong_t)) + fprintf(new, "#define SIZE_T_FMT \"%%llu\"\n"); +else + fprintf(new, "#define SIZE_T_FMT \"%%lu\"\n"); +# endif +#endif + /* Now search the makefile for certain settings */ base = fopen("Makefile", "rb"); @@ -356,6 +378,7 @@ while (fgets(buffer, sizeof(buffer), base) != NULL) uid_t uid = 0; gid_t gid = 0; int gid_set = 0; + int uid_not_set = 0; char *username = NULL; char *groupname = NULL; char *s; @@ -410,6 +433,7 @@ while (fgets(buffer, sizeof(buffer), base) != NULL) while (isspace(*user)) user++; username = user; gid_set = 1; + uid_not_set = 1; } else @@ -503,6 +527,19 @@ while (fgets(buffer, sizeof(buffer), base) != NULL) return 1; } + /* security sanity checks + if ref: is being used, we can never be sure, but we can take reasonable + steps to filter out the most obvious ones. */ + + if ((!uid_not_set && uid == 0) || + ((username != NULL) && ( + (strcmp(username, "root") == 0) || + (strcmp(username, "toor") == 0) ))) + { + printf("\n*** Exim's internal user must not be root.\n\n"); + return 1; + } + /* Output user and group names or uid/gid. When names are set, uid/gid are set to zero but will be replaced at runtime. */