Fix $auth1 problem in dovecot authenticator.
[exim.git] / doc / doc-txt / ChangeLog
CommitLineData
f0872424 1$Cambridge: exim/doc/doc-txt/ChangeLog,v 1.459 2007/01/23 12:22:00 ph10 Exp $
495ae4b0
PH
2
3Change log file for Exim from version 4.21
4-------------------------------------------
5
b4ed4da0
PH
6Exim version 4.67
7-----------------
8
22ad45c9
MH
9MH/01 Fix for bug #448, segfault in Dovecot authenticator when interface_address
10 is unset (happens when testing with -bh and -oMi isn't used). Thanks to
11 Jan Srzednicki.
12
b4ed4da0
PH
13PH/01 Added a new log selector smtp_no_mail, to log SMTP sessions that do not
14 issue a MAIL command.
15
431b7361
PH
16PH/02 In an ACL statement such as
17
18 deny dnslists = X!=127.0.0.2 : X=127.0.0.2
19
20 if a client was not listed at all, or was listed with a value other than
21 127.0.0.2, in the X list, but was listed with 127.0.0.2 in the Y list,
22 the condition was not true (as it should be), so access was not denied.
23 The bug was that the ! inversion was incorrectly passed on to the second
24 item. This has been fixed.
25
26PH/03 Added additional dnslists conditions == and =& which are different from
27 = and & when the dns lookup returns more than one IP address.
28
83da1223
PH
29PH/04 Added gnutls_require_{kx,mac,protocols} to give more control over the
30 cipher suites used by GnuTLS. These options are ignored by OpenSSL.
31
54fc8428
PH
32PH/05 After discussion on the list, added a compile time option ENABLE_DISABLE_
33 FSYNC, which compiles an option called disable_fsync that allows for
34 bypassing fsync(). The documentation is heavily laced with warnings.
35
34c5e8dd
SC
36SC/01 Updated eximstats to collate all SpamAssassin rejects into one bucket.
37
bbe15da8
PH
38PH/06 Some tidies to the infrastructure of the Test Suite that is concerned
39 with the auxiliary C programs that it uses: (1) Arrange for BIND_8_COMPAT
40 to be defined when compiling on OSX (Darwin); (2) Tidies to the Makefile,
41 including adding "make clean"; (3) Added -fPIC when compiling the test
42 dynamically loaded module, to get rid of a warning.
43
f0872424
PH
44PH/07 There was a bug in the dovecot authenticator such that the value of
45 $auth1 could be overwritten, and so not correctly preserved, after a
46 successful authentication. This usually meant that the value preserved by
47 the server_setid option was incorrect.
48
b4ed4da0 49
5dd1517f
PH
50Exim version 4.66
51-----------------
52
53PH/01 Two more bugs that were introduced by 4.64/PH/07, in addition to the one
54 fixed by 4.65/MH/01 (is this a record?) are fixed:
55
56 (i) An empty string was always treated as zero by the numeric comparison
57 operators. This behaviour has been restored.
58
59 (ii) It is documented that the numeric comparison operators always treat
60 their arguments as decimal numbers. This was broken in that numbers
61 starting with 0 were being interpreted as octal.
62
63 While fixing these problems I realized that there was another issue that
64 hadn't been noticed. Values of message_size_limit (both the global option
65 and the transport option) were treated as octal if they started with 0.
66 The documentation was vague. These values are now always treated as
67 decimal, and I will make that clear in the documentation.
68
69
93cfa765
TK
70Exim version 4.65
71-----------------
72
73TK/01 Disable default definition of HAVE_LINUX_SENDFILE. Clashes with
74 Linux large file support (_FILE_OFFSET_BITS=64) on older glibc
75 versions. (#438)
76
d6066548
MH
77MH/01 Don't check that the operands of numeric comparison operators are
78 integers when their expansion is in "skipping" mode (fixes bug
79 introduced by 4.64-PH/07).
80
4362ff0d
PH
81PH/01 If a system filter or a router generates more than SHRT_MAX (32767)
82 child addresses, Exim now panics and dies. Previously, because the count
83 is held in a short int, deliveries were likely to be lost. As such a
84 large number of recipients for a single message is ridiculous
85 (performance will be very, very poor), I have chosen to impose a limit
86 rather than extend the field.
87
93cfa765 88
944e9e9c
TF
89Exim version 4.64
90-----------------
aa41d2de 91
21d74bd9
TK
92TK/01 Bugzilla #401. Fix DK spooling code so that it can overwrite a
93 leftover -K file (the existence of which was triggered by #402).
94 While we were at it, introduced process PID as part of the -K
95 filename. This should rule out race conditions when creating
96 these files.
97
98TK/02 Bugzilla #402. Apply patch from Simon Arlott, speeding up DK signing
99 processing considerably. Previous code took too long for large mails,
100 triggering a timeout which in turn triggers #401.
101
102TK/03 Introduced HAVE_LINUX_SENDFILE to os.h-Linux. Currently only used
103 in the DK code in transports.c. sendfile() is not really portable,
104 hence the _LINUX specificness.
944e9e9c
TF
105
106TF/01 In the add_headers option to the mail command in an Exim filter,
107 there was a bug that Exim would claim a syntax error in any
108 header after the first one which had an odd number of characters
109 in the field name.
110
2b1c6e3a
PH
111PH/01 If a server that rejects MAIL FROM:<> was the target of a sender
112 callout verification, Exim cached a "reject" for the entire domain. This
113 is correct for most verifications, but it is not correct for a recipient
114 verification with use_sender or use_postmaster set, because in that case
115 the callout does not use MAIL FROM:<>. Exim now distinguishes the special
116 case of MAIL FROM:<> rejection from other early rejections (e.g.
117 rejection of HELO). When verifying a recipient using a non-null MAIL
118 address, the cache is ignored if it shows MAIL FROM:<> rejection.
119 Whatever the result of the callout, the value of the domain cache is
120 left unchanged (for any other kind of callout, getting as far as trying
121 RCPT means that the domain itself is ok).
122
1f872c80
PH
123PH/02 Tidied a number of unused variable and signed/unsigned warnings that
124 gcc 4.1.1 threw up.
125
126PH/03 On Solaris, an unexpectedly close socket (dropped connection) can
127 manifest itself as EPIPE rather than ECONNECT. When tidying away a
128 session, the daemon ignores ECONNECT errors and logs others; it now
129 ignores EPIPE as well.
130
d203e649
PH
131PH/04 Applied Nico Erfurth's refactoring patch to tidy up mime.c
132 (quoted-printable decoding).
133
cc2ed8f7 134PH/05 Applied Nico Erfurth's refactoring patch to tidy up spool_mbox.c, and
21a04aa3 135 later the small subsequent patch to fix an introduced bug.
f951fd57 136
ddfcd446
PH
137PH/06 Installed the latest Cygwin Makefile from the Cygwin maintainer.
138
d45b1de8
PH
139PH/07 There was no check for overflow in expansions such as ${if >{1}{4096M}}.
140
141PH/08 An error is now given if message_size_limit is specified negative.
142
38a0a95f 143PH/09 Applied and tidied up Jakob Hirsch's patch for allowing ACL variables
641cb756 144 to be given (somewhat) arbitrary names.
38a0a95f 145
a2405d83
JJ
146JJ/01 exipick 20060919.0, allow for arbitrary acl_ variables introduced
147 in 4.64-PH/09.
148
149JJ/02 exipick 20060919.0, --show-vars args can now be regular expressions,
150 miscellaneous code fixes
151
6ea85e9a
PH
152PH/10 Added the log_reject_target ACL modifier to specify where to log
153 rejections.
154
26da7e20
PH
155PH/11 Callouts were setting the name used for EHLO/HELO from $smtp_active_
156 hostname. This is wrong, because it relates to the incoming message (and
157 probably the interface on which it is arriving) and not to the outgoing
158 callout (which could be using a different interface). This has been
159 changed to use the value of the helo_data option from the smtp transport
160 instead - this is what is used when a message is actually being sent. If
161 there is no remote transport (possible with a router that sets up host
162 addresses), $smtp_active_hostname is used.
6ea85e9a 163
14aa5a05 164PH/12 Installed Andrey Panin's patch to add a dovecot authenticator. Various
7befa435 165 tweaks were necessary in order to get it to work (see also 21 below):
14aa5a05
PH
166 (a) The code assumed that strncpy() returns a negative number on buffer
167 overflow, which isn't the case. Replaced with Exim's string_format()
168 function.
169 (b) There were several signed/unsigned issues. I just did the minimum
170 hacking in of casts. There is scope for a larger refactoring.
171 (c) The code used strcasecmp() which is not a standard C function.
172 Replaced with Exim's strcmpic() function.
173 (d) The code set only $1; it now sets $auth1 as well.
174 (e) A simple test gave the error "authentication client didn't specify
175 service in request". It would seem that Dovecot has changed its
176 interface. Fortunately there's a specification; I followed it and
177 changed what the client sends and it appears to be working now.
178
ff75a1f7
PH
179PH/13 Added $message_headers_raw to provide the headers without RFC 2047
180 decoding.
181
e6f6568e
PH
182PH/14 Corrected misleading output from -bv when -v was also used. Suppose the
183 address A is aliased to B and C, where B exists and C does not. Without
184 -v the output is "A verified" because verification stops after a
185 successful redirection if more than one address is generated. However,
186 with -v the child addresses are also verified. Exim was outputting "A
187 failed to verify" and then showing the successful verification for C,
188 with its parentage. It now outputs "B failed to verify", showing B's
189 parentage before showing the successful verification of C.
190
d6f6e0dc
PH
191PH/15 Applied Michael Deutschmann's patch to allow DNS black list processing to
192 look up a TXT record in a specific list after matching in a combined
193 list.
194
322050c2
PH
195PH/16 It seems that the options setting for the resolver (RES_DEFNAMES and
196 RES_DNSRCH) can affect the behaviour of gethostbyname() and friends when
197 they consult the DNS. I had assumed they would set it the way they
198 wanted; and indeed my experiments on Linux seem to show that in some
199 cases they do (I could influence IPv6 lookups but not IPv4 lookups).
200 To be on the safe side, however, I have now made the interface to
201 host_find_byname() similar to host_find_bydns(), with an argument
202 containing the DNS resolver options. The host_find_byname() function now
203 sets these options at its start, just as host_find_bydns() does. The smtp
204 transport options dns_qualify_single and dns_search_parents are passed to
205 host_find_byname() when gethostbyname=TRUE in this transport. Other uses
206 of host_find_byname() use the default settings of RES_DEFNAMES
207 (qualify_single) but not RES_DNSRCH (search_parents).
208
08955dd3
PH
209PH/17 Applied (a modified version of) Nico Erfurth's patch to make
210 spool_read_header() do less string testing, by means of a preliminary
211 switch on the second character of optional "-foo" lines. (This is
212 overdue, caused by the large number of possibilities that now exist.
213 Originally there were few.) While I was there, I also converted the
214 str(n)cmp tests so they don't re-test the leading "-" and the first
215 character, in the hope this might squeeze out yet more improvement.
216
1eccaa59
PH
217PH/18 Two problems with "group" syntax in header lines when verifying: (1) The
218 flag allowing group syntax was set by the header_syntax check but not
219 turned off, possible causing trouble later; (2) The flag was not being
220 set at all for the header_verify test, causing "group"-style headers to
221 be rejected. I have now set it in this case, and also caused header_
222 verify to ignore an empty address taken from a group. While doing this, I
223 came across some other cases where the code for allowing group syntax
224 while scanning a header line wasn't quite right (mostly, not resetting
225 the flag correctly in the right place). These bugs could have caused
226 trouble for malformed header lines. I hope it is now all correct.
227
602e59e5
PH
228PH/19 The functions {pwcheck,saslauthd}_verify_password() are always called
229 with the "reply" argument non-NULL. The code, however (which originally
230 came from elsewhere) had *some* tests for NULL when it wrote to *reply,
231 but it didn't always do it. This confused somebody who was copying the
232 code for some other use. I have removed all the tests.
233
411ef850
PH
234PH/20 It was discovered that the GnuTLS code had support for RSA_EXPORT, a
235 feature that was used to support insecure browsers during the U.S. crypto
236 embargo. It requires special client support, and Exim is probably the
237 only MTA that supported it -- and would never use it because real RSA is
238 always available. This code has been removed, because it had the bad
239 effect of slowing Exim down by computing (never used) parameters for the
240 RSA_EXPORT functionality.
241
7befa435
PH
242PH/21 On the advice of Timo Sirainen, added a check to the dovecot
243 authenticator to fail if there's a tab character in the incoming data
244 (there should never be unless someone is messing about, as it's supposed
245 to be base64-encoded). Also added, on Timo's advice, the "secured" option
246 if the connection is using TLS or if the remote IP is the same as the
247 local IP, and the "valid-client-cert option" if a client certificate has
248 been verified.
249
48da4259 250PH/22 As suggested by Dennis Davis, added a server_condition option to *all*
16ff981e
PH
251 authenticators. This can be used for authorization after authentication
252 succeeds. (In the case of plaintext, it servers for both authentication
253 and authorization.)
254
48da4259
PH
255PH/23 Testing for tls_required and lost_connection in a retry rule didn't work
256 if any retry times were supplied.
257
d1d5595c
PH
258PH/24 Exim crashed if verify=helo was activated during an incoming -bs
259 connection, where there is no client IP address to check. In this
260 situation, the verify now always succeeds.
261
0ef732d9
PH
262PH/25 Applied John Jetmore's -Mset patch.
263
328895cc
PH
264PH/26 Added -bem to be like -Mset, but loading a message from a file.
265
fd700877
PH
266PH/27 In a string expansion for a processed (not raw) header when multiple
267 headers of the same name were present, leading whitespace was being
268 removed from all of them, but trailing whitespace was being removed only
269 from the last one. Now trailing whitespace is removed from each header
f6c332bd
PH
270 before concatenation. Completely empty headers in a concatenation (as
271 before) are ignored.
fd700877 272
8dce1a6f
PH
273PH/28 Fixed bug in backwards-compatibility feature of PH/09 (thanks to John
274 Jetmore). It would have mis-read ACL variables from pre-4.61 spool files.
275
17af4a17
PH
276PH/29 [Removed. This was a change that I later backed out, and forgot to
277 correct the ChangeLog entry (that I had efficiently created) before
278 committing the later change.]
f6c332bd
PH
279
280PH/30 Exim was sometimes attempting to deliver messages that had suffered
281 address errors (4xx response to RCPT) over the same connection as other
282 messages routed to the same hosts. Such deliveries are always "forced",
283 so retry times are not inspected. This resulted in far too many retries
284 for the affected addresses. The effect occurred only when there were more
285 hosts than the hosts_max_try setting in the smtp transport when it had
286 the 4xx errors. Those hosts that it had tried were not added to the list
287 of hosts for which the message was waiting, so if all were tried, there
288 was no problem. Two fixes have been applied:
289
290 (i) If there are any address or message errors in an SMTP delivery, none
291 of the hosts (tried or untried) are now added to the list of hosts
292 for which the message is waiting, so the message should not be a
293 candidate for sending over the same connection that was used for a
294 successful delivery of some other message. This seems entirely
295 reasonable: after all the message is NOT "waiting for some host".
296 This is so "obvious" that I'm not sure why it wasn't done
297 previously. Hope I haven't missed anything, but it can't do any
298 harm, as the worst effect is to miss an optimization.
299
300 (ii) If, despite (i), such a delivery is accidentally attempted, the
301 routing retry time is respected, so at least it doesn't keep
302 hammering the server.
303
c1114884
PH
304PH/31 Installed Andrew Findlay's patch to close the writing end of the socket
305 in ${readsocket because some servers need this prod.
306
7a0743eb
PH
307PH/32 Added some extra debug output when updating a wait-xxx database.
308
0d85fa3f
PH
309PH/33 The hint "could be header name not terminated by colon", which has been
310 given for certain expansion errors for a long time, was not being given
311 for the ${if def:h_colon_omitted{... case.
312
1bf43b78
PH
313PH/34 The spec says: "With one important exception, whenever a domain list is
314 being scanned, $domain contains the subject domain." There was at least
315 one case where this was not true.
316
520de300
PH
317PH/35 The error "getsockname() failed: connection reset by peer" was being
318 written to the panic log as well as the main log, but it isn't really
319 panic-worthy as it just means the connection died rather early on. I have
320 removed the panic log writing for the ECONNRESET error when getsockname()
321 fails.
322
48c7f9e2
PH
323PH/36 After a 4xx response to a RCPT error, that address was delayed (in queue
324 runs only) independently of the message's sender address. This meant
325 that, if the 4xx error was in fact related to the sender, a different
326 message to the same recipient with a different sender could confuse
327 things. In particualar, this can happen when sending to a greylisting
328 server, but other circumstances could also provoke similar problems.
329 I have changed the default so that the retry time for these errors is now
330 based a combination of the sender and recipient addresses. This change
331 can be overridden by setting address_retry_include_sender=false in the
332 smtp transport.
333
99ea1c86
PH
334PH/37 For LMTP over TCP/IP (the smtp transport), error responses from the
335 remote server are returned as part of bounce messages. This was not
336 happening for LMTP over a pipe (the lmtp transport), but now it is the
337 same for both kinds of LMTP.
338
a2042e78
PH
339PH/38 Despite being documented as not happening, Exim was rewriting addresses
340 in header lines that were in fact CNAMEs. This is no longer the case.
341
4fbcfc2e
PH
342PH/39 If -R or -S was given with -q<time>, the effect of -R or -S was ignored,
343 and queue runs started by the daemon processed all messages. This has
344 been fixed so that -R and -S can now usefully be given with -q<time>.
345
aa41d2de
PH
346PH/40 Import PCRE release 6.7 (fixes some bugs).
347
af561417
PH
348PH/41 Add bitwise logical operations to eval (courtesy Brad Jorsch).
349
3cc66b45
PH
350PH/42 Give an error if -q is specified more than once.
351
194cc0e4
PH
352PH/43 Renamed the variables $interface_address and $interface_port as
353 $received_ip_address and $received_port, to make it clear that these
354 values apply to message reception, and not to the outgoing interface when
355 a message is delivered. (The old names remain recognized, of course.)
356
a401ddaa
PH
357PH/44 There was no timeout on the connect() call when using a Unix domain
358 socket in the ${readsocket expansion. There now is.
359
4e88a19f
PH
360PH/45 Applied a modified version of Brad Jorsch's patch to allow "message" to
361 be meaningful with "accept".
362
d7d7b289
SC
363SC/01 Eximstats V1.43
364 Bug fix for V1.42 with -h0 specified. Spotted by Chris Lear.
365
366SC/02 Eximstats V1.44
367 Use a glob alias rather than an array ref in the generated
368 parser. This improves both readability and performance.
369
370SC/03 Eximstats V1.45 (Marco Gaiarin / Steve Campbell)
371 Collect SpamAssassin and rejection statistics.
372 Don't display local sender or destination tables unless
373 there is data to show.
374 Added average volumes into the top table text output.
375
376SC/04 Eximstats V1.46
377 Collect data on the number of addresses (recipients)
378 as well as the number of messages.
379
380SC/05 Eximstats V1.47
381 Added 'Message too big' to the list of mail rejection
382 reasons (thanks to Marco Gaiarin).
383
384SC/06 Eximstats V1.48
385 Mainlog lines which have GMT offsets and are too short to
386 have a flag are now skipped.
387
388SC/07 Eximstats V1.49 (Alain Williams)
389 Added the -emptyok flag.
390
391SC/08 Eximstats V1.50
392 Fixes for obtaining the IP address from reject messages.
393
0ea2a468
JJ
394JJ/03 exipick.20061117.2, made header handling as similar to exim as possible
395 (added [br]h_ prefixes, implemented RFC2047 decoding. Fixed
396 whitesspace changes from 4.64-PH/27
397
398JJ/04 exipick.20061117.2, fixed format and added $message_headers_raw to
399 match 4.64-PH/13
400
401JJ/05 exipick.20061117.2, bug fixes (error out sooner when invalid criteria
402 are found, allow negative numbers in numeric criteria)
403
404JJ/06 exipick.20061117.2, added new $message_body_missing variable
405
406JJ/07 exipick.20061117.2, added $received_ip_address and $received_port
407 to match changes made in 4.64-PH/43
408
8a10f5a4
PH
409PH/46 Applied Jori Hamalainen's patch to add features to exiqsumm.
410
30e18802
PH
411PH/47 Put in an explicit test for a DNS lookup of an address record where the
412 "domain" is actually an IP address, and force a failure. This locks out
413 those revolvers/nameservers that support "A-for-A" lookups, in
414 contravention of the specifications.
415
55728a4f
PH
416PH/48 When a host name was looked up from an IP address, and the subsequent
417 forward lookup of the name timed out, the host name was left in
418 $sender_host_name, contrary to the specification.
d7d7b289 419
d7837193
PH
420PH/49 Although default lookup types such as lsearch* or cdb*@ have always been
421 restricted to single-key lookups, Exim was not diagnosing an error if
422 * or *@ was used with a query-style lookup.
423
87054a31
PH
424PH/50 Increased the value of DH_BITS in tls-gnu.c from 768 to 1024.
425
ea2c01d2
MH
426MH/01 local_scan ABI version incremented to 1.1. It should have been updated
427 long ago, but noone interested enough thought of it. Let's just say that
428 the "1.1" means that there are some new functions that weren't there at
429 some point in the past.
430
e4fa6968
PH
431PH/51 Error processing for expansion failure of helo_data from an smtp
432 transport during callout processing was broken.
433
56f5d9bd
PH
434PH/52 Applied John Jetmore's patch to allow tls-on-connect and STARTTLS to be
435 tested/used via the -bh/-bhc/-bs options.
436
922e1c28
PH
437PH/53 Added missing "#include <time.h>" to pcre/pcretest.c (this was a PCRE
438 bug, fixed in subsequent PCRE releases).
439
21eb6e72
PH
440PH/54 Applied Robert Bannocks' patch to avoid a problem with references that
441 arises when using the Solaris LDAP libraries (but not with OpenLDAP).
442
a0540757
PH
443PH/55 Check for a ridiculously long file name in exim_dbmbuild.
444
944e9e9c 445
478be7b0
SC
446Exim version 4.63
447-----------------
448
449SC/01 Use a glob alias rather than an array ref in eximstats generated
450 parser. This improves both readability and performance.
451
452SC/02 Collect SpamAssassin and rejection statistics in eximstats.
453 Don't display local sender or destination tables in eximstats unless
454 there is data to show.
455 Added average volumes into the eximstats top table text output.
456
457SC/03 Collect data on the number of addresses (recipients) as well
458 as the number of messages in eximstats.
459
2b965a65
TF
460TF/01 Correct an error in the documentation for the redirect router. Exim
461 does (usually) call initgroups() when daemonizing.
478be7b0 462
45b91596
PH
463TF/02 Call initgroups() when dropping privilege in exim.c, so that Exim runs
464 with consistent privilege compared to when running as a daemon.
478be7b0 465
c59f5781
TF
466TF/03 Note in the spec that $authenticated_id is not set for local
467 submissions from trusted users.
468
90fc3069
TF
469TF/04 The ratelimit per_rcpt option now works correctly in acl_not_smtp.
470 Thanks to Dean Brooks <dean@iglou.com> for the patch.
471
6083aca0
TF
472TF/05 Make it easier to get SMTP authentication and TLS/SSL support working
473 by adding some example configuration directives to the default
474 configuration file. A little bit of work is required to uncomment the
475 directives and define how usernames and passwords are checked, but
476 there is now a framework to start from.
477
765b530f
PH
478PH/01 Added #define LDAP_DEPRECATED 1 to ldap.c because some of the "old"
479 functions that Exim currently uses aren't defined in ldap.h for OpenLDAP
480 without this. I don't know how relevant this is to other LDAP libraries.
481
4e167a8c
PH
482PH/02 Add the verb name to the "unknown ACL verb" error.
483
4608d683
PH
484PH/03 Magnus Holmgren's patch for filter_prepend_home.
485
b8dc3e4a
PH
486PH/03 Fixed Bugzilla #101: macro definition between ACLs doesn't work.
487
5418e93b
PH
488PH/04 Applied Magnus Holmgren's patch to fix Bugzilla #98: transport's home
489 directory not expanded when it should be if an expanded home directory
490 was set for the address (which is overridden by the transport).
491
b4a9bda2
PH
492PH/05 Applied Alex Kiernan's patch to fix Bugzilla #99: a problem with
493 libradius.
494
45b91596
PH
495PH/06 Added acl_not_smtp_start, based on Johannes Berg's patch, and set the
496 bit to forbid control=suppress_local_fixups in the acl_not_smtp ACL,
497 because it is too late at that time, and has no effect.
498
5547e2c5
PH
499PH/07 Changed ${quote_pgsql to quote ' as '' instead of \' because of a
500 security issue with \' (bugzilla #107). I could not use the
501 PQescapeStringConn() function, because it needs a PGconn value as one of
502 its arguments.
503
dbcef0ea
PH
504PH/08 When testing addresses using -bt, indicate those final addresses that
505 are duplicates that would not cause an additional delivery. At least one
506 person was confused, thinking that -bt output corresponded to deliveries.
507 (Suppressing duplicates isn't a good idea as you lose the information
508 about possibly different redirections that led to the duplicates.)
509
25257489
PH
510PH/09 Applied patch from Erik to use select() instead of poll() in spam.c on
511 systems where poll() doesn't work, in particular OS X.
512
c816d124
PH
513PH/10 Added more information to debugging output for retry time not reached.
514
a9ccd69a
PH
515PH/11 Applied patch from Arkadiusz Miskiewicz to apply a timeout to read
516 operations in malware.c.
517
75fa1910
PH
518PH/12 Applied patch from Magnus Holmgren to include the "h" tag in Domain Keys
519 signatures.
520
a7d7aa58
PH
521PH/13 If write_rejectlog was set false when logging was sent to syslog with
522 syslog_duplication set false, log lines that would normally be written
523 both the the main log and to the reject log were not written to syslog at
524 all.
525
42119b09
PH
526PH/14 In the default configuration, change the use of "message" in ACL warn
527 statements to "add_header".
528
41609df5
PH
529PH/15 Diagnose a filter syntax error for "seen", "unseen", or "noerror" if not
530 not followed by a command (e.g. "seen endif").
531
a5bd321b
PH
532PH/16 Recognize SMTP codes at the start of "message" in ACLs and after :fail:
533 and :defer: in a redirect router. Add forbid_smtp_code to suppress the
534 latter.
535
e85a7ad5 536PH/17 Added extra conditions to the default value of delay_warning_condition
5dff5817
PH
537 so that it is now:
538
e85a7ad5
PH
539 ${if or { \
540 { !eq{$h_list-id:$h_list-post:$h_list-subscribe:}{} } \
541 { match{$h_precedence:}{(?i)bulk|list|junk} } \
542 { match{$h_auto-submitted:}{(?i)auto-generated|auto-replied} } \
5dff5817
PH
543 }{no}{yes}}
544
e85a7ad5
PH
545 The Auto-Submitted: and various List- headers are standardised, whereas I
546 don't think Precedence: ever was.
5dff5817 547
d8fe1c03
PH
548PH/18 Refactored debugging code in route_finduser() to show more information,
549 in particular, the error code if getpwnam() issues one.
550
16282d2b
PH
551PH/19 Added PQsetClientEncoding(conn, "SQL_ASCII") to the pgsql code module.
552 This is apparently needed in addition to the PH/07 change above to avoid
553 any possible encoding problems.
554
35d40a98
PH
555PH/20 Perl can change the locale. Exim was resetting it after a ${perl call,
556 but not after initializing Perl.
557
034d99ab
PH
558PH/21 Added a call to PQsetNoticeProcessor() to catch pgsql "notices" and
559 output them only if debugging. By default they are written stderr,
560 apparently, which is not desirable.
561
6ec97b1b
PH
562PH/22 Added Alain Williams' LDAP patch to support setting REFERRALS=off on
563 queries.
564
e22ca4ac
JJ
565JJ/01 exipick: added --reverse (and -R synonym), --random, --size, --sort and
566 --not options
567
568JJ/02 exipick: rewrote --help documentation to hopefully make more clear.
569
33d73e3b
PH
570PH/23 Made -oMaa and -oMt work with -bh and -bs to pretend the connection is
571 authenticated or an ident call has been made. Suppress the default
572 values for $authenticated_id and $authenticated_sender (but permit -oMai
573 and -oMas) when testing with -bh.
574
9ecb03f3
PH
575PH/24 Re-jigged the order of the tests in the default configuration so that the
576 tests for valid domains and recipients precede the DNS black list and CSA
577 tests, on the grounds that those ones are more expensive.
578
084efe8d
PH
579PH/25 Exim was not testing for a space following SMTP commands such as EHLO
580 that require one. Thus, EHLORHUBARB was interpreted as a valid command.
581 This bug exists in every version of Exim that I still have, right back to
582 0.12.
583
366fc9f0
PH
584PH/26 (n)wildlsearch lookups are documented as being done case-insensitively.
585 However, an attempt to turn on case-sensitivity in a regex key by
586 including (?-i) didn't work because the subject string was already
587 lowercased, and the effects were non-intuitive. It turns out that a
588 one-line patch can be used to allow (?-i) to work as expected.
589
c59f5781 590
c887c79e
TF
591Exim version 4.62
592-----------------
593
594TF/01 Fix the add_header change below (4.61 PH/55) which had a bug that (amongst
595 other effects) broke the use of negated acl sub-conditions.
596
1cce3af8
PH
597PH/01 ${readsocket now supports Internet domain sockets (modified John Jetmore
598 patch).
599
afb3eaaf
PH
600PH/02 When tcp-wrappers is called from Exim, it returns only "deny" or "allow".
601 "Deny" causes Exim to reject the incoming connection with a 554 error.
602 Unfortunately, if there is a major crisis, such as a disk failure,
603 tcp-wrappers gives "deny", whereas what one would like would be some
604 kind of temporary error. A kludge has been added to help with this.
605 Before calling hosts_ctl(), errno is set zero. If the result is "deny", a
606 554 error is used if errno is still zero or contains ENOENT (which occurs
607 if either of the /etc/hosts.{allow,deny} files is missing). Otherwise, a
608 451 error is used.
609
e173618b
PH
610PH/03 Add -lutil to the default FreeBSD LIBS setting.
611
dd16e114
PH
612PH/04 Change PH/19 for 4.61 was too wide. It should not be applied to host
613 errors. Otherwise a message that provokes a temporary error (when other
614 messages do not) can cause a whole host to time out.
615
f7fd3850
PH
616PH/05 Batch deliveries by appendfile and pipe transports did not work when the
617 addresses were routed directly to files or pipes from a redirect router.
618 File deliveries just didn't batch; pipe deliveries might have suffered
619 odd errors.
620
d87df92c
PH
621PH/06 A failure to get a lock for a hints database would erroneously always say
622 "Failed to get write lock", even when it was really a read lock.
623
7e9f683d
PH
624PH/07 The appendfile transport was creating MBX lock files with a fixed mode
625 of 0600. This has been changed to use the value of the lockfile_mode
626 option (which defaults to 0600).
627
bfad5236
PH
628PH/08 Applied small patch from the Sieve maintainer.
629
01c490df
PH
630PH/09 If maildir_quota_directory_regex was set to exclude (say) the .Trash
631 folder from quota calculations, a direct delivery into this folder messed
632 up the contents of the maildirsize file. This was because the regex was
633 used only to exclude .Trash (or whatever) when the size of the mailbox
634 was calculated. There was no check that a delivery was happening into an
635 excluded directory. This bug has been fixed by ignoring all quota
636 processing for deliveries into excluded directories.
637
d6629cdc
PH
638PH/10 Added the maildirfolder_create_regex option to appendfile.
639
1cce3af8 640
214e2000
PH
641Exim version 4.61
642-----------------
643
644PH/01 The code for finding all the local interface addresses on a FreeBSD
645 system running IPv6 was broken. This may well have applied to all BSD
646 systems, as well as to others that have similar system calls. The broken
647 code found IPv4 interfaces correctly, but gave incorrect values for the
648 IPv6 interfaces. In particular, ::1 was not found. The effect in Exim was
649 that it would not match correctly against @[] and not recognize the IPv6
650 addresses as local.
651
f9daeae0
PH
652PH/02 The ipliteral router was not recognizing addresses of the form user@
653 [ipv6:....] because it didn't know about the "ipv6:" prefix.
654
7e66e54d
PH
655PH/03 Added disable_ipv6.
656
c8ea1597
PH
657PH/04 Changed $reply_address to use the raw form of the headers instead of the
658 decoded form, because it is most often used to construct To: headers
659 lines in autoreplies, and the decoded form may well be syntactically
660 invalid. However, $reply_address has leading white space removed, and all
661 newlines turned into spaces so that the autoreply transport does not
662 grumble.
663
911f6fde
PH
664PH/05 If group was specified without a user on a router, and no group or user
665 was specified on a transport, the group from the router was ignored.
666
47ca6d6c
PH
667PH/06 Increased the number of ACL variables to 20 of each type, and arranged
668 for visible compile-time settings that can be used to change these
669 numbers, for those that want even more. Backwards compatibility with old
670 spool files has been maintained. However, going back to a previous Exim
671 release will lost any variables that are in spool files.
672
ed0e9820
PH
673PH/07 Two small changes when running in the test harness: increase delay when
674 passing a TCP/IP connection to a new process, in case the original
675 process has to generate a bounce, and remove special handling of
676 127.0.0.2 (sic), which is no longer necessary.
677
eff37e47
PH
678PH/08 Changed debug output of dbfn_open() flags from numbers to names, so as to
679 be the same on different OS.
680
1921d2ea
PH
681PH/09 Moved a debug statement in filter processing to avoid a race problem when
682 testing.
683
b3f69ca8
JJ
684JJ/01 exipick: fixed bug where -b (brief) output option showed "Vars:"
685 whether --show-vars was specified or not
686
687JJ/02 exipick: Added support for new ACL variable spool format introduced
688 in 4.61-PH/06
689
424a1c63
PH
690PH/10 Fixed another bug related to PH/04 above: if an incoming message had a
691 syntactically invalid From: or Reply-to: line, and a filter used this to
692 generate an autoreply, and therefore failed to obtain an address for the
693 autoreply, Exim could try to deliver to a non-existent relative file
694 name, causing unrelated and misleading errors. What now happens is that
695 it logs this as a hard delivery error, but does not attempt to create a
696 bounce message.
697
7a100415
PH
698PH/11 The exinext utility has a -C option for testing purposes, but although
699 the given file was scanned by exinext itself; it wasn't being passed on
700 when Exim was called.
701
19b9dc85
PH
702PH/12 In the smtp transport, treat an explicit ECONNRESET error the same as
703 an end-of-file indication when reading a command response.
704
309bd837
PH
705PH/13 Domain literals for IPv6 were not recognized unless IPv6 support was
706 compiled. In many other places in Exim, IPv6 addresses are always
707 recognized, so I have changed this. It also means that IPv4 domain
708 literals of the form [IPV4:n.n.n.n] are now always recognized.
709
59e82a2a
PH
710PH/14 When a uid/gid is specified for the queryprogram router, it cannot be
711 used if the router is not running as root, for example, when verifying at
712 ACL time, or when using -bh. The debugging output from this situation was
713 non-existent - all you got was a failure to exec. I have made two
714 changes:
715
716 (a) Failures to set uid/gid, the current directory, or a process leader
717 in a subprocess such as that created by queryprogram now generate
718 suitable debugging ouput when -d is set.
719
720 (b) The queryprogram router detects when it is not running as root,
721 outputs suitable debugging information if -d is set, and then runs
722 the subprocess without attempting to change uid/gid.
723
9edc04ce
PH
724PH/15 Minor change to Makefile for building test_host (undocumented testing
725 feature).
726
1349e1e5
PH
727PH/16 As discussed on the list in Nov/Dec: Exim no longer looks at the
728 additional section of a DNS packet that returns MX or SRV records.
729 Instead, it always explicitly searches for A/AAAA records. This avoids
730 major problems that occur when a DNS server includes only records of one
731 type (A or AAAA) in an MX/SRV packet. A byproduct of this change has
732 fixed another bug: if SRV records were looked up and the corresponding
733 address records were *not* found in the additional section, the port
734 values from the SRV records were lost.
735
ea49d0e1
PH
736PH/17 If a delivery to a pipe, file, or autoreply was deferred, Exim was not
737 using the correct key (the original address) when searching the retry
738 rules in order to find which one to use for generating the retry hint.
739
064a94c9
PH
740PH/18 If quota_warn_message contains a From: header, Exim now refrains from
741 adding the default one. Similarly, if it contains a Reply-To: header, the
742 errors_reply_to option, if set, is not used.
743
727071f8
PH
744PH/19 When calculating a retry time, Exim used to measure the "time since
745 failure" by looking at the "first failed" field in the retry record. Now
746 it does not use this if it is later than than the arrival time of the
747 message. Instead it uses the arrival time. This makes for better
748 behaviour in cases where some deliveries succeed, thus re-setting the
749 "first failed" field. An example is a quota failure for a huge message
750 when small messages continue to be delivered. Without this change, the
751 "time since failure" will always be short, possible causing more frequent
752 delivery attempts for the huge message than are intended.
dd16e114 753 [Note: This change was subsequently modified - see PH/04 for 4.62.]
727071f8 754
f78eb7c6
PH
755PH/20 Added $auth1, $auth2, $auth3 to contain authentication data (as well as
756 $1, $2, $3) because the numerical variables can be reset during some
757 expansion items (e.g. "match"), thereby losing the authentication data.
758
21c28500
PH
759PH/21 Make -bV show the size of off_t variables so that the test suite can
760 decide whether to run tests for quotas > 2G.
761
762PH/22 Test the values given for quota, quota_filecount, quota_warn_threshold,
763 mailbox_size, and mailbox_filecount in the appendfile transport. If a
764 filecount value is greater than 2G or if a quota value is greater than 2G
765 on a system where the size of off_t is not greater than 4, a panic error
766 is given.
767
1688f43b
PH
768PH/23 When a malformed item such as 1.2.3/24 appears in a host list, it can
769 never match. The debug and -bh output now contains an explicit error
770 message indicating a malformed IPv4 address or mask.
771
772PH/24 An host item such as 1.2.3.4/abc was being treated as the IP address
773 1.2.3.4 without a mask. Now it is not recognized as an IP address, and
774 PH/23 above applies.
775
9675b384
PH
776PH/25 Do not write to syslog when running in the test harness. The only
777 occasion when this arises is a failure to open the main or panic logs
778 (for which there is an explicit test).
779
6a3f1455
PH
780PH/26 Added the /no_tell option to "control=freeze".
781
dac79d3e
PH
782PH/27 If a host name lookup failed very early in a connection, for example, if
783 the IP address matched host_lookup and the reverse lookup yielded a name
784 that did not have a forward lookup, an error message of the form "no IP
785 address found for host xxx.xxx.xxx (during SMTP connection from NULL)"
786 could be logged. Now it outputs the IP address instead of "NULL".
1349e1e5 787
5977a0b3
PH
788PH/28 An enabling patch from MH: add new function child_open_exim2() which
789 allows the sender and the authenticated sender to be set when
790 submitting a message from within Exim. Since child_open_exim() is
791 documented for local_scan(), the new function should be too.
792
c91535f3
PH
793PH/29 In GnuTLS, a forced expansion failure for tls_privatekey was not being
794 ignored. In both GnuTLS and OpenSSL, an expansion of tls_privatekey that
795 results in an empty string is now treated as unset.
796
0d46a8c8
PH
797PH/30 Fix eximon buffer overflow bug (Bugzilla #73).
798
278c6e6c
PH
799PH/31 Added sender_verify_fail logging option.
800
2cbb4081
PH
801PH/32 In November 2003, the code in Exim that added an empty Bcc: header when
802 needed by RFC 822 but not by RFC 2822 was commented out. I have now
803 tidied the source and removed it altogether.
804
3eef829e
PH
805PH/33 When a queue run was abandoned because the load average was too high, a
806 log line was always written; now it is written only if the queue_run log
807 selector is set. In addition, the log line for abandonment now contains
808 information about the queue run such as the pid. This is always present
809 in "start" and "stop" lines but was omitted from the "abandon" line.
810
1ab95fa6
PH
811PH/34 Omit spaces between a header name and the colon in the error message that
812 is given when verify = headers_syntax fails (if there are lots of them,
813 the message gets confusing).
814
230205fc
PH
815PH/35 Change the default for dns_check_names_pattern to allow slashes within
816 names, as there are now some PTR records that contain slashes. This check
817 is only to protect against broken name servers that fall over on strange
818 characters, so the fact that it applies to all lookups doesn't matter.
819
75e0e026
PH
820PH/36 Now that the new test suite is complete, we can remove some of the
821 special code in Exim that was needed for the old test suite. For example,
822 sorting DNS records because real resolvers return them in an arbitrary
823 order. The new test suite's fake resolver always returns records in the
824 same order.
825
826PH/37 When running in the test harness, use -odi for submitted messages (e.g.
827 bounces) except when queue_only is set, to avoid logging races between
828 the different processes.
829
145396a6
PH
830PH/38 Panic-die if .include specifies a non-absolute path.
831
3cd34f13
PH
832PH/39 A tweak to the "H" retry rule from its user.
833
11121d3d
JJ
834JJ/03 exipick: Removed parentheses from 'next' and 'last' calls that specified
835 a label. They prevented compilation on older perls.
836
837JJ/04 exipick: Refactored code to prevent implicit split to @_ which caused
838 a warning to be raised on newish perls.
839
840JJ/05 exipick: Fixed bug where -bpc always showed a count of all messages
841 on queue. Changes to match documented behaviour of showing count of
842 messages matching specified criteria.
843
8def5aaf
PH
844PH/40 Changed the default ident timeout from 30s to 5s.
845
929ba01c
PH
846PH/41 Added support for the use of login_cap features, on those BSD systems
847 that have them, for controlling the resources used by pipe deliveries.
848
2632889e
PH
849PH/42 The content-scanning code uses fopen() to create files in which to put
850 message data. Previously it was not paying any attention to the mode of
851 the files. Exim runs with umask(0) because the rest of the code creates
852 files with open(), and sets the required mode explicitly. Thus, these
853 files were ending up world-writeable. This was not a big issue, because,
854 being within the spool directory, they were not world-accessible. I have
855 created a function called modefopen, which takes an additional mode
856 argument. It sets umask(777), creates the file, chmods it to the required
857 mode, then resets the umask. All the relevant calls to fopen() in the
858 content scanning code have been changed to use this function.
859
944a9c55
PH
860PH/43 If retry_interval_max is set greater than 24 hours, it is quietly reset
861 to 24 hours. This avoids potential overflow problems when processing G
862 and H retry rules. I suspect nobody ever tinkers with this value.
863
4a23603b
PH
864PH/44 Added STRIP_COMMAND=/usr/bin/strip to the FreeBSD Makefile.
865
4730f942
PH
866PH/45 When the plaintext authenticator is running as a client, the server's
867 challenges are checked to ensure they are valid base64 strings. By
868 default, the authentication attempt is cancelled if an invalid string is
869 received. Setting client_ignore_invalid_base64 true ignores these errors.
870 The decoded challenge strings are now placed in $auth1, $auth2, etc. as
871 they are received. Thus, the responses can be made to depend on the
872 challenges. If an invalid string is ignored, an empty string is placed in
873 the variable.
874
30dba1e6
PH
875PH/46 Messages that are created by the autoreply transport now contains a
876 References: header, in accordance with RFCs 2822 and 3834.
877
382afc6b
PH
878PH/47 Added authenticated_sender_force to the smtp transport.
879
a86229cf
PH
880PH/48 The ${prvs expansion was broken on systems where time_t was long long.
881
50c99ba6
PH
882PH/49 Installed latest patch from the Sieve maintainer.
883
d35e429d
PH
884PH/50 When an Exim quota was set without a file count quota, and mailbox_size
885 was also set, the appendfile transport was unnecessarily scanning a
886 directory of message files (e.g. for maildir delivery) to find the count
887 of files (along with the size), even though it did not need this
888 information. It now does the scan only if it needs to find either the
889 size of the count of files.
890
f90d018c
PH
891PH/51 Added ${time_eval: to convert Exim time strings into seconds.
892
75def545
PH
893PH/52 Two bugs concerned with error handling when the smtp transport is
894 used in LMTP mode:
895
896 (i) Exim was not creating retry information for temporary errors given
897 for individual recipients after the DATA command when the smtp transport
898 was used in LMTP mode. This meant that they could be retried too
899 frequently, and not timed out correctly.
900
901 (ii) Exim was setting the flag that allows error details to be returned
902 for LMTP errors on RCPT commands, but not for LMTP errors for individual
903 recipients that were returned after the DATA command.
904
905PH/53 This is related to PH/52, but is more general: for any failing address,
906 when detailed error information was permitted to be returned to the
907 sender, but the error was temporary, then after the final timeout, only
908 "retry timeout exceeded" was returned. Now it returns the full error as
909 well as "retry timeout exceeded".
910
c46782ef
PH
911PH/54 Added control=allow_auth_unadvertised, as it seems there are clients that
912 do this, and (what is worse) MTAs that accept it.
913
71fafd95
PH
914PH/55 Added the add_header modified to ACLs. The use of "message" with "warn"
915 will now be deprecated.
916
2c5db4fd
PH
917PH/56 New os.c-cygwin from the Cygwin maintainer.
918
9cf6b11a
JJ
919JJ/06 exipick: added --unsorted option to allow unsorted output in all output
920 formats (previously only available in exim formats via -bpr, -bpru,
921 and -bpra. Now also available in native and exiqgrep formats)
922
923JJ/07 exipick: added --freeze and --thaw options to allow faster interaction
924 with very large, slow to parse queues
925
926JJ/08 exipick: added ! as generic prefix to negate any criteria format
927
928JJ/09 exipick: miscellaneous performance enhancements (~24% improvements)
929
898d150f
PH
930PH/57 Tidies in SMTP dialogue display in debug output: (i) It was not showing
931 responses to authentication challenges, though it was showing the
932 challenges; (ii) I've removed the CR characters from the debug output for
933 SMTP output lines.
934
46218253
PH
935PH/58 Allow for the insertion of a newline as well as a space when a string
936 is turned into more than one encoded-word during RFC 2047 encoding. The
937 Sieve code now uses this.
938
e97957bc
PH
939PH/59 Added the following errors that can be detected in retry rules: mail_4xx,
940 data_4xx, lost_connection, tls_required.
941
81e509d7
PH
942PH/60 When a VRFY deferred or FAILED, the log message rather than the user
943 message was being sent as an SMTP response.
944
3d240ff7
PH
945PH/61 Add -l and -k options to exicyclog.
946
b37c4101
PH
947PH/62 When verifying, if an address was redirected to one new address, so that
948 verification continued, and the new address failed or deferred after
949 having set something in $address_data, the value of $address_data was not
950 passed back to the ACL. This was different to the case when no
951 redirection occurred. The value is now passed back in both cases.
952
79378e0f
PH
953PH/63 Changed the macro HAVE_LOGIN_CAP (see PH/41 for this release above) to
954 HAVE_SETCLASSRESOURCES because there are different APIs in use that all
955 use login_cap.h, so on its own it isn't the distinguishing feature. The
956 new name refers directly to the setclassresources() function.
957
e49c7bb4
PH
958PH/65 Added configuration files for NetBSD3.
959
d114ec46
PH
960PH/66 Updated OS/Makefile-HP-UX for gcc 4.1.0 with HP-UX 11.
961
f3d7df6c
PH
962PH/67 Fixed minor infelicity in the sorting of addresses to ensure that IPv6
963 is preferred over IPv4.
964
715ab376
PH
965PH/68 The bounce_return_message and bounce_return_body options were not being
966 honoured for bounces generated during the reception of non-SMTP messages.
967 In particular, this applied to messages rejected by the ACL. This bug has
968 been fixed. However, if bounce_return_message is true and bounce_return_
969 body is false, the headers that are returned for a non-SMTP message
970 include only those that have been read before the error was detected.
971 (In the case of an ACL rejection, they have all been read.)
972
6b31b150
PH
973PH/69 The HTML version of the specification is now built in a directory called
974 spec_html instead of spec.html, because the latter looks like a path with
975 a MIME-type, and this confuses some software.
976
977PH/70 Catch two compiler warnings in sieve.c.
978
d515a917
PH
979PH/71 Fixed an obscure and subtle bug (thanks Alexander & Matthias). The
980 function verify_get_ident() calls ip_connect() to connect a socket, but
981 if the "connect()" function timed out, ip_connect() used to close the
982 socket. However, verify_get_ident() also closes the socket later, and in
983 between Exim writes to the log, which may get opened at this point. When
984 the socket was closed in ip_connect(), the log could get the same file
985 descriptor number as the socket. This naturally causes chaos. The fix is
986 not to close the socket in ip_connect(); the socket should be closed by
987 the function that creates it. There was only one place in the code where
988 this was missing, in the iplookup router, which I don't think anybody now
989 uses, but I've fixed it anyway.
990
9b8fadde
PH
991PH/72 Make dns_again_means_nonexist apply to lookups using gethostbyname() as
992 well as to direct DNS lookups. Otherwise the handling of names in host
993 lists is inconsistent and therefore confusing.
994
214e2000 995
5de37277
PH
996Exim version 4.60
997-----------------
998
cc38ddbf
PH
999PH/01 Two changes to the default runtime configuration:
1000
1001 (1) Move the checks for relay_from_hosts and authenticated clients from
1002 after to before the (commented out) DNS black list checks.
1003
1004 (2) Add control=submission to the relay_from_hosts and authenticated
1005 clients checks, on the grounds that messages accepted by these
1006 statements are most likely to be submissions.
5de37277 1007
72fdd6ae
PH
1008PH/02 Several tidies to the handling of ${prvs and ${prvscheck:
1009
1010 (1) Generate an error if the third argument for the ${prvs expansion is
1011 not a single digit.
1012
1013 (2) Treat a missing third argument of ${prvscheck as if it were an empty
1014 string.
1015
1016 (3) Reset the variables that are obtained from the first argument of
1017 ${prvscheck and used in the second argument before leaving the code,
1018 because their memory is reclaimed, so using them afterwards may do
1019 silly things.
1020
1021 (4) Tidy up the code for expanding the arguments of ${prvscheck one by
1022 one (it's much easier than Tom thought :-).
1023
1024 (5) Because of (4), we can now allow for the use of $prvscheck_result
1025 inside the third argument.
cb9328de 1026
cb741023
PH
1027PH/03 For some reason, the default setting of PATH when running a command from
1028 a pipe transport was just "/usr/bin". I have changed it to
1029 "/bin:/usr/bin".
1030
f174f16e
PH
1031PH/04 SUPPORT_TRANSLATE_IP_ADDRESS and MOVE_FROZEN_MESSAGES did not cause
1032 anything to be listed in the output from -bV.
b2f5a032 1033
c25242d7
PH
1034PH/05 When a filter generated an autoreply, the entire To: header line was
1035 quoted in the delivery log line, like this:
1036
1037 => >A.N.Other <ano@some.domain> <original@ddress> ...
1038
1039 This has been changed so that it extracts the operative address. There
1040 may be more than one such address. If so, they are comma-separated, like
1041 this:
1042
1043 => >ano@some.domain,ona@other.domain <original@ddress> ...
1044
82c19f95
PH
1045PH/06 When a client host used a correct literal IP address in a HELO or EHLO
1046 command, (for example, EHLO [1.2.3.4]) and the client's IP address was
1047 not being looked up in the rDNS to get a host name, Exim was showing the
1048 IP address twice in Received: lines, even though the IP addresses were
1049 identical. For example:
1050
1051 Received: from [1.2.3.4] (helo=[1.2.3.4])
1052
1053 However, if the real host name was known, it was omitting the HELO data
1054 if it matched the actual IP address. This has been tidied up so that it
1055 doesn't show the same IP address twice.
1056
d7ffbc12
PH
1057PH/07 When both +timestamp and +memory debugging was on, the value given by
1058 $tod_xxx expansions could be wrong, because the tod_stamp() function was
1059 called by the debug printing, thereby overwriting the timestamp buffer.
1060 Debugging no longer uses the tod_stamp() function when +timestamp is set.
1061
9f526266
PH
1062PH/08 When the original message was included in an autoreply transport, it
1063 always said "this is a copy of the message, including all the headers",
1064 even if body_only or headers_only was set. It now gives an appropriate
1065 message.
1066
87fcc8b9
PH
1067PH/09 Applied a patch from the Sieve maintainer which:
1068
1069 o fixes some comments
1070 o adds the (disabled) notify extension core
1071 o adds some debug output for the result of if/elsif tests
1072 o points to the current vacation draft in the documentation
1073 and documents the missing references header update
1074
1075 and most important:
1076
1077 o fixes a bug in processing the envelope test (when testing
1078 multiple envelope elements, the last element determinted the
1079 result)
1080
456682f5
PH
1081PH/10 Exim was violating RFC 3834 ("Recommendations for Automatic Responses to
1082 Electronic Mail") by including:
1083
1084 Auto-submitted: auto-generated
1085
1086 in the messages that it generates (bounce messages and others, such as
1087 warnings). In the case of bounce messages for non-SMTP mesages, there was
1088 also a typo: it was using "Auto_submitted" (underscore instead of
1089 hyphen). Since every message generated by Exim is necessarily in response
1090 to another message, thes have all been changed to:
1091
1092 Auto-Submitted: auto-replied
1093
1094 in accordance with these statements in the RFC:
1095
1096 The auto-replied keyword:
1097
1098 - SHOULD be used on messages sent in direct response to another
1099 message by an automatic process,
1100
1101 - MUST NOT be used on manually-generated messages,
1102
1103 - MAY be used on Delivery Status Notifications (DSNs) and Message
1104 Disposition Notifications (MDNs),
1105
1106 - MUST NOT be used on messages generated by automatic or periodic
1107 processes, except for messages which are automatic responses to
1108 other messages.
1109
3e46c1aa
PH
1110PH/11 Added "${if def:sender_address {(envelope-from <$sender_address>)\n\t}}"
1111 to the default Received: header definition.
456682f5 1112
49826d12
PH
1113PH/12 Added log selector acl_warn_skipped (default on).
1114
eba0c039
PH
1115PH/13 After a successful wildlsearch lookup, discard the values of numeric
1116 variables because (a) they are in the wrong storage pool and (b) even if
1117 they were copied, it wouldn't work properly because of the caching.
1118
a0d6ba8a
PH
1119PH/14 Add check_rfc2047_length to disable enforcement of RFC 2047 length
1120 checking when decoding. Apparently there are clients that generate
1121 overlong encoded strings. Why am I not surprised?
1122
f0917727
PH
1123PH/15 If the first argument of "${if match_address" was not empty, but did not
1124 contain an "@" character, Exim crashed. Now it writes a panic log message
1125 and treats the condition as false.
1126
096fee00
PH
1127PH/16 In autoreply, treat an empty string for "once" the same as unset.
1128
024bd3c2
PH
1129PH/17 A further patch from the Sieve maintainer: "Introduce the new Sieve
1130 extension "envelope-auth". The code is finished and in agreement with
1131 other implementations, but there is no documentation so far and in fact,
1132 nobody wrote the draft yet. This extension is currently #undef'ed, thus
1133 not changing the active code.
1134
1135 Print executed "if" and "elsif" statements when debugging is used. This
1136 helps a great deal to understand what a filter does.
1137
1138 Document more things not specified clearly in RFC3028. I had all this
1139 sorted out, when out of a sudden new issues came to my mind. Oops."
1140
df199fec
PH
1141PH/18 Exim was not recognizing the "net-" search type prefix in match_ip lists
1142 (Bugzilla #53).
1143
d27f1df3
PH
1144PH/19 Exim expands the IPv6 address given to -bh to its full non-abbreviated
1145 canonical form (as documented). However, after a host name lookup from
1146 the IP address, check_host() was doing a simple string comparison with
1147 addresses acquired from the DNS when checking that the found name did
1148 have the original IP as one of its addresses. Since any found IPv6
1149 addresses are likely to be in abbreviated form, the comparison could
1150 fail. Luckily, there already exists a function for doing the comparison
1151 by converting both addresses to binary, so now that is used instead of
1152 the text comparison.
1153
96776534
PH
1154PH/20 There was another similar case to PH/19, when a complete host name was
1155 given in a host list; looking up its IP address could give an abbreviated
1156 form, whereas the current host's name might or might not be abbreviated.
1157 The same fix has been applied.
1158
5de37277 1159
9a799bc0
PH
1160Exim version 4.54
1161-----------------
1162
1163PH/01 The ${base62: operator adjusted itself to base 36 when BASE_62 was
1164 set to 36 (for Darwin and Cygwin), but the ${base62d: operator did not.
1165 It now does.
1166
99a4b039
PH
1167PH/02 Two minor problems detected in Cygwin: the os.{c,h} files had lost */ on
1168 the CVS lines, and there was a missing #if HAVE_IPV6 in host.c.
1169
1170PH/03 Typo: missing ".o" in src/pcre/Makefile.
1171
4b233853
PH
1172PH/04 Tighten up "personal" tests: Instead of testing for any "List-"
1173 header line, restrict the check to what is listed in RFCs 2369 and 2929.
1174 Also, for "Auto-Submitted", treat anything other than "no" as
1175 non-personal, in accordance with RFC 3834. (Previously it treated
1176 anything starting "auto-" as non-personal.)
1177
8857ccfd
PH
1178TF/01 The control=submission/name=... option had a problem with syntax
1179 errors if the name included a slash character. The /name= option
1180 now slurps the rest of the string, so it can include any characters
1181 but it must come last in the list of options (after /sender_retain
1182 or /domain=).
1183
433a2980
PH
1184PH/05 Some modifications to the interface to the fake nameserver for the new
1185 testing suite.
1186
3e46c1aa 1187
9a799bc0 1188
e3a311ba
TK
1189Exim version 4.53
1190-----------------
1191
1192TK/01 Added the "success_on_redirect" address verification option. See
1193 NewStuff for rationale and an example.
1194
13b685f9
PH
1195PH/01 Added support for SQLite, basic code supplied by David Woodhouse.
1196
395ff96d
PH
1197PH/02 Patch to exigrep to allow it to work on syslog lines.
1198
5b68f6e4
PH
1199PH/03 When creating an mbox file for a virus/spam scan, use fseek() instead of
1200 fread() to skip over the body file's header line, because in Cygwin the
1201 header line is locked and is inaccessible.
1202
1ab52c69
PH
1203PH/04 Added $message_exim_id, ultimately to replace $message_id (they will both
1204 co-exist for some time) to make it clear that it is the Exim ID that is
1205 referenced, not the Message-ID: header line.
1206
b07e6aa3
PH
1207PH/05 Replaced all Tom's calls to snprintf() with calls to the internal
1208 string_format() function, because snprintf() does not exist on all
1209 operating systems.
1210
254e032f
PH
1211PH/06 The use of forbid_filter_existstest now also locks out the use of the
1212 ${stat: expansion item.
1213
3af76a81
PH
1214PH/07 Changed "SMTP protocol violation: synchronization error" into "SMTP
1215 protocol synchronization error", to keep the pedants happy.
1216
2548ba04
PH
1217PH/08 Arrange for USE_INET_NTOA_FIX to be set in config.h for AIX systems as
1218 well as for IRIX systems, when gcc is being used. See the host.c source
1219 file for comments.
1220
b6c6011d
PH
1221PH/09 Installed latest Cygwin configuration files from the Cygwin maintainer.
1222
cf39cf57
PH
1223PH/10 Named domain lists were not working if used in a queue_smtp_domains
1224 setting.
1225
f1513293
PH
1226PH/11 Added support for the IGNOREQUOTA extension to LMTP, both to the lmtp
1227 transport and to the smtp transport in LMTP mode.
1228
727549a4
PH
1229TK/02 Remove one case of BASE64 error detection FTTB (undocumented anyway).
1230
af46795e
PH
1231PH/12 There was a missing call to search_tidyup() before the fork() in rda.c to
1232 run a filter in a subprocess. This could lead to confusion in subsequent
1233 lookups in the parent process. There should also be a search_tidyup() at
1234 the end of the subprocess.
1235
d7b47fd0
PH
1236PH/13 Previously, if "verify = helo" was set in an ACL, the condition was true
1237 only if the host matched helo_try_verify_hosts, which caused the
1238 verification to occur when the EHLO/HELO command was issued. The ACL just
1239 tested the remembered result. Now, if a previous verification attempt has
1240 not happened, "verify = helo" does it there and then.
1241
ee744174
JJ
1242JJ/01 exipick: added $message_exim_id variable (see 4.53-PH/04)
1243
b582ab87
PH
1244TK/03 Fix log output including CR from clamd.
1245
41a13e0a
PH
1246PH/14 A reference to $reply_address when Reply-to: was empty and From: did not
1247 exist provoked a memory error which could cause a segfault.
1248
f625cc5a
PH
1249PH/15 Installed PCRE 6.2
1250
1251PH/17 Defined BIND_8_COMPAT in the Darwin os.h file.
1252
21f7af35
PH
1253PH/18 Reversed 4.52/PH/17 because the HP-UX user found it wasn't the cause
1254 of the problem. Specifically, suggested +O2 rather than +O1 for the
1255 HP-UX compiler.
1256
31480e42
PH
1257PH/19 Added sqlite_lock_timeout option (David Woodhouse's patch).
1258
2d280592
PH
1259PH/20 If a delivery was routed to a non-standard port by means of an SRV
1260 record, the port was not correctly logged when the outgoing_port log
1261 selector was set (it logged the transort's default port).
1262
7cd1141b
PH
1263PH/21 Added support for host-specific ports to manualroute, queryprogram,
1264 fallback_hosts, and "hosts" in the smtp transport.
1265
1266PH/22 If the log selector "outgoing_port" is set, the port is now also given on
1267 host errors such as "Connection refused".
1268
750af86e
PH
1269PH/23 Applied a patch to fix problems with exim-4.52 while doing radius
1270 authentication with radiusclient 0.4.9:
1271
1272 - Error returned from rc_read_config was caught wrongly
1273 - Username/password not passed on to radius server due to wrong length.
1274
1275 The presumption is that some radiusclient API changes for 4.51/PH/17
1276 were not taken care of correctly. The code is still untested by me (my
1277 Linux distribution still has 0.3.2 of radiusclient), but it was
1278 contributed by a Radius user.
1279
1280PH/24 When doing a callout, the value of $domain wasn't set correctly when
1281 expanding the "port" option of the smtp transport.
1282
4304270b
TK
1283TK/04 MIME ACL: Fix buffer underrun that occurs when EOF condition is met
1284 while reading a MIME header. Thanks to Tom Hughes for a patch.
1285
750af86e
PH
1286PH/24 Include config.h inside local_scan.h so that configuration settings are
1287 available.
1288
64ffc24f
PH
1289PH/25 Make $smtp_command_argument available after all SMTP commands. This means
1290 that in an ACL for RCPT (for example), you can examine exactly what was
1291 received.
1292
5dd9625b
PH
1293PH/26 Exim was recognizing IPv6 addresses of the form [IPv6:....] in EHLO
1294 commands, but it was not correctly comparing the address with the actual
1295 client host address. Thus, it would show the EHLO address in Received:
1296 header lines when this was not necessary.
1297
5591031b
PH
1298PH/27 Added the % operator to ${eval:}.
1299
ba18e66a
PH
1300PH/28 Exim tries to create and chdir to its spool directory when it starts;
1301 it should be ignoring failures (because with -C, for example, it has lost
1302 privilege). It wasn't ignoring creation failures other than "already
1303 exists".
1304
9cec981f
PH
1305PH/29 Added "crypteq" to the list of supported features that Exim outputs when
1306 -bV or -d is used.
1307
aa2b5c79
PH
1308PH/30 Fixed (presumably very longstanding) bug in exim_dbmbuild: if it failed
1309 because an input line was too long, either on its own, or by virtue of
1509d3a8
PH
1310 too many continuations, the temporary file was not being removed, and the
1311 return code was incorrect.
aa2b5c79 1312
48a53b7f
PH
1313PH/31 Missing "BOOL" in function definition in filtertest.c.
1314
1c59d63b
PH
1315PH/32 Applied Sieve patches from the maintainer.
1316
671012da
TK
1317TK/05 Domainkeys: Accomodate for a minor API change in libdomainkeys 0.67.
1318
1509d3a8
PH
1319PH/33 Added "verify = not_blind".
1320
1321PH/34 There are settings for CHOWN_COMMAND and MV_COMMAND that can be used in
1322 Local/Makefile (with some defaults set). These are used in built scripts
1323 such as exicyclog, but they have never been used in the exim_install
1324 script (though there are many overriding facilities there). I have
1325 arranged that the exim_install script now takes note of these two
1326 settings.
1327
1328PH/35 Installed configuration files for Dragonfly.
1329
2fe1a124
PH
1330PH/36 When a locally submitted message by a trusted user did not contain a
1331 From: header, and the sender address was obtained from -f or from an SMTP
1332 MAIL command, and the trusted user did not use -F to supply a sender
1333 name, $originator_name was incorrectly used when constructing a From:
1334 header. Furthermore, $originator_name was used for submission mode
1335 messages from external hosts without From: headers in a similar way,
1336 which is clearly wrong.
1337
8800895a
PH
1338PH/37 Added control=suppress_local_fixups.
1339
ccfdb010
PH
1340PH/38 When log_selector = +received_sender was set, and the addition of the
1341 sender made the log line's construction buffer exactly full, or one byte
1342 less than full, an overflow happened when the terminating "\n" was
1343 subsequently added.
1344
1130bfb0
PH
1345PH/39 Added a new log selector, "unknown_in_list", which provokes a log entry
1346 when the result of a list match is failure because a DNS lookup failed.
1347
ebcb507f
PH
1348PH/40 RM_COMMAND is now used in the building process.
1349
c35e155c
PH
1350PH/41 Added a "distclean" target to the top-level Makefile; it deletes all
1351 the "build-* directories that it finds.
1352
95d1f782
PH
1353PH/42 (But a TF fix): In a domain list, Exim incorrectly matched @[] if the IP
1354 address in a domain literal was a prefix of an interface address.
1355
fd6de02e
PH
1356PH/43 (Again a TF fix): In the dnslookup router, do not apply widen_domains
1357 when verifying a sender address, unless rewrite_headers is false.
1358
58de37c5
PH
1359PH/44 Wrote a long comment about why errors_to addresses are verified as
1360 recipients, not senders.
1361
261cf466
TF
1362TF/01 Add missing LIBS=-lm to OS/Makefile-OpenBSD which was overlooked when
1363 the ratelimit ACL was added.
1364
3ee512ff
PH
1365PH/45 Added $smtp_command for the full command (cf $smtp_command_argument).
1366
e08c430f
PH
1367PH/46 Added extra information about PostgreSQL errors to the error string.
1368
bef5a11f
PH
1369PH/47 Added an interface to a fake DNS resolver for use by the new test suite,
1370 avoiding the need to install special zones in a real server. This is
1371 backwards compatible; if it can't find the fake resolver, it drops back.
1372 Thus, both old and new test suites can be run.
1373
7546de58
TF
1374TF/02 Added util/ratelimit.pl
1375
e5d5a95f
TF
1376TF/03 Minor fix to the ratelimit code to improve its behaviour in case the
1377 clock is set back in time.
1378
2e88a017
TF
1379TF/04 Fix the ratelimit support in exim_fixdb. Patch provided by Brian
1380 Candler <B.Candler@pobox.com>.
1381
a5f65aa4
TF
1382TF/05 The fix for PH/43 was not completely correct; widen_domains is always
1383 OK for addresses that are the result of redirections.
1384
e7726cbf
PH
1385PH/48 A number of further additions for the benefit of the new test suite,
1386 including a fake gethostbyname() that interfaces to the fake DNS resolver
1387 (see PH/47 above).
1388
a7fdad5b
TF
1389TF/06 The fix for widen_domains has also been applied to qualify_single and
1390 search_parents which are the other dnslookup options that can cause
1391 header rewrites.
1392
6af56900
PH
1393PH/49 Michael Haardt's randomized retrying, but as a separate retry parameter
1394 type ("H").
1395
0925ede6
PH
1396PH/50 Make never_users, trusted_users, admin_groups, trusted_groups expandable.
1397
66afa403
TF
1398TF/07 Exim produced the error message "an SRV record indicated no SMTP
1399 service" if it encountered an MX record with an empty target hostname.
1400 The message is now "an MX or SRV record indicated no SMTP service".
1401
0154e85a
TF
1402TF/08 Change PH/13 introduced the possibility that verify=helo may defer,
1403 if the DNS of the sending site is misconfigured. This is quite a
1404 common situation. This change restores the behaviour of treating a
1405 helo verification defer as a failure.
1406
16f12c76
PH
1407PH/51 If self=fail was set on a router, the bounce message did not include the
1408 actual error message.
1409
bbe902f0 1410
e5a9dba6
PH
1411Exim version 4.52
1412-----------------
1413
1414TF/01 Added support for Client SMTP Authorization. See NewStuff for details.
1415
22c3b60b
PH
1416PH/01 When a transport filter timed out in a pipe delivery, and the pipe
1417 command itself ended in error, the underlying message about the transport
1418 filter timeout was being overwritten with the pipe command error. Now the
1419 underlying error message should be appended to the second error message.
1420
06a9b4b5
PH
1421TK/01 Fix poll() being unavailable on Mac OSX 10.2.
1422
c1ac6996
PH
1423PH/02 Reduce the amount of output that "make" produces by default. Full output
1424 can still be requested.
1425
9c7a242c
PH
1426PH/03 The warning log line about a condition test deferring for a "warn" verb
1427 was being output only once per connection, rather than after each
1428 occurrence (because it was using the same function as for successful
1429 "warn" verbs). This seems wrong, so I have changed it.
1430
87ba3f5f
PH
1431TF/02 Two buglets in acl.c which caused Exim to read a few bytes of memory that
1432 it should not have, which might have caused a crash in the right
1433 circumstances, but probably never did.
1434
1435PH/04 Installed a modified version of Tony Finch's patch to make submission
1436 mode fix the return path as well as the Sender: header line, and to
1437 add a /name= option so that you can make the user's friendly name appear
1438 in the header line.
1439
29aba418
TF
1440TF/03 Added the control = fakedefer ACL modifier.
1441
fe0dab11
TF
1442TF/04 Added the ratelimit ACL condition. See NewStuff for details. Thanks to
1443 Mark Lowes for thorough testing.
870f6ba8 1444
11d337a4
TK
1445TK/02 Rewrote SPF support to work with libspf2 versions >1.2.0.
1446
1447TK/03 Merged latest SRS patch from Miles Wilton.
1448
415c8f3b
PH
1449PH/05 There's a shambles in IRIX6 - it defines EX_OK in unistd.h which conflicts
1450 with the definition in sysexits.h (which is #included earlier).
1451 Fortunately, Exim does not actually use EX_OK. The code used to try to
1452 preserve the sysexits.h value, by assumimg that macro definitions were
1453 scanned for macro replacements. I have been disabused of this notion,
1454 so now the code just undefines EX_OK before #including unistd.h.
11d337a4 1455
958541e9
PH
1456PH/06 There is a timeout for writing blocks of data, set by, e.g. data_timeout
1457 in the smtp transport. When a block could not be written in a single
1458 write() function, the timeout was being re-applied to each part-write.
1459 This seems wrong - if the receiver was accepting one byte at a time it
1460 would take for ever. The timeout is now adjusted when this happens. It
1461 doesn't have to be particularly precise.
1462
c206415f
TK
1463TK/04 Added simple SPF lookup method in EXPERIMENTAL_SPF. See NewStuff for
1464 details. Thanks to Chris Webb <chris@arachsys.com> for the patch!
1465
2a4be8f9
PH
1466PH/07 Added "fullpostmaster" verify option, which does a check to <postmaster>
1467 without a domain if the check to <postmaster@domain> fails.
1468
1cba11c5
SC
1469SC/01 Eximstats: added -xls and the ability to specify output files
1470 (patch written by Frank Heydlauf).
1471
1472SC/02 Eximstats: use FileHandles for outputing results.
1473
1474SC/03 Eximstats: allow any combination of xls, txt, and html output.
1475
1476SC/04 Eximstats: fixed display of large numbers with -nvr option
1477
1478SC/05 Eximstats: fixed merging of reports with empty tables.
1479
1480SC/06 Eximstats: added the -include_original_destination flag
1481
1482SC/07 Eximstats: removed tabs and trailing whitespace.
1483
1005d00e
TK
1484TK/05 Malware: Improve on aveserver error handling. Patch from Alex Miller.
1485
1486TK/06 MBOX spool code: Add real "From " MBOX separator line
1487 so the .eml file is really in mbox format (even though
1488 most programs do not really care). Patch from Alex Miller.
1489
1490TK/07 MBOX spool code: Add X-Envelope-From: and X-Envelope-To: headers.
1491 The latter is generated from $received_to and is only set if the
1492 message has one envelope recipient. SA can use these headers,
1493 obviously out-of-the-box. Patch from Alex Miller.
1494
9b4768fa
PH
1495PH/08 The ${def test on a variable was returning false if the variable's
1496 value was "0", contrary to what the specification has always said!
1497 The result should be true unless the variable is empty.
1498
1499PH/09 The syntax error of a character other than { following "${if
1500 def:variable_name" (after optional whitespace) was not being diagnosed.
1501 An expansion such as ${if def:sender_ident:{xxx}{yyy}} in which an
1502 accidental colon was present, for example, could give incorrect results.
1503
0d7eb84a
PH
1504PH/10 Tidied the code in a number of places where the st_size field of a stat()
1505 result is used (not including appendfile, where other changes are about
1506 to be made).
1507
1508PH/11 Upgraded appendfile so that quotas larger than 2G are now supported.
1509 This involved changing a lot of size variables from int to off_t. It
1510 should work with maildirs and everything.
1511
40727bee
TK
1512TK/08 Apply fix provided by Michael Haardt to prevent deadlock in case of
1513 spamd dying while we are connected to it.
1514
554d2369
TF
1515TF/05 Fixed a ${extract error message typo reported by Jeremy Harris
1516 <jgh@wizmail.org>
1517
1f922db1
PH
1518PH/12 Applied Alex Kiernan's patch for the API change for the error callback
1519 function for BDB 4.3.
1520
ef213c3b
PH
1521PH/13 Changed auto_thaw such that it does not apply to bounce messages.
1522
8ac170f3
PH
1523PH/14 Imported PCRE 6.0; this was more than just a trivial operation because
1524 the sources for PCRE have been re-arranged and more files are now
1525 involved.
1526
b1c749bb
PH
1527PH/15 The code I had for printing potentially long long variables in PH/11
1528 above was not the best (it lost precision). The length of off_t variables
1529 is now inspected at build time, and an appropriate printing format (%ld
c6c2dc1d
PH
1530 or %lld) is chosen and #defined by OFF_T_FMT. We also define LONGLONG_T
1531 to be "long long int" or "long int". This is needed for the internal
1532 formatting function string_vformat().
b1c749bb 1533
4aac9b49
PH
1534PH/16 Applied Matthew Newton's patch to exicyclog: "If log_file_path is set in
1535 the configuration file to be ":syslog", then the script "guesses" where
1536 the logs files are, rather than using the compiled in default. In our
1537 case the guess is not the same as the compiled default, so the script
1538 suddenly stopped working when I started to use syslog. The patch checks
1539 to see if log_file_path is "". If so, it attempts to read it from exim
1540 with no configuration file to get the compiled in version, before it
1541 falls back to the previous guessing code."
1542
294520c8
TK
1543TK/09 Added "prvs" and "prvscheck" expansion items. These help a lot with
1544 implementing BATV in an Exim configuration. See NewStuff for the gory
1545 details.
1546
5bd022fe
PH
1547PH/17 Applied Michael Haardt's patch for HP-UX, affecting only the os.h and
1548 Makefile that are specific to HP-UX.
1549
90e9ce59
PH
1550PH/18 If the "use_postmaster" option was set for a recipient callout together
1551 with the "random" option, the postmaster address was used as the MAIL
1552 FROM address for the random test, but not for the subsequent recipient
1553 test. It is now used for both.
1554
5ea81592
PH
1555PH/19 Applied Michael Haardt's patch to update Sieve to RFC3028bis. "The
1556 patch removes a few documentation additions to RFC 3028, because the
1557 latest draft now contains them. It adds the new en;ascii-case comparator
1558 and a new error check for 8bit text in MIME parts. Comparator and
1559 require names are now matched exactly. I enabled the subaddress
1560 extension, but it is not well tested yet (read: it works for me)."
1561
c6c2dc1d
PH
1562PH/20 Added macros for time_t as for off_t (see PH/15 above) and used them to
1563 rework some of the code of TK/09 above to avoid the hardwired use of
1564 "%lld" and "long long". Replaced the call to snprintf() with a call to
1565 string_vformat().
1566
fffffe4c
PH
1567PH/21 Added some other messages to those in 4.51/PH/42, namely "All relevant MX
1568 records point to non-existent hosts", "retry timeout exceeded", and
1569 "retry time not reached for any host after a long failure period".
ca02eafb 1570
9a26b6b2
PH
1571PH/22 Fixed some oversights/typos causing bugs when Exim is compiled with
1572 experimental DomainKeys support:
1573
1574 (1) The filter variables $n0-$n9 and $sn0-$sn9 were broken.
1575 (2) On an error such as an illegally used "control", the wrong name for
1576 the control was given.
1577
1578 These problems did NOT occur unless DomainKeys support was compiled.
1579
4aee0225
PH
1580PH/23 Added daemon_startup_retries and daemon_startup_sleep.
1581
32d668a5
PH
1582PH/24 Added ${if match_ip condition.
1583
8187c3f3
PH
1584PH/25 Put debug statements on either side of calls to EXIM_DBOPEN() for hints
1585 databases so that it will be absolutely obvious if a crash occurs in the
1586 DB library. This is a regular occurrence (often caused by mis-matched
1587 db.h files).
1588
ff790e47 1589PH/26 Insert a lot of missing (void) casts for functions such as chown(),
f1e894f3
PH
1590 chmod(), fcntl(), sscanf(), and other functions from stdio.h. These were
1591 picked up on a user's system that detects such things. There doesn't seem
1592 to be a gcc warning option for this - only an attribute that has to be
1593 put on the function's prototype. It seems that in Fedora Core 4 they have
1594 set this on a number of new functions. No doubt there will be more in due
1595 course.
ff790e47 1596
5417f6d1
PH
1597PH/27 If a dnslookup or manualroute router is set with verify=only, it need not
1598 specify a transport. However, if an address that was verified by such a
1599 router was the subject of a callout, Exim crashed because it tried to
1600 read the rcpt_include_affixes from the non-existent transport. Now it
1601 just assumes that the setting of that option is false. This bug was
1602 introduced by 4.51/PH/31.
1603
59cf8544
PH
1604PH/28 Changed -d+all to exclude +memory, because that information is very
1605 rarely of interest, but it makes the output a lot bigger. People tend to
1606 do -d+all out of habit.
1607
e7ad8a65
PH
1608PH/29 Removed support for the Linux-libc5 build, as it is obsolete and the
1609 code in os-type was giving problems when libc.so lives in lib64, like on
1610 x86_64 Fedora Core.
1611
ade42478
PH
1612PH/30 Exim's DNS code uses the original T_xxx names for DNS record times. These
1613 aren't the modern standard, and it seems that some systems' include files
1614 don't always have them. Exim was already checking for some of the newer
1615 ones like T_AAAA, and defining it itself. I've added checks for all the
1616 record types that Exim uses.
1617
182ad5cf
PH
1618PH/31 When using GnuTLS, if the parameters cache file did not exist, Exim was
1619 not automatically generating a new one, as it is supposed to. This
1620 prevented TLS from working. If the file did exist, but contained invalid
1621 data, a new version was generated, as expected. It was only the case of a
1622 non-existent file that was broken.
1623
b0d9fc80
TK
1624TK/10 Domainkeys: Fix a bug in verification that caused a crash in conjunction
1625 with a change in libdomainkeys > 0.64.
1626
1627TK/11 Domainkeys: Change the logic how the "testing" policy flag is retrieved
1628 from DNS. If the selector record carries the flag, it now has
1629 precedence over the domain-wide flag.
1630
1631TK/12 Cleared some compiler warnings related to SPF, SRS and DK code.
1632
47c7a64a
PH
1633PH/32 In mua_wrapper mode, if an smtp transport configuration error (such as
1634 the use of a port name that isn't defined in /etc/services) occurred, the
1635 message was deferred as in a normal delivery, and thus remained on the
1636 spool, instead of being failed because of the mua_wrapper setting. This
1637 is now fixed, and I tidied up some of the mua_wrapper messages at the
1638 same time.
1639
a388bce4
SC
1640SC/08 Eximstats: whilst parsing the mainlog(s), store information about
1641 the messages in a hash of arrays rather than using individual hashes.
1642 This is a bit cleaner and results in dramatic memory savings, albeit
1643 at a slight CPU cost.
1644
1645SC/09 Eximstats: added the -show_rt<list> and the -show_dt<list> flags
1646 as requested by Marc Sherman.
1647
1648SC/10 Eximstats: added histograms for user specified patterns as requested
1649 by Marc Sherman.
1650
0793e4ed
SC
1651SC/11 Eximstats: v1.43 - bugfix for pattern histograms with -h0 specified.
1652
c58b88df
PH
1653PH/33 Patch from the Cygwin maintainer to add "b" to all occurences of
1654 fopen() in the content-scanning modules that did not already have it.
1655
e7ad8a65 1656
7982096b
PH
1657Exim version 4.51
1658-----------------
1659
1a46a8c5
PH
1660TK/01 Added Yahoo DomainKeys support via libdomainkeys. See
1661 doc/experimental-spec.txt for details. (http://domainkeys.sf.net)
1662
2f079f46 1663TK/02 Fix ACL "control" statement not being available in MIME ACL.
1a46a8c5
PH
1664
1665TK/03 Fix ACL "regex" condition not being available in MIME ACL.
1666
1667PH/01 Installed a patch from the Sieve maintainer that allows -bf to be used
1668 to test Sieve filters that use "vacation".
1669
1670PH/02 Installed a slightly modified version of Nikos Mavrogiannopoulos' patch
1671 that changes the way the GnuTLS parameters are stored in the cache file.
1672 The new format can be generated externally. For backward compatibility,
1673 if the data in the cache doesn't make sense, Exim assumes it has read an
1674 old-format file, and it generates new data and writes a new file. This
1675 means that you can't go back to an older release without removing the
1676 file.
1677
1678PH/03 A redirect router that has both "unseen" and "one_time" set does not
1679 work if there are any delivery delays because "one_time" forces the
1680 parent to be marked "delivered", so its unseen clone is never tried
1681 again. For this reason, Exim now forbids the simultaneous setting of
1682 these two options.
1683
1684PH/04 Change 4.11/85 fixed an obscure bug concerned with addresses that are
1685 redirected to themselves ("homonym" addresses). Read the long ChangeLog
1686 entry if you want to know the details. The fix, however, neglected to
1687 consider the case when local delivery batching is involved. The test for
1688 "previously delivered" was not happening when checking to see if an
1689 address could be batched with a previous (undelivered) one; under
1690 certain circumstances this could lead to multiple deliveries to the same
c2c19e9d 1691 address.
1a46a8c5
PH
1692
1693PH/05 Renamed the macro SOCKLEN_T as EXIM_SOCKLEN_T because AIX uses SOCKLEN_T
1694 in its include files, and this causes problems building Exim.
1695
1696PH/06 A number of "verify =" ACL conditions have no options (e.g. verify =
1697 header_syntax) but Exim was just ignoring anything given after a slash.
1698 In particular, this caused confusion with an attempt to use "verify =
1699 reverse_host_lookup/defer_ok". An error is now given when options are
1700 supplied for verify items that do not have them. (Maybe reverse_host_
1701 lookup should have a defer_ok option, but that's a different point.)
1702
1703PH/07 Increase the size of the buffer for incoming SMTP commands from 512 (as
1704 defined by RFC 821) to 2048, because there were problems with some AUTH
1705 commands, and RFC 1869 says the size should be increased for extended
1706 SMTP commands that take arguments.
1707
1708PH/08 Added ${dlfunc dynamically loaded function for expansion (code from Tony
1709 Finch).
1710
1711PH/09 Previously, an attempt to use ${perl when it wasn't compiled gave an
1712 "unknown" error; now it says that the functionality isn't in the binary.
8d67ada3 1713
49c2d5ea
PH
1714PH/10 Added a nasty fudge to try to recognize and flatten LDAP passwords in
1715 an address' error message when a string expansion fails (syntax or
f331f3b6
PH
1716 whatever). Otherwise the password may appear in the log. Following change
1717 PH/42 below, there is no longer a chance of it appearing in a bounce
1718 message.
49c2d5ea 1719
bf759a8b
PH
1720PH/11 Installed exipick version 20050225.0 from John Jetmore.
1721
83364d30
PH
1722PH/12 If the last host in a fallback_hosts list was multihomed, only the first
1723 of its addresses was ever tried. (Bugzilla bug #2.)
1724
7999bbd7
PH
1725PH/13 If "headers_add" in a transport didn't end in a newline, Exim printed
1726 the result incorrectly in the debug output. (It correctly added a newline
1727 to what was transported.)
1728
7dbf77c9
PH
1729TF/01 Added $received_time.
1730
74e0617f
PH
1731PH/14 Modified the default configuration to add an acl_smtp_data ACL, with
1732 commented out examples of how to interface to a virus scanner and to
1733 SpamAssassin. Also added commented examples of av_scanner and
1734 spamd_address settings.
1735
2f079f46
PH
1736PH/15 Further to TK/02 and TK/03 above, tidied up the tables of what conditions
1737 and controls are allowed in which ACLs. There were a couple of minor
1738 errors. Some of the entries in the conditions table (which is a table of
1739 where they are NOT allowed) were getting very unwieldy; rewrote them as a
1740 negation of where the condition IS allowed.
1741
8c841523
PH
1742PH/16 Installed updated OS/os.c-cygwin from the Cygwin maintainer.
1743
7766a4f0
PH
1744PH/17 The API for radiusclient changed at release 0.4.0. Unfortunately, the
1745 header file does not have a version number, so I've had to invent a new
1746 value for RADIUS_LIB_TYPE, namely "RADIUSCLIENTNEW" to request the new
1747 API. The code is untested by me (my Linux distribution still has 0.3.2 of
1748 radiusclient), but it was contributed by a Radius user.
1749
8b417f2c
PH
1750PH/18 Installed Lars Mainka's patch for the support of CRL collections in
1751 files or directories, for OpenSSL.
1752
901f42cb
PH
1753PH/19 When an Exim process that is running as root has to create an Exim log
1754 file, it does so in a subprocess that runs as exim:exim so as to get the
1755 ownership right at creation (otherwise, other Exim processes might see
1756 the file with the wrong ownership). There was no test for failure of this
1757 fork() call, which would lead to the process getting stuck as it waited
1758 for a non-existent subprocess. Forks do occasionally fail when resources
1759 run out. I reviewed all the other calls to fork(); they all seem to check
1760 for failure.
1761
f9b9210e
PH
1762PH/20 When checking for unexpected SMTP input at connect time (before writing
1763 the banner), Exim was not dealing correctly with a non-positive return
1764 from the read() function. If the client had disconnected by this time,
1765 the result was a log entry for a synchronization error with an empty
1766 string after "input=" when read() returned zero. If read() returned -1
1767 (an event I could not check), uninitialized data bytes were printed.
1768 There were reports of junk text (parts of files, etc) appearing after
1769 "input=".
1770
54cdb463
PH
1771PH/21 Added acl_not_smtp_mime to allow for MIME scanning for non-SMTP messages.
1772
cf00dad6
PH
1773PH/22 Added support for macro redefinition, and (re)definition in between
1774 driver and ACL definitions.
1775
acb1b346
PH
1776PH/23 The cyrus_sasl authenticator was expanding server_hostname, but then
1777 forgetting to use the resulting value; it was using the unexpanded value.
1778
c5ddb310
PH
1779PH/24 The cyrus_sasl authenticator was advertising mechanisms for which it
1780 hadn't been configured. The fix is from Juergen Kreileder, who
1781 understands it better than I do:
1782
1783 "Here's what I see happening with three configured cyrus_sasl
1784 authenticators configured (plain, login, cram-md5):
1785
1786 On startup auth_cyrus_sasl_init() gets called for each of these.
1787 This means three calls to sasl_listmech() without a specified mech_list.
1788 => SASL tests which mechs of all available mechs actually work
1789 => three warnings about OTP not working
1790 => the returned list contains: plain, login, cram-md5, digest-md5, ...
1791
1792 With the patch, sasl_listmech() also gets called three times. But now
1793 SASL's mech_list option is set to the server_mech specified in the the
1794 authenticator. Or in other words, the answer from sasl_listmech()
1795 gets limited to just the mech you're testing for (which is different
1796 for each call.)
1797 => the return list contains just 'plain' or 'login', 'cram-md5' or
1798 nothing depending on the value of ob->server_mech.
1799
1800 I've just tested the patch: Authentication still works fine,
1801 unavailable mechs specified in the exim configuration are still
1802 caught, and the auth.log warnings about OTP are gone."
1803
31619da6
PH
1804PH/25 When debugging is enabled, the contents of the command line are added
1805 to the debugging output, even when log_selector=+arguments is not
1806 specified.
1807
bebaf0fc
PH
1808PH/26 Change scripts/os-type so that when "uname -s" returns just "GNU", the
1809 answer is "GNU", and only if the return is "GNU/something" is the answer
1810 "Linux".
1811
475fe28a
PH
1812PH/27 $acl_verify_message is now set immediately after the failure of a
1813 verification in an ACL, and so is available in subsequent modifiers. In
1814 particular, the message can be preserved by coding like this:
1815
1816 warn !verify = sender
1817 set acl_m0 = $acl_verify_message
1818
1819 Previously, $acl_verify_message was set only while expanding "message"
1820 and "log_message" when a very denied access.
1821
7e8bec7a
PH
1822PH/28 Modified OS/os.c-Linux with
1823
1824 -#ifndef OS_LOAD_AVERAGE
1825 +#if !defined(OS_LOAD_AVERAGE) && defined(__linux__)
1826
1827 to make Exim compile on kfreebsd-gnu. (I'm totally confused about the
1828 nomenclature these days.)
1829
e4a89c47
PH
1830PH/29 Installed patch from the Sieve maintainer that adds the options
1831 sieve_useraddress and sieve_subaddress to the redirect router.
1832
5ca2a9a1
PH
1833PH/30 In these circumstances:
1834 . Two addresses routed to the same list of hosts;
1835 . First host does not offer TLS;
1836 . First host accepts first address;
1837 . First host gives temporary error to second address;
1838 . Second host offers TLS and a TLS session is established;
1839 . Second host accepts second address.
1840 Exim incorrectly logged both deliveries with the TLS parameters (cipher
1841 and peerdn, if requested) that were in fact used only for the second
1842 address.
7e8bec7a 1843
c688b954
PH
1844PH/31 When doing a callout as part of verifying an address, Exim was not paying
1845 attention to any local part prefix or suffix that was matched by the
1846 router that accepted the address. It now behaves in the same way as it
1847 does for delivery: the affixes are removed from the local part unless
1848 rcpt_include_affixes is set on the transport.
1849
fed77020
PH
1850PH/32 Add the sender address, as F=<...>, to the log line when logging a
1851 timeout during the DATA phase of an incoming message.
1852
7fe1560f
PH
1853PH/33 Sieve envelope tests were broken for match types other than :is. I have
1854 applied a patch sanctioned by the Sieve maintainer.
c688b954 1855
ebb6e6d5
PH
1856PH/34 Change 4.50/80 broke Exim in that it could no longer handle cases where
1857 the uid or gid is negative. A case of a negative gid caused this to be
1858 noticed. The fix allows for either to be negative.
1859
9c4e8f60
PH
1860PH/35 ACL_WHERE_MIME is now declared unconditionally, to avoid too much code
1861 clutter, but the tables that are indexed by ACL_WHERE_xxx values had been
1862 overlooked.
1863
1864PH/36 The change PH/12 above was broken. Fixed it.
1865
d7174846
PH
1866PH/37 Exim used to check for duplicate addresses in the middle of routing, on
1867 the grounds that routing the same address twice would always produce the
1868 same answer. This might have been true once, but it is certainly no
1869 longer true now. Routing a child address may depend on the previous
1870 routing that produced that child. Some complicated redirection strategies
1871 went wrong when messages had multiple recipients, and made Exim's
1872 behaviour dependent on the order in which the addresses were given.
1873
1874 I have moved the duplicate checking until after the routing is complete.
1875 Exim scans the addresses that are assigned to local and remote
1876 transports, and removes any duplicates. This means that more work will be
1877 done, as duplicates will always all be routed, but duplicates are
1878 presumably rare, so I don't expect this is of any significance.
1879
1880 For deliveries to pipes, files, and autoreplies, the duplicate checking
1881 still happens during the routing process, since they are not going to be
1882 routed further.
1883
cfe75fc3
PH
1884PH/38 Installed a patch from Ian Freislich, with the agreement of Tom Kistner.
1885 It corrects a timeout issue with spamd. This is Ian's comment: "The
1886 background is that sometimes spamd either never reads data from a
1887 connection it has accepted, or it never writes response data. The exiscan
1888 spam.[ch] uses a 3600 second timeout on spamd socket reads, further, it
1889 blindly assumes that writes won't block so it may never time out."
1890
be22d70e
PH
1891PH/39 Allow G after quota size as well as K and M.
1892
0612b098
PH
1893PH/40 The value set for $authenticated_id in an authenticator may not contain
1894 binary zeroes or newlines because the value is written to log lines and
1895 to spool files. There was no check on this. Now the value is run through
1896 the string_printing() function so that such characters are converted to
1897 printable escape sequences.
1898
2e0c1448
PH
1899PH/41 $message_linecount is a new variable that contains the total number of
1900 lines in the message. Compare $body_linecount, which is the count for the
1901 body only.
1902
447d236c
PH
1903PH/42 Exim no longer gives details of delivery errors for specific addresses in
1904 bounce and delay warning messages, except in certain special cases, which
1905 are as follows:
1906
1907 (a) An SMTP error message from a remote host;
1908 (b) A message specified in a :fail: redirection;
1909 (c) A message specified in a "fail" command in a system filter;
1910 (d) A message specified in a FAIL return from the queryprogram router;
1911 (e) A message specified by the cannot_route_message router option.
1912
1913 In these cases only, Exim does include the error details in bounce and
1914 warning messages. There are also a few cases where bland messages such
1915 as "unrouteable address" or "local delivery error" are given.
1916
d20976dc
PH
1917PH/43 $value is now also set for the "else" part of a ${run expansion.
1918
f656d135
PH
1919PH/44 Applied patch from the Sieve maintainer: "The vacation draft is still
1920 being worked on, but at least Exim now implements the latest version to
1921 play with."
1922
2e2a30b4
PH
1923PH/45 In a pipe transport, although a timeout while waiting for the pipe
1924 process to complete was treated as a delivery failure, a timeout while
1925 writing the message to the pipe was logged, but erroneously treated as a
1926 successful delivery. Such timeouts include transport filter timeouts. For
1927 consistency with the overall process timeout, these timeouts are now
1928 treated as errors, giving rise to delivery failures by default. However,
1929 there is now a new Boolean option for the pipe transport called
1930 timeout_defer, which, if set TRUE, converts the failures into defers for
1931 both kinds of timeout. A transport filter timeout is now identified in
1932 the log output.
1933
9176e9f0
PH
1934PH/46 The "scripts/Configure-config.h" script calls "make" at one point. On
1935 systems where "make" and "gmake" are different, calling "gmake" at top
1936 level broke things. I've arranged for the value of $(MAKE) to be passed
1937 from the Makefile to this script so that it can call the same version of
1938 "make".
1939
7982096b 1940
bbe902f0
PH
1941A note about Exim versions 4.44 and 4.50
1942----------------------------------------
1943
1944Exim 4.50 was meant to be the next release after 4.43. It contains a lot of
1945changes of various kinds. As a consequence, a big documentation update was
1946needed. This delayed the release for rather longer than seemed good, especially
1947in the light of a couple of (minor) security issues. Therefore, the changes
1948that fixed bugs were backported into 4.43, to create a 4.44 maintenance
1949release. So 4.44 and 4.50 are in effect two different branches that both start
1950from 4.43.
1951
1952I have left the 4.50 change log unchanged; it contains all the changes since
19534.43. The change log for 4.44 is below; many of its items are identical to
1954those for 4.50. This seems to be the most sensible way to preserve the
1955historical information.
1956
1957
f7b63901 1958Exim version 4.50
495ae4b0
PH
1959-----------------
1960
5fe762f6
PH
1961 1. Minor wording change to the doc/README.SIEVE file.
1962
139059f6 1963 2. Change 4.43/35 introduced a bug: if quota_filecount was set, the
5fe762f6 1964 computation of the current number of files was incorrect.
495ae4b0 1965
7086e875
PH
1966 3. Closing a stable door: arrange to panic-die if setitimer() ever fails. The
1967 bug fixed in 4.43/37 would have been diagnosed quickly if this had been in
1968 place.
1969
35af9f61
PH
1970 4. Give more explanation in the error message when the command for a transport
1971 filter fails to execute.
1972
b668c215
PH
1973 5. There are several places where Exim runs a non-Exim command in a
1974 subprocess. The SIGUSR1 signal should be disabled for these processes. This
1975 was being done only for the command run by the queryprogram router. It is
1976 now done for all such subprocesses. The other cases are: ${run, transport
1977 filters, and the commands run by the lmtp and pipe transports.
1978
a494b1e1
PH
1979 6. Added CONFIGURE_GROUP build-time option.
1980
1981 7. Some older OS have a limit of 256 on the maximum number of file
1982 descriptors. Exim was using setrlimit() to set 1000 as a large value
1983 unlikely to be exceeded. Change 4.43/17 caused a lot of logging on these
1984 systems. I've change it so that if it can't get 1000, it tries for 256.
35edf2ff 1985
c5fcb476
PH
1986 8. "control=submission" was allowed, but had no effect, in a DATA ACL. This
1987 was an oversight, and furthermore, ever since the addition of extra
1988 controls (e.g. 4.43/32), the checks on when to allow different forms of
1989 "control" were broken. There should now be diagnostics for all cases when a
1990 control that does not make sense is encountered.
1991
69358f02
PH
1992 9. Added the /retain_sender option to "control=submission".
1993
5be20824
PH
199410. $recipients is now available in the predata ACL (oversight).
1995
eb2c0248
PH
199611. Tidy the search cache before the fork to do a delivery from a message
1997 received from the command line. Otherwise the child will trigger a lookup
1998 failure and thereby defer the delivery if it tries to use (for example) a
1999 cached ldap connection that the parent has called unbind on.
2000
2a3eea10
PH
200112. If verify=recipient was followed by verify=sender in a RCPT ACL, the value
2002 of $address_data from the recipient verification was clobbered by the
2003 sender verification.
2004
200513. The value of address_data from a sender verification is now available in
2006 $sender_address_data in subsequent conditions in the ACL statement.
2007
23c7ff99
PH
200814. Added forbid_sieve_filter and forbid_exim_filter to the redirect router.
2009
4deaf07d
PH
201015. Added a new option "connect=<time>" to callout options, to set a different
2011 connection timeout.
2012
926e1192
PH
201316. If FIXED_NEVER_USERS was defined, but empty, Exim was assuming the uid 0
2014 was its contents. (It was OK if the option was not defined at all.)
2015
650edc6f
PH
201617. A "Completed" log line is now written for messages that are removed from
2017 the spool by the -Mrm option.
2018
2c7db3f5
PH
201918. New variables $sender_verify_failure and $recipient_verify_failure contain
2020 information about exactly what failed.
2021
3d235903
PH
202219. Added -dd to debug only the daemon process.
2023
7c7ad977
PH
202420. Incorporated Michael Haardt's patch to ldap.c for improving the way it
2025 handles timeouts, both on the server side and network timeouts. Renamed the
2026 CONNECT parameter as NETTIMEOUT (but kept the old name for compatibility).
2027
981756db
PH
202821. The rare case of EHLO->STARTTLS->HELO was setting the protocol to "smtp".
2029 It is now set to "smtps".
2030
d4eb88df
PH
203122. $host_address is now set to the target address during the checking of
2032 ignore_target_hosts.
2033
203423. When checking ignore_target_hosts for an ipliteral router, no host name was
2035 being passed; this would have caused $sender_host_name to have been used if
2036 matching the list had actually called for a host name (not very likely,
2037 since this list is usually IP addresses). A host name is now passed as
2038 "[x.x.x.x]".
2039
7d468ab8
PH
204024. Changed the calls that set up the SIGCHLD handler in the daemon to use the
2041 code that specifies a non-restarting handler (typically sigaction() in
2042 modern systems) in an attempt to fix a rare and obscure crash bug.
2043
204425. Narrowed the window for a race in the daemon that could cause it to ignore
2045 SIGCHLD signals. This is not a major problem, because they are used only to
2046 wake it up if nothing else does.
2047
62c0818f
PH
204826. A malformed maildirsize file could cause Exim to calculate negative values
2049 for the mailbox size or file count. Odd effects could occur as a result.
2050 The maildirsize information is now recalculated if the size or filecount
2051 end up negative.
2052
26034054
PH
205327. Added HAVE_SYS_STATVFS_H to the os.h file for Linux, as it has had this
2054 support for a long time. Removed HAVE_SYS_VFS_H.
2055
af66f652
PH
205628. Installed the latest version of exipick from John Jetmore.
2057
90af77f4
PH
205829. In an address list, if the pattern was not a regular expression, an empty
2059 subject address (from a bounce message) matched only if the pattern was an
2060 empty string. Non-empty patterns were not even tested. This was the wrong
2061 because it is perfectly reasonable to use an empty address as part of a
2062 database query. An empty address is now tested by patterns that are
2063 lookups. However, all the other forms of pattern expect the subject to
2064 contain a local part and a domain, and therefore, for them, an empty
2065 address still always fails if the pattern is not itself empty.
2066
d8ef3577
PH
206730. Exim went into a mad DNS loop when attempting to do a callout where the
2068 host was specified on an smtp transport, and looking it up yielded more
2069 than one IP address.
2070
5cb8cbc6
PH
207131. Re-factored the code for checking spool and log partition space into a
2072 function that finds that data and another that does the check. The former
2073 is then used to implement four new variables: $spool_space, $log_space,
2074 $spool_inodes, and $log_inodes.
2075
14702f5b
PH
207632. The RFC2047 encoding function was originally intended for short strings
2077 such as real names; it was not keeping to the 75-character limit for
2078 encoded words that the RFC imposes. It now respects the limit, and
2079 generates multiple encoded words if necessary. To be on the safe side, I
2080 have increased the buffer size for the ${rfc2047: expansion operator from
2081 1024 to 2048 bytes.
2082
063b1e99
PH
208333. It is now permitted to omit both strings after an "if" condition; if the
2084 condition is true, the result is "true". As before, when the second string
2085 is omitted, a false condition yields an empty string. This makes it less
2086 cumbersome to write custom ACL and router conditions.
2087
652e1b65
PH
208834. Failure to deliver a bounce message always caused it to be frozen, even if
2089 there was an errors_to setting on the router. The errors_to setting is now
2090 respected.
2091
6f0c9a4f
PH
209235. If an IPv6 address is given for -bh or -bhc, it is now converted to the
2093 canonical form (fully expanded) before being placed in
2094 $sender_host_address.
2095
33397d19
PH
209636. The table in the code that translates DNS record types into text (T_A to
2097 "A" for instance) was missing entries for NS and CNAME. It is just possible
2098 that this could have caused confusion if both these types were looked up
2099 for the same domain, because the text type is used as part of Exim's
2100 per-process caching. But the chance of anyone hitting this buglet seems
2101 very small.
2102
7bb56e1f
PH
210337. The dnsdb lookup has been extended in a number of ways.
2104
2105 (1) There is a new type, "zns", which walks up the domain tree until it
2106 finds some nameserver records. It should be used with care.
2107
ea3bc19b
PH
2108 (2) There is a new type, "mxh", which is like "mx" except that it returns
2109 just the host names, not the priorities.
2110
2111 (3) It is now possible to give a list of domains (or IP addresses) to be
ff4dbb19
PH
2112 looked up. The behaviour when one of the lookups defers can be
2113 controlled by a keyword.
7bb56e1f 2114
ea3bc19b 2115 (4) It is now possible to specify the separator character for use when
7bb56e1f 2116 multiple records are returned.
33397d19 2117
0bcb2a0e
PH
211838. The dnslists ACL condition has been extended: it is now possible to supply
2119 a list of IP addresses and/or domains to be looked up in a particular DNS
2120 domain.
2121
2ac0e484
PH
212239. Added log_selector=+queue_time_overall.
2123
4e1fde53
PH
212440. When running the queue in the test harness, wait just a tad after forking a
2125 delivery process, to get repeatability of debugging output.
2126
de365ded
PH
212741. Include certificate and key file names in error message when GnuTLS fails
2128 to set them up, because the GnuTLS error message doesn't include the name
2129 of the failing file when there is a problem reading it.
2130
f05da2e8
PH
213142. Allow both -bf and -bF in the same test run.
2132
d6453af2
PH
213343. Did the same fix as 41 above for OpenSSL, which had the same infelicity.
2134
f7b63901
PH
213544. The "Exiscan patch" is now merged into the mainline Exim source.
2136
213745. Sometimes the final signoff response after QUIT could fail to get
2138 transmitted in the non-TLS case. Testing !tls_active instead of tls_active
2139 < 0 before doing a fflush(). This bug looks as though it goes back to the
2140 introduction of TLS in release 3.20, but "sometimes" must have been rare
2141 because the tests only now provoked it.
2142
a444213a
PH
214346. Reset the locale to "C" after calling embedded Perl, in case it was changed
2144 (this can affect the format of dates).
2145
0ec020ea
PH
214647. exim_tidydb, when checking for the continued existence of a message for
2147 which it has found a message-specific retry record, was not finding
2148 messages that were in split spool directories. Consequently, it was
2149 deleting retry records that should have stayed in existence.
2150
b1206957
PH
215148. Steve fixed some bugs in eximstats.
2152
215349. The SPA authentication driver was not abandoning authentication and moving
2154 on to the next authenticator when an expansion was forced to fail,
2155 contradicting the general specification for all authenticators. Instead it
2156 was generating a temporary error. It now behaves as specified.
2157
26dd5a95
PH
215850. The default ordering of permitted cipher suites for GnuTLS was pessimal
2159 (the order specifies the preference for clients). The order is now AES256,
2160 AES128, 3DES, ARCFOUR128.
2161
343b2385
PH
216251. Small patch to Sieve code - explicitly set From: when generating an
2163 autoreply.
2164
1c5466b9
PH
216552. Exim crashed if a remote delivery caused a very long error message to be
2166 recorded - for instance if somebody sent an entire SpamAssassin report back
2167 as a large number of 550 error lines. This bug was coincidentally fixed by
2168 increasing the size of one of Exim's internal buffers (big_buffer) that
2169 happened as part of the Exiscan merge. However, to be on the safe side, I
2170 have made the code more robust (and fixed the comments that describe what
2171 is going on).
2172
55ee9ee3
PH
217353. Now that there can be additional text after "Completed" in log lines (if
2174 the queue_time_overall log selector is set), a one-byte patch to exigrep
2175 was needed to allow it to recognize "Completed" as not the last thing in
2176 the line.
2177
d38f8232
PH
217854. The LDAP lookup was not handling a return of LDAP_RES_SEARCH_REFERENCE. A
2179 patch that reportedly fixes this has been added. I am not expert enough to
2180 create a test for it. This is what the patch creator wrote:
2181
2182 "I found a little strange behaviour of ldap code when working with
2183 Windows 2003 AD Domain, where users was placed in more than one
2184 Organization Units. When I tried to give exim partial DN, the exit code
2185 of ldap_search was unknown to exim because of LDAP_RES_SEARCH_REFERENCE.
2186 But simultaneously result of request was absolutely normal ldap result,
2187 so I produce this patch..."
2188
3295e65b
PH
2189 Later: it seems that not all versions of LDAP support LDAP_RES_SEARCH_
2190 REFERENCE, so I have modified the code to exclude the patch when that macro
2191 is not defined.
2192
7102e136
PH
219355. Some experimental protocols are using DNS PTR records for new purposes. The
2194 keys for these records are domain names, not reversed IP addresses. The
b975ba52
PH
2195 dnsdb PTR lookup now tests whether its key is an IP address. If not, it
2196 leaves it alone. Component reversal etc. now happens only for IP addresses.
ea3a6f44 2197 CAN-2005-0021
7102e136 2198
3ca0ba97
PH
219956. Improve error message when ldap_search() fails in OpenLDAP or Solaris LDAP.
2200
c2bcbe20
PH
220157. Double the size of the debug message buffer (to 2048) so that more of very
2202 long debug lines gets shown.
2203
18ce445d
PH
220458. The exicyclog utility now does better if the number of log files to keep
2205 exceeds 99. In this case, it numbers them 001, 002 ... instead of 01, 02...
2206
1f5b4c3d
PH
220759. Two changes related to the smtp_active_hostname option:
2208
2209 (1) $smtp_active_hostname is now available as a variable.
2210 (2) The default for smtp_banner uses $smtp_active_hostname instead
2211 of $primary_hostname.
2212
b975ba52
PH
221360. The host_aton() function is supposed to be passed a string that is known
2214 to be a valid IP address. However, in the case of IPv6 addresses, it was
2215 not checking this. This is a hostage to fortune. Exim now panics and dies
2216 if the condition is not met. A case was found where this could be provoked
85b87bc2
PH
2217 from a dnsdb PTR lookup with an IPv6 address that had more than 8
2218 components; fortuitously, this particular loophole had already been fixed
2219 by change 4.50/55 above.
2220
2221 If there are any other similar loopholes, the new check in host_aton()
2222 itself should stop them being exploited. The report I received stated that
2223 data on the command line could provoke the exploit when Exim was running as
2224 exim, but did not say which command line option was involved. All I could
2225 find was the use of -be with a bad dnsdb PTR lookup, and in that case it is
2226 running as the user.
ea3a6f44 2227 CAN-2005-0021
85b87bc2
PH
2228
222961. There was a buffer overflow vulnerability in the SPA authentication code
2230 (which came originally from the Samba project). I have added a test to the
2231 spa_base64_to_bits() function which I hope fixes it.
ea3a6f44 2232 CAN-2005-0022
b975ba52 2233
17ffcae7
PH
223462. Configuration update for GNU/Hurd and variations. Updated Makefile-GNU and
2235 os.h-GNU, and added configuration files for GNUkFreeBSD and GNUkNetBSD.
2236
d95f9fdb
PH
223763. The daemon start-up calls getloadavg() while still root for those OS that
2238 need the first call to be done as root, but it missed one case: when
2239 deliver_queue_load_max is set with deliver_drop_privilege. This is
2240 necessary for the benefit of the queue runner, because there is no re-exec
2241 when deliver_drop_privilege is set.
2242
86b8287f
PH
224364. A call to exiwhat cut short delays set up by "delay" modifiers in ACLs.
2244 This has been fixed.
2245
60dc5e56
PH
224665. Caching of lookup data for "hosts =" ACL conditions, when a named host list
2247 was in use, was not putting the data itself into the right store pool;
2248 consequently, it could be overwritten for a subsequent message in the same
2249 SMTP connection. (Fix 4.40/11 dealt with the non-cache case, but overlooked
2250 the caching.)
2251
533244af
PH
225266. Added hosts_max_try_hardlimit to the smtp transport, default 50.
2253
a5a28604
PH
225467. The string_is_ip_address() function returns 0, 4, or 6, for "no an IP
2255 address", "IPv4 address", and "IPv6 address", respectively. Some calls of
2256 the function were treating the return as a boolean value, which happened to
2257 work because 0=false and not-0=true, but is not correct code.
2258
7e634d24
PH
225968. The host_aton() function was not handling scoped IPv6 addresses (those
2260 with, for example, "%eth0" on the end) correctly.
2261
3e11c26b
PH
226269. Fixed some compiler warnings in acl.c for the bitmaps specified with
2263 negated items (that is, ~something) in unsigned ints. Some compilers
2264 apparently mutter when there is no cast.
2265
6729cf78
PH
226670. If an address verification called from an ACL failed, and did not produce a
2267 user-specific message (i.e. there was only a "system" message), nothing was
2268 put in $acl_verify_message. In this situation, it now puts the system
2269 message there.
2270
00f00ca5
PH
227171. Change 4.23/11 added synchronization checking at the start of an SMTP
2272 session; change 4.31/43 added the unwanted input to the log line - except
2273 that it did not do this in the start of session case. It now does.
2274
c9bdd01c
PH
227572. After a timeout in a callout SMTP session, Exim still sent a QUIT command.
2276 This is wrong and can cause the other end to generate a synchronization
2277 error if it is another Exim or anything else that does the synchronization
2278 check. A QUIT command is no longer sent after a timeout.
2279
d43194df
PH
228073. $host_lookup_deferred has been added, to make it easier to detect DEFERs
2281 during host lookups.
2282
fe5b5d0b
PH
228374. The defer_ok option of callout verification was not working if it was used
2284 when verifying addresses in header lines, that is, for this case:
2285
2286 verify = header_sender/callout=defer_ok
2287
76a2d7ba
PH
228875. A backgrounded daemon closed stdin/stdout/stderr on entry; this meant that
2289 those file descriptors could be used for SMTP connections. If anything
2290 wrote to stderr (the example that came up was "warn" in embedded Perl), it
2291 could be sent to the SMTP client, causing chaos. The daemon now opens
2292 stdin, stdout, and stderr to /dev/null when it puts itself into the
2293 background.
2294
229576. Arrange for output from Perl's "warn" command to be written to Exim's main
2296 log by default. The user can override this with suitable Perl magic.
2297
04f7d5b9
PH
229877. The use of log_message on a "discard" ACL verb, which is supposed to add to
2299 the log message when discard triggers, was not working for the DATA ACL or
2300 for the non-SMTP ACL.
2301
bc60667e
PH
230278. Error message wording change in sieve.c.
2303
bb6e88ff
PH
230479. If smtp_accept_max_per_host was set, the number of connections could be
2305 restricted to fewer than expected, because the daemon was trying to set up
2306 a new connection before checking whether the processes handling previous
2307 connections had finished. The check for completed processes is now done
2308 earlier. On busy systems, this bug wouldn't be noticed because something
2309 else would have woken the daemon, and it would have reaped the completed
2310 process earlier.
2311
1e70f85b
PH
231280. If a message was submitted locally by a user whose login name contained one
2313 or more spaces (ugh!), the spool file that Exim wrote was not re-readable.
2314 It caused a spool format error. I have fixed the spool reading code. A
2315 related problem was that the "from" clause in the Received: line became
2316 illegal because of the space(s). It is now covered by ${quote_local_part.
2317
231881. Included the latest eximstats from Steve (adds average sizes to HTML Top
2319 tables).
2320
4e01f9d6
PH
232182. Updated OS/Makefile-AIX as per message from Mike Meredith.
2322
1ee1cef2
PH
232383. Patch from Sieve maintainer to fix unterminated string problem in
2324 "vacation" handling.
2325
6e2b4ccc
PH
232684. Some minor changes to the Linux configuration files to help with other
2327 OS variants using glibc.
2328
8e669ac1
PH
232985. One more patch for Sieve to update vacation handling to latest spec.
2330
495ae4b0 2331
bbe902f0
PH
2332----------------------------------------------------
2333See the note above about the 4.44 and 4.50 releases.
2334----------------------------------------------------
2335
2336
2337Exim version 4.44
2338-----------------
2339
2340 1. Change 4.43/35 introduced a bug that caused file counts to be
2341 incorrectly computed when quota_filecount was set in an appendfile
2342 transport
2343
2344 2. Closing a stable door: arrange to panic-die if setitimer() ever fails. The
2345 bug fixed in 4.43/37 would have been diagnosed quickly if this had been in
2346 place.
2347
2348 3. Give more explanation in the error message when the command for a transport
2349 filter fails to execute.
2350
2351 4. There are several places where Exim runs a non-Exim command in a
2352 subprocess. The SIGUSR1 signal should be disabled for these processes. This
2353 was being done only for the command run by the queryprogram router. It is
2354 now done for all such subprocesses. The other cases are: ${run, transport
2355 filters, and the commands run by the lmtp and pipe transports.
2356
2357 5. Some older OS have a limit of 256 on the maximum number of file
2358 descriptors. Exim was using setrlimit() to set 1000 as a large value
2359 unlikely to be exceeded. Change 4.43/17 caused a lot of logging on these
2360 systems. I've change it so that if it can't get 1000, it tries for 256.
2361
2362 6. "control=submission" was allowed, but had no effect, in a DATA ACL. This
2363 was an oversight, and furthermore, ever since the addition of extra
2364 controls (e.g. 4.43/32), the checks on when to allow different forms of
2365 "control" were broken. There should now be diagnostics for all cases when a
2366 control that does not make sense is encountered.
2367
2368 7. $recipients is now available in the predata ACL (oversight).
2369
2370 8. Tidy the search cache before the fork to do a delivery from a message
2371 received from the command line. Otherwise the child will trigger a lookup
2372 failure and thereby defer the delivery if it tries to use (for example) a
2373 cached ldap connection that the parent has called unbind on.
2374
2375 9. If verify=recipient was followed by verify=sender in a RCPT ACL, the value
2376 of $address_data from the recipient verification was clobbered by the
2377 sender verification.
2378
237910. If FIXED_NEVER_USERS was defined, but empty, Exim was assuming the uid 0
2380 was its contents. (It was OK if the option was not defined at all.)
2381
238211. A "Completed" log line is now written for messages that are removed from
2383 the spool by the -Mrm option.
2384
238512. $host_address is now set to the target address during the checking of
2386 ignore_target_hosts.
2387
238813. When checking ignore_target_hosts for an ipliteral router, no host name was
2389 being passed; this would have caused $sender_host_name to have been used if
2390 matching the list had actually called for a host name (not very likely,
2391 since this list is usually IP addresses). A host name is now passed as
2392 "[x.x.x.x]".
2393
239414. Changed the calls that set up the SIGCHLD handler in the daemon to use the
2395 code that specifies a non-restarting handler (typically sigaction() in
2396 modern systems) in an attempt to fix a rare and obscure crash bug.
2397
239815. Narrowed the window for a race in the daemon that could cause it to ignore
2399 SIGCHLD signals. This is not a major problem, because they are used only to
2400 wake it up if nothing else does.
2401
240216. A malformed maildirsize file could cause Exim to calculate negative values
2403 for the mailbox size or file count. Odd effects could occur as a result.
2404 The maildirsize information is now recalculated if the size or filecount
2405 end up negative.
2406
240717. Added HAVE_SYS_STATVFS_H to the os.h file for Linux, as it has had this
2408 support for a long time. Removed HAVE_SYS_VFS_H.
2409
ea3a6f44 241018. Updated exipick to current release from John Jetmore.
bbe902f0
PH
2411
241219. Allow an empty sender to be matched against a lookup in an address list.
2413 Previously the only cases considered were a regular expression, or an
2414 empty pattern.
2415
241620. Exim went into a mad DNS lookup loop when doing a callout where the
2417 host was specified on the transport, if the DNS lookup yielded more than
2418 one IP address.
2419
ea3a6f44
NM
242021. The RFC2047 encoding function was originally intended for short strings
2421 such as real names; it was not keeping to the 75-character limit for
2422 encoded words that the RFC imposes. It now respects the limit, and
2423 generates multiple encoded words if necessary. To be on the safe side, I
2424 have increased the buffer size for the ${rfc2047: expansion operator from
2425 1024 to 2048 bytes.
bbe902f0 2426
ea3a6f44
NM
242722. Failure to deliver a bounce message always caused it to be frozen, even if
2428 there was an errors_to setting on the router. The errors_to setting is now
2429 respected.
bbe902f0
PH
2430
243123. If an IPv6 address is given for -bh or -bhc, it is now converted to the
2432 canonical form (fully expanded) before being placed in
2433 $sender_host_address.
2434
243524. Updated eximstats to version 1.33
2436
ea3a6f44
NM
243725. Include certificate and key file names in error message when GnuTLS fails
2438 to set them up, because the GnuTLS error message doesn't include the name
2439 of the failing file when there is a problem reading it.
bbe902f0
PH
2440
244126. Expand error message when OpenSSL has problems setting up cert/key files.
ea3a6f44 2442 As per change 25.
bbe902f0 2443
ea3a6f44
NM
244427. Reset the locale to "C" after calling embedded Perl, in case it was changed
2445 (this can affect the format of dates).
bbe902f0 2446
ea3a6f44
NM
244728. exim_tidydb, when checking for the continued existence of a message for
2448 which it has found a message-specific retry record, was not finding
2449 messages that were in split spool directories. Consequently, it was
2450 deleting retry records that should have stayed in existence.
bbe902f0
PH
2451
245229. eximstats updated to version 1.35
2453 1.34 - allow eximstats to parse syslog lines as well as mainlog lines
2454 1.35 - bugfix such that pie charts by volume are generated correctly
2455
ea3a6f44
NM
245630. The SPA authentication driver was not abandoning authentication and moving
2457 on to the next authenticator when an expansion was forced to fail,
2458 contradicting the general specification for all authenticators. Instead it
2459 was generating a temporary error. It now behaves as specified.
bbe902f0 2460
ea3a6f44
NM
246131. The default ordering of permitted cipher suites for GnuTLS was pessimal
2462 (the order specifies the preference for clients). The order is now AES256,
2463 AES128, 3DES, ARCFOUR128.
bbe902f0 2464
ea3a6f44
NM
246531. Small patch to Sieve code - explicitly set From: when generating an
2466 autoreply.
bbe902f0 2467
ea3a6f44
NM
246832. Exim crashed if a remote delivery caused a very long error message to be
2469 recorded - for instance if somebody sent an entire SpamAssassin report back
2470 as a large number of 550 error lines. This bug was coincidentally fixed by
2471 increasing the size of one of Exim's internal buffers (big_buffer) that
2472 happened as part of the Exiscan merge. However, to be on the safe side, I
2473 have made the code more robust (and fixed the comments that describe what
2474 is going on).
bbe902f0 2475
ea3a6f44
NM
247633. Some experimental protocols are using DNS PTR records for new purposes. The
2477 keys for these records are domain names, not reversed IP addresses. The
2478 dnsdb PTR lookup now tests whether its key is an IP address. If not, it
2479 leaves it alone. Component reversal etc. now happens only for IP addresses.
bbe902f0
PH
2480 CAN-2005-0021
2481
ea3a6f44
NM
248234. The host_aton() function is supposed to be passed a string that is known
2483 to be a valid IP address. However, in the case of IPv6 addresses, it was
2484 not checking this. This is a hostage to fortune. Exim now panics and dies
2485 if the condition is not met. A case was found where this could be provoked
2486 from a dnsdb PTR lookup with an IPv6 address that had more than 8
2487 components; fortuitously, this particular loophole had already been fixed
2488 by change 4.50/55 or 4.44/33 above.
2489
2490 If there are any other similar loopholes, the new check in host_aton()
2491 itself should stop them being exploited. The report I received stated that
2492 data on the command line could provoke the exploit when Exim was running as
2493 exim, but did not say which command line option was involved. All I could
2494 find was the use of -be with a bad dnsdb PTR lookup, and in that case it is
2495 running as the user.
bbe902f0
PH
2496 CAN-2005-0021
2497
ea3a6f44
NM
249835. There was a buffer overflow vulnerability in the SPA authentication code
2499 (which came originally from the Samba project). I have added a test to the
2500 spa_base64_to_bits() function which I hope fixes it.
bbe902f0
PH
2501 CAN-2005-0022
2502
ea3a6f44
NM
250336. The daemon start-up calls getloadavg() while still root for those OS that
2504 need the first call to be done as root, but it missed one case: when
2505 deliver_queue_load_max is set with deliver_drop_privilege. This is
2506 necessary for the benefit of the queue runner, because there is no re-exec
2507 when deliver_drop_privilege is set.
bbe902f0 2508
ea3a6f44
NM
250937. Caching of lookup data for "hosts =" ACL conditions, when a named host list
2510 was in use, was not putting the data itself into the right store pool;
2511 consequently, it could be overwritten for a subsequent message in the same
2512 SMTP connection. (Fix 4.40/11 dealt with the non-cache case, but overlooked
2513 the caching.)
bbe902f0 2514
ea3a6f44
NM
251538. Sometimes the final signoff response after QUIT could fail to get
2516 transmitted in the non-TLS case. Testing !tls_active instead of tls_active
2517 < 0 before doing a fflush(). This bug looks as though it goes back to the
2518 introduction of TLS in release 3.20, but "sometimes" must have been rare
2519 because the tests only now provoked it.
bbe902f0
PH
2520
2521
495ae4b0
PH
2522Exim version 4.43
2523-----------------
2524
2525 1. Fixed a longstanding but relatively impotent bug: a long time ago, before
2526 PIPELINING, the function smtp_write_command() used to return TRUE or FALSE.
2527 Now it returns an integer. A number of calls were still expecting a T/F
2528 return. Fortuitously, in all cases, the tests worked in OK situations,
2529 which is the norm. However, things would have gone wrong on any write
2530 failures on the smtp file descriptor. This function is used when sending
2531 messages over SMTP and also when doing verify callouts.
2532
2533 2. When Exim is called to do synchronous delivery of a locally submitted
2534 message (the -odf or -odi options), it no longer closes stderr before doing
2535 the delivery.
2536
2537 3. Implemented the mua_wrapper option.
2538
2539 4. Implemented mx_fail_domains and srv_fail_domains for the dnslookup router.
2540
2541 5. Implemented the functions header_remove(), header_testname(),
2542 header_add_at_position(), and receive_remove_recipient(), and exported them
2543 to local_scan().
2544
2545 6. If an ACL "warn" statement specified the addition of headers, Exim already
2546 inserted X-ACL-Warn: at the start if there was no header name. However, it
2547 was not making this test for the second and subsequent header lines if
2548 there were newlines in the string. This meant that an invalid header could
2549 be inserted if Exim was badly configured.
2550
2551 7. Allow an ACL "warn" statement to add header lines at the start or after all
2552 the Received: headers, as well as at the end.
2553
2554 8. Added the rcpt_4xx retry error code.
2555
2556 9. Added postmaster_mailfrom=xxx to callout verification option.
2557
255810. Added mailfrom=xxxx to the callout verification option, for verify=
2559 header_sender only.
2560
256111. ${substr_1_:xxxx} and ${substr__3:xxxx} are now diagnosed as syntax errors
2562 (they previously behaved as ${substr_1_0:xxxx} and ${substr:_0_3:xxxx}).
2563
256412. Inserted some casts to stop certain compilers warning when using pointer
2565 differences as field lengths or precisions in printf-type calls (mostly
2566 affecting debugging statements).
2567
256813. Added optional readline() support for -be (dynamically loaded).
2569
257014. Obscure bug fix: if a message error (e.g. 4xx to MAIL) happened within the
2571 same clock tick as a message's arrival, so that its received time was the
2572 same as the "first fail" time on the retry record, and that message
2573 remained on the queue past the ultimate address timeout, every queue runner
2574 would try a delivery (because it was past the ultimate address timeout) but
2575 after another failure, the ultimate address timeout, which should have then
2576 bounced the address, did not kick in. This was a "< instead of <=" error;
2577 in most cases the first failure would have been in the next clock tick
2578 after the received time, and all would be well.
2579
258015. The special items beginning with @ in domain lists (e.g. @mx_any) were not
2581 being recognized when the domain list was tested by the match_domain
2582 condition in an expansion string.
2583
258416. Added the ${str2b64: operator.
2585
258617. Exim was always calling setrlimit() to set a large limit for the number of
2587 processes, without checking whether the existing limit was already
2588 adequate. (It did check for the limit on file descriptors.) Furthermore,
2589 errors from getrlimit() and setrlimit() were being ignored. Now they are
2590 logged to the main and panic logs, but Exim does carry on, to try to do its
2591 job under whatever limits there are.
2592
259318. Imported PCRE 5.0.
2594
259519. Trivial typo in log message " temporarily refused connection" (the leading
2596 space).
2597
259820. If the log selector return_path_on_delivery was set and an address was
2599 redirected to /dev/null, the delivery process crashed because it assumed
2600 that a return path would always be set for a "successful" delivery. In this
2601 case, the whole delivery is bypassed as an optimization, and therefore no
2602 return path is set.
2603
260421. Internal re-arrangement: the function for sending a challenge and reading
2605 a response while authentication was assuming a zero-terminated challenge
2606 string. It's now changed to take a pointer and a length, to allow for
2607 binary data in such strings.
2608
260922. Added the cyrus_sasl authenticator (code supplied by MBM).
2610
261123. Exim was not respecting finduser_retries when seeking the login of the
2612 uid under which it was called; it was always trying 10 times. (The default
2613 setting of finduser_retries is zero.) Also, it was sleeping after the final
2614 failure, which is pointless.
2615
261624. Implemented tls_on_connect_ports.
2617
261825. Implemented acl_smtp_predata.
2619
262026. If the domain in control=submission is set empty, Exim assumes that the
2621 authenticated id is a complete email address when it generates From: or
2622 Sender: header lines.
2623
262427. Added "#define SOCKLEN_T int" to OS/os.h-SCO and OS/os.h-SCO_SV. Also added
2625 definitions to OS/Makefile-SCO and OS/Makefile-SCO_SV that put basename,
2626 chown and chgrp in /bin and hostname in /usr/bin.
2627
262828. Exim was keeping the "process log" file open after each use, just as it
2629 does for the main log. This opens the possibility of it remaining open for
2630 long periods when the USR1 signal hits a daemon. Occasional processlog
2631 errors were reported, that could have been caused by this. Anyway, it seems
2632 much more sensible not to leave this file open at all, so that is what now
2633 happens.
2634
263529. The long-running daemon process does not normally write to the log once it
2636 has entered its main loop, and it closes the log before doing so. This is
2637 so that log files can straightforwardly be renamed and moved. However,
2638 there are a couple of unusual error situations where the daemon does write
2639 log entries, and I had neglected to close the log afterwards.
2640
264130. The text of an SMTP error response that was received during a remote
2642 delivery was being truncated at 512 bytes. This is too short for some of
2643 the long messages that one sometimes sees. I've increased the limit to
2644 1024.
2645
264631. It is now possible to make retry rules that apply only when a message has a
2647 specific sender, in particular, an empty sender.
2648
264932. Added "control = enforce_sync" and "control = no_enforce_sync". This makes
2650 it possible to be selective about when SMTP synchronization is enforced.
2651
265233. Added "control = caseful_local_part" and "control = "caselower_local_part".
2653
265432. Implemented hosts_connection_nolog.
2655
265633. Added an ACL for QUIT.
2657
265834. Setting "delay_warning=" to disable warnings was not working; it gave a
2659 syntax error.
2660
266135. Added mailbox_size and mailbox_filecount to appendfile.
2662
266336. Added control = no_multiline_responses to ACLs.
2664
266537. There was a bug in the logic of the code that waits for the clock to tick
2666 in the case where the clock went backwards by a substantial amount such
2667 that the microsecond fraction of "now" was more than the microsecond
2668 fraction of "then" (but the whole seconds number was less).
2669
267038. Added support for the libradius Radius client library this is found on
2671 FreeBSD (previously only the radiusclient library was supported).
2672
2673
2674Exim version 4.42
2675-----------------
2676
2677 1. When certain lookups returned multiple values in the form name=value, the
2678 quoting of the values was not always being done properly. Specifically:
2679 (a) If the value started with a double quote, but contained no whitespace,
2680 it was not quoted.
2681 (b) If the value contained whitespace other than a space character (i.e.
2682 tabs or newlines or carriage returns) it was not quoted.
2683 This fix has been applied to the mysql and pgsql lookups by writing a
2684 separate quoting function and calling it from the lookup code. The fix
2685 should probably also be applied to nisplus, ibase and oracle lookups, but
2686 since I cannot test any of those, I have not disturbed their existing code.
2687
2688 2. A hit in the callout cache for a specific address caused a log line with no
2689 reason for rejecting RCPT. Now it says "Previous (cached) callout
2690 verification failure".
2691
2692 3. There was an off-by-one bug in the queryprogram router. An over-long
2693 return line was truncated at 256 instead of 255 characters, thereby
2694 overflowing its buffer with the terminating zero. As well as fixing this, I
2695 have increased the buffer size to 1024 (and made a note to document this).
2696
2697 4. If an interrupt, such as the USR1 signal that is send by exiwhat, arrives
2698 when Exim is waiting for an SMTP response from a remote server, Exim
2699 restarts its select() call on the socket, thereby resetting its timeout.
2700 This is not a problem when such interrupts are rare. Somebody set up a cron
2701 job to run exiwhat every 2 minutes, which is less than the normal select()
2702 timeout (5 or 10 minutes). This meant that the select() timeout never
2703 kicked in because it was always reset. I have fixed this by comparing the
2704 time when an interrupt arrives with the time at the start of the first call
2705 to select(). If more time than the timeout has elapsed, the interrupt is
2706 treated as a timeout.
2707
2708 5. Some internal re-factoring in preparation for the addition of Sieve
2709 extensions (by MH). In particular, the "personal" test is moved to a
2710 separate function, and given an option for scanning Cc: and Bcc: (which is
2711 not set for Exim filters).
2712
2713 6. When Exim created an email address using the login of the caller as the
2714 local part (e.g. when creating a From: or Sender: header line), it was not
2715 quoting the local part when it contained special characters such as @.
2716
2717 7. Installed new OpenBSD configuration files.
2718
2719 8. Reworded some messages for syntax errors in "and" and "or" conditions to
2720 try to make them clearer.
2721
2722 9. Callout options, other than the timeout value, were being ignored when
2723 verifying sender addresses in header lines. For example, when using
2724
2725 verify = header_sender/callout=no_cache
2726
2727 the cache was (incorrectly) being used.
2728
272910. Added a missing instance of ${EXE} to the exim_install script; this affects
2730 only the Cygwin environment.
2731
273211. When return_path_on_delivery was set as a log selector, if different remote
2733 addresses in the same message used different return paths and parallel
2734 remote delivery occurred, the wrong values would sometimes be logged.
2735 (Whenever a remote delivery process finished, the return path value from
2736 the most recently started remote delivery process was logged.)
2737
273812. RFC 3848 specifies standard names for the "with" phrase in Received: header
2739 lines when AUTH and/or TLS are in use. This is the "received protocol"
2740 field. Exim used to use "asmtp" for authenticated SMTP, without any
2741 indication (in the protocol name) for TLS use. Now it follows the RFC and
2742 uses "esmtpa" if the connection is authenticated, "esmtps" if it is
2743 encrypted, and "esmtpsa" if it is both encrypted and authenticated. These
2744 names appear in log lines as well as in Received: header lines.
2745
274613. Installed MH's patches for Sieve to add the "copy" and "vacation"
2747 extensions, and comparison tests, and to fix some bugs.
2748
274914. Changes to the "personal" filter test:
2750
2751 (1) The test was buggy in that it was just doing the equivalent of
2752 "contains" tests on header lines. For example, if a user's address was
2753 anne@some.where, the "personal" test would incorrectly be true for
2754
2755 To: susanne@some.where
2756
2757 This test is now done by extracting each address from the header in turn,
2758 and checking the entire address. Other tests that are part of "personal"
2759 are now done using regular expressions (for example, to check local parts
2760 of addresses in From: header lines).
2761
2762 (2) The list of non-personal local parts in From: addresses has been
2763 extended to include "listserv", "majordomo", "*-request", and "owner-*",
2764 taken from the Sieve specification recommendations.
2765
2766 (3) If the message contains any header line starting with "List-" it is
2767 treated as non-personal.
2768
2769 (4) The test for "circular" in the Subject: header line has been removed
2770 because it now seems ill-conceived.
2771
277215. Minor typos in src/EDITME comments corrected.
2773
277416. Installed latest exipick from John Jetmore.
2775
277617. If headers_add on a router specified a text string that was too long for
2777 string_sprintf() - that is, longer than 8192 bytes - Exim panicked. The use
2778 of string_sprintf() is now avoided.
2779
278018. $message_body_size was not set (it was always zero) when running the DATA
2781 ACL and the local_scan() function.
2782
278319. For the "mail" command in an Exim filter, no default was being set for
2784 the once_repeat time, causing a random time value to be used if "once" was
2785 specified. (If the value happened to be <= 0, no repeat happened.) The
2786 default is now 0s, meaning "never repeat". The "vacation" command was OK
2787 (its default is 7d). It's somewhat surprising nobody ever noticed this bug
2788 (I found it when inspecting the code).
2789
279020. There is now an overall timeout for performing a callout verification. It
2791 defaults to 4 times the callout timeout, which applies to individual SMTP
2792 commands during the callout. The overall timeout applies when there is more
2793 than one host that can be tried. The timeout is checked before trying the
2794 next host. This prevents very long delays if there are a large number of
2795 hosts and all are timing out (e.g. when the network connections are timing
2796 out). The value of the overall timeout can be changed by specifying an
2797 additional sub-option for "callout", called "maxwait". For example:
2798
2799 verify = sender/callout=5s,maxwait=20s
2800
280121. Add O_APPEND to the open() call for maildirsize files (Exim already seeks
2802 to the end before writing, but this should make it even safer).
2803
280422. Exim was forgetting that it had advertised PIPELINING for the second and
2805 subsequent messages on an SMTP connection. It was also not resetting its
2806 memory on STARTTLS and an internal HELO.
2807
280823. When Exim logs an SMTP synchronization error within a session, it now
2809 records whether PIPELINING has been advertised or not.
2810
281124. Added 3 instances of "(long int)" casts to time_t variables that were being
2812 formatted using %ld, because on OpenBSD (and perhaps others), time_t is int
2813 rather than long int.
2814
281525. Installed the latest Cygwin configuration files from the Cygwin maintainer.
2816
281726. Added the never_mail option to autoreply.
2818
2819
2820Exim version 4.41
2821-----------------
2822
2823 1. A reorganization of the code in order to implement 4.40/8 caused a daemon
2824 crash if the getsockname() call failed; this can happen if a connection is
2825 closed very soon after it is established. The problem was simply in the
2826 order in which certain operations were done, causing Exim to try to write
2827 to the SMTP stream before it had set up the file descriptor. The bug has
2828 been fixed by making things happen in the correct order.
2829
2830
2831Exim version 4.40
2832-----------------
2833
2834 1. If "drop" was used in a DATA ACL, the SMTP output buffer was not flushed
2835 before the connection was closed, thus losing the rejection response.
2836
2837 2. Commented out the definition of SOCKLEN_T in os.h-SunOS5. It is needed for
2838 some early Solaris releases, but causes trouble in current releases where
2839 socklen_t is defined.
2840
2841 3. When std{in,out,err} are closed, re-open them to /dev/null so that they
2842 always exist.
2843
2844 4. Minor refactoring of os.c-Linux to avoid compiler warning when IPv6 is not
2845 configured.
2846
2847 5. Refactoring in expand.c to improve memory usage. Pre-allocate a block so
2848 that releasing the top of it at the end releases what was used for sub-
2849 expansions (unless the block got too big). However, discard this block if
2850 the first thing is a variable or header, so that we can use its block when
2851 it is dynamic (useful for very large $message_headers, for example).
2852
2853 6. Lookups now cache *every* query, not just the most recent. A new, separate
2854 store pool is used for this. It can be recovered when all lookup caches are
2855 flushed. Lookups now release memory at the end of their result strings.
2856 This has involved some general refactoring of the lookup sources.
2857
2858 7. Some code has been added to the store_xxx() functions to reduce the amount
2859 of flapping under certain conditions.
2860
2861 8. log_incoming_interface used to affect only the <= reception log lines. Now
2862 it causes the local interface and port to be added to several more SMTP log
2863 lines, for example "SMTP connection from", and rejection lines.
2864
2865 9. The Sieve author supplied some patches for the doc/README.SIEVE file.
2866
286710. Added a conditional definition of _BSD_SOCKLEN_T to os.h-Darwin.
2868
286911. If $host_data was set by virtue of a hosts lookup in an ACL, its value
2870 could be overwritten at the end of the current message (or the start of a
2871 new message if it was set in a HELO ACL). The value is now preserved for
2872 the duration of the SMTP connection.
2873
287412. If a transport had a headers_rewrite setting, and a matching header line
2875 contained an unqualified address, that address was qualified, even if it
2876 did not match any rewriting rules. The underlying bug was that the values
2877 of the flags that permit the existence of unqualified sender and recipient
2878 addresses in header lines (set by {sender,recipient}_unqualified_hosts for
2879 non-local messages, and by -bnq for local messages) were not being
2880 preserved with the message after it was received.
2881
288213. When Exim was logging an SMTP synchronization error, it could sometimes log
2883 "next input=" as part of the text comprising the host identity instead of
2884 the correct text. The code was using the same buffer for two different
2885 strings. However, depending on which order the printing function evaluated
2886 its arguments, the bug did not always show up. Under Linux, for example, my
2887 test suite worked just fine.
2888
288914. Exigrep contained a use of Perl's "our" scoping after change 4.31/70. This
2890 doesn't work with some older versions of Perl. It has been changed to "my",
2891 which in any case is probably the better facility to use.
2892
289315. A really picky compiler found some instances of statements for creating
2894 error messages that either had too many or two few arguments for the format
2895 string.
2896
289716. The size of the buffer for calls to the DNS resolver has been increased
2898 from 1024 to 2048. A larger buffer is needed when performing PTR lookups
2899 for addresses that have a lot of PTR records. This alleviates a problem; it
2900 does not fully solve it.
2901
290217. A dnsdb lookup for PTR records that receives more data than will fit in the
2903 buffer now truncates the list and logs the incident, which is the same
2904 action as happens when Exim is looking up a host name and its aliases.
2905 Previously in this situation something unpredictable would happen;
2906 sometimes it was "internal error: store_reset failed".
2907
290818. If a server dropped the connection unexpectedly when an Exim client was
2909 using GnuTLS and trying to read a response, the client delivery process
2910 crashed while trying to generate an error log message.
2911
291219. If a "warn" verb in an ACL added multiple headers to a message in a single
2913 string, for example:
2914
2915 warn message = H1: something\nH2: something
2916
2917 the text was added as a single header line from Exim's point of view
2918 though it ended up OK in the delivered message. However, searching for the
2919 second and subsequent header lines using $h_h2: did not work. This has been
2920 fixed. Similarly, if a system filter added multiple headers in this way,
2921 the routers could not see them.
2922
292320. Expanded the error message when iplsearch is called with an invalid key to
2924 suggest using net-iplsearch in a host list.
2925
292621. When running tests using -bh, any delays imposed by "delay" modifiers in
2927 ACLs are no longer actually imposed (and a message to that effect is
2928 output).
2929
293022. If a "gecos" field in a passwd entry contained escaped characters, in
2931 particular, if it contained a \" sequence, Exim got it wrong when building
2932 a From: or a Sender: header from that name. A second bug also caused
2933 incorrect handling when an unquoted " was present following a character
2934 that needed quoting.
2935
293623. "{crypt}" as a password encryption mechanism for a "crypteq" expansion item
2937 was not being matched caselessly.
2938
293924. Arranged for all hyphens in the exim.8 source to be escaped with
2940 backslashes.
2941
294225. Change 16 of 4.32, which reversed 71 or 4.31 didn't quite do the job
2943 properly. Recipient callout cache records were still being keyed to include
2944 the sender, even when use_sender was set false. This led to far more
2945 callouts that were necessary. The sender is no longer included in the key
2946 when use_sender is false.
2947
294826. Added "control = submission" modifier to ACLs.
2949
295027. Added the ${base62d: operator to decode base 62 numbers.
2951
295228. dnsdb lookups can now access SRV records.
2953
295429. CONFIGURE_OWNER can be set at build time to define an alternative owner for
2955 the configuration file.
2956
295730. The debug message "delivering xxxxxx-xxxxxx-xx" is now output in verbose
2958 (-v) mode. This makes the output for a verbose queue run more intelligible.
2959
296031. Added a use_postmaster feature to recipient callouts.
2961
296232. Added the $body_zerocount variable, containing the number of binary zero
2963 bytes in the message body.
2964
296533. The time of last modification of the "new" subdirectory is now used as the
2966 "mailbox time last read" when there is a quota error for a maildir
2967 delivery.
2968
296934. Added string comparison operators lt, lti, le, lei, gt, gti, ge, gei.
2970
297135. Added +ignore_unknown as a special item in host lists.
2972
297336. Code for decoding IPv6 addresses in host lists is now included, even if
2974 IPv6 support is not being compiled. This fixes a bug in which an IPv6
2975 address was recognized as an IP address, but was then not correctly decoded
2976 into binary, causing unexpected and incorrect effects when compared with
2977 another IP address.
2978
2979
2980Exim version 4.34
2981-----------------
2982
2983 1. Very minor rewording of debugging text in manualroute to say "list of
2984 hosts" instead of "hostlist".
2985
2986 2. If verify=header_syntax was set, and a header line with an unqualified
2987 address (no domain) and a large number of spaces between the end of the
2988 name and the colon was received, the reception process suffered a buffer
2989 overflow, and (when I tested it) crashed. This was caused by some obsolete
2990 code that should have been removed. The fix is to remove it!
2991
2992 3. When running in the test harness, delay a bit after writing a bounce
2993 message to get a bit more predictability in the log output.
2994
2995 4. Added a call to search_tidyup() just before forking a reception process. In
2996 theory, someone could use a lookup in the expansion of smtp_accept_max_
2997 per_host which, without the tidyup, could leave open a database connection.
2998
2999 5. Added the variables $recipient_data and $sender_data which get set from a
3000 lookup success in an ACL "recipients" or "senders" condition, or a router
3001 "senders" option, similar to $domain_data and $local_part_data.
3002
3003 6. Moved the writing of debug_print from before to after the "senders" test
3004 for routers.
3005
3006 7. Change 4.31/66 (moving the time when the Received: is generated) caused
3007 problems for message scanning, either using a data ACL, or using
3008 local_scan() because the Received: header was not generated till after they
3009 were called (in order to set the time as the time of reception completion).
3010 I have revised the way this works. The header is now generated after the
3011 body is received, but before the ACL or local_scan() are called. After they
3012 are run, the timestamp in the header is updated.
3013
3014
3015Exim version 4.33
3016-----------------
3017
3018 1. Change 4.24/6 introduced a bug because the SIGALRM handler was disabled
3019 before starting a queue runner without re-exec. This happened only when
3020 deliver_drop_privilege was set or when the Exim user was set to root. The
3021 effect of the bug was that timeouts during subsequent deliveries caused
3022 crashes instead of being properly handled. The handler is now left at its
3023 default (and expected) setting.
3024
3025 2. The other case in which a daemon avoids a re-exec is to deliver an incoming
3026 message, again when deliver_drop_privilege is set or Exim is run as root.
3027 The bug described in (1) was not present in this case, but the tidying up
3028 of the other signals was missing. I have made the two cases consistent.
3029
3030 3. The ignore_target_hosts setting on a manualroute router was being ignored
3031 for hosts that were looked up using the /MX notation.
3032
3033 4. Added /ignore=<ip list> feature to @mx_any, @mx_primary, and @mx_secondary
3034 in domain lists.
3035
3036 5. Change 4.31/55 was buggy, and broke when there was a rewriting rule that
3037 operated on the sender address. After changing the $sender_address to <>
3038 for the sender address verify, Exim was re-instated it as the original
3039 (before rewriting) address, but remembering that it had rewritten it, so it
3040 wasn't rewriting it again. This bug also had the effect of breaking the
3041 sender address verification caching when the sender address was rewritten.
3042
3043 6. The ignore_target_hosts option was being ignored by the ipliteral router.
3044 This has been changed so that if the ip literal address matches
3045 ignore_target_hosts, the router declines.
3046
3047 7. Added expansion conditions match_domain, match_address, and match_local_
3048 part (NOT match_host).
3049
3050 8. The placeholder for the Received: header didn't have a length field set.
3051
3052 9. Added code to Exim itself and to exim_lock to test for a specific race
3053 condition that could lead to file corruption when using MBX delivery. The
3054 issue is with the lockfile that is created in /tmp. If this file is removed
3055 after a process has opened it but before that process has acquired a lock,
3056 there is the potential for a second process to recreate the file and also
3057 acquire a lock. This could lead to two Exim processes writing to the file
3058 at the same time. The added code performs the same test as UW imapd; it
3059 checks after acquiring the lock that its file descriptor still refers to
3060 the same named file.
3061
306210. The buffer for building added header lines was of fixed size, 8192 bytes.
3063 It is now parameterized by HEADER_ADD_BUFFER_SIZE and this can be adjusted
3064 when Exim is built.
3065
306611. Added the smtp_active_hostname option. If used, this will typically be made
3067 to depend on the incoming interface address. Because $interface_address is
3068 not set up until the daemon has forked a reception process, error responses
3069 that can happen earlier (such as "too many connections") no longer contain
3070 a host name.
3071
307212. If an expansion in a condition on a "warn" statement fails because a lookup
3073 defers, the "warn" statement is abandoned, and the next ACL statement is
3074 processed. Previously this caused the whole ACL to be aborted.
3075
307613. Added the iplsearch lookup type.
3077
307814. Added ident_timeout as a log selector.
3079
308015. Added tls_certificate_verified as a log selector.
3081
308216. Added a global option tls_require_ciphers (compare the smtp transport
3083 option of the same name). This controls incoming TLS connections.
3084
308517. I finally figured out how to make tls_require_ciphers do a similar thing
3086 in GNUtls to what it does in OpenSSL, that is, set up an appropriate list
3087 before starting the TLS session.
3088
308918. Tabs are now shown as \t in -bP output.
3090
309119. If the log selector return_path_on_delivery was set, Exim crashed when
3092 bouncing a message because it had too many Received: header lines.
3093
309420. If two routers both had headers_remove settings, and the first one included
3095 a superfluous trailing colon, the final name in the first list and the
3096 first name in the second list were incorrectly joined into one item (with a
3097 colon in the middle).
3098
3099
3100Exim version 4.32
3101-----------------
3102
3103 1. Added -C and -D options to the exinext utility, mainly to make it easier
3104 to include in the automated testing, but these could be helpful when
3105 multiple configurations are in use.
3106
3107 2. The exinext utility was not formatting the output nicely when there was
3108 an alternate port involved in the retry record key, nor when there was a
3109 message id as well (for retries that were specific to a specific message
3110 and a specific host). It was also confused by IPv6 addresses, because of
3111 the additional colons they contain. I have fixed the IPv4 problem, and
3112 patched it up to do a reasonable job for IPv6.
3113
3114 3. When there is an error after a MAIL, RCPT, or DATA SMTP command during
3115 delivery, the log line now contains "pipelined" if PIPELINING was used.
3116
3117 4. An SMTP transport process used to panic and die if the bind() call to set
3118 an explicit outgoing interface failed. This has been changed; it is now
3119 treated in the same way as a connect() failure.
3120
3121 5. A reference to $sender_host_name in the part of a conditional expansion
3122 that was being skipped was still causing a DNS lookup. This no longer
3123 occurs.
3124
3125 6. The def: expansion condition was not recognizing references to header lines
3126 that used bh_ and bheader_.
3127
3128 7. Added the _cache feature to named lists.
3129
3130 8. The code for checking quota_filecount in the appendfile transport was
3131 allowing one more file than it should have been.
3132
3133 9. For compatibility with Sendmail, the command line option
3134
3135 -prval:sval
3136
3137 is equivalent to
3138
3139 -oMr rval -oMs sval
3140
3141 and sets the incoming protocol and host name (for trusted callers). The
3142 host name and its colon can be omitted when only the protocol is to be set.
3143 Note the Exim already has two private options, -pd and -ps, that refer to
3144 embedded Perl. It is therefore impossible to set a protocol value of "d" or
3145 "s", but I don't think that's a major issue.
3146
314710. A number of refactoring changes to the code, none of which should affect
3148 Exim's behaviour:
3149
3150 (a) The number of logging options was getting close to filling up the
3151 32-bit word that was used as a bit map. I have split them into two classes:
3152 those that are passed in the argument to log_write(), and those that are
3153 only ever tested independently outside of that function. These are now in
3154 separate 32-bit words, so there is plenty of room for expansion again.
3155 There is no change in the user interface or the logging behaviour.
3156
3157 (b) When building, for example, log lines, the code previously used a
3158 macro that called string_cat() twice, in order to add two strings. This is
3159 not really sufficiently general. Furthermore, there was one instance where
3160 it was actually wrong because one of the argument was used twice, and in
3161 one call a function was used. (As it happened, calling the function twice
3162 did not affect the overall behaviour.) The macro has been replaced by a
3163 function that can join an arbitrary number of extra strings onto a growing
3164 string.
3165
3166 (c) The code for expansion conditions now uses a table and a binary chop
3167 instead of a serial search (which was left over from when there were very
3168 few conditions). Also, it now recognizes conditions like "pam" even when
3169 the relevant support is not compiled in: a suitably worded error message is
3170 given if an attempt is made to use such a condition.
3171
317211. Added ${time_interval:xxxxx}.
3173
317412. A bug was causing one of the ddress fields not to be passed back correctly
3175 from remote delivery subprocesses. The field in question was not being
3176 subsequently used, so this caused to problems in practice.
3177
317813. Added new log selectors queue_time and deliver_time.
3179
318014. Might have fixed a bug in maildirsizefile handling that threw up
3181 "unexpected character" debug warnings, and recalculated the data
3182 unnecessarily. In any case, I expanded the warning message to give more
3183 information.
3184
318515. Added the message "Restricted characters in address" to the statements in
3186 the default ACL that block characters like @ and % in local parts.
3187
318816. Change 71 for release 4.31 proved to be much less benign that I imagined.
3189 Three changes have been made:
3190
3191 (a) There was a serious bug; a negative response to MAIL caused the whole
3192 recipient domain to be cached as invalid, thereby blocking all messages
3193 to all local parts at the same domain, from all senders. This bug has
3194 been fixed. The domain is no longer cached after a negative response to
3195 MAIL if the sender used is not empty.
3196
3197 (b) The default behaviour of using MAIL FROM:<> for recipient callouts has
3198 been restored.
3199
3200 (c) A new callout option, "use_sender" has been added for people who want
3201 the modified behaviour.
3202
3203
3204Exim version 4.31
3205-----------------
3206
3207 1. Removed "EXTRALIBS=-lwrap" from OS/Makefile-Unixware7 on the advice of
3208 Larry Rosenman.
3209
3210 2. Removed "LIBS = -lresolv" from OS/Makefile-Darwin as it is not needed, and
3211 indeed breaks things for older releases.
3212
3213 3. Added additional logging to the case where there is a problem reading data
3214 from a filter that is running in a subprocess using a pipe, in order to
3215 try to track down a specific problem.
3216
3217 4. Testing facility fudge: when running in the test harness and attempting
3218 to connect to 10.x.x.x (expecting a connection timeout) I'm now sometimes
3219 getting "No route to host". Convert this to a timeout.
3220
3221 5. Define ICONV_ARG2_TYPE as "char **" for Unixware7 to avoid compiler
3222 warning.
3223
3224 6. Some OS don't have socklen_t but use size_t instead. This affects the
3225 fifth argument of getsockopt() amongst other things. This is now
3226 configurable by a macro called SOCKLEN_T which defaults to socklen_t, but
3227 can be set for individual OS. I have set it for SunOS5, OSF1, and
3228 Unixware7. Current versions of SunOS5 (aka Solaris) do have socklen_t, but
3229 some earlier ones do not.
3230
3231 7. Change 4.30/15 was not doing the test caselessly.
3232
3233 8. The standard form for an IPv6 address literal was being rejected by address
3234 parsing in, for example, MAIL and RCPT commands. An example of this kind of
3235 address is [IPv6:2002:c1ed:8229:10:202:2dff:fe07:a42a]. Exim now accepts
3236 this, as well as the form without the "IPv6" on the front (but only when
3237 address literals are enabled, of course).
3238
3239 9. Added some casts to avoid compiler warnings in OS/os.c-Linux.
3240
324110. Exim crashed if a message with an empty sender address specified by -f
3242 encountered a router with an errors_to setting. This could be provoked only
3243 by a command such as
3244
3245 exim -f "" ...
3246
3247 where an empty string was supplied; "<>" did not hit this bug.
3248
324911. Installed PCRE release 4.5.
3250
325112. If EHLO/HELO was rejected by an ACL, the value of $sender_helo_name
3252 remained set. It is now erased.
3253
325413. exiqgrep wasn't working on MacOS X because it didn't correctly compute
3255 times from message ids (which are base 36 rather than the normal 62).
3256
325714. "Expected" SMTP protocol errors that can arise when PIPELINING is in use
3258 were being counted as actual protocol errors, and logged if the log
3259 selector +smtp_protocol_error was set. One cannot be perfect in this test,
3260 but now, if PIPELINING has been advertised, RCPT following a rejected MAIL,
3261 and DATA following a set of rejected RCPTs do not count as protocol errors.
3262 In other words, Exim assumes they were pipelined, though this may not
3263 actually be the case. Of course, in all cases the client gets an
3264 appropriate error code.
3265
326615. If a lookup fails in an ACL condition, a message about the failure may
3267 be available; it is used if testing the ACL cannot continue, because most
3268 such messages specify what the cause of the deferral is. However, some
3269 messages (e.g. "MYSQL: no data found") do not cause a defer. There was bug
3270 that caused an old message to be retained and used if a later statement
3271 caused a defer, replacing the real cause of the deferral.
3272
327316. If an IP address had so many PTR records that the DNS lookup buffer
3274 was not large enough to hold them, Exim could crash while trying to process
3275 the truncated data. It now detects and logs this case.
3276
327717. Further to 4.21/58, another change has been made: if (and only if) the
3278 first line of a message (the first header line) ends with CRLF, a bare LF
3279 in a subsequent header line has a space inserted after it, so as not to
3280 terminate the header.
3281
328218. Refactoring: tidied an ugly bit of code in appendfile that copied data
3283 unnecessarily, used atoi() instead of strtol(), and didn't check the
3284 termination when getting file sizes from file names by regex.
3285
328619. Completely re-implemented the support for maildirsize files, in the light
3287 of a number of problems with the previous contributed implementation
3288 (4.30/29). In particular:
3289
3290 . If the quota is zero, the maildirsize file is maintained, but no quota is
3291 imposed.
3292
3293 . If the maildir directory does not exist, it is created before any attempt
3294 to write a maildirsize file.
3295
3296 . The quota value in the file is just a cache; if the quota is changed in
3297 the transport, the new value overrides.
3298
3299 . A regular expression is available for excluding directories from the
3300 count.
3301
330220. The autoreply transport checks the characters in options that define the
3303 message's headers; it allows continued headers, but it was checking with
3304 isspace() after an embedded newline instead of explicitly looking for a
3305 space or a tab.
3306
330721. If all the "regular" hosts to which an address was routed had passed their
3308 expiry times, and had not reached their retry times, the address was
3309 bounced, even if fallback hosts were defined. Now Exim should go on to try
3310 the fallback hosts.
3311
331222. Increased buffer sizes in the callout code from 1024 to 4096 to match the
3313 equivalent code in the SMTP transport. Some hosts send humungous responses
3314 to HELO/EHLO, more than 1024 it seems.
3315
331623. Refactoring: code in filter.c used (void *) for "any old type" but this
3317 gives compiler warnings in some environments. I've now done it "properly",
3318 using a union.
3319
332024. The replacement for inet_ntoa() that is used with gcc on IRIX systems
3321 (because of problems with the built-in one) was declared to return uschar *
3322 instead of char *, causing compiler failure.
3323
332425. Fixed a file descriptor leak when processing alias/forward files.
3325
332626. Fixed a minor format string issue in dbfn.c.
3327
332827. Typo in exim.c: ("dmbnz" for "dbmnz").
3329
333028. If a filter file refered to $h_xxx or $message_headers, and the headers
3331 contained RFC 2047 "words", Exim's memory could, under certain conditions,
3332 become corrupted.
3333
333429. When a sender address is verified, it is cached, to save repeating the test
3335 when there is more than one recipient in a message. However, when the
3336 verification involves a callout, it is possible for different callout
3337 options to be set for different recipients. It is too complicated to keep
3338 track of this in the cache, so now Exim always runs a verification when a
3339 callout is required, relying on the callout cache for the optimization.
3340 The overhead is duplication of the address routing, but this should not be
3341 too great.
3342
334330. Fixed a bug in callout caching. If a RCPT command caused the sender address
3344 to be verified with callout=postmaster, and the main callout worked but the
3345 postmaster check failed, the verification correctly failed. However, if a
3346 subsequent RCPT command asked for sender verification *without* the
3347 postmaster check, incorrect caching caused this verification also to fail,
3348 incorrectly.
3349
335031. Exim caches DNS lookup failures so as to avoid multiple timeouts; however,
3351 it was not caching the DNS options (qualify_single, search_parents) that
3352 were used when the lookup failed. A subsequent lookup with different
3353 options therefore always gave the same answer, though there were cases
3354 where it should not have. (Example: a "domains = !$mx_any" option on a
3355 dnslookup router: the "domains" option is always processed without any
3356 widening, but the router might have qualify_single set.) Now Exim uses the
3357 cached value only when the same options are set.
3358
335932. Added John Jetmore's "exipick" utility to the distribution.
3360
336133. GnuTLS: When an attempt to start a TLS session fails for any reason other
3362 than a timeout (e.g. a certificate is required, and is not provided), an
3363 Exim server now closes the connection immediately. Previously it waited for
3364 the client to close - but if the client is SSL, it seems that they each
3365 wait for each other, leading to a delay before one of them times out.
3366
336734: GnuTLS: Updated the code to use the new GnuTLS 1.0.0 API. I have not
3368 maintained 0.8.x compatibility because I don't think many are using it, and
3369 it is clearly obsolete.
3370
337135. Added TLS support for CRLs: a tls_crl global option and one for the smtp
3372 transport.
3373
337436. OpenSSL: $tls_certificate_verified was being set to 1 even if the
3375 client certificate was expired. A simple patch fixes this, though I don't
3376 understand the full logic of why the verify callback is called multiple
3377 times.
3378
337937. OpenSSL: a patch from Robert Roselius: "Enable client-bug workaround.
3380 Versions of OpenSSL as of 0.9.6d include a 'CBC countermeasure' feature,
3381 which causes problems with some clients (such as the Certicom SSL Plus
3382 library used by Eudora). This option, SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS,
3383 disables the coutermeasure allowing Eudora to connect."
3384
338538. Exim was not checking that a write() to a log file succeeded. This could
3386 lead to Bad Things if a log got too big, in particular if it hit a file
3387 size limit. Exim now panics and dies if it cannot write to a log file, just
3388 as it does if it cannot open a log file.
3389
339039. Modified OS/Makefile-Linux so that it now contains
3391
3392 CFLAGS=-O -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
3393
3394 The two -D definitions ensure that Exim is compiled with large file
3395 support, which makes it possible to handle log files that are bigger than
3396 2^31.
3397
339840. Fixed a subtle caching bug: if (in an ACL or a set of routers, for
3399 instance) a domain was checked against a named list that involved a lookup,
3400 causing $domain_data to be set, then another domain was checked against the
3401 same list, then the first domain was re-checked, the value of $domain_data
3402 after the final check could be wrong. In particular, if the second check
3403 failed, it could be set empty. This bug probably also applied to
3404 $localpart_data.
3405
340641. The strip_trailing_dot option was not being applied to the address given
3407 with the -f command-line option.
3408
340942. The code for reading a message's header from the spool was incrementing
3410 $received_count, but never initializing it. This meant that the value was
3411 incorrect (doubled) while delivering a message in the same process in which
3412 it was received. In the most common configuration of Exim, this never
3413 happens - a fresh exec is done - but it can happen when
3414 deliver_drop_privilege is set.
3415
341643. When Exim logs an SMTP synchronization error - client data sent too soon -
3417 it now includes up to 150 characters of the unexpected data in the log
3418 line.
3419
342044. The exim_dbmbuild utility uses fixed size buffers for reading input lines
3421 and building data strings. The size of both of these buffers was 10 000
3422 bytes - far larger than anybody would *ever* want, thought I. Needless to
3423 say, somebody hit the limit. I have increased the maximum line length to
3424 20 000 and the maximum data length of concatenated lines to 100 000. I have
3425 also fixed two bugs, because there was no checking on these buffers. Tsk,
3426 tsk. Now exim_dbmbuild gives a message and exits with an error code if a
3427 buffer is too small.
3428
342945. The exim_dbmbuild utility did not support quoted keys, as Exim does in
3430 lsearch lookups. Now it does.
3431
343246. When parsing a route_list item in a manualroute router, a fixed-length
3433 buffer was used for the list of hosts. I made this 1024 bytes long,
3434 thinking that nobody would ever have a list of hosts that long. Wrong.
3435 Somebody had a whole pile of complicated expansion conditions, and the
3436 string was silently truncated, leading to an expansion error. It turns out
3437 that it is easier to change to an unlimited length (owing to other changes
3438 that have happened since this code was originally written) than to build
3439 structure for giving a limitation error. The length of the item that
3440 expands into the list of hosts is now unlimited.
3441
344247. The lsearch lookup could not handle data where the length of text line was
3443 more than 4095 characters. Such lines were truncated, leading to shortened
3444 data being returned. It should now handle lines of any length.
3445
344648. Minor wording revision: "cannot test xxx in yyy ACL" becomes "cannot test
3447 xxx condition in yyy ACL" (e.g. "cannot test domains condition in DATA
3448 ACL").
3449
345049. Cosmetic tidy to scripts like exicyclog that are generated by globally
3451 replacing strings such as BIN_DIRECTORY in a source file: the replacement
3452 no longer happens in comment lines. A list of replacements is now placed
3453 at the head of all of the source files, except those whose only change is
3454 to replace PERL_COMMAND in the very first #! line.
3455
345650. Replaced the slow insertion sort in queue.c, for sorting the list of
3457 messages on the queue, with a bottom-up merge sort, using code contributed
3458 by Michael Haardt. This should make operations like -bp somewhat faster on
3459 large queues. It won't affect queue runners, except when queue_run_in_order
3460 is set.
3461
346251. Installed eximstats 1.31 in the distribution.
3463
346452. Added support for SRV lookups to the dnslookup router.
3465
346653. If an ACL referred to $message_body or $message_body_end, the value was not
3467 reset for any messages that followed in the same SMTP session.
3468
346954. The store-handling optimization for building very long strings was not
3470 differentiating between the different store pools. I don't think this
3471 actually made any difference in practice, but I've tidied it.
3472
347355. While running the routers to verify a sender address, $sender_address
3474 was still set to the sender address. This is wrong, because when routing to
3475 send a bounce to the sender, it would be empty. Therefore, I have changed
3476 it so that, while verifying a sender address, $sender_address is set to <>.
3477 (There is no change to what happens when verifying a recipient address.)
3478
347956. After finding MX (or SRV) records, Exim was doing a DNS lookup for the
3480 target A or AAAA records (if not already returned) without resetting the
3481 qualify_single or search_parents options of the DNS resolver. These are
3482 inappropriate in this case because the targets of MX and SRV records must
3483 be FQDNs. A broken DNS record could cause trouble if it happened to have a
3484 target that, when qualified, matched something in the local domain. These
3485 two options are now turned off when doing these lookups.
3486
348757. It seems that at least some releases of Reiserfs (which does not have the
3488 concept of a fixed number of inodes) returns zero and not -1 for the
3489 number of available inodes. This interacted badly with check_spool_inodes,
3490 which assumed that -1 was the "no such thing" setting. What I have done is
3491 to check that the total number of inodes is greater than zero before doing
3492 the test of how many are available.
3493
349458. When a "warn" ACL statement has a log_message modifier, the message is
3495 remembered, and not repeated. This is to avoid a lot of repetition when a
3496 message has many recipients that cause the same warning to be written.
3497 Howewer, Exim was preserving the list of already written lines for an
3498 entire SMTP session, which doesn't seem right. The memory is now reset if a
3499 new message is started.
3500
350159. The "rewrite" debugging flag was not showing the result of rewriting in the
3502 debugging output unless log_rewrite was also set.
3503
350460. Avoid a compiler warning on 64-bit systems in dsearch.c by avoiding the use
3505 of (int)(handle) when we know that handle contains (void *)(-1).
3506
350761. The Exim daemon panic-logs an error return when it closes the incoming
3508 connection. However "connection reset by peer" seems to be common, and
3509 isn't really an error worthy of noting specially, so that particular error
3510 is no long logged.
3511
351262. When Exim is trying to find all the local interfaces, it used to panic and
3513 die if the ioctl to get the interface flags failed. However, it seems that
3514 on at least one OS (Solaris 9) it is possible to have an interface that is
3515 included in the list of interfaces, but for which you get a failure error
3516 for this call. This happens when the interface is not "plumbed" into a
3517 protocol (i.e. neither IPv4 nor IPv6). I've changed the code so that a
3518 failure of the "get flags" call assumes that the interface is down.
3519
352063. Added a ${eval10: operator, which assumes all numbers are decimal. This
3521 makes life easier for people who are doing arithmetic on fields extracted
3522 from dates, where you often get leading zeros that should not be
3523 interpreted as octal.
3524
352564. Added qualify_domain to the redirect router, to override the global
3526 setting.
3527
352865. If a pathologically long header line contained very many addresses (the
3529 report of this problem mentioned 10 000) and each of them was rewritten,
3530 Exim could use up a very large amount of memory. (It kept on making new
3531 copies of the header line as it rewrote, and never released the old ones.)
3532 At the expense of a bit more processing, the header rewriting function has
3533 been changed so that it no longer eats memory in this way.
3534
353566. The generation of the Received: header has been moved from the time that a
3536 message starts to be received, to the time that it finishes. The timestamp
3537 in the Received: header should now be very close to that of the <= log
3538 line. There are two side-effects of this change:
3539
3540 (a) If a message is rejected by a DATA or non-SMTP ACL or local_scan(), the
3541 logged header lines no longer include the local Received: line, because
3542 it has not yet been created. The same applies to a copy of the message
3543 that is returned to a non-SMTP sender when a message is rejected.
3544
3545 (b) When a filter file is tested using -bf, no additional Received: header
3546 is added to the test message. After some thought, I decided that this
3547 is a bug fix.
3548
3549 This change does not affect the value of $received_for. It is still set
3550 after address rewriting, but before local_scan() is called.
3551
355267. Installed the latest Cygwin-specific files from the Cygwin maintainer.
3553
355468. GnuTLS: If an empty file is specified for tls_verify_certificates, GnuTLS
3555 gave an unhelpful panic error message, and a defer error. I have managed to
3556 change this behaviour so that it now rejects any supplied certificate,
3557 which seems right, as the list of acceptable certificates is empty.
3558
355969. OpenSSL: If an empty file is specified for tls_verify_certificates, OpenSSL
3560 gave an unhelpful defer error. I have not managed to make this reject any
3561 supplied certificates, but the error message it gives is "no certificate
3562 supplied", which is not helpful.
3563
356470. exigrep's output now also includes lines that are not associated with any
3565 message, but which match the given pattern. Implemented by a patch from
3566 Martin Sluka, which also tidied up the Perl a bit.
3567
356871. Recipient callout verification, like sender verification, was using <> in
3569 the MAIL FROM command. This isn't really the right thing, since the actual
3570 sender may affect whether the remote host accepts the recipient or not. I
3571 have changed it to use the actual sender in the callout; this means that
3572 the cache record is now keyed on a recipient/sender pair, not just the
3573 recipient address. There doesn't seem to be a real danger of callout loops,
3574 since a callout by the remote host to check the sender would use <>.
3575 [SEE ABOVE: changed after hitting problems.]
3576
357772. Exim treats illegal SMTP error codes that do not begin with 4 or 5 as
3578 temporary errors. However, in the case of such a code being given after
3579 the end of a data transmission (i.e. after ".") Exim was failing to write
3580 a retry record for the message. (Yes, there was some broken host that was
3581 actually sending 8xx at this point.)
3582
358373. An unknown lookup type in a host list could cause Exim to panic-die when
3584 the list was checked. (An example that provoked this was putting <; in the
3585 middle of a list instead of at the start.) If this happened during a DATA
3586 ACL check, a -D file could be left lying around. This kind of configuration
3587 error no longer causes Exim to die; instead it causes a defer errror. The
3588 incident is still logged to the main and panic logs.
3589
359074. Buglet left over from Exim 3 conversion. The message "too many messages
3591 in one connection" was written to the rejectlog but not the mainlog, except
3592 when address rewriting (yes!) was being logged.
3593
359475. Added write_rejectlog option.
3595
359676. When a system filter was run not as root (that is, when system_filter_user
3597 was set), the values of the $n variables were not being returned to the