From fd786d039107ffbd976ee152203d149ab032defa Mon Sep 17 00:00:00 2001 From: Eileen McNaughton Date: Thu, 15 Jan 2015 20:37:12 +1300 Subject: [PATCH] comment fixes --- .../WebTest/Event/MultiprofileEventTest.php | 4 +++- tests/phpunit/api/v3/ContributionTest.php | 20 ++----------------- .../phpunit/api/v3/SyntaxConformanceTest.php | 2 ++ 3 files changed, 7 insertions(+), 19 deletions(-) diff --git a/tests/phpunit/WebTest/Event/MultiprofileEventTest.php b/tests/phpunit/WebTest/Event/MultiprofileEventTest.php index 86a26e0cf6..80162f73d4 100644 --- a/tests/phpunit/WebTest/Event/MultiprofileEventTest.php +++ b/tests/phpunit/WebTest/Event/MultiprofileEventTest.php @@ -270,7 +270,9 @@ class WebTest_Event_MultiprofileEventTest extends CiviSeleniumTestCase { } /** - * @param $customGrpId1 + * Get custom field ID. + * + * @param int $customGrpId1 * * @return array */ diff --git a/tests/phpunit/api/v3/ContributionTest.php b/tests/phpunit/api/v3/ContributionTest.php index 6ab4bed8e0..264f0bd5bb 100644 --- a/tests/phpunit/api/v3/ContributionTest.php +++ b/tests/phpunit/api/v3/ContributionTest.php @@ -272,23 +272,6 @@ class api_v3_ContributionTest extends CiviUnitTestCase { ); $this->callAPISuccess('contribution', 'create', $params); } - /* - * ensure we continue to support contribution_type_id as part of the api commitment to - * stability - *///////////////// civicrm_contribution_ - - public function testCreateLegacyBehaviour() { - $params = array( - 'contribution_id' => FALSE, - 'contact_id' => 1, - 'total_amount' => 1, - 'check_permissions' => FALSE, - 'contribution_type_id' => 3, - ); - $contribution = $this->callAPISuccess('contribution', 'create', $params); - $contribution = $this->callAPISuccess('contribution', 'getsingle', array('id' => $contribution['id'])); - $this->assertEquals(3, $contribution['financial_type_id']); - } /** * Check with complete array + custom field @@ -314,7 +297,8 @@ class api_v3_ContributionTest extends CiviUnitTestCase { } /** - * Check with complete array + custom field + * Check with complete array + custom field. + * * Note that the test is written on purpose without any * variables specific to participant so it can be replicated into other entities * and / or moved to the automated test suite diff --git a/tests/phpunit/api/v3/SyntaxConformanceTest.php b/tests/phpunit/api/v3/SyntaxConformanceTest.php index 88c5b2411b..2fe3a5c0e5 100644 --- a/tests/phpunit/api/v3/SyntaxConformanceTest.php +++ b/tests/phpunit/api/v3/SyntaxConformanceTest.php @@ -265,6 +265,8 @@ class api_v3_SyntaxConformanceTest extends CiviUnitTestCase { } /** + * Get entities to be skipped for get call. + * * Mailing Contact Just doesn't support id. We have always insisted on finding a way to * support id in API but in this case the underlying tables are crying out for a restructure * & it just doesn't make sense, on the otherhand Event need id to be existant as pseudo property -- 2.25.1