From fbd33b7a131b9518108bb8e8fe1d9b5136d68dad Mon Sep 17 00:00:00 2001
From: Bradley Taylor <hello@brad-taylor.co.uk>
Date: Sat, 11 Feb 2023 15:26:04 +0000
Subject: [PATCH] [REF][PHP8.2] Declare property in
 CRM_Pledge_BAO_PledgeBlockTest

---
 .../CRM/Pledge/BAO/PledgeBlockTest.php        | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/tests/phpunit/CRM/Pledge/BAO/PledgeBlockTest.php b/tests/phpunit/CRM/Pledge/BAO/PledgeBlockTest.php
index 6144b7558d..3b0031dd8f 100644
--- a/tests/phpunit/CRM/Pledge/BAO/PledgeBlockTest.php
+++ b/tests/phpunit/CRM/Pledge/BAO/PledgeBlockTest.php
@@ -17,6 +17,11 @@
  */
 class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
 
+  /**
+   * @var int
+   */
+  private $contributionPageID;
+
   /**
    * Sets up the fixture, for example, opens a network connection.
    * This method is called before a test is executed.
@@ -24,7 +29,7 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
   protected function setUp(): void {
     parent::setUp();
     $contributionPage = $this->contributionPageCreate();
-    $this->_contributionPageId = $contributionPage['id'];
+    $this->contributionPageID = $contributionPage['id'];
   }
 
   /**
@@ -39,7 +44,7 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
     ];
 
     $params = [
-      'entity_id' => $this->_contributionPageId,
+      'entity_id' => $this->contributionPageID,
       'entity_table' => 'civicrm_contribution_page',
       'pledge_frequency_unit' => $pledgeFrequencyUnit,
       'max_reminders' => 2,
@@ -73,7 +78,7 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
     $pledgeFrequencySerialized = implode(CRM_Core_DAO::VALUE_SEPARATOR, array_keys(array_filter($pledgeFrequencyUnit)));
 
     $params = [
-      'entity_id' => $this->_contributionPageId,
+      'entity_id' => $this->contributionPageID,
       'entity_table' => 'civicrm_contribution_page',
       'pledge_frequency_unit' => $pledgeFrequencyUnit,
       'max_reminders' => 2,
@@ -91,7 +96,7 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
 
     $params = [
       'id' => $pledgeBlock->id,
-      'entity_id' => $this->_contributionPageId,
+      'entity_id' => $this->contributionPageID,
       'entity_table' => 'civicrm_contribution_page',
       'pledge_frequency_unit' => $pledgeFrequencyUnit,
       'max_reminders' => 3,
@@ -122,7 +127,7 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
     $pledgeFrequencySerialized = implode(CRM_Core_DAO::VALUE_SEPARATOR, array_keys(array_filter($pledgeFrequencyUnit)));
 
     $params = [
-      'entity_id' => $this->_contributionPageId,
+      'entity_id' => $this->contributionPageID,
       'entity_table' => 'civicrm_contribution_page',
       'pledge_frequency_unit' => $pledgeFrequencyUnit,
       'max_reminders' => 2,
@@ -134,14 +139,14 @@ class CRM_Pledge_BAO_PledgeBlockTest extends CiviUnitTestCase {
 
     // use retrieve() method
     $retrieveParams = [
-      'entity_id' => $this->_contributionPageId,
+      'entity_id' => $this->contributionPageID,
       'entity_table' => 'civicrm_contribution_page',
     ];
     $default = [];
     $retrievePledgeBlock = CRM_Pledge_BAO_PledgeBlock::retrieve($retrieveParams, $default);
 
     // use getPledgeBlock() method
-    $getPledgeBlock = CRM_Pledge_BAO_PledgeBlock::getPledgeBlock($this->_contributionPageId);
+    $getPledgeBlock = CRM_Pledge_BAO_PledgeBlock::getPledgeBlock($this->contributionPageID);
 
     // This param is expected to get serialized
     $params['pledge_frequency_unit'] = $pledgeFrequencySerialized;
-- 
2.25.1