From fb5cfee16575cb7f08e0e6efb87098e98e96084e Mon Sep 17 00:00:00 2001
From: Coleman Watts <coleman@civicrm.org>
Date: Fri, 22 Nov 2019 12:49:17 -0500
Subject: [PATCH] Display improvements

---
 ext/afform/gui/ang/afGuiEditor.js                    | 4 ++--
 ext/afform/gui/ang/afGuiEditor/inputType/Date.html   | 4 ++--
 ext/afform/gui/ang/afGuiEditor/inputType/Number.html | 2 +-
 ext/afform/gui/ang/afGuiEditor/inputType/Select.html | 2 +-
 ext/afform/gui/ang/afGuiEditor/inputType/Text.html   | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/ext/afform/gui/ang/afGuiEditor.js b/ext/afform/gui/ang/afGuiEditor.js
index 9c51eb7305..16fe6b949c 100644
--- a/ext/afform/gui/ang/afGuiEditor.js
+++ b/ext/afform/gui/ang/afGuiEditor.js
@@ -815,13 +815,13 @@
           var htmlVal = element.html();
           if (!htmlVal) {
             htmlVal = scope.defaultValue;
-            element.html(htmlVal);
+            element.text(htmlVal);
           }
           ngModel.$setViewValue(htmlVal);
         }
 
         ngModel.$render = function() {
-          element.html(ngModel.$viewValue || scope.defaultValue);
+          element.text(ngModel.$viewValue || scope.defaultValue);
         };
 
         // Special handling for enter and escape keys
diff --git a/ext/afform/gui/ang/afGuiEditor/inputType/Date.html b/ext/afform/gui/ang/afGuiEditor/inputType/Date.html
index 32ce51104b..a3d88733eb 100644
--- a/ext/afform/gui/ang/afGuiEditor/inputType/Date.html
+++ b/ext/afform/gui/ang/afGuiEditor/inputType/Date.html
@@ -1,5 +1,5 @@
 <div class="form-inline">
-  <input autocomplete="off" class="form-control crm-form-date crm-placeholder-icon" placeholder="&#xF073" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" />
+  <input autocomplete="off" class="form-control crm-form-date crm-placeholder-icon" placeholder="&#xF073" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" title="{{ ts('Click to add placeholder text') }}" />
   <span class="addon fa fa-calendar"></span>
-  <input autocomplete="off" ng-if="getProp('input_attrs.time')" placeholder="&#xF017" class="form-control crm-form-time crm-placeholder-icon" ng-model="getSet('input_attrs.timePlaceholder')" ng-model-options="{getterSetter: true}" type="text" />
+  <input autocomplete="off" ng-if="getProp('input_attrs.time')" placeholder="&#xF017" class="form-control crm-form-time crm-placeholder-icon" ng-model="getSet('input_attrs.timePlaceholder')" ng-model-options="{getterSetter: true}" type="text" title="{{ ts('Click to add placeholder text') }}" />
 </div>
diff --git a/ext/afform/gui/ang/afGuiEditor/inputType/Number.html b/ext/afform/gui/ang/afGuiEditor/inputType/Number.html
index 812d08dae8..91c12c3a3b 100644
--- a/ext/afform/gui/ang/afGuiEditor/inputType/Number.html
+++ b/ext/afform/gui/ang/afGuiEditor/inputType/Number.html
@@ -1 +1 @@
-<input autocomplete="off" class="form-control" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" />
+<input autocomplete="off" class="form-control" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" title="{{ ts('Click to add placeholder text') }}" />
diff --git a/ext/afform/gui/ang/afGuiEditor/inputType/Select.html b/ext/afform/gui/ang/afGuiEditor/inputType/Select.html
index 6d06d33571..afebdae570 100644
--- a/ext/afform/gui/ang/afGuiEditor/inputType/Select.html
+++ b/ext/afform/gui/ang/afGuiEditor/inputType/Select.html
@@ -1,6 +1,6 @@
 <div class="form-inline">
   <div class="input-group">
-    <input autocomplete="off" class="form-control" placeholder="{{ ts('Select') }}" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" />
+    <input autocomplete="off" class="form-control" placeholder="{{ ts('Select') }}" title="{{ ts('Click to add placeholder text') }}" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" />
     <div class="input-group-btn" af-gui-menu>
       <button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false"><i class="crm-i fa-caret-down"></i></button>
       <ul class="dropdown-menu" ng-if="menu.open">
diff --git a/ext/afform/gui/ang/afGuiEditor/inputType/Text.html b/ext/afform/gui/ang/afGuiEditor/inputType/Text.html
index 812d08dae8..91c12c3a3b 100644
--- a/ext/afform/gui/ang/afGuiEditor/inputType/Text.html
+++ b/ext/afform/gui/ang/afGuiEditor/inputType/Text.html
@@ -1 +1 @@
-<input autocomplete="off" class="form-control" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" />
+<input autocomplete="off" class="form-control" ng-model="getSet('input_attrs.placeholder')" ng-model-options="{getterSetter: true}" type="text" title="{{ ts('Click to add placeholder text') }}" />
-- 
2.25.1