From f9fcdb6f159a1624b4fe28a128750286ccc2058f Mon Sep 17 00:00:00 2001
From: colemanw <coleman@civicrm.org>
Date: Fri, 13 Oct 2023 19:44:50 -0400
Subject: [PATCH] CRM/Mailing - Refactor unnecessary uses of
 CRM_Utils_Array::value

---
 CRM/Mailing/BAO/Mailing.php    | 2 +-
 CRM/Mailing/BAO/MailingJob.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/CRM/Mailing/BAO/Mailing.php b/CRM/Mailing/BAO/Mailing.php
index f63ef91ff0..5270a8a666 100644
--- a/CRM/Mailing/BAO/Mailing.php
+++ b/CRM/Mailing/BAO/Mailing.php
@@ -2863,7 +2863,7 @@ ORDER BY civicrm_mailing.id DESC";
       $mailing['openstats'] = "Opens: " .
         CRM_Utils_Array::value($values['mailing_id'], $openCounts, 0) .
         "<br />Clicks: " .
-        CRM_Utils_Array::value($values['mailing_id'], $clickCounts, 0);
+        $clickCounts[$values['mailing_id']] ?? 0;
 
       $actionLinks = [
         CRM_Core_Action::VIEW => [
diff --git a/CRM/Mailing/BAO/MailingJob.php b/CRM/Mailing/BAO/MailingJob.php
index ed18b5ca37..3d75980079 100644
--- a/CRM/Mailing/BAO/MailingJob.php
+++ b/CRM/Mailing/BAO/MailingJob.php
@@ -45,7 +45,7 @@ class CRM_Mailing_BAO_MailingJob extends CRM_Mailing_DAO_MailingJob {
       throw new CRM_Core_Exception("Failed to create job: Unknown mailing ID");
     }
     $op = empty($params['id']) ? 'create' : 'edit';
-    CRM_Utils_Hook::pre($op, 'MailingJob', CRM_Utils_Array::value('id', $params), $params);
+    CRM_Utils_Hook::pre($op, 'MailingJob', $params['id'] ?? NULL, $params);
 
     $jobDAO = new CRM_Mailing_BAO_MailingJob();
     $jobDAO->copyValues($params);
-- 
2.25.1