From f808224cbfb67ac65e9617415b912f1c91315650 Mon Sep 17 00:00:00 2001 From: Coleman Watts Date: Wed, 20 Oct 2021 14:50:51 -0400 Subject: [PATCH] SearchKit - Fix console errors when adding non-field columns --- .../ang/crmSearchAdmin/crmSearchAdminDisplay.component.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js b/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js index 9bb5c4f7f7..22219d6672 100644 --- a/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js +++ b/ext/search_kit/ang/crmSearchAdmin/crmSearchAdminDisplay.component.js @@ -192,10 +192,12 @@ return !col.image && !col.rewrite && !col.link && !info.fn && info.args[0] && info.args[0].field && !info.args[0].field.readonly; }; + // Checks if a column contains a sortable value + // Must be a real sql expression (not a pseudo-field like `result_row_num`) this.canBeSortable = function(col) { var expr = ctrl.getExprFromSelect(col.key), info = searchMeta.parseExpr(expr), - arg = (_.findWhere(info.args, {type: 'field'}) || {}); + arg = (info && info.args && _.findWhere(info.args, {type: 'field'})) || {}; return arg.field && arg.field.type !== 'Pseudo'; }; -- 2.25.1