From f7935ad90826059e858c67304bd5a29b81be1870 Mon Sep 17 00:00:00 2001 From: eileen Date: Wed, 5 Aug 2020 18:25:53 +1200 Subject: [PATCH] Do not pass-by-reference to recur function This is called once, from the main function and the values are not used again --- CRM/Core/Payment/AuthorizeNetIPN.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CRM/Core/Payment/AuthorizeNetIPN.php b/CRM/Core/Payment/AuthorizeNetIPN.php index 12aa6cce84..83697bd338 100644 --- a/CRM/Core/Payment/AuthorizeNetIPN.php +++ b/CRM/Core/Payment/AuthorizeNetIPN.php @@ -100,15 +100,15 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN { * * @return bool */ - public function recur(&$input, &$ids, &$objects, $first) { + public function recur($input, $ids, $objects, $first) { $this->_isRecurring = TRUE; $recur = &$objects['contributionRecur']; $paymentProcessorObject = $objects['contribution']->_relatedObjects['paymentProcessor']['object']; // do a subscription check if ($recur->processor_id != $input['subscription_id']) { - CRM_Core_Error::debug_log_message("Unrecognized subscription."); - echo "Failure: Unrecognized subscription

"; + CRM_Core_Error::debug_log_message('Unrecognized subscription.'); + echo 'Failure: Unrecognized subscription

'; return FALSE; } @@ -178,7 +178,7 @@ class CRM_Core_Payment_AuthorizeNetIPN extends CRM_Core_Payment_BaseIPN { // check if contribution is already completed, if so we ignore this ipn if ($objects['contribution']->contribution_status_id == 1) { CRM_Core_Error::debug_log_message("Returning since contribution has already been handled."); - echo "Success: Contribution has already been handled

"; + echo 'Success: Contribution has already been handled

'; return TRUE; } -- 2.25.1