From f63fae912121d4a23bc660aaa38d12ec0fd389a0 Mon Sep 17 00:00:00 2001 From: Eileen Date: Mon, 6 Jan 2014 15:18:38 +1300 Subject: [PATCH] CRM-13918 CRM_Report_Form - variable scope, is not defined in 4.4.3, I added it for 4.4.4 but as public. I think this was incorrect so changing to protected I looked for instances in Core & all referred to ->_output. It seems that defining it will cause probs for anyone who has already defined a difference scope in their extension nsio (either way) so should just do it once right ---------------------------------------- * CRM-13918: Add Report.getrows api http://issues.civicrm.org/jira/browse/CRM-13918 --- CRM/Report/Form.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CRM/Report/Form.php b/CRM/Report/Form.php index f8e092c883..92686b6b2d 100644 --- a/CRM/Report/Form.php +++ b/CRM/Report/Form.php @@ -240,11 +240,9 @@ class CRM_Report_Form extends CRM_Core_Form { /** * outputmode e.g 'print', 'csv', 'pdf' - * @todo have declared this as public as fixing an e-Notice in a point release - would - * be better converted to protected in 4.5 * @var string */ - public $_outputMode; + protected $_outputMode; public $_having = NULL; public $_select = NULL; -- 2.25.1