From f557467c81680a7e89230a90d957fcb4823666af Mon Sep 17 00:00:00 2001 From: eileen Date: Sat, 29 Jun 2019 10:43:33 +1200 Subject: [PATCH] [REF] do not receive by reference in CustomField::create I audited the places where this is called in core and the object is not later interogated for changes --- CRM/Core/BAO/CustomField.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CRM/Core/BAO/CustomField.php b/CRM/Core/BAO/CustomField.php index 308cde26d3..a6e839cbe9 100644 --- a/CRM/Core/BAO/CustomField.php +++ b/CRM/Core/BAO/CustomField.php @@ -151,7 +151,7 @@ class CRM_Core_BAO_CustomField extends CRM_Core_DAO_CustomField { * * @return CRM_Core_DAO_CustomField */ - public static function create(&$params) { + public static function create($params) { $origParams = array_merge(array(), $params); $op = empty($params['id']) ? 'create' : 'edit'; -- 2.25.1