From f24c4b72b4ce40cbf629ec38996d4df170afea9a Mon Sep 17 00:00:00 2001 From: Jon Goldberg Date: Thu, 1 Jun 2023 17:11:56 -0400 Subject: [PATCH] fix Mailsettings.testconnection picking wrong settings to test --- Civi/Api4/Action/MailSettings/TestConnection.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Civi/Api4/Action/MailSettings/TestConnection.php b/Civi/Api4/Action/MailSettings/TestConnection.php index 51076236b6..344ef57a3d 100644 --- a/Civi/Api4/Action/MailSettings/TestConnection.php +++ b/Civi/Api4/Action/MailSettings/TestConnection.php @@ -12,6 +12,7 @@ namespace Civi\Api4\Action\MailSettings; use Civi\Api4\Generic\BasicBatchAction; +use Civi\Api4\MailSettings; class TestConnection extends BasicBatchAction { @@ -24,8 +25,13 @@ class TestConnection extends BasicBatchAction { * @return array */ protected function doTask($item) { + $mailingName = MailSettings::get(FALSE) + ->addSelect('name') + ->addWhere('id', '=', $item['id']) + ->execute() + ->first()['name']; try { - $mailStore = \CRM_Mailing_MailStore::getStore($item['name']); + $mailStore = \CRM_Mailing_MailStore::getStore($mailingName); } catch (\Throwable $t) { \Civi::log()->warning('MailSettings: Failed to establish test connection', [ -- 2.25.1