From f1518315c4efa5e66e7abd72cecc483215d1a15c Mon Sep 17 00:00:00 2001 From: eileen Date: Mon, 14 Sep 2020 11:57:50 +1200 Subject: [PATCH] dev/core#1921 remove isoToMysql The test testPaymentDontChangeReceiveDate passes through these 2 lines of code - which I think is probably about the most we can confirm testing wise as we expect there to be no reason to cast to mysql anymore --- CRM/Activity/BAO/Activity.php | 2 +- CRM/Financial/BAO/FinancialItem.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CRM/Activity/BAO/Activity.php b/CRM/Activity/BAO/Activity.php index 40f6fdc906..378b9d6b57 100644 --- a/CRM/Activity/BAO/Activity.php +++ b/CRM/Activity/BAO/Activity.php @@ -1732,7 +1732,7 @@ WHERE activity.id IN ($activityIds)"; $params['campaign_id'] = $activity->campaign_id; } - $date = CRM_Utils_Date::isoToMysql($activity->receive_date); + $date = $activity->receive_date; } $activityParams = [ diff --git a/CRM/Financial/BAO/FinancialItem.php b/CRM/Financial/BAO/FinancialItem.php index fb5dca3d16..d63db1dbb8 100644 --- a/CRM/Financial/BAO/FinancialItem.php +++ b/CRM/Financial/BAO/FinancialItem.php @@ -74,7 +74,7 @@ class CRM_Financial_BAO_FinancialItem extends CRM_Financial_DAO_FinancialItem { $itemStatus = array_search('Partially paid', $financialItemStatus); } $params = [ - 'transaction_date' => CRM_Utils_Date::isoToMysql($contribution->receive_date), + 'transaction_date' => $contribution->receive_date, 'contact_id' => $contribution->contact_id, 'amount' => $lineItem->line_total, 'currency' => $contribution->currency, -- 2.25.1